* [Buildroot] [PATCH v4 1/2] package/libtirpc: Add optional GSSAPI support
@ 2021-07-18 20:44 James Hilliard
2021-07-18 20:44 ` [Buildroot] [PATCH v4 2/2] package/nfs-utils: Add optional GSS support James Hilliard
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: James Hilliard @ 2021-07-18 20:44 UTC (permalink / raw)
To: buildroot
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
Changes v3 -> v4:
- rebase
Changes v2 -> v3:
- use krb5-config instead of -lgssapi_krb5
---
package/libtirpc/Config.in | 8 ++++++++
package/libtirpc/libtirpc.mk | 8 +++++++-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
index 2e9c939fa8..1899edefbf 100644
--- a/package/libtirpc/Config.in
+++ b/package/libtirpc/Config.in
@@ -7,5 +7,13 @@ config BR2_PACKAGE_LIBTIRPC
http://sourceforge.net/projects/libtirpc/
+config BR2_PACKAGE_LIBTIRPC_GSS
+ bool "gss"
+ depends on BR2_USE_MMU # libkrb5
+ depends on BR2_PACKAGE_LIBTIRPC
+ select BR2_PACKAGE_LIBKRB5
+ help
+ Enable GSSAPI support
+
comment "libtirpc needs a toolchain w/ threads"
depends on !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/libtirpc/libtirpc.mk b/package/libtirpc/libtirpc.mk
index 31be113965..4b385b7003 100644
--- a/package/libtirpc/libtirpc.mk
+++ b/package/libtirpc/libtirpc.mk
@@ -18,7 +18,13 @@ LIBTIRPC_AUTORECONF = YES
# getrpcby{number,name} are only provided if 'GQ' is defined
LIBTIRPC_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -DGQ"
-LIBTIRPC_CONF_OPTS = --disable-gssapi
+ifeq ($(BR2_PACKAGE_LIBTIRPC_GSS),y)
+LIBTIRPC_CONF_ENV += KRB5_CONFIG=$(STAGING_DIR)/usr/bin/krb5-config
+LIBTIRPC_CONF_OPTS += --enable-gssapi
+LIBTIRPC_DEPENDENCIES += libkrb5
+else
+LIBTIRPC_CONF_OPTS += --disable-gssapi
+endif
HOST_LIBTIRPC_CONF_OPTS = --disable-gssapi
$(eval $(autotools-package))
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Buildroot] [PATCH v4 2/2] package/nfs-utils: Add optional GSS support
2021-07-18 20:44 [Buildroot] [PATCH v4 1/2] package/libtirpc: Add optional GSSAPI support James Hilliard
@ 2021-07-18 20:44 ` James Hilliard
2021-07-21 20:40 ` Petr Vorel
2021-07-21 20:38 ` [Buildroot] [PATCH v4 1/2] package/libtirpc: Add optional GSSAPI support Petr Vorel
2021-07-25 16:21 ` Arnout Vandecappelle
2 siblings, 1 reply; 7+ messages in thread
From: James Hilliard @ 2021-07-18 20:44 UTC (permalink / raw)
To: buildroot
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/nfs-utils/Config.in | 7 +++++++
package/nfs-utils/nfs-utils.mk | 11 ++++++++++-
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/package/nfs-utils/Config.in b/package/nfs-utils/Config.in
index bd1e091331..f2997b9c91 100644
--- a/package/nfs-utils/Config.in
+++ b/package/nfs-utils/Config.in
@@ -26,6 +26,13 @@ config BR2_PACKAGE_NFS_UTILS_NFSV4
help
Enable NFSv4/NFSv4.1 support
+config BR2_PACKAGE_NFS_UTILS_GSS
+ bool "gss"
+ depends on BR2_PACKAGE_NFS_UTILS_NFSV4
+ select BR2_PACKAGE_LIBTIRPC_GSS
+ help
+ Enable GSS support
+
config BR2_PACKAGE_NFS_UTILS_RPCDEBUG
bool "rpcdebug"
help
diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
index 0b4bca4772..763dd57ace 100644
--- a/package/nfs-utils/nfs-utils.mk
+++ b/package/nfs-utils/nfs-utils.mk
@@ -16,7 +16,6 @@ NFS_UTILS_AUTORECONF = YES
NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no
NFS_UTILS_CONF_OPTS = \
- --disable-gss \
--enable-tirpc \
--enable-ipv6 \
--without-tcp-wrappers \
@@ -52,6 +51,16 @@ else
NFS_UTILS_CONF_OPTS += --disable-nfsv4 --disable-nfsv41
endif
+ifeq ($(BR2_PACKAGE_NFS_UTILS_GSS),y)
+NFS_UTILS_CONF_OPTS += \
+ --enable-gss \
+ --enable-svcgss \
+ --with-krb5=$(STAGING_DIR)/usr
+NFS_UTILS_DEPENDENCIES += libkrb5
+else
+NFS_UTILS_CONF_OPTS += --disable-gss --disable-svcgss
+endif
+
ifeq ($(BR2_PACKAGE_LIBCAP),y)
NFS_UTILS_CONF_OPTS += --enable-caps
NFS_UTILS_DEPENDENCIES += libcap
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH v4 1/2] package/libtirpc: Add optional GSSAPI support
2021-07-18 20:44 [Buildroot] [PATCH v4 1/2] package/libtirpc: Add optional GSSAPI support James Hilliard
2021-07-18 20:44 ` [Buildroot] [PATCH v4 2/2] package/nfs-utils: Add optional GSS support James Hilliard
@ 2021-07-21 20:38 ` Petr Vorel
2021-07-25 16:21 ` Arnout Vandecappelle
2 siblings, 0 replies; 7+ messages in thread
From: Petr Vorel @ 2021-07-21 20:38 UTC (permalink / raw)
To: James Hilliard; +Cc: Giulio Benetti, Thomas Petazzoni, buildroot
Hi James,
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Thanks!
Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH v4 1/2] package/libtirpc: Add optional GSSAPI support
2021-07-18 20:44 [Buildroot] [PATCH v4 1/2] package/libtirpc: Add optional GSSAPI support James Hilliard
2021-07-18 20:44 ` [Buildroot] [PATCH v4 2/2] package/nfs-utils: Add optional GSS support James Hilliard
2021-07-21 20:38 ` [Buildroot] [PATCH v4 1/2] package/libtirpc: Add optional GSSAPI support Petr Vorel
@ 2021-07-25 16:21 ` Arnout Vandecappelle
2021-07-25 17:37 ` Thomas Petazzoni
2 siblings, 1 reply; 7+ messages in thread
From: Arnout Vandecappelle @ 2021-07-25 16:21 UTC (permalink / raw)
To: James Hilliard, buildroot; +Cc: Giulio Benetti, Thomas Petazzoni
On 18/07/2021 22:44, James Hilliard wrote:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Both applied to master, thanks.
Regards,
Arnout
> ---
> Changes v3 -> v4:
> - rebase
> Changes v2 -> v3:
> - use krb5-config instead of -lgssapi_krb5
> ---
> package/libtirpc/Config.in | 8 ++++++++
> package/libtirpc/libtirpc.mk | 8 +++++++-
> 2 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
> index 2e9c939fa8..1899edefbf 100644
> --- a/package/libtirpc/Config.in
> +++ b/package/libtirpc/Config.in
> @@ -7,5 +7,13 @@ config BR2_PACKAGE_LIBTIRPC
>
> http://sourceforge.net/projects/libtirpc/
>
> +config BR2_PACKAGE_LIBTIRPC_GSS
> + bool "gss"
> + depends on BR2_USE_MMU # libkrb5
> + depends on BR2_PACKAGE_LIBTIRPC
> + select BR2_PACKAGE_LIBKRB5
> + help
> + Enable GSSAPI support
> +
> comment "libtirpc needs a toolchain w/ threads"
> depends on !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/libtirpc/libtirpc.mk b/package/libtirpc/libtirpc.mk
> index 31be113965..4b385b7003 100644
> --- a/package/libtirpc/libtirpc.mk
> +++ b/package/libtirpc/libtirpc.mk
> @@ -18,7 +18,13 @@ LIBTIRPC_AUTORECONF = YES
> # getrpcby{number,name} are only provided if 'GQ' is defined
> LIBTIRPC_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -DGQ"
>
> -LIBTIRPC_CONF_OPTS = --disable-gssapi
> +ifeq ($(BR2_PACKAGE_LIBTIRPC_GSS),y)
> +LIBTIRPC_CONF_ENV += KRB5_CONFIG=$(STAGING_DIR)/usr/bin/krb5-config
> +LIBTIRPC_CONF_OPTS += --enable-gssapi
> +LIBTIRPC_DEPENDENCIES += libkrb5
> +else
> +LIBTIRPC_CONF_OPTS += --disable-gssapi
> +endif
> HOST_LIBTIRPC_CONF_OPTS = --disable-gssapi
>
> $(eval $(autotools-package))
>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Buildroot] [PATCH v4 1/2] package/libtirpc: Add optional GSSAPI support
2021-07-25 16:21 ` Arnout Vandecappelle
@ 2021-07-25 17:37 ` Thomas Petazzoni
2021-07-25 20:47 ` James Hilliard
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2021-07-25 17:37 UTC (permalink / raw)
To: Arnout Vandecappelle; +Cc: James Hilliard, Giulio Benetti, buildroot
On Sun, 25 Jul 2021 18:21:08 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:
> Both applied to master, thanks.
Gah, I should have replied earlier. I didn't apply this because there
was a small issue, see below.
> > +config BR2_PACKAGE_LIBTIRPC_GSS
> > + bool "gss"
> > + depends on BR2_USE_MMU # libkrb5
> > + depends on BR2_PACKAGE_LIBTIRPC
> > + select BR2_PACKAGE_LIBKRB5
libkrb5 has a !BR2_STATIC_LIBS that is not taken into account here (and
the libtirpc main option does not have such a dependency).
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH v4 1/2] package/libtirpc: Add optional GSSAPI support
2021-07-25 17:37 ` Thomas Petazzoni
@ 2021-07-25 20:47 ` James Hilliard
0 siblings, 0 replies; 7+ messages in thread
From: James Hilliard @ 2021-07-25 20:47 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Giulio Benetti, buildroot
On Sun, Jul 25, 2021 at 11:37 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Sun, 25 Jul 2021 18:21:08 +0200
> Arnout Vandecappelle <arnout@mind.be> wrote:
>
> > Both applied to master, thanks.
>
> Gah, I should have replied earlier. I didn't apply this because there
> was a small issue, see below.
>
> > > +config BR2_PACKAGE_LIBTIRPC_GSS
> > > + bool "gss"
> > > + depends on BR2_USE_MMU # libkrb5
> > > + depends on BR2_PACKAGE_LIBTIRPC
> > > + select BR2_PACKAGE_LIBKRB5
>
> libkrb5 has a !BR2_STATIC_LIBS that is not taken into account here (and
> the libtirpc main option does not have such a dependency).
Fixed here:
https://patchwork.ozlabs.org/project/buildroot/patch/20210725204624.1620567-1-james.hilliard1@gmail.com/
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-07-25 20:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-18 20:44 [Buildroot] [PATCH v4 1/2] package/libtirpc: Add optional GSSAPI support James Hilliard
2021-07-18 20:44 ` [Buildroot] [PATCH v4 2/2] package/nfs-utils: Add optional GSS support James Hilliard
2021-07-21 20:40 ` Petr Vorel
2021-07-21 20:38 ` [Buildroot] [PATCH v4 1/2] package/libtirpc: Add optional GSSAPI support Petr Vorel
2021-07-25 16:21 ` Arnout Vandecappelle
2021-07-25 17:37 ` Thomas Petazzoni
2021-07-25 20:47 ` James Hilliard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox