[Buildroot] [PATCH] package/wpa_supplicant: enable libnl for the WIRED driver

[Buildroot] [PATCH] package/wpa_supplicant: enable libnl for the WIRED driver

[yegorslists--- via buildroot]

From: Yegor Yefremov <yegorslists@googlemail.com>

BR2_PACKAGE_WPA_SUPPLICANT_WIRED also enables the MACSEC_LINUX
driver. This driver requires libnl.

Also fix CONFIG_DRIVER_MACSEC option to enable only the generic
Linux driver and not QCA extensions.

Fixes:
http://autobuild.buildroot.net/results/2dea7dee521794b306cc610601fda322987e6cd0

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/wpa_supplicant/Config.in         |  2 ++
 package/wpa_supplicant/wpa_supplicant.mk | 11 +++++++++--
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in
index 8f095cdf2d..0094531548 100644
--- a/package/wpa_supplicant/Config.in
+++ b/package/wpa_supplicant/Config.in
@@ -41,6 +41,8 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WEXT
 
 config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
 	bool "Enable wired support"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
+	select BR2_PACKAGE_LIBNL
 	select BR2_PACKAGE_WPA_SUPPLICANT_EAP
 	help
 	  Include the "wired" driver, so the internal IEEE 802.1x
diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
index a2ca8a0b30..ac66d1f7e0 100644
--- a/package/wpa_supplicant/wpa_supplicant.mk
+++ b/package/wpa_supplicant/wpa_supplicant.mk
@@ -63,11 +63,18 @@ WPA_SUPPLICANT_CONFIG_DISABLE += \
 	CONFIG_FILS
 endif
 
-ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIRED),)
+ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIRED),y)
+WPA_SUPPLICANT_DEPENDENCIES += host-pkgconf libnl
+WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_LIBNL32
+WPA_SUPPLICANT_CONFIG_ENABLE += \
+	CONFIG_DRIVER_WIRED \
+	CONFIG_MACSEC \
+	CONFIG_DRIVER_MACSEC_LINUX
+else
 WPA_SUPPLICANT_CONFIG_DISABLE += \
 	CONFIG_DRIVER_WIRED \
 	CONFIG_MACSEC \
-	CONFIG_DRIVER_MACSEC
+	CONFIG_DRIVER_MACSEC_LINUX
 endif
 
 ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT),)
-- 
2.17.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/wpa_supplicant: enable libnl for the WIRED driver

[Sergey Matyukevich]

Hi Yegor,

> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> BR2_PACKAGE_WPA_SUPPLICANT_WIRED also enables the MACSEC_LINUX
> driver. This driver requires libnl.
> 
> Also fix CONFIG_DRIVER_MACSEC option to enable only the generic
> Linux driver and not QCA extensions.
> 
> Fixes:
> http://autobuild.buildroot.net/results/2dea7dee521794b306cc610601fda322987e6cd0
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Thanks for looking into this issue.

Reviewed-by: Sergey Matyukevich <geomatsi@gmail.com>

Regards,
Sergey
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/wpa_supplicant: enable libnl for the WIRED driver

[Arnout Vandecappelle]

On 11/04/2022 11:07, yegorslists--- via buildroot wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> BR2_PACKAGE_WPA_SUPPLICANT_WIRED also enables the MACSEC_LINUX
> driver. This driver requires libnl.
> 
> Also fix CONFIG_DRIVER_MACSEC option to enable only the generic
> Linux driver and not QCA extensions.
> 
> Fixes:
> http://autobuild.buildroot.net/results/2dea7dee521794b306cc610601fda322987e6cd0
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>   package/wpa_supplicant/Config.in         |  2 ++
>   package/wpa_supplicant/wpa_supplicant.mk | 11 +++++++++--
>   2 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in
> index 8f095cdf2d..0094531548 100644
> --- a/package/wpa_supplicant/Config.in
> +++ b/package/wpa_supplicant/Config.in
> @@ -41,6 +41,8 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WEXT
>   
>   config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
>   	bool "Enable wired support"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # libnl

  You also need to add a comment for this.

> +	select BR2_PACKAGE_LIBNL
>   	select BR2_PACKAGE_WPA_SUPPLICANT_EAP
>   	help
>   	  Include the "wired" driver, so the internal IEEE 802.1x
> diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
> index a2ca8a0b30..ac66d1f7e0 100644
> --- a/package/wpa_supplicant/wpa_supplicant.mk
> +++ b/package/wpa_supplicant/wpa_supplicant.mk
> @@ -63,11 +63,18 @@ WPA_SUPPLICANT_CONFIG_DISABLE += \
>   	CONFIG_FILS
>   endif
>   
> -ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIRED),)
> +ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIRED),y)
> +WPA_SUPPLICANT_DEPENDENCIES += host-pkgconf libnl
> +WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_LIBNL32
> +WPA_SUPPLICANT_CONFIG_ENABLE += \

  This looks a bit kludgy, just put everything in a single CONFIG_ENABLE.

  Applied to master with those two fixed, thanks.

  Regards,
  Arnout

> +	CONFIG_DRIVER_WIRED \
> +	CONFIG_MACSEC \
> +	CONFIG_DRIVER_MACSEC_LINUX
> +else
>   WPA_SUPPLICANT_CONFIG_DISABLE += \
>   	CONFIG_DRIVER_WIRED \
>   	CONFIG_MACSEC \
> -	CONFIG_DRIVER_MACSEC
> +	CONFIG_DRIVER_MACSEC_LINUX
>   endif
>   
>   ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT),)
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/wpa_supplicant: enable libnl for the WIRED driver

[Peter Korsgaard]

>>>>> "yegorslists---" == yegorslists--- via buildroot <buildroot@buildroot.org> writes:

 > From: Yegor Yefremov <yegorslists@googlemail.com>
 > BR2_PACKAGE_WPA_SUPPLICANT_WIRED also enables the MACSEC_LINUX
 > driver. This driver requires libnl.

 > Also fix CONFIG_DRIVER_MACSEC option to enable only the generic
 > Linux driver and not QCA extensions.

 > Fixes:
 > http://autobuild.buildroot.net/results/2dea7dee521794b306cc610601fda322987e6cd0

 > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot