[Buildroot] mstpd install location

[Buildroot] mstpd install location

[Colin Foster]

Hello,

I'm finally getting mstpd to start working in buildroot. I noticed two
blockers:

mstpd was running "pidof -c" while busybox doesn't support the -c
option. As a result, mstpd would fail entirely. I'm working with mstpd
to either remove the -c option if it isn't necessary, or detect
capabilities.

Also, the bridge-stp script gets called by the kernel, and needs to be
in /sbin. However, the install directory is /usr/sbin. I'm confused,
since Makefile.in seems to use $(DESTDIR)/sbin.

It seems there are two options:
1. Change the install directory of mstpd to /sbin, or
2. Add a post-install hook to soft link /sbin files to
/usr/sbin/{mstpd,mstpctl,bridge-stp}

I'm not familiar with autotools-package, so I'm not sure why option 1
isn't already happening. If option 1 couldn't, or shouldn't happen, I
can certainly look into implementing option 2.


Any feedback is appreciated.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] mstpd install location

[François Perrad]

[-- Attachment #1.1: Type: text/plain, Size: 1357 bytes --]

Le ven. 8 juil. 2022 à 21:26, Colin Foster <colin.foster@in-advantage.com>
a écrit :

> Hello,
>
> I'm finally getting mstpd to start working in buildroot. I noticed two
> blockers:
>
> mstpd was running "pidof -c" while busybox doesn't support the -c
> option. As a result, mstpd would fail entirely. I'm working with mstpd
> to either remove the -c option if it isn't necessary, or detect
> capabilities.
>
> Also, the bridge-stp script gets called by the kernel, and needs to be
> in /sbin. However, the install directory is /usr/sbin. I'm confused,
> since Makefile.in seems to use $(DESTDIR)/sbin.
>
> It seems there are two options:
> 1. Change the install directory of mstpd to /sbin, or
> 2. Add a post-install hook to soft link /sbin files to
> /usr/sbin/{mstpd,mstpctl,bridge-stp}
>
> I'm not familiar with autotools-package, so I'm not sure why option 1
> isn't already happening. If option 1 couldn't, or shouldn't happen, I
> can certainly look into implementing option 2.
>
>
For option 1, see
https://patchwork.ozlabs.org/project/buildroot/patch/20220709155557.2907518-1-francois.perrad@gadz.org/

François


> Any feedback is appreciated.
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>

[-- Attachment #1.2: Type: text/html, Size: 2260 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] mstpd install location

[Colin Foster]

On Sat, Jul 09, 2022 at 05:59:43PM +0200, François Perrad wrote:
> Le ven. 8 juil. 2022 à 21:26, Colin Foster <colin.foster@in-advantage.com>
> a écrit :
> 
> > Hello,
> >
> > I'm finally getting mstpd to start working in buildroot. I noticed two
> > blockers:
> >
> > mstpd was running "pidof -c" while busybox doesn't support the -c
> > option. As a result, mstpd would fail entirely. I'm working with mstpd
> > to either remove the -c option if it isn't necessary, or detect
> > capabilities.
> >
> > Also, the bridge-stp script gets called by the kernel, and needs to be
> > in /sbin. However, the install directory is /usr/sbin. I'm confused,
> > since Makefile.in seems to use $(DESTDIR)/sbin.
> >
> > It seems there are two options:
> > 1. Change the install directory of mstpd to /sbin, or
> > 2. Add a post-install hook to soft link /sbin files to
> > /usr/sbin/{mstpd,mstpctl,bridge-stp}
> >
> > I'm not familiar with autotools-package, so I'm not sure why option 1
> > isn't already happening. If option 1 couldn't, or shouldn't happen, I
> > can certainly look into implementing option 2.
> >
> >
> For option 1, see
> https://patchwork.ozlabs.org/project/buildroot/patch/20220709155557.2907518-1-francois.perrad@gadz.org/

Golden! Thank you.

> 
> François
> 
> 
> > Any feedback is appreciated.
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> >
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot