Re: [Buildroot] [PATCH 3/3] board/qemu/aarch64-sbsa: drop unused kernel config file

From: "Vincent Stehlé" <vincent.stehle@arm.com>
To: Niklas Cassel <niklas.cassel@wdc.com>
Cc: Romain Naour <romain.naour@gmail.com>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 3/3] board/qemu/aarch64-sbsa: drop unused kernel config file
Date: Thu, 2 Mar 2023 14:12:45 +0100	[thread overview]
Message-ID: <ZACgzebwfOVNcfdC@debian> (raw)
In-Reply-To: <20230301155810.3222459-4-niklas.cassel@wdc.com>

On Wed, Mar 01, 2023 at 04:58:10PM +0100, Niklas Cassel wrote:
> The config file board/qemu/aarch64-sbsa/linux.config has
> never been in use by configs/qemu_aarch64_sbsa_defconfig,
> neither via BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE, nor via
> BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES.
> 
> Thus the config file is and has always been unused.

Hi Niklas,

This fragment seems to be used by edk2 python unit test
`support/testing/tests/boot/test_edk2.py'.
I missed that during my testing of the defconfigs.

Best regards,
Vincent.

> Remove it such that no one might get the silly idea that
> it is actually used for something.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
> ---
>  board/qemu/aarch64-sbsa/linux.config | 68 ----------------------------
>  1 file changed, 68 deletions(-)
>  delete mode 100644 board/qemu/aarch64-sbsa/linux.config
> 
> diff --git a/board/qemu/aarch64-sbsa/linux.config b/board/qemu/aarch64-sbsa/linux.config
> deleted file mode 100644
> index a60cce02ec..0000000000
> --- a/board/qemu/aarch64-sbsa/linux.config
> +++ /dev/null
> @@ -1,68 +0,0 @@
> -CONFIG_SYSVIPC=y
> -CONFIG_POSIX_MQUEUE=y
> -CONFIG_NO_HZ_IDLE=y
> -CONFIG_HIGH_RES_TIMERS=y
> -CONFIG_TASKSTATS=y
> -CONFIG_SCHED_AUTOGROUP=y
> -CONFIG_PROFILING=y
> -CONFIG_ARCH_VEXPRESS=y
> -CONFIG_COMPAT=y
> -CONFIG_FW_CFG_SYSFS=y
> -CONFIG_FW_CFG_SYSFS_CMDLINE=y
> -CONFIG_ACPI=y
> -CONFIG_MODULES=y
> -CONFIG_MODULE_UNLOAD=y
> -CONFIG_BLK_DEV_BSGLIB=y
> -CONFIG_BINFMT_MISC=y
> -CONFIG_TRANSPARENT_HUGEPAGE=y
> -CONFIG_NET=y
> -CONFIG_PACKET=y
> -CONFIG_PACKET_DIAG=y
> -CONFIG_UNIX=y
> -CONFIG_NET_KEY=y
> -CONFIG_INET=y
> -CONFIG_IP_MULTICAST=y
> -CONFIG_IP_ADVANCED_ROUTER=y
> -CONFIG_BRIDGE=m
> -CONFIG_NET_SCHED=y
> -CONFIG_VSOCKETS=y
> -CONFIG_PCI=y
> -CONFIG_PCI_HOST_GENERIC=y
> -CONFIG_DEVTMPFS=y
> -CONFIG_DEVTMPFS_MOUNT=y
> -CONFIG_VIRTIO_BLK=y
> -CONFIG_BLK_DEV_SD=y
> -CONFIG_CHR_DEV_SG=y
> -CONFIG_SCSI_CONSTANTS=y
> -CONFIG_SCSI_LOGGING=y
> -CONFIG_SCSI_SCAN_ASYNC=y
> -CONFIG_SCSI_VIRTIO=y
> -CONFIG_ATA=y
> -CONFIG_SATA_AHCI_PLATFORM=y
> -CONFIG_NETDEVICES=y
> -CONFIG_DUMMY=y
> -CONFIG_MACVLAN=y
> -CONFIG_VIRTIO_NET=y
> -CONFIG_NLMON=y
> -CONFIG_SERIAL_AMBA_PL011=y
> -CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
> -CONFIG_VIRTIO_CONSOLE=y
> -CONFIG_HW_RANDOM=y
> -CONFIG_HW_RANDOM_VIRTIO=y
> -CONFIG_TCG_TPM=y
> -CONFIG_TCG_TIS=y
> -CONFIG_DRM=y
> -CONFIG_DRM_VIRTIO_GPU=y
> -CONFIG_RTC_CLASS=y
> -CONFIG_RTC_DRV_PL031=y
> -CONFIG_VIRTIO_PCI=y
> -CONFIG_VIRTIO_MMIO=y
> -CONFIG_VIRTIO_MMIO_CMDLINE_DEVICES=y
> -CONFIG_MAILBOX=y
> -CONFIG_PL320_MBOX=y
> -CONFIG_ARM_SMMU_V3=y
> -CONFIG_EXT4_FS=y
> -CONFIG_FUSE_FS=y
> -CONFIG_VIRTIO_FS=y
> -CONFIG_TMPFS=y
> -CONFIG_TMPFS_POSIX_ACL=y
> -- 
> 2.39.2
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot