* [Buildroot] [PATCH 1/3] board/qemu/aarch64-sbsa: use PARTLABEL to specify root
2023-03-01 15:58 [Buildroot] [PATCH 0/3] misc aarch64-sbsa cleanups Niklas Cassel via buildroot
@ 2023-03-01 15:58 ` Niklas Cassel via buildroot
2023-03-01 15:58 ` [Buildroot] [PATCH 2/3] board/qemu/aarch64-sbsa: use the default console specified by ACPI Niklas Cassel via buildroot
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Niklas Cassel via buildroot @ 2023-03-01 15:58 UTC (permalink / raw)
To: buildroot
Cc: Niklas Cassel, Romain Naour, Vincent Stehlé, Damien Le Moal
Specifying /dev/sda2 is ambigious, and when booting my arm64 machine
this tries to mount the second partition of my ATA drive, instead of
the second partition of the USB-stick, simply because the ATA driver
is probed earlier than the USB controller driver.
To solve this problem, use PARTLABEL=root to specify the root filesystem.
This is similar to how it is currently done for board/aarch64-efi/grub.cfg
and board/qemu/aarch64-ebbr/grub.cfg.
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
---
board/qemu/aarch64-sbsa/grub.cfg | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/qemu/aarch64-sbsa/grub.cfg b/board/qemu/aarch64-sbsa/grub.cfg
index cd486caf4c..39b7842f8f 100644
--- a/board/qemu/aarch64-sbsa/grub.cfg
+++ b/board/qemu/aarch64-sbsa/grub.cfg
@@ -2,5 +2,5 @@ set default="0"
set timeout="5"
menuentry "Buildroot" {
- linux /Image root=/dev/sda2 rootwait console=ttyAMA0
+ linux /Image root=PARTLABEL=root rootwait console=ttyAMA0
}
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 2/3] board/qemu/aarch64-sbsa: use the default console specified by ACPI
2023-03-01 15:58 [Buildroot] [PATCH 0/3] misc aarch64-sbsa cleanups Niklas Cassel via buildroot
2023-03-01 15:58 ` [Buildroot] [PATCH 1/3] board/qemu/aarch64-sbsa: use PARTLABEL to specify root Niklas Cassel via buildroot
@ 2023-03-01 15:58 ` Niklas Cassel via buildroot
2023-03-01 15:58 ` [Buildroot] [PATCH 3/3] board/qemu/aarch64-sbsa: drop unused kernel config file Niklas Cassel via buildroot
2023-03-02 12:59 ` [Buildroot] [PATCH 0/3] misc aarch64-sbsa cleanups Vincent Stehlé
3 siblings, 0 replies; 6+ messages in thread
From: Niklas Cassel via buildroot @ 2023-03-01 15:58 UTC (permalink / raw)
To: buildroot
Cc: Niklas Cassel, Romain Naour, Vincent Stehlé, Damien Le Moal
ARM SBBR (Server Base Boot Requirements) defines SPCR (Serial Port
Console Redirection Table) as a mandatory ACPI table that specifies
the configuration of a serial console.
In the linux kernel, ARM developers have decided that consoles defined
by SPCR are always enabled when existing, see e.g.:
https://lore.kernel.org/linux-serial/20200430161438.17640-1-alpernebiyasak@gmail.com/T/
Specifying console=ttyAMA0 (which is a serial console) is thus
redundant for an ARM SBSA board. (It also blindly assumes that
the serial console is on ttyAMA0, which might not be true.)
Drop the explicit console=ttyAMA0 on the kernel command line,
such that the kernel can pick up the default console defined
by SPCR.
This is similar to how it is currently done for
board/aarch64-efi/grub.cfg.
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
---
board/qemu/aarch64-sbsa/grub.cfg | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/qemu/aarch64-sbsa/grub.cfg b/board/qemu/aarch64-sbsa/grub.cfg
index 39b7842f8f..d99e19c4cd 100644
--- a/board/qemu/aarch64-sbsa/grub.cfg
+++ b/board/qemu/aarch64-sbsa/grub.cfg
@@ -2,5 +2,5 @@ set default="0"
set timeout="5"
menuentry "Buildroot" {
- linux /Image root=PARTLABEL=root rootwait console=ttyAMA0
+ linux /Image root=PARTLABEL=root rootwait
}
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 3/3] board/qemu/aarch64-sbsa: drop unused kernel config file
2023-03-01 15:58 [Buildroot] [PATCH 0/3] misc aarch64-sbsa cleanups Niklas Cassel via buildroot
2023-03-01 15:58 ` [Buildroot] [PATCH 1/3] board/qemu/aarch64-sbsa: use PARTLABEL to specify root Niklas Cassel via buildroot
2023-03-01 15:58 ` [Buildroot] [PATCH 2/3] board/qemu/aarch64-sbsa: use the default console specified by ACPI Niklas Cassel via buildroot
@ 2023-03-01 15:58 ` Niklas Cassel via buildroot
2023-03-02 13:12 ` Vincent Stehlé
2023-03-02 12:59 ` [Buildroot] [PATCH 0/3] misc aarch64-sbsa cleanups Vincent Stehlé
3 siblings, 1 reply; 6+ messages in thread
From: Niklas Cassel via buildroot @ 2023-03-01 15:58 UTC (permalink / raw)
To: buildroot
Cc: Niklas Cassel, Romain Naour, Vincent Stehlé, Damien Le Moal
The config file board/qemu/aarch64-sbsa/linux.config has
never been in use by configs/qemu_aarch64_sbsa_defconfig,
neither via BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE, nor via
BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES.
Thus the config file is and has always been unused.
Remove it such that no one might get the silly idea that
it is actually used for something.
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
---
board/qemu/aarch64-sbsa/linux.config | 68 ----------------------------
1 file changed, 68 deletions(-)
delete mode 100644 board/qemu/aarch64-sbsa/linux.config
diff --git a/board/qemu/aarch64-sbsa/linux.config b/board/qemu/aarch64-sbsa/linux.config
deleted file mode 100644
index a60cce02ec..0000000000
--- a/board/qemu/aarch64-sbsa/linux.config
+++ /dev/null
@@ -1,68 +0,0 @@
-CONFIG_SYSVIPC=y
-CONFIG_POSIX_MQUEUE=y
-CONFIG_NO_HZ_IDLE=y
-CONFIG_HIGH_RES_TIMERS=y
-CONFIG_TASKSTATS=y
-CONFIG_SCHED_AUTOGROUP=y
-CONFIG_PROFILING=y
-CONFIG_ARCH_VEXPRESS=y
-CONFIG_COMPAT=y
-CONFIG_FW_CFG_SYSFS=y
-CONFIG_FW_CFG_SYSFS_CMDLINE=y
-CONFIG_ACPI=y
-CONFIG_MODULES=y
-CONFIG_MODULE_UNLOAD=y
-CONFIG_BLK_DEV_BSGLIB=y
-CONFIG_BINFMT_MISC=y
-CONFIG_TRANSPARENT_HUGEPAGE=y
-CONFIG_NET=y
-CONFIG_PACKET=y
-CONFIG_PACKET_DIAG=y
-CONFIG_UNIX=y
-CONFIG_NET_KEY=y
-CONFIG_INET=y
-CONFIG_IP_MULTICAST=y
-CONFIG_IP_ADVANCED_ROUTER=y
-CONFIG_BRIDGE=m
-CONFIG_NET_SCHED=y
-CONFIG_VSOCKETS=y
-CONFIG_PCI=y
-CONFIG_PCI_HOST_GENERIC=y
-CONFIG_DEVTMPFS=y
-CONFIG_DEVTMPFS_MOUNT=y
-CONFIG_VIRTIO_BLK=y
-CONFIG_BLK_DEV_SD=y
-CONFIG_CHR_DEV_SG=y
-CONFIG_SCSI_CONSTANTS=y
-CONFIG_SCSI_LOGGING=y
-CONFIG_SCSI_SCAN_ASYNC=y
-CONFIG_SCSI_VIRTIO=y
-CONFIG_ATA=y
-CONFIG_SATA_AHCI_PLATFORM=y
-CONFIG_NETDEVICES=y
-CONFIG_DUMMY=y
-CONFIG_MACVLAN=y
-CONFIG_VIRTIO_NET=y
-CONFIG_NLMON=y
-CONFIG_SERIAL_AMBA_PL011=y
-CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
-CONFIG_VIRTIO_CONSOLE=y
-CONFIG_HW_RANDOM=y
-CONFIG_HW_RANDOM_VIRTIO=y
-CONFIG_TCG_TPM=y
-CONFIG_TCG_TIS=y
-CONFIG_DRM=y
-CONFIG_DRM_VIRTIO_GPU=y
-CONFIG_RTC_CLASS=y
-CONFIG_RTC_DRV_PL031=y
-CONFIG_VIRTIO_PCI=y
-CONFIG_VIRTIO_MMIO=y
-CONFIG_VIRTIO_MMIO_CMDLINE_DEVICES=y
-CONFIG_MAILBOX=y
-CONFIG_PL320_MBOX=y
-CONFIG_ARM_SMMU_V3=y
-CONFIG_EXT4_FS=y
-CONFIG_FUSE_FS=y
-CONFIG_VIRTIO_FS=y
-CONFIG_TMPFS=y
-CONFIG_TMPFS_POSIX_ACL=y
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 3/3] board/qemu/aarch64-sbsa: drop unused kernel config file
2023-03-01 15:58 ` [Buildroot] [PATCH 3/3] board/qemu/aarch64-sbsa: drop unused kernel config file Niklas Cassel via buildroot
@ 2023-03-02 13:12 ` Vincent Stehlé
0 siblings, 0 replies; 6+ messages in thread
From: Vincent Stehlé @ 2023-03-02 13:12 UTC (permalink / raw)
To: Niklas Cassel; +Cc: Romain Naour, Damien Le Moal, buildroot
On Wed, Mar 01, 2023 at 04:58:10PM +0100, Niklas Cassel wrote:
> The config file board/qemu/aarch64-sbsa/linux.config has
> never been in use by configs/qemu_aarch64_sbsa_defconfig,
> neither via BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE, nor via
> BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES.
>
> Thus the config file is and has always been unused.
Hi Niklas,
This fragment seems to be used by edk2 python unit test
`support/testing/tests/boot/test_edk2.py'.
I missed that during my testing of the defconfigs.
Best regards,
Vincent.
> Remove it such that no one might get the silly idea that
> it is actually used for something.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
> ---
> board/qemu/aarch64-sbsa/linux.config | 68 ----------------------------
> 1 file changed, 68 deletions(-)
> delete mode 100644 board/qemu/aarch64-sbsa/linux.config
>
> diff --git a/board/qemu/aarch64-sbsa/linux.config b/board/qemu/aarch64-sbsa/linux.config
> deleted file mode 100644
> index a60cce02ec..0000000000
> --- a/board/qemu/aarch64-sbsa/linux.config
> +++ /dev/null
> @@ -1,68 +0,0 @@
> -CONFIG_SYSVIPC=y
> -CONFIG_POSIX_MQUEUE=y
> -CONFIG_NO_HZ_IDLE=y
> -CONFIG_HIGH_RES_TIMERS=y
> -CONFIG_TASKSTATS=y
> -CONFIG_SCHED_AUTOGROUP=y
> -CONFIG_PROFILING=y
> -CONFIG_ARCH_VEXPRESS=y
> -CONFIG_COMPAT=y
> -CONFIG_FW_CFG_SYSFS=y
> -CONFIG_FW_CFG_SYSFS_CMDLINE=y
> -CONFIG_ACPI=y
> -CONFIG_MODULES=y
> -CONFIG_MODULE_UNLOAD=y
> -CONFIG_BLK_DEV_BSGLIB=y
> -CONFIG_BINFMT_MISC=y
> -CONFIG_TRANSPARENT_HUGEPAGE=y
> -CONFIG_NET=y
> -CONFIG_PACKET=y
> -CONFIG_PACKET_DIAG=y
> -CONFIG_UNIX=y
> -CONFIG_NET_KEY=y
> -CONFIG_INET=y
> -CONFIG_IP_MULTICAST=y
> -CONFIG_IP_ADVANCED_ROUTER=y
> -CONFIG_BRIDGE=m
> -CONFIG_NET_SCHED=y
> -CONFIG_VSOCKETS=y
> -CONFIG_PCI=y
> -CONFIG_PCI_HOST_GENERIC=y
> -CONFIG_DEVTMPFS=y
> -CONFIG_DEVTMPFS_MOUNT=y
> -CONFIG_VIRTIO_BLK=y
> -CONFIG_BLK_DEV_SD=y
> -CONFIG_CHR_DEV_SG=y
> -CONFIG_SCSI_CONSTANTS=y
> -CONFIG_SCSI_LOGGING=y
> -CONFIG_SCSI_SCAN_ASYNC=y
> -CONFIG_SCSI_VIRTIO=y
> -CONFIG_ATA=y
> -CONFIG_SATA_AHCI_PLATFORM=y
> -CONFIG_NETDEVICES=y
> -CONFIG_DUMMY=y
> -CONFIG_MACVLAN=y
> -CONFIG_VIRTIO_NET=y
> -CONFIG_NLMON=y
> -CONFIG_SERIAL_AMBA_PL011=y
> -CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
> -CONFIG_VIRTIO_CONSOLE=y
> -CONFIG_HW_RANDOM=y
> -CONFIG_HW_RANDOM_VIRTIO=y
> -CONFIG_TCG_TPM=y
> -CONFIG_TCG_TIS=y
> -CONFIG_DRM=y
> -CONFIG_DRM_VIRTIO_GPU=y
> -CONFIG_RTC_CLASS=y
> -CONFIG_RTC_DRV_PL031=y
> -CONFIG_VIRTIO_PCI=y
> -CONFIG_VIRTIO_MMIO=y
> -CONFIG_VIRTIO_MMIO_CMDLINE_DEVICES=y
> -CONFIG_MAILBOX=y
> -CONFIG_PL320_MBOX=y
> -CONFIG_ARM_SMMU_V3=y
> -CONFIG_EXT4_FS=y
> -CONFIG_FUSE_FS=y
> -CONFIG_VIRTIO_FS=y
> -CONFIG_TMPFS=y
> -CONFIG_TMPFS_POSIX_ACL=y
> --
> 2.39.2
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 0/3] misc aarch64-sbsa cleanups
2023-03-01 15:58 [Buildroot] [PATCH 0/3] misc aarch64-sbsa cleanups Niklas Cassel via buildroot
` (2 preceding siblings ...)
2023-03-01 15:58 ` [Buildroot] [PATCH 3/3] board/qemu/aarch64-sbsa: drop unused kernel config file Niklas Cassel via buildroot
@ 2023-03-02 12:59 ` Vincent Stehlé
3 siblings, 0 replies; 6+ messages in thread
From: Vincent Stehlé @ 2023-03-02 12:59 UTC (permalink / raw)
To: Niklas Cassel; +Cc: Romain Naour, Damien Le Moal, buildroot
On Wed, Mar 01, 2023 at 04:58:07PM +0100, Niklas Cassel wrote:
> Hello,
>
> Here come some small aarch64-sbsa cleanups.
> Please consider for inclusion.
Hi Niklas,
Thank you for this patch series. It works fine on my side (on top of `master'
and `next'). Feel free to add:
Tested-by: Vincent Stehlé <vincent.stehle@arm.com>
Best regards,
Vincent.
>
>
> Kind regards,
> Niklas
>
>
> Niklas Cassel (3):
> board/qemu/aarch64-sbsa: use PARTLABEL to specify root
> board/qemu/aarch64-sbsa: use the default console specified by ACPI
> board/qemu/aarch64-sbsa: drop unused kernel config file
>
> board/qemu/aarch64-sbsa/grub.cfg | 2 +-
> board/qemu/aarch64-sbsa/linux.config | 68 ----------------------------
> 2 files changed, 1 insertion(+), 69 deletions(-)
> delete mode 100644 board/qemu/aarch64-sbsa/linux.config
>
> --
> 2.39.2
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread