From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Romain Naour <romain.naour@smile.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/pkg-python.mk: fix typo
Date: Fri, 8 Dec 2023 23:43:13 +0100 [thread overview]
Message-ID: <ZXOcAb2EJ6W0eXkd@landeda> (raw)
In-Reply-To: <20231208131309.1036690-1-romain.naour@smile.fr>
Romain, All,
On 2023-12-08 14:13 +0100, Romain Naour spake thusly:
> Commit [1] introduced PKG_PYTHON_MATURIN_INSTALL_CMD while
> it should be HOST_PKG_PYTHON_MATURIN_INSTALL_CMD.
>
> Adding any new host python package using maturin setup type will
> fail during the install step.
>
> [1] 6b915358babe37a721b4f6e032ec884174bd6e0b
>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
Applied to master, thanks.
You could/should have pushed that yourself! ;-)
Regards,
Yann E. MORIN.
> ---
> package/pkg-python.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/pkg-python.mk b/package/pkg-python.mk
> index bda79116c8..4bed5a1835 100644
> --- a/package/pkg-python.mk
> +++ b/package/pkg-python.mk
> @@ -258,8 +258,8 @@ HOST_PKG_PYTHON_MATURIN_ENV = \
> HOST_PKG_PYTHON_MATURIN_BUILD_CMD = \
> $(HOST_PKG_PYTHON_PEP517_BUILD_CMD)
>
> -PKG_PYTHON_MATURIN_INSTALL_CMD = \
> - $(PKG_PYTHON_PEP517_INSTALL_CMD)
> +HOST_PKG_PYTHON_MATURIN_INSTALL_CMD = \
> + $(HOST_PKG_PYTHON_PEP517_INSTALL_CMD)
>
> ################################################################################
> # inner-python-package -- defines how the configuration, compilation
> --
> 2.43.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-12-08 22:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 13:13 [Buildroot] [PATCH] package/pkg-python.mk: fix typo Romain Naour
2023-12-08 22:43 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXOcAb2EJ6W0eXkd@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=romain.naour@smile.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox