* [Buildroot] [PATCH] package/pkg-python.mk: fix typo
@ 2023-12-08 13:13 Romain Naour
2023-12-08 22:43 ` Yann E. MORIN
0 siblings, 1 reply; 2+ messages in thread
From: Romain Naour @ 2023-12-08 13:13 UTC (permalink / raw)
To: buildroot; +Cc: Romain Naour
Commit [1] introduced PKG_PYTHON_MATURIN_INSTALL_CMD while
it should be HOST_PKG_PYTHON_MATURIN_INSTALL_CMD.
Adding any new host python package using maturin setup type will
fail during the install step.
[1] 6b915358babe37a721b4f6e032ec884174bd6e0b
Cc: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Romain Naour <romain.naour@smile.fr>
---
package/pkg-python.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/pkg-python.mk b/package/pkg-python.mk
index bda79116c8..4bed5a1835 100644
--- a/package/pkg-python.mk
+++ b/package/pkg-python.mk
@@ -258,8 +258,8 @@ HOST_PKG_PYTHON_MATURIN_ENV = \
HOST_PKG_PYTHON_MATURIN_BUILD_CMD = \
$(HOST_PKG_PYTHON_PEP517_BUILD_CMD)
-PKG_PYTHON_MATURIN_INSTALL_CMD = \
- $(PKG_PYTHON_PEP517_INSTALL_CMD)
+HOST_PKG_PYTHON_MATURIN_INSTALL_CMD = \
+ $(HOST_PKG_PYTHON_PEP517_INSTALL_CMD)
################################################################################
# inner-python-package -- defines how the configuration, compilation
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH] package/pkg-python.mk: fix typo
2023-12-08 13:13 [Buildroot] [PATCH] package/pkg-python.mk: fix typo Romain Naour
@ 2023-12-08 22:43 ` Yann E. MORIN
0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2023-12-08 22:43 UTC (permalink / raw)
To: Romain Naour; +Cc: buildroot
Romain, All,
On 2023-12-08 14:13 +0100, Romain Naour spake thusly:
> Commit [1] introduced PKG_PYTHON_MATURIN_INSTALL_CMD while
> it should be HOST_PKG_PYTHON_MATURIN_INSTALL_CMD.
>
> Adding any new host python package using maturin setup type will
> fail during the install step.
>
> [1] 6b915358babe37a721b4f6e032ec884174bd6e0b
>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
Applied to master, thanks.
You could/should have pushed that yourself! ;-)
Regards,
Yann E. MORIN.
> ---
> package/pkg-python.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/pkg-python.mk b/package/pkg-python.mk
> index bda79116c8..4bed5a1835 100644
> --- a/package/pkg-python.mk
> +++ b/package/pkg-python.mk
> @@ -258,8 +258,8 @@ HOST_PKG_PYTHON_MATURIN_ENV = \
> HOST_PKG_PYTHON_MATURIN_BUILD_CMD = \
> $(HOST_PKG_PYTHON_PEP517_BUILD_CMD)
>
> -PKG_PYTHON_MATURIN_INSTALL_CMD = \
> - $(PKG_PYTHON_PEP517_INSTALL_CMD)
> +HOST_PKG_PYTHON_MATURIN_INSTALL_CMD = \
> + $(HOST_PKG_PYTHON_PEP517_INSTALL_CMD)
>
> ################################################################################
> # inner-python-package -- defines how the configuration, compilation
> --
> 2.43.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-08 22:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-08 13:13 [Buildroot] [PATCH] package/pkg-python.mk: fix typo Romain Naour
2023-12-08 22:43 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox