* [Buildroot] [PATCH 1/1] package/memtest86: pass TARGET_CC @ 2023-12-07 22:09 Fabrice Fontaine 2023-12-08 22:53 ` Yann E. MORIN 0 siblings, 1 reply; 7+ messages in thread From: Fabrice Fontaine @ 2023-12-07 22:09 UTC (permalink / raw) To: buildroot; +Cc: Steve Kenton, Fabrice Fontaine Pass CC=$(TARGET_CC) to make to avoid the following build failure raised since bump to version 6.20 in commit a743087593a5fd5b33e2650591cada09929c27a6: gcc -m32 -x assembler-with-cpp -c -I../boot -o boot/startup.o ../boot/startup32.S gcc: error: unrecognized command-line option '-m32' Fixes: - http://autobuild.buildroot.org/results/15ece19703bb21c1326ff353aa79f3550a01f648 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/memtest86/memtest86.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/memtest86/memtest86.mk b/package/memtest86/memtest86.mk index c0f85755fe..51d5805e0a 100644 --- a/package/memtest86/memtest86.mk +++ b/package/memtest86/memtest86.mk @@ -20,7 +20,8 @@ endif endif define MEMTEST86_BUILD_CMDS - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/$(MEMTEST86_BUILD_DIR) + $(TARGET_CONFIGURE_OPTS) $(MAKE) CC=$(TARGET_CC) \ + -C $(@D)/$(MEMTEST86_BUILD_DIR) endef define MEMTEST86_INSTALL_IMAGES_CMDS -- 2.42.0 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/memtest86: pass TARGET_CC 2023-12-07 22:09 [Buildroot] [PATCH 1/1] package/memtest86: pass TARGET_CC Fabrice Fontaine @ 2023-12-08 22:53 ` Yann E. MORIN 2023-12-08 23:04 ` Fabrice Fontaine 0 siblings, 1 reply; 7+ messages in thread From: Yann E. MORIN @ 2023-12-08 22:53 UTC (permalink / raw) To: Fabrice Fontaine; +Cc: Steve Kenton, buildroot On 2023-12-07 23:09 +0100, Fabrice Fontaine spake thusly: > Pass CC=$(TARGET_CC) to make to avoid the following build failure raised > since bump to version 6.20 in commit > a743087593a5fd5b33e2650591cada09929c27a6: > > gcc -m32 -x assembler-with-cpp -c -I../boot -o boot/startup.o ../boot/startup32.S > gcc: error: unrecognized command-line option '-m32' > > Fixes: > - http://autobuild.buildroot.org/results/15ece19703bb21c1326ff353aa79f3550a01f648 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/memtest86/memtest86.mk | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/package/memtest86/memtest86.mk b/package/memtest86/memtest86.mk > index c0f85755fe..51d5805e0a 100644 > --- a/package/memtest86/memtest86.mk > +++ b/package/memtest86/memtest86.mk > @@ -20,7 +20,8 @@ endif > endif > > define MEMTEST86_BUILD_CMDS > - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/$(MEMTEST86_BUILD_DIR) > + $(TARGET_CONFIGURE_OPTS) $(MAKE) CC=$(TARGET_CC) \ CC=$(TARGET_CC) is already present in TARGET_CONFIGURE_OPTS, so why is it not accounted for? Regards, Yann E. MORIN. > + -C $(@D)/$(MEMTEST86_BUILD_DIR) > endef > > define MEMTEST86_INSTALL_IMAGES_CMDS > -- > 2.42.0 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/memtest86: pass TARGET_CC 2023-12-08 22:53 ` Yann E. MORIN @ 2023-12-08 23:04 ` Fabrice Fontaine 2023-12-08 23:12 ` Yann E. MORIN 0 siblings, 1 reply; 7+ messages in thread From: Fabrice Fontaine @ 2023-12-08 23:04 UTC (permalink / raw) To: Yann E. MORIN; +Cc: Steve Kenton, buildroot Le ven. 8 déc. 2023 à 23:54, Yann E. MORIN <yann.morin.1998@free.fr> a écrit : > > On 2023-12-07 23:09 +0100, Fabrice Fontaine spake thusly: > > Pass CC=$(TARGET_CC) to make to avoid the following build failure raised > > since bump to version 6.20 in commit > > a743087593a5fd5b33e2650591cada09929c27a6: > > > > gcc -m32 -x assembler-with-cpp -c -I../boot -o boot/startup.o ../boot/startup32.S > > gcc: error: unrecognized command-line option '-m32' > > > > Fixes: > > - http://autobuild.buildroot.org/results/15ece19703bb21c1326ff353aa79f3550a01f648 > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > --- > > package/memtest86/memtest86.mk | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/package/memtest86/memtest86.mk b/package/memtest86/memtest86.mk > > index c0f85755fe..51d5805e0a 100644 > > --- a/package/memtest86/memtest86.mk > > +++ b/package/memtest86/memtest86.mk > > @@ -20,7 +20,8 @@ endif > > endif > > > > define MEMTEST86_BUILD_CMDS > > - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/$(MEMTEST86_BUILD_DIR) > > + $(TARGET_CONFIGURE_OPTS) $(MAKE) CC=$(TARGET_CC) \ > > CC=$(TARGET_CC) is already present in TARGET_CONFIGURE_OPTS, so why is > it not accounted for? Because "CC=$(TARGET_CC) make" is not the same as "make CC=$(TARGET_CC)" as build{32,64}/Makefile is setting CC to gcc. > > Regards, > Yann E. MORIN. > > > + -C $(@D)/$(MEMTEST86_BUILD_DIR) > > endef > > > > define MEMTEST86_INSTALL_IMAGES_CMDS > > -- > > 2.42.0 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@buildroot.org > > https://lists.buildroot.org/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------' Best Regards, Fabrice _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/memtest86: pass TARGET_CC 2023-12-08 23:04 ` Fabrice Fontaine @ 2023-12-08 23:12 ` Yann E. MORIN 2023-12-08 23:20 ` Fabrice Fontaine 0 siblings, 1 reply; 7+ messages in thread From: Yann E. MORIN @ 2023-12-08 23:12 UTC (permalink / raw) To: Fabrice Fontaine; +Cc: Steve Kenton, buildroot Fbrice, All, On 2023-12-09 00:04 +0100, Fabrice Fontaine spake thusly: > Le ven. 8 déc. 2023 à 23:54, Yann E. MORIN <yann.morin.1998@free.fr> a écrit : > > On 2023-12-07 23:09 +0100, Fabrice Fontaine spake thusly: > > > Pass CC=$(TARGET_CC) to make to avoid the following build failure raised > > > since bump to version 6.20 in commit > > > a743087593a5fd5b33e2650591cada09929c27a6: [--SNIP--] > > > define MEMTEST86_BUILD_CMDS > > > - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/$(MEMTEST86_BUILD_DIR) > > > + $(TARGET_CONFIGURE_OPTS) $(MAKE) CC=$(TARGET_CC) \ > > CC=$(TARGET_CC) is already present in TARGET_CONFIGURE_OPTS, so why is > > it not accounted for? > Because "CC=$(TARGET_CC) make" is not the same as "make > CC=$(TARGET_CC)" Yeah, I know that pretty well (even if I never remember the rules of precedence for the environment, argument, and Makefile variables)... > as build{32,64}/Makefile is setting CC to gcc. But that was not the case previously, I guess, as you said it appeared with the bump to 6.20. So maybe we should now move the whole of $(TARGET_CONFIGURE_OPTS) to be arguments rather than environment variables, instead of just moving CC there. Regards, Yann E. MORIN. > > > > Regards, > > Yann E. MORIN. > > > > > + -C $(@D)/$(MEMTEST86_BUILD_DIR) > > > endef > > > > > > define MEMTEST86_INSTALL_IMAGES_CMDS > > > -- > > > 2.42.0 > > > > > > _______________________________________________ > > > buildroot mailing list > > > buildroot@buildroot.org > > > https://lists.buildroot.org/mailman/listinfo/buildroot > > > > -- > > .-----------------.--------------------.------------------.--------------------. > > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > > '------------------------------^-------^------------------^--------------------' > > Best Regards, > > Fabrice -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/memtest86: pass TARGET_CC 2023-12-08 23:12 ` Yann E. MORIN @ 2023-12-08 23:20 ` Fabrice Fontaine 2023-12-09 9:28 ` Yann E. MORIN 0 siblings, 1 reply; 7+ messages in thread From: Fabrice Fontaine @ 2023-12-08 23:20 UTC (permalink / raw) To: Yann E. MORIN; +Cc: Steve Kenton, buildroot Le sam. 9 déc. 2023 à 00:12, Yann E. MORIN <yann.morin.1998@free.fr> a écrit : > > Fbrice, All, > > On 2023-12-09 00:04 +0100, Fabrice Fontaine spake thusly: > > Le ven. 8 déc. 2023 à 23:54, Yann E. MORIN <yann.morin.1998@free.fr> a écrit : > > > On 2023-12-07 23:09 +0100, Fabrice Fontaine spake thusly: > > > > Pass CC=$(TARGET_CC) to make to avoid the following build failure raised > > > > since bump to version 6.20 in commit > > > > a743087593a5fd5b33e2650591cada09929c27a6: > [--SNIP--] > > > > define MEMTEST86_BUILD_CMDS > > > > - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/$(MEMTEST86_BUILD_DIR) > > > > + $(TARGET_CONFIGURE_OPTS) $(MAKE) CC=$(TARGET_CC) \ > > > CC=$(TARGET_CC) is already present in TARGET_CONFIGURE_OPTS, so why is > > > it not accounted for? > > Because "CC=$(TARGET_CC) make" is not the same as "make > > CC=$(TARGET_CC)" > > Yeah, I know that pretty well (even if I never remember the rules of > precedence for the environment, argument, and Makefile variables)... > > > as build{32,64}/Makefile is setting CC to gcc. > > But that was not the case previously, I guess, as you said it appeared > with the bump to 6.20. So maybe we should now move the whole of > $(TARGET_CONFIGURE_OPTS) to be arguments rather than environment > variables, instead of just moving CC there. I already tried that but it raises a build failure because the following CFLAGS will be overridden: CFLAGS = -std=c11 -Wall -Wextra -Wshadow -m32 -march=i586 -fpic -fno-builtin \ -ffreestanding -fomit-frame-pointer -fno-stack-protector > > Regards, > Yann E. MORIN. > > > > > > > Regards, > > > Yann E. MORIN. > > > > > > > + -C $(@D)/$(MEMTEST86_BUILD_DIR) > > > > endef > > > > > > > > define MEMTEST86_INSTALL_IMAGES_CMDS > > > > -- > > > > 2.42.0 > > > > > > > > _______________________________________________ > > > > buildroot mailing list > > > > buildroot@buildroot.org > > > > https://lists.buildroot.org/mailman/listinfo/buildroot > > > > > > -- > > > .-----------------.--------------------.------------------.--------------------. > > > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > > > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > > > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > > > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > > > '------------------------------^-------^------------------^--------------------' > > > > Best Regards, > > > > Fabrice > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------' Best Regards, Fabrice _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/memtest86: pass TARGET_CC 2023-12-08 23:20 ` Fabrice Fontaine @ 2023-12-09 9:28 ` Yann E. MORIN 2023-12-23 20:10 ` Thomas Petazzoni via buildroot 0 siblings, 1 reply; 7+ messages in thread From: Yann E. MORIN @ 2023-12-09 9:28 UTC (permalink / raw) To: Fabrice Fontaine; +Cc: Steve Kenton, buildroot Fabrice, All, On 2023-12-09 00:20 +0100, Fabrice Fontaine spake thusly: > Le sam. 9 déc. 2023 à 00:12, Yann E. MORIN <yann.morin.1998@free.fr> a écrit : > > On 2023-12-09 00:04 +0100, Fabrice Fontaine spake thusly: > > > Le ven. 8 déc. 2023 à 23:54, Yann E. MORIN <yann.morin.1998@free.fr> a écrit : > > > > On 2023-12-07 23:09 +0100, Fabrice Fontaine spake thusly: > > > > > Pass CC=$(TARGET_CC) to make to avoid the following build failure raised > > > > > since bump to version 6.20 in commit > > > > > a743087593a5fd5b33e2650591cada09929c27a6: > > [--SNIP--] > > > > > define MEMTEST86_BUILD_CMDS > > > > > - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/$(MEMTEST86_BUILD_DIR) > > > > > + $(TARGET_CONFIGURE_OPTS) $(MAKE) CC=$(TARGET_CC) \ > > > > CC=$(TARGET_CC) is already present in TARGET_CONFIGURE_OPTS, so why is > > > > it not accounted for? > > > Because "CC=$(TARGET_CC) make" is not the same as "make > > > CC=$(TARGET_CC)" > > > > Yeah, I know that pretty well (even if I never remember the rules of > > precedence for the environment, argument, and Makefile variables)... > > > > > as build{32,64}/Makefile is setting CC to gcc. > > > > But that was not the case previously, I guess, as you said it appeared > > with the bump to 6.20. So maybe we should now move the whole of > > $(TARGET_CONFIGURE_OPTS) to be arguments rather than environment > > variables, instead of just moving CC there. > > I already tried that but it raises a build failure because the > following CFLAGS will be overridden: > > CFLAGS = -std=c11 -Wall -Wextra -Wshadow -m32 -march=i586 -fpic -fno-builtin \ > -ffreestanding -fomit-frame-pointer -fno-stack-protector OK, but then it means we also have to forcibly override a few other variables, as the Makefile defines them: AS = as -64 CC = gcc OBJCOPY = objcopy Both AS and OBJCOPY are equally wrong in cross-compilation as CC is. But for LD, it does iuse the one from the environment. Also, arguably, letting the packag define its own CFLAGS is not nice, because it is missing all the ones we are setting, like the _FORTIFY, the optimisations, or the debug levels... But in fact, memtest86+ is a free-standing project (it runs as a kernel or a bootloader in fact), so that's OK to let it override those CFLAGS. Also, I know why that did not happen in previous versions: we simply were not building memtes86+ and were just copying the pre-built files. Can you please respin to account for AS and OBJDUMP, and add a blurb that CFLAGS is overriden but that's OK? Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/memtest86: pass TARGET_CC 2023-12-09 9:28 ` Yann E. MORIN @ 2023-12-23 20:10 ` Thomas Petazzoni via buildroot 0 siblings, 0 replies; 7+ messages in thread From: Thomas Petazzoni via buildroot @ 2023-12-23 20:10 UTC (permalink / raw) To: Yann E. MORIN; +Cc: Steve Kenton, Fabrice Fontaine, buildroot On Sat, 9 Dec 2023 10:28:13 +0100 "Yann E. MORIN" <yann.morin.1998@free.fr> wrote: > Can you please respin to account for AS and OBJDUMP, and add a blurb > that CFLAGS is overriden but that's OK? Then, does it make sense to pass $(TARGET_CONFIGURE_OPTS) in the environment altogether? Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-12-23 20:10 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-12-07 22:09 [Buildroot] [PATCH 1/1] package/memtest86: pass TARGET_CC Fabrice Fontaine 2023-12-08 22:53 ` Yann E. MORIN 2023-12-08 23:04 ` Fabrice Fontaine 2023-12-08 23:12 ` Yann E. MORIN 2023-12-08 23:20 ` Fabrice Fontaine 2023-12-09 9:28 ` Yann E. MORIN 2023-12-23 20:10 ` Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox