Re: [Buildroot] [PATCH 1/3] configs: add support for the Raspberry Pi 5 board.

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Christophe Blaess" <christophe.blaess@logilin.fr>,
	"Gaël PORTAY" <gael.portay@rtone.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/3] configs: add support for the Raspberry Pi 5 board.
Date: Wed, 13 Dec 2023 22:01:41 +0100	[thread overview]
Message-ID: <ZXobtaqzrUQ3eXLw@landeda> (raw)
In-Reply-To: <20231211081730.1406640-1-christophe.blaess@logilin.fr>

Christophe, All,

+Gaël for almost simultaneous similar submission.

On 2023-12-11 09:17 +0100, Christophe Blaess spake thusly:
> The Raspberry Pi 5 defconfig is mostly inspired by the Raspberry
> Pi 4 64-bits defconfig.
> 
> 
> (sorry for possible double post, I had some issues with the email I
> used for subscribing to the mailing list).
> 
> Signed-off-by: Christophe Blaess <christophe.blaess@logilin.fr>

This series is not correct: if we apply just the first patch, then the
config file will be missing: it should have been a single commit.

Besides, the change to rpi-firmware should have come first.

Gaël has sent another series about the rpi5:
    https://patchwork.ozlabs.org/project/buildroot/list/?series=386144

Can you look at his patch and see what is missing compared to what you
did?

Regards,
Yann E. MORIN.

> ---
>  configs/raspberrypi5_defconfig | 45 ++++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 configs/raspberrypi5_defconfig
> 
> diff --git a/configs/raspberrypi5_defconfig b/configs/raspberrypi5_defconfig
> new file mode 100644
> index 0000000000..031f24a977
> --- /dev/null
> +++ b/configs/raspberrypi5_defconfig
> @@ -0,0 +1,45 @@
> +BR2_aarch64=y
> +BR2_cortex_a76=y
> +BR2_ARM_FPU_VFPV4=y
> +
> +BR2_TOOLCHAIN_BUILDROOT_CXX=y
> +
> +BR2_SYSTEM_DHCP="eth0"
> +
> +# Linux headers same as kernel, a 6.1 series
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
> +
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,17f135b742c4edb340afb365873c3a574f7e16cb)/linux-17f135b742c4edb340afb365873c3a574f7e16cb.tar.gz"
> +BR2_LINUX_KERNEL_DEFCONFIG="bcm2712"
> +
> +# Build the DTB from the kernel sources
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="broadcom/bcm2712-rpi-5-b"
> +
> +BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> +
> +BR2_PACKAGE_RPI_FIRMWARE=y
> +BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4=y
> +BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi5/config_5.txt"
> +
> +# Required tools to create the SD image
> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +BR2_PACKAGE_HOST_MTOOLS=y
> +
> +# Filesystem / image
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
> +# BR2_TARGET_ROOTFS_TAR is not set
> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi5/post-build.sh"
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi5/post-image.sh"
> +
> +# Enable compressed kernel module support
> +BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
> +BR2_PACKAGE_KMOD_TOOLS=y
> +BR2_PACKAGE_XZ=y
> +BR2_PACKAGE_KMOD=y
> +BR2_PACKAGE_HOST_KMOD_XZ=y
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot