Re: [Buildroot] [PATCH v2 2/3] package/ripgrep: bump to version 14.0.3

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Antoine Coutant <antoine.coutant@smile.fr>,
	romain.naour@smile.fr, sebastian.weyer@smile.fr,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 2/3] package/ripgrep: bump to version 14.0.3
Date: Sat, 30 Dec 2023 20:44:33 +0100	[thread overview]
Message-ID: <ZZBzIdHGdJufQNWn@landeda> (raw)
In-Reply-To: <20231230190019.434e1b4b@windsurf>

Thomas, All,

On 2023-12-30 19:00 +0100, Thomas Petazzoni via buildroot spake thusly:
> On Fri, 29 Dec 2023 23:13:35 +0100
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > If that's so, then we have a big problem: the hashes for all the
> > cargo-based packages will change, and thus it means we will have to
> > name the generated archive based on the cargo version used to do the
> > vendoring. That would apply to:
> Note that I also encountered some hash mismatch on some Rust/Cargo
> package recently, and BR was falling back to sources.buildroot.net. I
> did not have the time to investigate at the time (I was looking into
> another issue, and didn't want to enter an infinite recursion of
> problem solving quest). And now, I don't remember with which package I
> encountered this. But yes, it seems like we have a reproducibility
> issue.

So, I tested with commit b7938d2, i.e. before the rust version bump, and
ripgrep already has a hash issue:

    ERROR: ripgrep-af6b6c543b224d348a8876f0c06245d9ea7929c5.tar.gz has wrong sha256 hash:
    ERROR: expected: 6f1d4a8b653ce48d59ad777288b1257cbda607db29db19d031b7e622c60526f8
    ERROR: got     : 9d9769e45ffe6089f58bc19fa39dd6b6299aa0c3ad90508d21dfa27a3d3416d5

In 2023-01-01, it was already failing but the reported hash was
different:

http://autobuild.buildroot.org/results/43d/43d9b993a019c9c46701924f664476c2ac900b2b/build-end.log

    ERROR: got     : ed72a5ad6592c2c605ed9712e896872fd3858b94895601dbbb9f7d2a94b105af

Then on 2023-06-25, a vendoring suceeded (the last ripgrep build failure
reported in autobuilder):

http://autobuild.buildroot.org/results/15b/15bea8d3bc8765ec9088c5bc380d482caee1b6d5/build-end.log

Then, I had hash issues with host-sentry-cli, too:

    ERROR: sentry-cli-2.20.3.tar.gz has wrong sha256 hash:
    ERROR: expected: 2188b8eead4f2b6543725b23852427bea164e8dd76bf1ce33f41ca0c03cfeee7
    ERROR: got     : 4db94489e7c427ff092483529eee56229fa764b619669f9f9e6e663cc4a05abc

The other cargo-vendored packages were all OK.

Then, with the rust version bump to 1.74.1, the vendoring status is
unchanged:

  - ripgrep fails vendoring, and reports the same hash failure
  - host-sentry-cli fails vendoring, again with the same reported hash
    failure
  - all other cargo-vendored packages are fine and don't need a hash
    bump because of th rust bump.

So, we need to understand why we have two cargo-vendored packages that
are not reproducible...

More investigations later on...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot