Re: [Buildroot] [PATCH v2 2/3] package/ripgrep: bump to version 14.0.3

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Thomas, Antoine, All,

+James and Eric fr their previous work on the rust side

On 2023-12-30 20:44 +0100, Yann E. MORIN spake thusly:
> On 2023-12-30 19:00 +0100, Thomas Petazzoni via buildroot spake thusly:
> > On Fri, 29 Dec 2023 23:13:35 +0100
> > "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > Note that I also encountered some hash mismatch on some Rust/Cargo
> > package recently, and BR was falling back to sources.buildroot.net. I
> > did not have the time to investigate at the time (I was looking into
> > another issue, and didn't want to enter an infinite recursion of
> > problem solving quest). And now, I don't remember with which package I
> > encountered this. But yes, it seems like we have a reproducibility
> > issue.
> So, I tested with commit b7938d2, i.e. before the rust version bump, and
> ripgrep already has a hash issue:
>     ERROR: ripgrep-af6b6c543b224d348a8876f0c06245d9ea7929c5.tar.gz has wrong sha256 hash:
>     ERROR: expected: 6f1d4a8b653ce48d59ad777288b1257cbda607db29db19d031b7e622c60526f8
>     ERROR: got     : 9d9769e45ffe6089f58bc19fa39dd6b6299aa0c3ad90508d21dfa27a3d3416d5

I took some time to try and pinpoint the issue. Alas, I have no clue,
just more questions.

I first tried to reproduce the original hash for ripgrep, i.e. when it
was converted over to the cargo infra, commit 342fd3e735. But that fails
to build because of an unrelated issue in the package infra, which was
fixed a few commits later, e27a700f3e.

And on that commit, it fails to reproduce a valid hash here: the hash I
got was again something else totally:
    ERROR: got     : 37d14c1eecb24e5b921c3b0e8a22ed93501db6f7aa4d0732d6be03dfc8647f77

This is very troubling. My system is a Fedora 39 recently installed on
my new laptop. What about I try and reproduce on an older system that
was current back when ripgrep was converted? So I used that old Ubuntu
16.04 that lies around, and there, miracle, the hash for ripgrep, on
commit e27a700f3e, does match what we expect!

So, can that machine get us a proper hash for ripgrep on master? Nope;
    ERROR: got     : 9d9769e45ffe6089f58bc19fa39dd6b6299aa0c3ad90508d21dfa27a3d3416d5

OK, back to square one.

So, can our (current) docker-run wrapper help us? Back to commit
e27a700f3e, which is known good on ubuntu 16.04, but bad on Fedora 39:

    ripgrep-af6b6c543b224d348a8876f0c06245d9ea7929c5.tar.gz: OK (sha256: 6f1d4a8b653ce48d59ad777288b1257cbda607db29db19d031b7e622c60526f8)

OK, so what, now?

As a reminder, commit e27a700f3e contains the core infra fix just after
the conversion of ripgrep to the cargo infra. Here's a little summary of
what happens

                            e27a700f3e      master
    Ubuntu 16.04.7;
      - native              OK              KO +
    Fedora 39:
      - native              KO *            KO +
      - ./utils/docker-run  OK              KO +

*: hash 37d14c1eecb24e5b921c3b0e8a22ed93501db6f7aa4d0732d6be03dfc8647f77
+: hash 9d9769e45ffe6089f58bc19fa39dd6b6299aa0c3ad90508d21dfa27a3d3416d5

So, we have two issues:

  - the cargo version has an impact on the vendoring

  - the build environment has an impact on the vendoring.

On my side, further investigations will probably have to wait for next
year... Notably, I'll try and see what diffoscope points out as a delta
between those various tarballs...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot