[Buildroot] [PATCH 1/1] package/eudev: add sgx group for eudev-3.2.12

[Buildroot] [PATCH 1/1] package/eudev: add sgx group for eudev-3.2.12

[Kunihiko Hayashi]

The eudev has "sgx" group in 50-udev-default.rules as default
since commit 247724da450b.

The group is defined by package/systemd [1], however, when
enabling BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y with
qemu_aarch64_virt_defconfig, the systemd isn't used and the following
warning occurs:

    udevd[153]: specified group 'sgx' unknown

Just add sgx group to the package/eudev.

[1] https://lists.buildroot.org/pipermail/buildroot/2022-April/641079.html

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 package/eudev/eudev.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/eudev/eudev.mk b/package/eudev/eudev.mk
index 235a71967ef5..14e22ee50a1f 100644
--- a/package/eudev/eudev.mk
+++ b/package/eudev/eudev.mk
@@ -55,6 +55,10 @@ define EUDEV_INSTALL_INIT_OPENRC
 	@:
 endef
 
+define EUDEV_USERS
+	- - sgx -1 * - - - SGX device nodes
+endef
+
 HOST_EUDEV_DEPENDENCIES = host-gperf host-pkgconf
 
 HOST_EUDEV_CONF_OPTS = \
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/eudev: add sgx group for eudev-3.2.12

[Thomas Petazzoni via buildroot]

On Wed, 20 Dec 2023 19:56:23 +0900
Kunihiko Hayashi <hayashi.kunihiko@socionext.com> wrote:

> The eudev has "sgx" group in 50-udev-default.rules as default
> since commit 247724da450b.
> 
> The group is defined by package/systemd [1], however, when
> enabling BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y with
> qemu_aarch64_virt_defconfig, the systemd isn't used and the following
> warning occurs:
> 
>     udevd[153]: specified group 'sgx' unknown

If I'm correct, this is due to those rules:

SUBSYSTEM=="misc", KERNEL=="sgx_enclave", GROUP="sgx", MODE="0660"
SUBSYSTEM=="misc", KERNEL=="sgx_vepc", GROUP="sgx", MODE="0660"

why do these rules trigger on an AArch64 system? Isn't SGX an Intel
thing?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/eudev: add sgx group for eudev-3.2.12

[Kunihiko Hayashi]

Hi Thomas,

Thank you for your comment.

On 2023/12/23 23:26, Thomas Petazzoni wrote:
> On Wed, 20 Dec 2023 19:56:23 +0900
> Kunihiko Hayashi <hayashi.kunihiko@socionext.com> wrote:
> 
>> The eudev has "sgx" group in 50-udev-default.rules as default
>> since commit 247724da450b.
>>
>> The group is defined by package/systemd [1], however, when
>> enabling BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y with
>> qemu_aarch64_virt_defconfig, the systemd isn't used and the following
>> warning occurs:
>>
>>      udevd[153]: specified group 'sgx' unknown
> 
> If I'm correct, this is due to those rules:
> 
> SUBSYSTEM=="misc", KERNEL=="sgx_enclave", GROUP="sgx", MODE="0660"
> SUBSYSTEM=="misc", KERNEL=="sgx_vepc", GROUP="sgx", MODE="0660"
> 
> why do these rules trigger on an AArch64 system? Isn't SGX an Intel
> thing?

As you said, aarch64 system doesn't trigger these rules.

It seems that eudev checks once whether each group defined by GROUP
exists in /etc/group, regardless of any conditions.

Thank you,

---
Best Regards
Kunihiko Hayashi
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/eudev: add sgx group for eudev-3.2.12

[Yann E. MORIN]

Kunihiko Hayashi, All,

On 2023-12-20 19:56 +0900, Kunihiko Hayashi spake thusly:
> The eudev has "sgx" group in 50-udev-default.rules as default
> since commit 247724da450b.
> 
> The group is defined by package/systemd [1], however, when
> enabling BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y with
> qemu_aarch64_virt_defconfig, the systemd isn't used and the following
> warning occurs:
> 
>     udevd[153]: specified group 'sgx' unknown
> 
> Just add sgx group to the package/eudev.
> 
> [1] https://lists.buildroot.org/pipermail/buildroot/2022-April/641079.html
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

Peter has sent a better patch, which I applied:
    https://gitlab.com/buildroot.org/buildroot/-/commit/edfa9ea45ce3c2ddad2c52ab57a8047f4257c76f

Thank you for your contribution nonetheless!

Regards,
Yann E. MORIN.

> ---
>  package/eudev/eudev.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/eudev/eudev.mk b/package/eudev/eudev.mk
> index 235a71967ef5..14e22ee50a1f 100644
> --- a/package/eudev/eudev.mk
> +++ b/package/eudev/eudev.mk
> @@ -55,6 +55,10 @@ define EUDEV_INSTALL_INIT_OPENRC
>  	@:
>  endef
>  
> +define EUDEV_USERS
> +	- - sgx -1 * - - - SGX device nodes
> +endef
> +
>  HOST_EUDEV_DEPENDENCIES = host-gperf host-pkgconf
>  
>  HOST_EUDEV_CONF_OPTS = \
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/eudev: add sgx group for eudev-3.2.12

[Kunihiko Hayashi]

Hi Yann,

On 2024/01/11 19:38, Yann E. MORIN wrote:
> Kunihiko Hayashi, All,
> 
> On 2023-12-20 19:56 +0900, Kunihiko Hayashi spake thusly:
>> The eudev has "sgx" group in 50-udev-default.rules as default
>> since commit 247724da450b.
>>
>> The group is defined by package/systemd [1], however, when
>> enabling BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y with
>> qemu_aarch64_virt_defconfig, the systemd isn't used and the following
>> warning occurs:
>>
>>      udevd[153]: specified group 'sgx' unknown
>>
>> Just add sgx group to the package/eudev.
>>
>> [1] https://lists.buildroot.org/pipermail/buildroot/2022-April/641079.html
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> 
> Peter has sent a better patch, which I applied:
>      https://gitlab.com/buildroot.org/buildroot/-/commit/edfa9ea45ce3c2ddad2c52ab57a8047f4257c76f
> 
> Thank you for your contribution nonetheless!

Thank you for letting me know.
I think it's better to add it in udev, too.

Thank you,

---
Best Regards
Kunihiko Hayashi
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot