Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/criu: add C++ comment
@ 2024-01-14 11:28 Fabrice Fontaine
  2024-01-14 11:40 ` Yann E. MORIN
  2024-01-14 21:27 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2024-01-14 11:28 UTC (permalink / raw)
  To: buildroot; +Cc: Marcus Folkesson, Fabrice Fontaine

Commit 3e4b479f39c15ffdf307ec8395d856680c727204 forgot to add C++
comment

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/criu/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/criu/Config.in b/package/criu/Config.in
index fc0da823b3..4c295acf4f 100644
--- a/package/criu/Config.in
+++ b/package/criu/Config.in
@@ -43,9 +43,9 @@ config BR2_PACKAGE_CRIU
 
 	  https://criu.org/Main_Page
 
-comment "criu needs a glibc or musl toolchain w/ threads, gcc >= 8, headers >= 4.18, dynamic library, wchar"
+comment "criu needs a glibc or musl toolchain w/ threads, gcc >= 8, headers >= 4.18, C++, dynamic library, wchar"
 	depends on BR2_PACKAGE_CRIU_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || !BR2_TOOLCHAIN_HAS_THREADS \
 		|| !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_18 \
-		|| BR2_TOOLCHAIN_USES_UCLIBC \
+		|| BR2_TOOLCHAIN_USES_UCLIBC || !BR2_INSTALL_LIBSTDCPP \
 		|| BR2_STATIC_LIBS || !BR2_USE_WCHAR
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/criu: add C++ comment
  2024-01-14 11:28 [Buildroot] [PATCH 1/1] package/criu: add C++ comment Fabrice Fontaine
@ 2024-01-14 11:40 ` Yann E. MORIN
  2024-01-14 21:27 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2024-01-14 11:40 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Marcus Folkesson, buildroot

Fabrice, All,

On 2024-01-14 12:28 +0100, Fabrice Fontaine spake thusly:
> Commit 3e4b479f39c15ffdf307ec8395d856680c727204 forgot to add C++
> comment
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/criu/Config.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/criu/Config.in b/package/criu/Config.in
> index fc0da823b3..4c295acf4f 100644
> --- a/package/criu/Config.in
> +++ b/package/criu/Config.in
> @@ -43,9 +43,9 @@ config BR2_PACKAGE_CRIU
>  
>  	  https://criu.org/Main_Page
>  
> -comment "criu needs a glibc or musl toolchain w/ threads, gcc >= 8, headers >= 4.18, dynamic library, wchar"
> +comment "criu needs a glibc or musl toolchain w/ threads, gcc >= 8, headers >= 4.18, C++, dynamic library, wchar"
>  	depends on BR2_PACKAGE_CRIU_ARCH_SUPPORTS
>  	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || !BR2_TOOLCHAIN_HAS_THREADS \
>  		|| !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_18 \
> -		|| BR2_TOOLCHAIN_USES_UCLIBC \
> +		|| BR2_TOOLCHAIN_USES_UCLIBC || !BR2_INSTALL_LIBSTDCPP \
>  		|| BR2_STATIC_LIBS || !BR2_USE_WCHAR
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/criu: add C++ comment
  2024-01-14 11:28 [Buildroot] [PATCH 1/1] package/criu: add C++ comment Fabrice Fontaine
  2024-01-14 11:40 ` Yann E. MORIN
@ 2024-01-14 21:27 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2024-01-14 21:27 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Marcus Folkesson, buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Commit 3e4b479f39c15ffdf307ec8395d856680c727204 forgot to add C++
 > comment

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-01-14 21:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-14 11:28 [Buildroot] [PATCH 1/1] package/criu: add C++ comment Fabrice Fontaine
2024-01-14 11:40 ` Yann E. MORIN
2024-01-14 21:27 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox