Re: [Buildroot] [PATCH v3 08/10] package/flutter-gallery: add a configure step

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Adam, All,

On 2024-01-17 15:50 -0700, Adam Duskett spake thusly:
> To make the next patch easier to understand, add a configure step to the
> flutter-gallery.mk file. The `$(HOST_FLUTTER_SDK_BIN_FLUTTER) build bundle`
> command is placed in the configure step because it generates several files
> needed for the flutter_gen_snapshot tool to generate the target .so file.
> 
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
>  package/flutter-gallery/flutter-gallery.mk | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/package/flutter-gallery/flutter-gallery.mk b/package/flutter-gallery/flutter-gallery.mk
> index 57a476b1ab..50ddd9ffba 100644
> --- a/package/flutter-gallery/flutter-gallery.mk
> +++ b/package/flutter-gallery/flutter-gallery.mk
> @@ -14,12 +14,17 @@ FLUTTER_GALLERY_DEPENDENCIES = \
>  
>  FLUTTER_GALLERY_INSTALL_DIR = $(TARGET_DIR)/usr/share/flutter/gallery/$(FLUTTER_ENGINE_RUNTIME_MODE)
>  
> -define FLUTTER_GALLERY_BUILD_CMDS
> +define FLUTTER_GALLERY_CONFIGURE_CMDS
>  	cd $(@D) && \
>  		FLUTTER_RUNTIME_MODES=$(FLUTTER_ENGINE_RUNTIME_MODE) \
>  		$(HOST_FLUTTER_SDK_BIN_FLUTTER) clean && \
> -		$(HOST_FLUTTER_SDK_BIN_FLUTTER) packages get && \
> +		$(HOST_FLUTTER_SDK_BIN_FLUTTER) pub get && \

As disucssed on IRC< that belonged to a spearate patch, so I split this
patch int two, and applied to master, thanks.

Regards,
Yann E. MORIN.

> -		$(HOST_FLUTTER_SDK_BIN_FLUTTER) build bundle && \
> +		$(HOST_FLUTTER_SDK_BIN_FLUTTER) build bundle
> +endef
> +
> +define FLUTTER_GALLERY_BUILD_CMDS
> +	cd $(@D) && \
> +		FLUTTER_RUNTIME_MODES=$(FLUTTER_ENGINE_RUNTIME_MODE) \
>  		$(HOST_FLUTTER_SDK_BIN_DART_BIN) package:gallery/main.dart && \
>  		$(HOST_FLUTTER_SDK_BIN_ENV) $(FLUTTER_ENGINE_GEN_SNAPSHOT) \
>  			--deterministic \
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot