Re: [Buildroot] [PATCH v3 07/10] package/flutter-pi/Config.in: propagate flutter-engine dependencies

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Adam, All,

On 2024-01-17 15:50 -0700, Adam Duskett spake thusly:
> As discussed with Yann, it is better to make the dependencies of
> flutter-pi verbose, even if flutter-engine and host-flutter-sdk-bin have
> eleven dependencies combined. This change clears up any ambiguity a user may
> have regarding the dependencies the flutter-pi package relies upon and why.

This patch does not really do what the commit log states. Indeed, there
is no need to "propagate flutter-engine dependencies", as the package
"depends on" flutter-engine.

What the package does, really, is invert the semantics of the dependency
to flutter-engine.

Indeed, the reasoning is that flutter-engine, by name, is an engine,
i.e. a runtime that executes applications. As such, it is more logical
that applications select flutter-engine, rather than depend on it, hence
the inversion of the dependency logic in this patch.

It also makes flutter-pi, an embedder, behave the same as
ivi-homescreen, another embedder.

So, I've eventually applied to master, with a reworded commit log,
thanks.

Regards,
Yann E. MORIN.

> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
>  package/flutter-pi/Config.in | 31 ++++++++++++++++++++++++++++---
>  1 file changed, 28 insertions(+), 3 deletions(-)
> 
> diff --git a/package/flutter-pi/Config.in b/package/flutter-pi/Config.in
> index 4bbdc3cc77..bb0e3702c1 100644
> --- a/package/flutter-pi/Config.in
> +++ b/package/flutter-pi/Config.in
> @@ -1,9 +1,20 @@
>  menuconfig BR2_PACKAGE_FLUTTER_PI
>  	bool "flutter-pi"
> -	depends on BR2_PACKAGE_FLUTTER_ENGINE
> +	depends on BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_ARCH_SUPPORTS
> +	depends on BR2_PACKAGE_FLUTTER_ENGINE_ARCH_SUPPORTS
> +	depends on BR2_HOST_GCC_AT_LEAST_5 # flutter-engine
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # flutter-engine
> +	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # flutter-engine
> +	depends on BR2_TOOLCHAIN_USES_GLIBC # flutter-engine
> +	depends on BR2_INSTALL_LIBSTDCPP # flutter-engine
> +	depends on !BR2_STATIC_LIBS # flutter-engine, wayland
> +	depends on BR2_USE_WCHAR # flutter-engine
> +	depends on BR2_PACKAGE_HAS_LIBGL || BR2_PACKAGE_HAS_LIBGLES # flutter-engine
>  	depends on BR2_PACKAGE_HAS_LIBGBM
>  	depends on BR2_PACKAGE_SYSTEMD # Event loop and dbus support
>  	depends on BR2_PACKAGE_HAS_UDEV # libinput
> +	select BR2_PACKAGE_HOST_FLUTTER_SDK_BIN
> +	select BR2_PACKAGE_FLUTTER_ENGINE
>  	select BR2_PACKAGE_LIBDRM
>  	select BR2_PACKAGE_LIBINPUT
>  	select BR2_PACKAGE_LIBXKBCOMMON
> @@ -80,8 +91,22 @@ config BR2_PACKAGE_FLUTTER_PI_TEXT_INPUT_PLUGIN
>  
>  endif
>  
> -comment "flutter-pi needs flutter-engine"
> -	depends on !BR2_PACKAGE_FLUTTER_ENGINE
> +comment "flutter-pi needs a glibc toolchain w/ wchar, C++, gcc >= 5, dynamic library, host gcc >= 5"
> +	depends on BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_ARCH_SUPPORTS
> +	depends on BR2_PACKAGE_FLUTTER_ENGINE_ARCH_SUPPORTS
> +	depends on !BR2_TOOLCHAIN_USES_GLIBC || !BR2_INSTALL_LIBSTDCPP \
> +		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_5 || BR2_STATIC_LIBS \
> +		|| !BR2_USE_WCHAR || !BR2_HOST_GCC_AT_LEAST_5
> +
> +comment "flutter-pi needs a toolchain not affected by GCC bug 64735"
> +	depends on BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_ARCH_SUPPORTS
> +	depends on BR2_PACKAGE_FLUTTER_ENGINE_ARCH_SUPPORTS
> +	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> +
> +comment "flutter-pi needs an OpenGL or OpenGLES backend"
> +	depends on BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_ARCH_SUPPORTS
> +	depends on BR2_PACKAGE_FLUTTER_ENGINE_ARCH_SUPPORTS
> +	depends on !BR2_PACKAGE_HAS_LIBGL && !BR2_PACKAGE_HAS_LIBGLES
>  
>  comment "flutter-pi needs GBM, systemd, and udev"
>  	depends on !BR2_PACKAGE_HAS_LIBGBM || \
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot