Re: [Buildroot] [PATCH v4 3/7] package/spirv-llvm-translator: add target variant to provide LLVMSPIRVLib

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Antoine Coutant <antoine.coutant@smile.fr>
Cc: sebastian.weyer@smile.fr, bernd@kuhls.net, romain.naour@smile.fr,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v4 3/7] package/spirv-llvm-translator: add target variant to provide LLVMSPIRVLib
Date: Wed, 7 Feb 2024 16:08:42 +0100	[thread overview]
Message-ID: <ZcOc-u_S09WCYWE1@landeda> (raw)
In-Reply-To: <20240202093625.1409559-4-antoine.coutant@smile.fr>

Antoine, All,

On 2024-02-02 10:36 +0100, Antoine Coutant spake thusly:
> From: Romain Naour <romain.naour@smile.fr>
> 
> This target version is needed for Rusticl which is an LLVM based OpenCL
> framework[1]. Rusticl allow programs to compile OpenCL C/C++ code
> at runtime with Clang. Clang generates LLVM IR which is translated into
> SPIR-V by spirv-llvm-translator. Finally, mesa can use its internal
> tools to manage SPIR-V.
> 
> [1]: https://docs.mesa3d.org/rusticl.html
> 
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> Signed-off-by: Sebastian Weyer <sebastian.weyer@smile.fr>
> Signed-off-by: Antoine Coutant <antoine.coutant@smile.fr>
> ---
[--SNIP--]
> diff --git a/package/spirv-llvm-translator/spirv-llvm-translator.mk b/package/spirv-llvm-translator/spirv-llvm-translator.mk
> index 523890a986..8361a74c59 100644
> --- a/package/spirv-llvm-translator/spirv-llvm-translator.mk
> +++ b/package/spirv-llvm-translator/spirv-llvm-translator.mk
> @@ -10,7 +10,7 @@ SPIRV_LLVM_TRANSLATOR_VERSION = v15.0.0-46-ge82ecc2bd7295604fcf1824e47c95fa6a09c
>  SPIRV_LLVM_TRANSLATOR_SITE = $(call github,KhronosGroup,SPIRV-LLVM-Translator,$(SPIRV_LLVM_TRANSLATOR_VERSION))
>  SPIRV_LLVM_TRANSLATOR_LICENSE = NCSA
>  SPIRV_LLVM_TRANSLATOR_LICENSE_FILES = LICENSE.TXT
> -HOST_SPIRV_LLVM_TRANSLATOR_DEPENDENCIES = host-clang host-llvm host-spirv-headers
> +HOST_SPIRV_LLVM_TRANSLATOR_DEPENDENCIES = host-clang host-llvm host-spirv-headers spirv-headers zlib

It looks dubious that a host package, host-spirv-llvm-translator,
depends on target packages, spirv-headers and zlib.

If this is really the case, then this would require a good explanation
in the commit log.

>  HOST_SPIRV_LLVM_TRANSLATOR_CONF_OPTS = \
>  	-DLLVM_BUILD_TOOLS=ON \
>  	-DLLVM_DIR=$(HOST_DIR)/lib/cmake/llvm \
> @@ -19,4 +19,14 @@ HOST_SPIRV_LLVM_TRANSLATOR_CONF_OPTS = \
>  	-DLLVM_EXTERNAL_PROJECTS="SPIRV-Headers" \
>  	-DLLVM_EXTERNAL_SPIRV_HEADERS_SOURCE_DIR=$(HOST_DIR)/include
>  
> +SPIRV_LLVM_TRANSLATOR_INSTALL_STAGING = YES
> +SPIRV_LLVM_TRANSLATOR_DEPENDENCIES = host-clang host-llvm llvm
> +SPIRV_LLVM_TRANSLATOR_CONF_OPTS = \
> +	-DLLVM_EXTERNAL_SPIRV_HEADERS_SOURCE_DIR=${STAGING_DIR}/usr \

    $ ./utils/docker-run make check-package
    package/spirv-llvm-translator/spirv-llvm-translator.mk:25: use $() to delimit variables, not ${}

Regards,
Yann E. MORIN.

> +	-DLLVM_BUILD_TOOLS=ON \
> +	-DLLVM_DIR=$(STAGING_DIR)/lib/cmake/llvm \
> +	-DLLVM_SPIRV_BUILD_EXTERNAL=YES \
> +	-DLLVM_SPIRV_INCLUDE_TESTS=OFF
> +
> +$(eval $(cmake-package))
>  $(eval $(host-cmake-package))
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot