Re: [Buildroot] [PATCH v4 4/7] package/opencl-headers: new package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Antoine, All,

On 2024-02-02 10:36 +0100, Antoine Coutant spake thusly:
> From: Sebastian Weyer <sebastian.weyer@smile.fr>
> 
> These headers provide the C language API bindings. It is a complement to
> the C++ bindings already available in opencl-clhpp. This package is
> required to build opencl-icd-loader:
> 
> https://github.com/KhronosGroup/OpenCL-ICD-Loader#dependencies
> 
> Signed-off-by: Sebastian Weyer <sebastian.weyer@smile.fr>
> Signed-off-by: Antoine Coutant <antoine.coutant@smile.fr>
> ---
[--SNIP--]
> diff --git a/package/opencl-headers/Config.in b/package/opencl-headers/Config.in
> new file mode 100644
> index 0000000000..092d8a2a4d
> --- /dev/null
> +++ b/package/opencl-headers/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_OPENCL_HEADERS
> +	bool "opencl-headers"
> +	depends on BR2_PACKAGE_HAS_LIBOPENCL

BR2_PACKAGE_HAS_LIBOPENCL can be set by mesa3d when BR2_PACKAGE_MESA3D_OPENCL
is enabled. In this case, will mesa3d install its own headers? If so,
that will generate a conflict.

Furthermore, this will also conflict with mesa3d-headers, and it also
installs CL headers.

So, why do we need opencl-headers and can't rely on the existing
mesa3d-headers package?

Regards,
Yann E. MORIN.

> +	help
> +	  C language headers for the OpenCL API
> +
> +	  https://github.com/KhronosGroup/OpenCL-Headers
> diff --git a/package/opencl-headers/opencl-headers.hash b/package/opencl-headers/opencl-headers.hash
> new file mode 100644
> index 0000000000..802ed05450
> --- /dev/null
> +++ b/package/opencl-headers/opencl-headers.hash
> @@ -0,0 +1,3 @@
> +#Locally generated
> +sha256  407d5e109a70ec1b6cd3380ce357c21e3d3651a91caae6d0d8e1719c69a1791d  OpenCL-Headers-2023.12.14.tar.gz
> +sha256  cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30  LICENSE
> diff --git a/package/opencl-headers/opencl-headers.mk b/package/opencl-headers/opencl-headers.mk
> new file mode 100644
> index 0000000000..7aa0e0d168
> --- /dev/null
> +++ b/package/opencl-headers/opencl-headers.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# opencl-headers
> +#
> +################################################################################
> +
> +OPENCL_HEADERS_VERSION = 2023.12.14
> +OPENCL_HEADERS_SOURCE = OpenCL-Headers-$(OPENCL_HEADERS_VERSION).tar.gz
> +OPENCL_HEADERS_SITE = $(call github,KhronosGroup,OpenCL-Headers,v$(OPENCL_HEADERS_VERSION))
> +OPENCL_HEADERS_LICENSE = Apache-2.0
> +OPENCL_HEADERS_LICENSE_FILES = LICENSE
> +OPENCL_HEADERS_INSTALL_STAGING = YES
> +
> +OPENCL_HEADERS_INSTALL_TARGET = NO
> +
> +define OPENCL_HEADERS_INSTALL_STAGING_CMDS
> +	mkdir -p $(STAGING_DIR)/usr/include/CL
> +	$(INSTALL) -D -m 0644 $(@D)/CL/* \
> +		$(STAGING_DIR)/usr/include/CL
> +endef
> +
> +$(eval $(generic-package))
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot