From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Reza Arbab <arbab@linux.ibm.com>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>,
Laurent Vivier <laurent@vivier.eu>, Joel Stanley <joel@jms.id.au>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v5 1/5] package/petitboot: minor makefile cleanup
Date: Wed, 7 Feb 2024 20:14:16 +0100 [thread overview]
Message-ID: <ZcPWiF48ZmAVFALi@landeda> (raw)
In-Reply-To: <20240207175135.1532037-2-arbab@linux.ibm.com>
Reza, All,
On 2024-02-07 11:51 -0600, Reza Arbab spake thusly:
> Normalize the order of arguments to $(INSTALL). Remove an unnecessary
> pair of parentheses.
>
> Signed-off-by: Reza Arbab <arbab@linux.ibm.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/petitboot/petitboot.mk | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/petitboot/petitboot.mk b/package/petitboot/petitboot.mk
> index 2087f01b090c..4c8bc35adb38 100644
> --- a/package/petitboot/petitboot.mk
> +++ b/package/petitboot/petitboot.mk
> @@ -63,15 +63,15 @@ define PETITBOOT_POST_INSTALL
> $(TARGET_DIR)/etc/petitboot/boot.d/01-create-default-dtb
> $(INSTALL) -D -m 0755 $(@D)/utils/hooks/90-sort-dtb \
> $(TARGET_DIR)/etc/petitboot/boot.d/90-sort-dtb
> - $(INSTALL) -m 0755 -D $(PETITBOOT_PKGDIR)/S15pb-discover \
> + $(INSTALL) -D -m 0755 $(PETITBOOT_PKGDIR)/S15pb-discover \
> $(TARGET_DIR)/etc/init.d/S15pb-discover
> $(INSTALL) -D -m 0755 $(PETITBOOT_PKGDIR)/pb-console \
> $(TARGET_DIR)/etc/init.d/pb-console
>
> mkdir -p $(TARGET_DIR)/etc/udev/rules.d
> - (for port in $(PETITBOOT_GETTY_PORT); do \
> + for port in $(PETITBOOT_GETTY_PORT); do \
> printf 'SUBSYSTEM=="tty", KERNEL=="%s", RUN+="/etc/init.d/pb-console start $$name"\n' "$$port"; \
> - done) > $(TARGET_DIR)/etc/udev/rules.d/petitboot-console-ui.rules
> + done > $(TARGET_DIR)/etc/udev/rules.d/petitboot-console-ui.rules
>
> mkdir -p $(TARGET_DIR)/usr/share/udhcpc/default.script.d/
> ln -sf /usr/sbin/pb-udhcpc \
> --
> 2.39.3
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-02-07 19:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 17:51 [Buildroot] [PATCH v5 0/5] package/petitboot: misc fixes/enhancement Reza Arbab
2024-02-07 17:51 ` [Buildroot] [PATCH v5 1/5] package/petitboot: minor makefile cleanup Reza Arbab
2024-02-07 19:14 ` Yann E. MORIN [this message]
2024-03-08 11:27 ` Peter Korsgaard
2024-02-07 17:51 ` [Buildroot] [PATCH v5 2/5] package/petitboot: prefer UTF-8 support Reza Arbab
2024-02-07 19:43 ` Yann E. MORIN
2024-03-08 11:27 ` Peter Korsgaard
2024-02-07 17:51 ` [Buildroot] [PATCH v5 3/5] package/petitboot: fix shutdown Reza Arbab
2024-07-12 22:02 ` Arnout Vandecappelle via buildroot
2024-02-07 17:51 ` [Buildroot] [PATCH v5 4/5] package/petitboot: run script when exiting to shell Reza Arbab
2024-07-12 22:02 ` Arnout Vandecappelle via buildroot
2024-02-07 17:51 ` [Buildroot] [PATCH v5 5/5] package/petitboot: run UI as non-root user Reza Arbab
2024-07-12 22:03 ` Arnout Vandecappelle via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcPWiF48ZmAVFALi@landeda \
--to=yann.morin.1998@free.fr \
--cc=arbab@linux.ibm.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=joel@jms.id.au \
--cc=laurent@vivier.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox