Re: [Buildroot] [PATCH v5 2/5] package/petitboot: prefer UTF-8 support

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Reza Arbab <arbab@linux.ibm.com>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>,
	Laurent Vivier <laurent@vivier.eu>, Joel Stanley <joel@jms.id.au>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v5 2/5] package/petitboot: prefer UTF-8 support
Date: Wed, 7 Feb 2024 20:43:33 +0100	[thread overview]
Message-ID: <ZcPdZSkAFZViQ5vV@landeda> (raw)
In-Reply-To: <20240207175135.1532037-3-arbab@linux.ibm.com>

Reza, All,

On 2024-02-07 11:51 -0600, Reza Arbab spake thusly:
> The petitboot UI looks much nicer in a Unicode locale:
> 
> * Items in the language selection submenu use multibyte Unicode
>   characters. In other locales, they say "Unable to display text in this
>   locale".
> 
> * The combination of TERM=linux with a UTF-8 locale is required to
>   trigger a special-case workaround in ncurses code[1]. Without
>   this, line-drawing characters in the menu look like q's.
> 
> Turn on wchar support in ncurses, and add a reminder that a UTF-8 locale
> should be generated for things to look right.
> 
> [1] https://invisible-island.net/ncurses/ncurses.faq.html#no_line_drawing
> 
> Signed-off-by: Reza Arbab <arbab@linux.ibm.com>
> ---
>  package/petitboot/Config.in | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/petitboot/Config.in b/package/petitboot/Config.in
> index 6a3d476b11b3..4f3b1c1ea4d1 100644
> --- a/package/petitboot/Config.in
> +++ b/package/petitboot/Config.in
> @@ -10,6 +10,7 @@ config BR2_PACKAGE_PETITBOOT
>  	select BR2_PACKAGE_ELFUTILS
>  	select BR2_PACKAGE_LVM2 # devmapper
>  	select BR2_PACKAGE_NCURSES
> +	select BR2_PACKAGE_NCURSES_WCHAR
>  	# run-time dependencies
>  	select BR2_PACKAGE_KEXEC if !BR2_PACKAGE_KEXEC_LITE_ARCH_SUPPORTS
>  	select BR2_PACKAGE_KEXEC_LITE if BR2_PACKAGE_KEXEC_LITE_ARCH_SUPPORTS && !BR2_PACKAGE_KEXEC
> @@ -18,6 +19,8 @@ config BR2_PACKAGE_PETITBOOT
>  	help
>  	  Petitboot is a small kexec-based bootloader
>  
> +	  NOTE: petitboot looks best in a UTF-8 locale (BR2_GENERATE_LOCALE)

    $ ./utils/docker-run make check-package
    package/petitboot/Config.in:22: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)

I slightly reworded that sentence to better fit.

Applied to master with the above fixed, thanks.

Regards,
Yann E. MORIN.

>  	  http://www.kernel.org/pub/linux/kernel/people/geoff/petitboot/petitboot.html
>  
>  if BR2_PACKAGE_PETITBOOT
> -- 
> 2.39.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot