Re: [Buildroot] [PATCH 2/2] package/python-cython: bump to version 3.0.8

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Joseph Kogut <joseph.kogut@gmail.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/python-cython: bump to version 3.0.8
Date: Sun, 11 Feb 2024 22:30:29 +0100	[thread overview]
Message-ID: <Zck8dbS2rUrI23uZ@landeda> (raw)
In-Reply-To: <20240209175631.1337370-2-james.hilliard1@gmail.com>

James, All,

On 2024-02-09 10:56 -0700, James Hilliard spake thusly:
> License hash changed due to changing links from http to https:
> https://github.com/cython/cython/commit/331d9d824ee5f0c539310332215ebd6ed3257325

Thanks for the simple and sufficient explanation. 👍

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
[--SNIP--]
> diff --git a/package/python-cython/python-cython.mk b/package/python-cython/python-cython.mk
> index 47e105c065..d76bfb766d 100644
> --- a/package/python-cython/python-cython.mk
> +++ b/package/python-cython/python-cython.mk
> @@ -4,9 +4,9 @@
>  #
>  ################################################################################
>  
> -PYTHON_CYTHON_VERSION = 0.29.36
> +PYTHON_CYTHON_VERSION = 3.0.8

Given there was an earlier discussion about how the cython bump was
causing some issues with various packages, I would have expected at
least a post-commit summarising what tests were done to ensure the bump
was OK.

Also, as those same discussions hinted at, cython 0.29 seems to still be
in active development (or at least active maintenance), so the commit
log should have also explained why it was decided to go with a full bump
to 3.0.x rather than intriducing a cython3 package and installing both
in parallel. Or that it was not possiblr to do so becaus they can't be
installed in parallel.

Could you respin this series, fixing the check-package issues in patch
1, and extending the commit log pqtch 2 to better assess the situation,
please?

Regards,
Yann E. MORIN.

>  PYTHON_CYTHON_SOURCE = Cython-$(PYTHON_CYTHON_VERSION).tar.gz
> -PYTHON_CYTHON_SITE = https://files.pythonhosted.org/packages/38/db/df0e99d6c5fe19ee5c981d22aad557be4bdeed3ecfae25d47b84b07f0f98
> +PYTHON_CYTHON_SITE = https://files.pythonhosted.org/packages/68/09/ffb61f29b8e3d207c444032b21328327d753e274ea081bc74e009827cc81
>  PYTHON_CYTHON_SETUP_TYPE = setuptools
>  PYTHON_CYTHON_LICENSE = Apache-2.0
>  PYTHON_CYTHON_LICENSE_FILES = COPYING.txt LICENSE.txt
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot