Re: [Buildroot] [PATCH 1/2] package/python-uvloop: add support for cython3

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Joseph Kogut <joseph.kogut@gmail.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/python-uvloop: add support for cython3
Date: Sun, 11 Feb 2024 22:57:51 +0100	[thread overview]
Message-ID: <ZclC3_dSvLTp6Ras@landeda> (raw)
In-Reply-To: <CADvTj4ppD06TSGnYUUBSzB_sV6vErb2ozyMuGr1QjyLtu_pvPA@mail.gmail.com>

James, All,

On 2024-02-11 14:39 -0700, James Hilliard spake thusly:
> On Sun, Feb 11, 2024 at 2:24 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > On 2024-02-09 10:56 -0700, James Hilliard spake thusly:
> > > Add patches from pending upstream pull request which add cython3
> > > compatibility.
> > We are a little bit cautious at applying random patches that have not
> > yet been at least reviewd by upstream. In this case, there has not been
> > any upstream activity since the last release, and not muc before that
> > either...
> Well these patches are being used by gentoo so they are not entirely
> untested in the real world.

It's not that they are tested or not. It is about whether they'll have a
chance to be accepted upstream, or whether we'll have to carry and
maintain them forever in Buildroot.

Maybe it's time that someone pings upstream about that PR?

> > We have no in-tree user of uvloop, so I wonder whether it makes snse to
> > keep it, espcially since it mau be blocking the bumps of other packages
> > (like cython 3.x being required by whats-its-name).
> That's not entirely true, it's a common optional dependency for packages
> like python-uvicorn for example.

    $ git grep -i -E python.uvloop

would turn only python-uvloop itself, and its runtime test. If it
is only optional, and prevents us from updating unless we apply
non-upstreamable patches, then I'd argue we should drop it.

[--SNIP--]
> I'll fix and resend.

Thanks.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot