[Buildroot] [PATCH 1/1] package/google-breakpad: fix missing include error

[Buildroot] [PATCH 1/1] package/google-breakpad: fix missing include error

[Kadambini Nema]

src/common/module.cc: In member function ‘bool google_breakpad::Module::AddFunction(Function*)’:
src/common/module.cc:194:52: error: ‘find_if’ is not a member of ‘std’; did you mean ‘find’?
  194 |     FunctionSet::iterator existing_function = std::find_if(
      |                                                    ^~~~~~~
      |                                                    find
Makefile:8309: recipe for target 'src/common/tools_mac_dump_syms_dump_syms_mac-module.o' failed

This error is seen on gcc-14.

https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5137658
https://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-devtools/breakpad/breakpad/0001-Fixed-missing-include-for-std-find_if.patch

Signed-off-by: Kadambini Nema <kadambini.nema@gmail.com>
---
 ...ixed-missing-include-for-std-find_if.patch | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch

diff --git a/package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch b/package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch
new file mode 100644
index 0000000000..141e12b613
--- /dev/null
+++ b/package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch
@@ -0,0 +1,26 @@
+From 898a997855168c0e6a689072fefba89246271a5d Mon Sep 17 00:00:00 2001
+From: Nathan Moinvaziri <nathan@nathanm.com>
+Date: Tue, 19 Dec 2023 14:35:05 -0800
+Subject: [PATCH] Fixed missing include for std::find_if.
+
+Throws an error when compiling on Windows.
+
+Change-Id: Ieb34c00cf199aaa1b45a440086c48b8ed363b3c7
+Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5137658
+Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
+Upstream: https://github.com/google/breakpad/commit/898a997855168c0e6a689072fefba89246271a5d
+Signed-off-by: Kadambini Nema <kadambini.nema@gmail.com>
+---
+
+diff --git a/src/common/module.cc b/src/common/module.cc
+index 0eb5aad..b6f5da7 100644
+--- a/src/common/module.cc
++++ b/src/common/module.cc
+@@ -42,6 +42,7 @@
+ #include <stdio.h>
+ #include <string.h>
+ 
++#include <algorithm>
+ #include <functional>
+ #include <iostream>
+ #include <memory>
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/google-breakpad: fix missing include error

[Yann E. MORIN]

Kadambini, All,

On 2024-02-19 12:40 -0800, Kadambini Nema spake thusly:
> src/common/module.cc: In member function ‘bool google_breakpad::Module::AddFunction(Function*)’:
> src/common/module.cc:194:52: error: ‘find_if’ is not a member of ‘std’; did you mean ‘find’?
>   194 |     FunctionSet::iterator existing_function = std::find_if(
>       |                                                    ^~~~~~~
>       |                                                    find
> Makefile:8309: recipe for target 'src/common/tools_mac_dump_syms_dump_syms_mac-module.o' failed
> 
> This error is seen on gcc-14.
> 
> https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5137658
> https://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-devtools/breakpad/breakpad/0001-Fixed-missing-include-for-std-find_if.patch
> 
> Signed-off-by: Kadambini Nema <kadambini.nema@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  ...ixed-missing-include-for-std-find_if.patch | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch
> 
> diff --git a/package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch b/package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch
> new file mode 100644
> index 0000000000..141e12b613
> --- /dev/null
> +++ b/package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch
> @@ -0,0 +1,26 @@
> +From 898a997855168c0e6a689072fefba89246271a5d Mon Sep 17 00:00:00 2001
> +From: Nathan Moinvaziri <nathan@nathanm.com>
> +Date: Tue, 19 Dec 2023 14:35:05 -0800
> +Subject: [PATCH] Fixed missing include for std::find_if.
> +
> +Throws an error when compiling on Windows.
> +
> +Change-Id: Ieb34c00cf199aaa1b45a440086c48b8ed363b3c7
> +Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5137658
> +Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
> +Upstream: https://github.com/google/breakpad/commit/898a997855168c0e6a689072fefba89246271a5d
> +Signed-off-by: Kadambini Nema <kadambini.nema@gmail.com>
> +---
> +
> +diff --git a/src/common/module.cc b/src/common/module.cc
> +index 0eb5aad..b6f5da7 100644
> +--- a/src/common/module.cc
> ++++ b/src/common/module.cc
> +@@ -42,6 +42,7 @@
> + #include <stdio.h>
> + #include <string.h>
> + 
> ++#include <algorithm>
> + #include <functional>
> + #include <iostream>
> + #include <memory>
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 1/1] package/google-breakpad: fix missing include error

[Kadambini Nema]

src/common/module.cc: In member function ‘bool google_breakpad::Module::AddFunction(Function*)’:
src/common/module.cc:194:52: error: ‘find_if’ is not a member of ‘std’; did you mean ‘find’?
  194 |     FunctionSet::iterator existing_function = std::find_if(
      |                                                    ^~~~~~~
      |                                                    find
Makefile:8309: recipe for target 'src/common/tools_mac_dump_syms_dump_syms_mac-module.o' failed

This error is seen on gcc-14.

related links:
https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5137658
https://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-devtools/breakpad/breakpad/0001-Fixed-missing-include-for-std-find_if.patch

Signed-off-by: Kadambini Nema <kadambini.nema@gmail.com>
---
 ...ixed-missing-include-for-std-find_if.patch | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch

diff --git a/package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch b/package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch
new file mode 100644
index 0000000000..80eab723b3
--- /dev/null
+++ b/package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch
@@ -0,0 +1,24 @@
+From 898a997855168c0e6a689072fefba89246271a5d Mon Sep 17 00:00:00 2001
+From: Nathan Moinvaziri <nathan@nathanm.com>
+Date: Tue, 19 Dec 2023 14:35:05 -0800
+Subject: [PATCH] Fixed missing include for std::find_if.
+
+Throws an error when compiling on Windows.
+
+Change-Id: Ieb34c00cf199aaa1b45a440086c48b8ed363b3c7
+Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5137658
+Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
+---
+
+diff --git a/src/common/module.cc b/src/common/module.cc
+index 0eb5aad..b6f5da7 100644
+--- a/src/common/module.cc
++++ b/src/common/module.cc
+@@ -42,6 +42,7 @@
+ #include <stdio.h>
+ #include <string.h>
+ 
++#include <algorithm>
+ #include <functional>
+ #include <iostream>
+ #include <memory>
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/google-breakpad: fix missing include error

[Yann E. MORIN]

Kadambini, All,

On 2024-02-17 17:16 -0800, Kadambini Nema spake thusly:
> src/common/module.cc: In member function ‘bool google_breakpad::Module::AddFunction(Function*)’:
> src/common/module.cc:194:52: error: ‘find_if’ is not a member of ‘std’; did you mean ‘find’?
>   194 |     FunctionSet::iterator existing_function = std::find_if(
>       |                                                    ^~~~~~~
>       |                                                    find
> Makefile:8309: recipe for target 'src/common/tools_mac_dump_syms_dump_syms_mac-module.o' failed
> 
> This error is seen on gcc-14.
> 
> related links:
> https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5137658
> https://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-devtools/breakpad/breakpad/0001-Fixed-missing-include-for-std-find_if.patch
> 
> Signed-off-by: Kadambini Nema <kadambini.nema@gmail.com>
> ---
>  ...ixed-missing-include-for-std-find_if.patch | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch
> 
> diff --git a/package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch b/package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch
> new file mode 100644
> index 0000000000..80eab723b3
> --- /dev/null
> +++ b/package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch
> @@ -0,0 +1,24 @@
> +From 898a997855168c0e6a689072fefba89246271a5d Mon Sep 17 00:00:00 2001
> +From: Nathan Moinvaziri <nathan@nathanm.com>
> +Date: Tue, 19 Dec 2023 14:35:05 -0800
> +Subject: [PATCH] Fixed missing include for std::find_if.
> +
> +Throws an error when compiling on Windows.
> +
> +Change-Id: Ieb34c00cf199aaa1b45a440086c48b8ed363b3c7
> +Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5137658
> +Reviewed-by: Ivan Penkov <ivanpe@chromium.org>

    $ ./utils/docker-run make check-package
    package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch:0: missing Signed-off-by in the header (https://nightly.buildroot.org/#_format_and_licensing_of_the_package_patches)
    package/google-breakpad/0001-Fixed-missing-include-for-std-find_if.patch:0: missing Upstream in the header (https://nightly.buildroot.org/#_additional_patch_documentation)

Although I could have fixed the Uptream tag issue, I can't add your SoB
line. Could you please respin with:

  - your Signed-off-by: tag
  - the Upstream: tag, that points to the upstream commit, i.e.:
    https://github.com/google/breakpad/commit/898a997855168c0e6a689072fefba89246271a5d

Regards,
Yann E. MORIN.

> +---
> +
> +diff --git a/src/common/module.cc b/src/common/module.cc
> +index 0eb5aad..b6f5da7 100644
> +--- a/src/common/module.cc
> ++++ b/src/common/module.cc
> +@@ -42,6 +42,7 @@
> + #include <stdio.h>
> + #include <string.h>
> + 
> ++#include <algorithm>
> + #include <functional>
> + #include <iostream>
> + #include <memory>
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot