From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Francois Perrad <francois.perrad@gadz.org>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH 3/3] package/lua-lgdbm: new package
Date: Wed, 3 Apr 2024 23:12:03 +0200 [thread overview]
Message-ID: <Zg3GI3q2nTcbBIPM@landeda> (raw)
In-Reply-To: <20240403085424.1650628-3-francois.perrad@gadz.org>
Fraçois, All
On 2024-04-03 10:54 +0200, Francois Perrad spake thusly:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
[--SNIP--]
> diff --git a/package/lua-lgdbm/Config.in b/package/lua-lgdbm/Config.in
> new file mode 100644
> index 0000000000..ac5c64cc79
> --- /dev/null
> +++ b/package/lua-lgdbm/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_LUA_LGDBM
> + bool "lua-lgdbm"
> + depends on BR2_PACKAGE_LUA_5_3 || BR2_PACKAGE_LUA_5_4
> + select BR2_PACKAGE_GDBM
You need to propagate the dependencies of gdbm here: MMU and WCHAR.
> new file mode 100644
> index 0000000000..b21565fb6e
> --- /dev/null
> +++ b/support/testing/tests/package/test_lua_lgdbm.py
> @@ -0,0 +1,14 @@
> +from tests.package.test_lua import TestLuaBase
> +
> +
> +class TestLuaLgdbm(TestLuaBase):
> + config = TestLuaBase.config + \
> + """
> + BR2_PACKAGE_LUA=y
> + BR2_PACKAGE_LUA_LGDBM=y
> + """
> +
> + def test_run(self):
> + self.login()
> + self.module_test("gdbm")
> +
Runtime test, wee! :-)
But:
$ ./utils/docker-run make check-package
support/testing/tests/package/test_lua_lgdbm.py:0: run 'flake8' and fix the warnings
$ ./utils/docker-run python3 -m flake8 support/testing/tests/package/test_lua_lgdbm.py
support/testing/tests/package/test_lua_lgdbm.py:14:1: W391 blank line at end of file
Applied to master, with the gdbm dependencies propagated and the
check-package/flake8 issue fixed, thanks!
Regards,
Yann E. MORIN.
> --
> 2.39.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-04-03 21:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 8:54 [Buildroot] [PATCH 1/3] package/lmdb: new package Francois Perrad
2024-04-03 8:54 ` [Buildroot] [PATCH 2/3] package/lua-lightningmdb: " Francois Perrad
2024-04-03 8:54 ` [Buildroot] [PATCH 3/3] package/lua-lgdbm: " Francois Perrad
2024-04-03 21:12 ` Yann E. MORIN [this message]
2024-04-03 20:57 ` [Buildroot] [PATCH 1/3] package/lmdb: " Yann E. MORIN
2024-04-03 21:17 ` Emile Cormier
2024-04-03 21:25 ` Yann E. MORIN
-- strict thread matches above, loose matches on Subject: below --
2023-12-06 9:39 Francois Perrad
2023-12-06 9:39 ` [Buildroot] [PATCH 3/3] package/lua-lgdbm: " Francois Perrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zg3GI3q2nTcbBIPM@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
--cc=francois.perrad@gadz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox