Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 3/3] package/lua-lgdbm: new package
  2023-12-06  9:39 Francois Perrad
@ 2023-12-06  9:39 ` Francois Perrad
  0 siblings, 0 replies; 8+ messages in thread
From: Francois Perrad @ 2023-12-06  9:39 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/Config.in                               |  1 +
 package/lua-lgdbm/Config.in                     | 12 ++++++++++++
 package/lua-lgdbm/lua-lgdbm.hash                |  2 ++
 package/lua-lgdbm/lua-lgdbm.mk                  | 13 +++++++++++++
 support/testing/tests/package/test_lua_lgdbm.py | 14 ++++++++++++++
 5 files changed, 42 insertions(+)
 create mode 100644 package/lua-lgdbm/Config.in
 create mode 100644 package/lua-lgdbm/lua-lgdbm.hash
 create mode 100644 package/lua-lgdbm/lua-lgdbm.mk
 create mode 100644 support/testing/tests/package/test_lua_lgdbm.py

diff --git a/package/Config.in b/package/Config.in
index e7032127cd..e8c210e22b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -739,6 +739,7 @@ menu "Lua libraries/modules"
 	source "package/lua-iconv/Config.in"
 	source "package/lua-inotify/Config.in"
 	source "package/lua-lightningmdb/Config.in"
+	source "package/lua-lgdbm/Config.in"
 	source "package/lua-livr/Config.in"
 	source "package/lua-livr-extra/Config.in"
 	source "package/lua-lpeg-patterns/Config.in"
diff --git a/package/lua-lgdbm/Config.in b/package/lua-lgdbm/Config.in
new file mode 100644
index 0000000000..ac5c64cc79
--- /dev/null
+++ b/package/lua-lgdbm/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_LUA_LGDBM
+	bool "lua-lgdbm"
+	depends on BR2_PACKAGE_LUA_5_3 || BR2_PACKAGE_LUA_5_4
+	select BR2_PACKAGE_GDBM
+	help
+	  A database library for Lua using GDBM.
+
+	  http://www.tecgraf.puc-rio.br/~lhf/ftp/lua/#lgdbm
+
+comment "lua-lgdbm needs Lua >= 5.2"
+	depends on !BR2_PACKAGE_LUA_5_3
+	depends on !BR2_PACKAGE_LUA_5_4
diff --git a/package/lua-lgdbm/lua-lgdbm.hash b/package/lua-lgdbm/lua-lgdbm.hash
new file mode 100644
index 0000000000..06f22f1509
--- /dev/null
+++ b/package/lua-lgdbm/lua-lgdbm.hash
@@ -0,0 +1,2 @@
+# computed by luarocks/buildroot
+sha256  8cb7e25254b1c9889894654f6cf26d09f2c2ee10fe966f45152eb5deb0a24f9b  lgdbm-20211118.52-0.src.rock
diff --git a/package/lua-lgdbm/lua-lgdbm.mk b/package/lua-lgdbm/lua-lgdbm.mk
new file mode 100644
index 0000000000..35ca9c93f4
--- /dev/null
+++ b/package/lua-lgdbm/lua-lgdbm.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# lua-lgdbm
+#
+################################################################################
+
+LUA_LGDBM_VERSION = 20211118.52-0
+LUA_LGDBM_NAME_UPSTREAM = lgdbm
+LUA_LGDBM_SUBDIR = gdbm
+LUA_LGDBM_LICENSE = Public Domain
+LUA_LGDBM_DEPENDENCIES = gdbm
+
+$(eval $(luarocks-package))
diff --git a/support/testing/tests/package/test_lua_lgdbm.py b/support/testing/tests/package/test_lua_lgdbm.py
new file mode 100644
index 0000000000..b21565fb6e
--- /dev/null
+++ b/support/testing/tests/package/test_lua_lgdbm.py
@@ -0,0 +1,14 @@
+from tests.package.test_lua import TestLuaBase
+
+
+class TestLuaLgdbm(TestLuaBase):
+    config = TestLuaBase.config + \
+        """
+        BR2_PACKAGE_LUA=y
+        BR2_PACKAGE_LUA_LGDBM=y
+        """
+
+    def test_run(self):
+        self.login()
+        self.module_test("gdbm")
+
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/3] package/lmdb: new package
@ 2024-04-03  8:54 Francois Perrad
  2024-04-03  8:54 ` [Buildroot] [PATCH 2/3] package/lua-lightningmdb: " Francois Perrad
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Francois Perrad @ 2024-04-03  8:54 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 DEVELOPERS             |  1 +
 package/Config.in      |  1 +
 package/lmdb/Config.in | 13 +++++++++++++
 package/lmdb/lmdb.hash |  3 +++
 package/lmdb/lmdb.mk   | 35 +++++++++++++++++++++++++++++++++++
 5 files changed, 53 insertions(+)
 create mode 100644 package/lmdb/Config.in
 create mode 100644 package/lmdb/lmdb.hash
 create mode 100644 package/lmdb/lmdb.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 904c7ebf2d..5b47ee4e29 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1126,6 +1126,7 @@ F:	package/libwpe/
 F:	package/linenoise/
 F:	package/ljlinenoise/
 F:	package/lua-inotify/
+F:	package/lmdb/
 F:	package/lpeg/
 F:	package/lpty/
 F:	package/lrandom/
diff --git a/package/Config.in b/package/Config.in
index 5a3410d758..4473169544 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1556,6 +1556,7 @@ menu "Database"
 	source "package/libodb-mysql/Config.in"
 	source "package/libodb-pgsql/Config.in"
 	source "package/libpqxx/Config.in"
+	source "package/lmdb/Config.in"
 	source "package/mongodb/Config.in"
 	source "package/mysql/Config.in"
 	source "package/postgresql/Config.in"
diff --git a/package/lmdb/Config.in b/package/lmdb/Config.in
new file mode 100644
index 0000000000..f4ae9f3103
--- /dev/null
+++ b/package/lmdb/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_LMDB
+	bool "lmdb"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	help
+	  OpenLDAP Lightning Memory-Mapped Database
+
+	  LMDB is compact, fast, powerful, and robust and implements
+	  a simplified variant of the BerkeleyDB (BDB) API.
+
+	  https://symas.com/lmdb/
+
+comment "lmdb needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/lmdb/lmdb.hash b/package/lmdb/lmdb.hash
new file mode 100644
index 0000000000..d72c66aace
--- /dev/null
+++ b/package/lmdb/lmdb.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256  dd70a8c67807b3b8532b3e987b0a4e998962ecc28643e1af5ec77696b081c9b0  lmdb-0.9.31.tar.gz
+sha256  310fe25c858a9515fc8c8d7d1f24a67c9496f84a91e0a0e41ea9975b1371e569  libraries/liblmdb/LICENSE
diff --git a/package/lmdb/lmdb.mk b/package/lmdb/lmdb.mk
new file mode 100644
index 0000000000..5e2ad2d05a
--- /dev/null
+++ b/package/lmdb/lmdb.mk
@@ -0,0 +1,35 @@
+################################################################################
+#
+# lmdb
+#
+################################################################################
+
+LMDB_VERSION = 0.9.31
+LMDB_SITE = $(call github,LMDB,lmdb,LMDB_$(LMDB_VERSION))
+LMDB_LICENSE = OpenLDAP Public License
+LMDB_LICENSE_FILES = libraries/liblmdb/LICENSE
+LMDB_INSTALL_STAGING = YES
+
+define LMDB_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libraries/liblmdb \
+		CC="$(TARGET_CC)" \
+		XCFLAGS="$(TARGET_CFLAGS)" \
+		AR="$(TARGET_CROSS)ar" \
+		all
+endef
+
+define LMDB_INSTALL_STAGING_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libraries/liblmdb \
+		DESTDIR="$(STAGING_DIR)" \
+		prefix=/usr \
+		install
+endef
+
+define LMDB_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libraries/liblmdb \
+		DESTDIR="$(TARGET_DIR)" \
+		prefix=/usr \
+		install
+endef
+
+$(eval $(generic-package))
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 2/3] package/lua-lightningmdb: new package
  2024-04-03  8:54 [Buildroot] [PATCH 1/3] package/lmdb: new package Francois Perrad
@ 2024-04-03  8:54 ` Francois Perrad
  2024-04-03  8:54 ` [Buildroot] [PATCH 3/3] package/lua-lgdbm: " Francois Perrad
  2024-04-03 20:57 ` [Buildroot] [PATCH 1/3] package/lmdb: " Yann E. MORIN
  2 siblings, 0 replies; 8+ messages in thread
From: Francois Perrad @ 2024-04-03  8:54 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/Config.in                                  |  1 +
 package/lua-lightningmdb/Config.in                 | 13 +++++++++++++
 package/lua-lightningmdb/lua-lightningmdb.hash     |  3 +++
 package/lua-lightningmdb/lua-lightningmdb.mk       | 14 ++++++++++++++
 .../testing/tests/package/test_lua_lightningmdb.py | 14 ++++++++++++++
 5 files changed, 45 insertions(+)
 create mode 100644 package/lua-lightningmdb/Config.in
 create mode 100644 package/lua-lightningmdb/lua-lightningmdb.hash
 create mode 100644 package/lua-lightningmdb/lua-lightningmdb.mk
 create mode 100644 support/testing/tests/package/test_lua_lightningmdb.py

diff --git a/package/Config.in b/package/Config.in
index 4473169544..e7032127cd 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -738,6 +738,7 @@ menu "Lua libraries/modules"
 	source "package/lua-http/Config.in"
 	source "package/lua-iconv/Config.in"
 	source "package/lua-inotify/Config.in"
+	source "package/lua-lightningmdb/Config.in"
 	source "package/lua-livr/Config.in"
 	source "package/lua-livr-extra/Config.in"
 	source "package/lua-lpeg-patterns/Config.in"
diff --git a/package/lua-lightningmdb/Config.in b/package/lua-lightningmdb/Config.in
new file mode 100644
index 0000000000..cd08cfbe79
--- /dev/null
+++ b/package/lua-lightningmdb/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_LUA_LIGHTNINGMDB
+	bool "lua-lightningmdb"
+	depends on !BR2_PACKAGE_LUAJIT
+	depends on BR2_TOOLCHAIN_HAS_THREADS # lmdb
+	select BR2_PACKAGE_LMDB
+	help
+	  A thin wrapper around OpenLDAP Lightning Memory-Mapped
+	  Database (LMDB).
+
+	  https://github.com/shmul/lightningmdb
+
+comment "lua-lightningmdb needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/lua-lightningmdb/lua-lightningmdb.hash b/package/lua-lightningmdb/lua-lightningmdb.hash
new file mode 100644
index 0000000000..49ac7ea09c
--- /dev/null
+++ b/package/lua-lightningmdb/lua-lightningmdb.hash
@@ -0,0 +1,3 @@
+# computed by luarocks/buildroot
+sha256  d836709e8a1374eb8913f0e9787bb3f0fc4d49b29e01112691b619f7d1355f8c  lightningmdb-0.9.22.1-1.src.rock
+sha256  3d0562e11bc52bf45a735e1d60c6f8522886927a8bcfbe7dee219a61ec30b07a  lightningmdb-0.9.22.1-1/LICENSE
diff --git a/package/lua-lightningmdb/lua-lightningmdb.mk b/package/lua-lightningmdb/lua-lightningmdb.mk
new file mode 100644
index 0000000000..f70cbc4b06
--- /dev/null
+++ b/package/lua-lightningmdb/lua-lightningmdb.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# lua-lightningmdb
+#
+################################################################################
+
+LUA_LIGHTNINGMDB_VERSION = 0.9.22.1-1
+LUA_LIGHTNINGMDB_NAME_UPSTREAM = Lightningmdb
+LUA_LIGHTNINGMDB_SUBDIR = lightningmdb-$(LUA_LIGHTNINGMDB_VERSION)
+LUA_LIGHTNINGMDB_LICENSE = MIT
+LUA_LIGHTNINGMDB_LICENSE_FILES = $(LUA_LIGHTNINGMDB_SUBDIR)/LICENSE
+LUA_LIGHTNINGMDB_DEPENDENCIES = lmdb
+
+$(eval $(luarocks-package))
diff --git a/support/testing/tests/package/test_lua_lightningmdb.py b/support/testing/tests/package/test_lua_lightningmdb.py
new file mode 100644
index 0000000000..6c7a567e7a
--- /dev/null
+++ b/support/testing/tests/package/test_lua_lightningmdb.py
@@ -0,0 +1,14 @@
+from tests.package.test_lua import TestLuaBase
+
+
+class TestLuaLightningmdb(TestLuaBase):
+    config = TestLuaBase.config + \
+        """
+        BR2_PACKAGE_LUA=y
+        BR2_PACKAGE_LUA_LIGHTNINGMDB=y
+        """
+
+    def test_run(self):
+        self.login()
+        self.module_test("lightningmdb")
+
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 3/3] package/lua-lgdbm: new package
  2024-04-03  8:54 [Buildroot] [PATCH 1/3] package/lmdb: new package Francois Perrad
  2024-04-03  8:54 ` [Buildroot] [PATCH 2/3] package/lua-lightningmdb: " Francois Perrad
@ 2024-04-03  8:54 ` Francois Perrad
  2024-04-03 21:12   ` Yann E. MORIN
  2024-04-03 20:57 ` [Buildroot] [PATCH 1/3] package/lmdb: " Yann E. MORIN
  2 siblings, 1 reply; 8+ messages in thread
From: Francois Perrad @ 2024-04-03  8:54 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/Config.in                               |  1 +
 package/lua-lgdbm/Config.in                     | 12 ++++++++++++
 package/lua-lgdbm/lua-lgdbm.hash                |  2 ++
 package/lua-lgdbm/lua-lgdbm.mk                  | 13 +++++++++++++
 support/testing/tests/package/test_lua_lgdbm.py | 14 ++++++++++++++
 5 files changed, 42 insertions(+)
 create mode 100644 package/lua-lgdbm/Config.in
 create mode 100644 package/lua-lgdbm/lua-lgdbm.hash
 create mode 100644 package/lua-lgdbm/lua-lgdbm.mk
 create mode 100644 support/testing/tests/package/test_lua_lgdbm.py

diff --git a/package/Config.in b/package/Config.in
index e7032127cd..e8c210e22b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -739,6 +739,7 @@ menu "Lua libraries/modules"
 	source "package/lua-iconv/Config.in"
 	source "package/lua-inotify/Config.in"
 	source "package/lua-lightningmdb/Config.in"
+	source "package/lua-lgdbm/Config.in"
 	source "package/lua-livr/Config.in"
 	source "package/lua-livr-extra/Config.in"
 	source "package/lua-lpeg-patterns/Config.in"
diff --git a/package/lua-lgdbm/Config.in b/package/lua-lgdbm/Config.in
new file mode 100644
index 0000000000..ac5c64cc79
--- /dev/null
+++ b/package/lua-lgdbm/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_LUA_LGDBM
+	bool "lua-lgdbm"
+	depends on BR2_PACKAGE_LUA_5_3 || BR2_PACKAGE_LUA_5_4
+	select BR2_PACKAGE_GDBM
+	help
+	  A database library for Lua using GDBM.
+
+	  http://www.tecgraf.puc-rio.br/~lhf/ftp/lua/#lgdbm
+
+comment "lua-lgdbm needs Lua >= 5.2"
+	depends on !BR2_PACKAGE_LUA_5_3
+	depends on !BR2_PACKAGE_LUA_5_4
diff --git a/package/lua-lgdbm/lua-lgdbm.hash b/package/lua-lgdbm/lua-lgdbm.hash
new file mode 100644
index 0000000000..06f22f1509
--- /dev/null
+++ b/package/lua-lgdbm/lua-lgdbm.hash
@@ -0,0 +1,2 @@
+# computed by luarocks/buildroot
+sha256  8cb7e25254b1c9889894654f6cf26d09f2c2ee10fe966f45152eb5deb0a24f9b  lgdbm-20211118.52-0.src.rock
diff --git a/package/lua-lgdbm/lua-lgdbm.mk b/package/lua-lgdbm/lua-lgdbm.mk
new file mode 100644
index 0000000000..35ca9c93f4
--- /dev/null
+++ b/package/lua-lgdbm/lua-lgdbm.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# lua-lgdbm
+#
+################################################################################
+
+LUA_LGDBM_VERSION = 20211118.52-0
+LUA_LGDBM_NAME_UPSTREAM = lgdbm
+LUA_LGDBM_SUBDIR = gdbm
+LUA_LGDBM_LICENSE = Public Domain
+LUA_LGDBM_DEPENDENCIES = gdbm
+
+$(eval $(luarocks-package))
diff --git a/support/testing/tests/package/test_lua_lgdbm.py b/support/testing/tests/package/test_lua_lgdbm.py
new file mode 100644
index 0000000000..b21565fb6e
--- /dev/null
+++ b/support/testing/tests/package/test_lua_lgdbm.py
@@ -0,0 +1,14 @@
+from tests.package.test_lua import TestLuaBase
+
+
+class TestLuaLgdbm(TestLuaBase):
+    config = TestLuaBase.config + \
+        """
+        BR2_PACKAGE_LUA=y
+        BR2_PACKAGE_LUA_LGDBM=y
+        """
+
+    def test_run(self):
+        self.login()
+        self.module_test("gdbm")
+
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/3] package/lmdb: new package
  2024-04-03  8:54 [Buildroot] [PATCH 1/3] package/lmdb: new package Francois Perrad
  2024-04-03  8:54 ` [Buildroot] [PATCH 2/3] package/lua-lightningmdb: " Francois Perrad
  2024-04-03  8:54 ` [Buildroot] [PATCH 3/3] package/lua-lgdbm: " Francois Perrad
@ 2024-04-03 20:57 ` Yann E. MORIN
  2024-04-03 21:17   ` Emile Cormier
  2 siblings, 1 reply; 8+ messages in thread
From: Yann E. MORIN @ 2024-04-03 20:57 UTC (permalink / raw)
  To: Francois Perrad; +Cc: buildroot, i Mauro Condarelli, Emile Cormier

François, All,

+Mauro for pyhon-lmdb
+Emile for python-zlmdb

On 2024-04-03 10:54 +0200, Francois Perrad spake thusly:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
[--SNIP--]
> diff --git a/package/lmdb/Config.in b/package/lmdb/Config.in
> new file mode 100644
> index 0000000000..f4ae9f3103
> --- /dev/null
> +++ b/package/lmdb/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_LMDB
> +	bool "lmdb"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	help
> +	  OpenLDAP Lightning Memory-Mapped Database
> +
> +	  LMDB is compact, fast, powerful, and robust and implements
> +	  a simplified variant of the BerkeleyDB (BDB) API.
> +
> +	  https://symas.com/lmdb/
> +
> +comment "lmdb needs a toolchain w/ threads"
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS

Mauro, Emile: python-lmdb bundles a copy of lmdb, but it is possible to
configure it to use the system-provided library instead [0]. Do you know
if there would be adverse effects to do so in Buildroot? Indeed, we
prefer to configure packages to use system libraries rather than use
there bundled copy whenever possible...

[0] https://lmdb.readthedocs.io/en/release/#installation-unix

I haven't looked at python-zlmdb, though...

[--SNIP--]
> diff --git a/package/lmdb/lmdb.mk b/package/lmdb/lmdb.mk
> new file mode 100644
> index 0000000000..5e2ad2d05a
> --- /dev/null
> +++ b/package/lmdb/lmdb.mk
> @@ -0,0 +1,35 @@
> +################################################################################
> +#
> +# lmdb
> +#
> +################################################################################
> +
> +LMDB_VERSION = 0.9.31
> +LMDB_SITE = $(call github,LMDB,lmdb,LMDB_$(LMDB_VERSION))
> +LMDB_LICENSE = OpenLDAP Public License

I think we want to use the SPDX short tag here: OLDAP-2.8. Incidentally,
this is also what is already used for python-lmdb.

> +LMDB_LICENSE_FILES = libraries/liblmdb/LICENSE
> +LMDB_INSTALL_STAGING = YES
> +
> +define LMDB_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libraries/liblmdb \
> +		CC="$(TARGET_CC)" \
> +		XCFLAGS="$(TARGET_CFLAGS)" \
> +		AR="$(TARGET_CROSS)ar" \

Why not use $(TARGET_CONFIGURE_OPTS) and just add the special XCFLAGS?

> +		all

'all' is usually the default target, for being the first in the
Makefile, which is also the cae here, so there is no reason to specify
it.

> +endef
> +
> +define LMDB_INSTALL_STAGING_CMDS
> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libraries/liblmdb \
> +		DESTDIR="$(STAGING_DIR)" \
> +		prefix=/usr \
> +		install
> +endef
> +
> +define LMDB_INSTALL_TARGET_CMDS
> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libraries/liblmdb \
> +		DESTDIR="$(TARGET_DIR)" \
> +		prefix=/usr \
> +		install
> +endef
> +
> +$(eval $(generic-package))
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 3/3] package/lua-lgdbm: new package
  2024-04-03  8:54 ` [Buildroot] [PATCH 3/3] package/lua-lgdbm: " Francois Perrad
@ 2024-04-03 21:12   ` Yann E. MORIN
  0 siblings, 0 replies; 8+ messages in thread
From: Yann E. MORIN @ 2024-04-03 21:12 UTC (permalink / raw)
  To: Francois Perrad; +Cc: buildroot

Fraçois, All

On 2024-04-03 10:54 +0200, Francois Perrad spake thusly:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
[--SNIP--]
> diff --git a/package/lua-lgdbm/Config.in b/package/lua-lgdbm/Config.in
> new file mode 100644
> index 0000000000..ac5c64cc79
> --- /dev/null
> +++ b/package/lua-lgdbm/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_LUA_LGDBM
> +	bool "lua-lgdbm"
> +	depends on BR2_PACKAGE_LUA_5_3 || BR2_PACKAGE_LUA_5_4
> +	select BR2_PACKAGE_GDBM

You need to propagate the dependencies of gdbm here: MMU and WCHAR.

> new file mode 100644
> index 0000000000..b21565fb6e
> --- /dev/null
> +++ b/support/testing/tests/package/test_lua_lgdbm.py
> @@ -0,0 +1,14 @@
> +from tests.package.test_lua import TestLuaBase
> +
> +
> +class TestLuaLgdbm(TestLuaBase):
> +    config = TestLuaBase.config + \
> +        """
> +        BR2_PACKAGE_LUA=y
> +        BR2_PACKAGE_LUA_LGDBM=y
> +        """
> +
> +    def test_run(self):
> +        self.login()
> +        self.module_test("gdbm")
> +

Runtime test, wee! :-)

But:

    $ ./utils/docker-run make check-package
    support/testing/tests/package/test_lua_lgdbm.py:0: run 'flake8' and fix the warnings

    $ ./utils/docker-run python3 -m flake8 support/testing/tests/package/test_lua_lgdbm.py
    support/testing/tests/package/test_lua_lgdbm.py:14:1: W391 blank line at end of file

Applied to master, with the gdbm dependencies propagated and the
check-package/flake8 issue fixed, thanks!

Regards,
Yann E. MORIN.

> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/3] package/lmdb: new package
  2024-04-03 20:57 ` [Buildroot] [PATCH 1/3] package/lmdb: " Yann E. MORIN
@ 2024-04-03 21:17   ` Emile Cormier
  2024-04-03 21:25     ` Yann E. MORIN
  0 siblings, 1 reply; 8+ messages in thread
From: Emile Cormier @ 2024-04-03 21:17 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: buildroot, i Mauro Condarelli


[-- Attachment #1.1: Type: text/plain, Size: 4678 bytes --]

Hi,

My only interest in python-zlmdb was to be able to build a more recent
version of Crossbar, and I didn't even use that database component of
Crossbar that depended on ZLMDB.

I no longer use Crossbar (I'm developing my own C++ WAMP router), so I've
lost interest in those packages long ago.

Sorry, but I don't remember much about what I did concerning Crossbar and
Buildroot. I can tell you that the philosophy behind Crossbar's build is
not to rely too much on installed system packages.

Unless someone is still actively using it, you may want to consider
dropping Crossbar support in Buildroot because the amount of work needed to
be able to build the latest version in Buildroot is monumental.

Cheers,
Emile Cormier

On Wed, Apr 3, 2024 at 5:57 PM Yann E. MORIN <yann.morin.1998@free.fr>
wrote:

> François, All,
>
> +Mauro for pyhon-lmdb
> +Emile for python-zlmdb
>
> On 2024-04-03 10:54 +0200, Francois Perrad spake thusly:
> > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> [--SNIP--]
> > diff --git a/package/lmdb/Config.in b/package/lmdb/Config.in
> > new file mode 100644
> > index 0000000000..f4ae9f3103
> > --- /dev/null
> > +++ b/package/lmdb/Config.in
> > @@ -0,0 +1,13 @@
> > +config BR2_PACKAGE_LMDB
> > +     bool "lmdb"
> > +     depends on BR2_TOOLCHAIN_HAS_THREADS
> > +     help
> > +       OpenLDAP Lightning Memory-Mapped Database
> > +
> > +       LMDB is compact, fast, powerful, and robust and implements
> > +       a simplified variant of the BerkeleyDB (BDB) API.
> > +
> > +       https://symas.com/lmdb/
> > +
> > +comment "lmdb needs a toolchain w/ threads"
> > +     depends on !BR2_TOOLCHAIN_HAS_THREADS
>
> Mauro, Emile: python-lmdb bundles a copy of lmdb, but it is possible to
> configure it to use the system-provided library instead [0]. Do you know
> if there would be adverse effects to do so in Buildroot? Indeed, we
> prefer to configure packages to use system libraries rather than use
> there bundled copy whenever possible...
>
> [0] https://lmdb.readthedocs.io/en/release/#installation-unix
>
> I haven't looked at python-zlmdb, though...
>
> [--SNIP--]
> > diff --git a/package/lmdb/lmdb.mk b/package/lmdb/lmdb.mk
> > new file mode 100644
> > index 0000000000..5e2ad2d05a
> > --- /dev/null
> > +++ b/package/lmdb/lmdb.mk
> > @@ -0,0 +1,35 @@
> >
> +################################################################################
> > +#
> > +# lmdb
> > +#
> >
> +################################################################################
> > +
> > +LMDB_VERSION = 0.9.31
> > +LMDB_SITE = $(call github,LMDB,lmdb,LMDB_$(LMDB_VERSION))
> > +LMDB_LICENSE = OpenLDAP Public License
>
> I think we want to use the SPDX short tag here: OLDAP-2.8. Incidentally,
> this is also what is already used for python-lmdb.
>
> > +LMDB_LICENSE_FILES = libraries/liblmdb/LICENSE
> > +LMDB_INSTALL_STAGING = YES
> > +
> > +define LMDB_BUILD_CMDS
> > +     $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libraries/liblmdb \
> > +             CC="$(TARGET_CC)" \
> > +             XCFLAGS="$(TARGET_CFLAGS)" \
> > +             AR="$(TARGET_CROSS)ar" \
>
> Why not use $(TARGET_CONFIGURE_OPTS) and just add the special XCFLAGS?
>
> > +             all
>
> 'all' is usually the default target, for being the first in the
> Makefile, which is also the cae here, so there is no reason to specify
> it.
>
> > +endef
> > +
> > +define LMDB_INSTALL_STAGING_CMDS
> > +     $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libraries/liblmdb \
> > +             DESTDIR="$(STAGING_DIR)" \
> > +             prefix=/usr \
> > +             install
> > +endef
> > +
> > +define LMDB_INSTALL_TARGET_CMDS
> > +     $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libraries/liblmdb \
> > +             DESTDIR="$(TARGET_DIR)" \
> > +             prefix=/usr \
> > +             install
> > +endef
> > +
> > +$(eval $(generic-package))
> > --
> > 2.39.2
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
>
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
>      |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is
> no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
>  conspiracy.  |
>
> '------------------------------^-------^------------------^--------------------'
>

[-- Attachment #1.2: Type: text/html, Size: 6425 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/3] package/lmdb: new package
  2024-04-03 21:17   ` Emile Cormier
@ 2024-04-03 21:25     ` Yann E. MORIN
  0 siblings, 0 replies; 8+ messages in thread
From: Yann E. MORIN @ 2024-04-03 21:25 UTC (permalink / raw)
  To: Emile Cormier; +Cc: buildroot, i Mauro Condarelli

Emile, All,

On 2024-04-03 18:17 -0300, Emile Cormier spake thusly:
> My only interest in python-zlmdb was to be able to build a more recent version
> of Crossbar, and I didn't even use that database component of Crossbar that
> depended on ZLMDB.
[--SNIP--]
> Unless someone is still actively using it, you may want to consider dropping
> Crossbar support in Buildroot because the amount of work needed to be able to
> build the latest version in Buildroot is monumental.

We've already removed crossbar a little while ago, as it is not
python-3.12 compatible, and it did not seem to be on the radar
upstream...

As for python-zlmdb, unless it gets broken, there is no reason to drop
it for now.

Thanks for your quick reply providing some useful context! :-)

Regards,
Yann E. MORIN.

> Cheers,
> Emile Cormier
> 
> On Wed, Apr 3, 2024 at 5:57 PM Yann E. MORIN <[1]yann.morin.1998@free.fr>
> wrote:
> 
>     François, All,
> 
>     +Mauro for pyhon-lmdb
>     +Emile for python-zlmdb
> 
>     On 2024-04-03 10:54 +0200, Francois Perrad spake thusly:
>     > Signed-off-by: Francois Perrad <[2]francois.perrad@gadz.org>
>     [--SNIP--]
>     > diff --git a/package/lmdb/Config.in b/package/lmdb/Config.in
>     > new file mode 100644
>     > index 0000000000..f4ae9f3103
>     > --- /dev/null
>     > +++ b/package/lmdb/Config.in
>     > @@ -0,0 +1,13 @@
>     > +config BR2_PACKAGE_LMDB
>     > +     bool "lmdb"
>     > +     depends on BR2_TOOLCHAIN_HAS_THREADS
>     > +     help
>     > +       OpenLDAP Lightning Memory-Mapped Database
>     > +
>     > +       LMDB is compact, fast, powerful, and robust and implements
>     > +       a simplified variant of the BerkeleyDB (BDB) API.
>     > +
>     > +       [3]https://symas.com/lmdb/
>     > +
>     > +comment "lmdb needs a toolchain w/ threads"
>     > +     depends on !BR2_TOOLCHAIN_HAS_THREADS
> 
>     Mauro, Emile: python-lmdb bundles a copy of lmdb, but it is possible to
>     configure it to use the system-provided library instead [0]. Do you know
>     if there would be adverse effects to do so in Buildroot? Indeed, we
>     prefer to configure packages to use system libraries rather than use
>     there bundled copy whenever possible...
> 
>     [0] [4]https://lmdb.readthedocs.io/en/release/#installation-unix
> 
>     I haven't looked at python-zlmdb, though...
> 
>     [--SNIP--]
>     > diff --git a/package/lmdb/[5]lmdb.mk b/package/lmdb/[6]lmdb.mk
>     > new file mode 100644
>     > index 0000000000..5e2ad2d05a
>     > --- /dev/null
>     > +++ b/package/lmdb/[7]lmdb.mk
>     > @@ -0,0 +1,35 @@
>     > +########################################################################
>     ########
>     > +#
>     > +# lmdb
>     > +#
>     > +########################################################################
>     ########
>     > +
>     > +LMDB_VERSION = 0.9.31
>     > +LMDB_SITE = $(call github,LMDB,lmdb,LMDB_$(LMDB_VERSION))
>     > +LMDB_LICENSE = OpenLDAP Public License
> 
>     I think we want to use the SPDX short tag here: OLDAP-2.8. Incidentally,
>     this is also what is already used for python-lmdb.
> 
>     > +LMDB_LICENSE_FILES = libraries/liblmdb/LICENSE
>     > +LMDB_INSTALL_STAGING = YES
>     > +
>     > +define LMDB_BUILD_CMDS
>     > +     $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libraries/liblmdb \
>     > +             CC="$(TARGET_CC)" \
>     > +             XCFLAGS="$(TARGET_CFLAGS)" \
>     > +             AR="$(TARGET_CROSS)ar" \
> 
>     Why not use $(TARGET_CONFIGURE_OPTS) and just add the special XCFLAGS?
> 
>     > +             all
> 
>     'all' is usually the default target, for being the first in the
>     Makefile, which is also the cae here, so there is no reason to specify
>     it.
> 
>     > +endef
>     > +
>     > +define LMDB_INSTALL_STAGING_CMDS
>     > +     $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libraries/liblmdb \
>     > +             DESTDIR="$(STAGING_DIR)" \
>     > +             prefix=/usr \
>     > +             install
>     > +endef
>     > +
>     > +define LMDB_INSTALL_TARGET_CMDS
>     > +     $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libraries/liblmdb \
>     > +             DESTDIR="$(TARGET_DIR)" \
>     > +             prefix=/usr \
>     > +             install
>     > +endef
>     > +
>     > +$(eval $(generic-package))
>     > --
>     > 2.39.2
>     >
>     > _______________________________________________
>     > buildroot mailing list
>     > [8]buildroot@buildroot.org
>     > [9]https://lists.buildroot.org/mailman/listinfo/buildroot
> 
>     --
>     .-----------------.--------------------.------------------.--------------------.
>     |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
>     conspiracy: |
>     | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___           
>        |
>     | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is
>     no  |
>     | [10]http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v 
>      conspiracy.  |
>     '------------------------------^-------^------------------^
>     --------------------'
> 
> 
> References:
> 
> [1] mailto:yann.morin.1998@free.fr
> [2] mailto:francois.perrad@gadz.org
> [3] https://symas.com/lmdb/
> [4] https://lmdb.readthedocs.io/en/release/#installation-unix
> [5] http://lmdb.mk/
> [6] http://lmdb.mk/
> [7] http://lmdb.mk/
> [8] mailto:buildroot@buildroot.org
> [9] https://lists.buildroot.org/mailman/listinfo/buildroot
> [10] http://ymorin.is-a-geek.org/

> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot


-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-04-03 21:25 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-03  8:54 [Buildroot] [PATCH 1/3] package/lmdb: new package Francois Perrad
2024-04-03  8:54 ` [Buildroot] [PATCH 2/3] package/lua-lightningmdb: " Francois Perrad
2024-04-03  8:54 ` [Buildroot] [PATCH 3/3] package/lua-lgdbm: " Francois Perrad
2024-04-03 21:12   ` Yann E. MORIN
2024-04-03 20:57 ` [Buildroot] [PATCH 1/3] package/lmdb: " Yann E. MORIN
2024-04-03 21:17   ` Emile Cormier
2024-04-03 21:25     ` Yann E. MORIN
  -- strict thread matches above, loose matches on Subject: below --
2023-12-06  9:39 Francois Perrad
2023-12-06  9:39 ` [Buildroot] [PATCH 3/3] package/lua-lgdbm: " Francois Perrad

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox