[Buildroot] [PATCH 1/1] package/zlib-ng: disable riscv with uclibc

[Buildroot] [PATCH 1/1] package/zlib-ng: disable riscv with uclibc

[Fabrice Fontaine]

Disable riscv with uclibc to avoid the following build failure with
uclibc-ng < 1.0.43 raised since bump to version 2.1.6 in commit
47b6737e841baf8b666ea9f37edc5f169652e88d and
https://github.com/zlib-ng/zlib-ng/commit/6ff8b52cefe56a824fae1d53fdd687bcde2e53c9:

/home/autobuild/autobuild/instance-2/output-1/build/zlib-ng-2.1.6/arch/riscv/riscv_features.c:4:10: fatal error: sys/auxv.h: No such file or directory
    4 | #include <sys/auxv.h>
      |          ^~~~~~~~~~~~

Indeed, upstream is reluctant to avoid calling getauxval if is not
available: https://github.com/zlib-ng/zlib-ng/pull/1700

Fixes: 47b6737e841baf8b666ea9f37edc5f169652e88d
 - http://autobuild.buildroot.org/results/06a7d8e59ec4de7c711d3f4a4624f67b97d78afe

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/zlib/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/zlib/Config.in b/package/zlib/Config.in
index 3a486376ac..346202c8bf 100644
--- a/package/zlib/Config.in
+++ b/package/zlib/Config.in
@@ -7,7 +7,7 @@ config BR2_PACKAGE_ZLIB_NG_ARCH_SUPPORTS
 	default y if BR2_aarch64
 	default y if BR2_i386
 	default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
-	default y if BR2_riscv
+	default y if BR2_riscv && !BR2_TOOLCHAIN_USES_UCLIBC
 	default y if BR2_s390x
 	default y if BR2_x86_64
 
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/zlib-ng: disable riscv with uclibc

[Arnout Vandecappelle via buildroot]

On 20/03/2024 23:13, Fabrice Fontaine wrote:
> Disable riscv with uclibc to avoid the following build failure with
> uclibc-ng < 1.0.43 raised since bump to version 2.1.6 in commit

  I believe we generally don't fix issues in packages if the issue is actually 
in the libc itself. This does mean we will have build failures for older 
prebuilt external toolchains, but those we should fix using the exclusions in 
genrandconfig.

  I'm putting the other maintainers in Cc to check if they agree with my assessment.

  For now, marked as Changes Requested.

  Regards,
  Arnout


> 47b6737e841baf8b666ea9f37edc5f169652e88d and
> https://github.com/zlib-ng/zlib-ng/commit/6ff8b52cefe56a824fae1d53fdd687bcde2e53c9:
> 
> /home/autobuild/autobuild/instance-2/output-1/build/zlib-ng-2.1.6/arch/riscv/riscv_features.c:4:10: fatal error: sys/auxv.h: No such file or directory
>      4 | #include <sys/auxv.h>
>        |          ^~~~~~~~~~~~
> 
> Indeed, upstream is reluctant to avoid calling getauxval if is not
> available: https://github.com/zlib-ng/zlib-ng/pull/1700
> 
> Fixes: 47b6737e841baf8b666ea9f37edc5f169652e88d
>   - http://autobuild.buildroot.org/results/06a7d8e59ec4de7c711d3f4a4624f67b97d78afe
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>   package/zlib/Config.in | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/zlib/Config.in b/package/zlib/Config.in
> index 3a486376ac..346202c8bf 100644
> --- a/package/zlib/Config.in
> +++ b/package/zlib/Config.in
> @@ -7,7 +7,7 @@ config BR2_PACKAGE_ZLIB_NG_ARCH_SUPPORTS
>   	default y if BR2_aarch64
>   	default y if BR2_i386
>   	default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
> -	default y if BR2_riscv
> +	default y if BR2_riscv && !BR2_TOOLCHAIN_USES_UCLIBC
>   	default y if BR2_s390x
>   	default y if BR2_x86_64
>   
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/zlib-ng: disable riscv with uclibc

[Thomas Petazzoni via buildroot]

On Sun, 24 Mar 2024 17:33:04 +0100
Arnout Vandecappelle <arnout@mind.be> wrote:

>   I believe we generally don't fix issues in packages if the issue is actually 
> in the libc itself. This does mean we will have build failures for older 
> prebuilt external toolchains, but those we should fix using the exclusions in 
> genrandconfig.
> 
>   I'm putting the other maintainers in Cc to check if they agree with my assessment.

I agree with your assessment. If Bootlin toolchains need to be rebuilt,
let me know, and I will be happy to rebuild them.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/zlib-ng: disable riscv with uclibc

[Yann E. MORIN]

Arnout, All,

On 2024-03-24 17:33 +0100, Arnout Vandecappelle via buildroot spake thusly:
> On 20/03/2024 23:13, Fabrice Fontaine wrote:
> > Disable riscv with uclibc to avoid the following build failure with
> > uclibc-ng < 1.0.43 raised since bump to version 2.1.6 in commit
>  I believe we generally don't fix issues in packages if the issue is
> actually in the libc itself. This does mean we will have build failures for
> older prebuilt external toolchains, but those we should fix using the
> exclusions in genrandconfig.
> 
>  I'm putting the other maintainers in Cc to check if they agree with my assessment.

+1

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot