Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Perale <thomas.perale@essensium.com>
Cc: Christian Stewart <christian@paral.in>,
	Thomas Perale <thomas.perale@mind.be>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/6] DEVELOPERS: add Thomas Perale for 'go'
Date: Mon, 15 Apr 2024 22:20:16 +0200	[thread overview]
Message-ID: <Zh2MAAqe0NEOa3bO@landeda> (raw)
In-Reply-To: <f2bc83c5-c77c-4360-b1da-73aa069bb08d@essensium.com>

On 2024-04-15 19:38 +0200, Thomas Perale spake thusly:
> Please use SoB @mind.be.
> 
> I subscribed with the @essensium email to the buildroot ML and if i recall
> correctly i received an error when sending with the @mind alias and didn't
> really bothered fixing it.

In that case, I think you can tell git send-email to always inject the
pseudo From-header at the beginning of the commit, and when we git-am,
that's what get used instead of the mail's From field.

I had a similar issue with my @work setup [0], I'll dig up the git
config I use there tomorrow.

[0] https://lore.kernel.org/buildroot/ZNCU8E59+%2FD%2Frn5T@tl-lnx-nyma7486-2/

Regards,
Yann E. MORIN.

> Regards,
> PERALE Thomas
> 
> On 4/15/24 6:44 PM, Yann E. MORIN wrote:
> > Thomas, All,
> > 
> > On 2024-04-15 18:22 +0200, Thomas Perale via buildroot spake thusly:
> > > Signed-off-by: Thomas Perale <thomas.perale@mind.be>
> > Your From and Signed-off-by are still not the same: @essensium.com vs.
> > @mind.be.
> > 
> > Check your ~/.gitconfig for the proper user.email key. If you also set
> > format.signOff, it should automatically inject the proper SoB line, but
> > if you, like me, explicitly inject SoB lines [0], check your code
> > snippet.
> > 
> > [0] I use vim's snipmate plugin https://github.com/garbas/vim-snipmate
> >      with my own snippets for SoB lines:
> > 
> >      snippet sob
> >          Signed-off-by:
> >      snippet ME
> >          Yann E. MORIN <yann.morin.1998@free.fr>
> > 
> > (so that I can reflex-type sob<TAB>ME<TAB> for my SoB lines.)
> > 
> > For this series, no need to respin _just_ for this: just reply whether
> > to use the SoB line (@mind) or the From field (@essentium), and I can
> > fix it locally when applying.
> > 
> > Regards,
> > Yann E. MORIN.
> > 
> > > ---
> > >   DEVELOPERS | 3 +++
> > >   1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/DEVELOPERS b/DEVELOPERS
> > > index 399b2931ff..039b803d50 100644
> > > --- a/DEVELOPERS
> > > +++ b/DEVELOPERS
> > > @@ -2979,6 +2979,9 @@ F:	package/frotz/
> > >   F:	package/kvm-unit-tests/
> > >   F:	package/xorcurses/
> > > 
> > > +N:	Thomas Perale <thomas.perale@mind.be>
> > > +F:	package/go/
> > > +
> > >   N:	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> > >   F:	arch/Config.in.arm
> > >   F:	board/beaglev/
> > > --
> > > 2.44.0
> > > 
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot@buildroot.org
> > > https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-04-15 20:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 16:22 [Buildroot] [PATCH v2 0/6] support for a pre-built Go compiler Thomas Perale via buildroot
2024-04-15 16:22 ` [Buildroot] [PATCH v2 1/6] DEVELOPERS: add Thomas Perale for 'go' Thomas Perale via buildroot
2024-04-15 16:44   ` Yann E. MORIN
2024-04-15 17:38     ` Thomas Perale via buildroot
2024-04-15 20:20       ` Yann E. MORIN [this message]
2024-06-01 15:39   ` Yann E. MORIN
2024-04-15 16:22 ` [Buildroot] [PATCH v2 2/6] package/go: new subdirectory for go variants Thomas Perale via buildroot
2024-06-01 15:41   ` Yann E. MORIN
2024-04-15 16:22 ` [Buildroot] [PATCH v2 3/6] package/pkg-golang: select BR2_PACKAGE_HOST_GO Thomas Perale via buildroot
2024-06-01 15:41   ` Yann E. MORIN
2024-06-06 11:44   ` Yann E. MORIN
2024-04-15 16:22 ` [Buildroot] [PATCH v2 4/6] package/go: make host package a virtual package Thomas Perale via buildroot
2024-06-01 15:42   ` Yann E. MORIN
2024-04-15 16:22 ` [Buildroot] [PATCH v2 5/6] package/go/go-bin: new host-go provider Thomas Perale via buildroot
2024-06-01 15:51   ` Yann E. MORIN
2024-06-14  4:07     ` Christian Stewart via buildroot
2024-06-14  5:44       ` Yann E. MORIN
2024-06-15  7:20         ` Yann E. MORIN
2024-08-19 21:22       ` Yann E. MORIN
2024-04-15 16:22 ` [Buildroot] [PATCH v2 6/6] support/testing: add tests for Go providers Thomas Perale via buildroot
2024-06-01 15:51   ` Yann E. MORIN
2024-06-01 15:54 ` [Buildroot] [PATCH v2 0/6] support for a pre-built Go compiler Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zh2MAAqe0NEOa3bO@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=christian@paral.in \
    --cc=thomas.perale@essensium.com \
    --cc=thomas.perale@mind.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox