Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Perale <thomas.perale@essensium.com>
Cc: Christian Stewart <christian@paral.in>,
	Thomas Perale <thomas.perale@mind.be>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 3/6] package/pkg-golang: select BR2_PACKAGE_HOST_GO
Date: Sat, 1 Jun 2024 17:41:59 +0200	[thread overview]
Message-ID: <ZltBR4HNEeCcAjM-@landeda> (raw)
In-Reply-To: <20240415162229.1357491-4-thomas.perale@mind.be>

Thomas, All,

On 2024-04-15 18:22 +0200, Thomas Perale via buildroot spake thusly:
> Makes every packages built by the Go compiler select a new variable
> introduced in this patch: BR2_PACKAGE_HOST_GO.
> In later commits Go compiler variant will be introduced (built from
> source, pre-built binaries) and selecting BR2_PACKAGE_HOST_GO will
> force to add host-go provider to the dependency list.
> 
> The same pattern is used for Rust packages.
> 
> Signed-off-by: Thomas Perale <thomas.perale@mind.be>

Applied to next, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/balena-engine/Config.in        | 1 +
>  package/cni-plugins/Config.in          | 1 +
>  package/containerd/Config.in           | 1 +
>  package/crucible/Config.in             | 1 +
>  package/delve/Config.in                | 1 +
>  package/delve/Config.in.host           | 1 +
>  package/docker-cli/Config.in           | 1 +
>  package/docker-compose/Config.in       | 1 +
>  package/docker-engine/Config.in        | 1 +
>  package/embiggen-disk/Config.in        | 1 +
>  package/flannel/Config.in              | 1 +
>  package/gitlab-runner/Config.in        | 1 +
>  package/go/Config.in.host              | 5 +++++
>  package/gocryptfs/Config.in            | 1 +
>  package/mender-artifact/Config.in.host | 1 +
>  package/mender-connect/Config.in       | 1 +
>  package/mender/Config.in               | 1 +
>  package/moby-buildkit/Config.in        | 1 +
>  package/moby-buildkit/Config.in.host   | 1 +
>  package/nerdctl/Config.in              | 1 +
>  package/runc/Config.in                 | 1 +
>  package/runc/Config.in.host            | 1 +
>  package/tinifier/Config.in             | 1 +
>  package/wtfutil/Config.in              | 1 +
>  24 files changed, 28 insertions(+)
> 
> diff --git a/package/balena-engine/Config.in b/package/balena-engine/Config.in
> index 02f694515e..5966b33f58 100644
> --- a/package/balena-engine/Config.in
> +++ b/package/balena-engine/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_BALENA_ENGINE
>  	depends on !BR2_TOOLCHAIN_USES_UCLIBC # no fexecve
>  	depends on BR2_USE_MMU # util-linux
>  	select BR2_PACKAGE_CGROUPFS_MOUNT if !BR2_PACKAGE_SYSTEMD # runtime
> +	select BR2_PACKAGE_HOST_GO
>  	select BR2_PACKAGE_IPTABLES # runtime
>  	select BR2_PACKAGE_UTIL_LINUX # runtime
>  	select BR2_PACKAGE_UTIL_LINUX_BINARIES # runtime
> diff --git a/package/cni-plugins/Config.in b/package/cni-plugins/Config.in
> index 25e6ff534d..6d4ca0a5b4 100644
> --- a/package/cni-plugins/Config.in
> +++ b/package/cni-plugins/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_CNI_PLUGINS
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on !BR2_TOOLCHAIN_USES_UCLIBC # no fexecve
>  	depends on BR2_USE_MMU
> +	select BR2_PACKAGE_HOST_GO
>  	help
>  	  Container Networking Interface plugins.
> 
> diff --git a/package/containerd/Config.in b/package/containerd/Config.in
> index 2dd04b109c..f014c56e10 100644
> --- a/package/containerd/Config.in
> +++ b/package/containerd/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_CONTAINERD
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on !BR2_TOOLCHAIN_USES_UCLIBC # runc
>  	depends on BR2_USE_MMU # util-linux
> +	select BR2_PACKAGE_HOST_GO
>  	select BR2_PACKAGE_RUNC if !BR2_PACKAGE_CRUN # runtime dependency
>  	select BR2_PACKAGE_UTIL_LINUX # runtime dependency
>  	select BR2_PACKAGE_UTIL_LINUX_BINARIES
> diff --git a/package/crucible/Config.in b/package/crucible/Config.in
> index b27eb31ae5..1e1b29c3df 100644
> --- a/package/crucible/Config.in
> +++ b/package/crucible/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_CRUCIBLE
>  	bool "crucible"
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS
> +	select BR2_PACKAGE_HOST_GO
>  	help
>  	  Crucible is a One-Time-Programmable (OTP) fusing tool for the
>  	  i.MX family.
> diff --git a/package/delve/Config.in b/package/delve/Config.in
> index 9428e4016a..288dc1ea15 100644
> --- a/package/delve/Config.in
> +++ b/package/delve/Config.in
> @@ -7,6 +7,7 @@ config BR2_PACKAGE_DELVE_ARCH_SUPPORTS
>  	default y if BR2_x86_64
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_CGO_LINKING_SUPPORTS
> +	select BR2_PACKAGE_HOST_GO
> 
>  config BR2_PACKAGE_DELVE
>  	bool "delve"
> diff --git a/package/delve/Config.in.host b/package/delve/Config.in.host
> index dab5ca8914..0938ab0659 100644
> --- a/package/delve/Config.in.host
> +++ b/package/delve/Config.in.host
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_HOST_DELVE
>  	bool "host delve"
>  	depends on BR2_PACKAGE_HOST_GO_HOST_ARCH_SUPPORTS
> +	select BR2_PACKAGE_HOST_GO
>  	help
>  	  Delve is a debugger for the Go programming language.
> 
> diff --git a/package/docker-cli/Config.in b/package/docker-cli/Config.in
> index 6f187c9d22..52e7f7c871 100644
> --- a/package/docker-cli/Config.in
> +++ b/package/docker-cli/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_DOCKER_CLI
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_CGO_LINKING_SUPPORTS
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	select BR2_PACKAGE_HOST_GO
>  	help
>  	  Docker is a platform to build, ship,
>  	  and run applications as lightweight containers.
> diff --git a/package/docker-compose/Config.in b/package/docker-compose/Config.in
> index 59128f7a19..f3560e402b 100644
> --- a/package/docker-compose/Config.in
> +++ b/package/docker-compose/Config.in
> @@ -4,6 +4,7 @@ config BR2_PACKAGE_DOCKER_COMPOSE
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_CGO_LINKING_SUPPORTS
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on BR2_PACKAGE_DOCKER_CLI
> +	select BR2_PACKAGE_HOST_GO
>  	help
>  	  Multi-container applications with the Docker CLI.
> 
> diff --git a/package/docker-engine/Config.in b/package/docker-engine/Config.in
> index d48ffe6484..49a002a647 100644
> --- a/package/docker-engine/Config.in
> +++ b/package/docker-engine/Config.in
> @@ -9,6 +9,7 @@ config BR2_PACKAGE_DOCKER_ENGINE
>  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 # libseccomp
>  	select BR2_PACKAGE_CGROUPFS_MOUNT if !BR2_PACKAGE_SYSTEMD # runtime dependency
>  	select BR2_PACKAGE_CONTAINERD # runtime dependency
> +	select BR2_PACKAGE_HOST_GO
>  	select BR2_PACKAGE_IPTABLES # runtime dependency
>  	select BR2_PACKAGE_LIBSECCOMP
>  	help
> diff --git a/package/embiggen-disk/Config.in b/package/embiggen-disk/Config.in
> index 667d71c86e..c323fb1b6d 100644
> --- a/package/embiggen-disk/Config.in
> +++ b/package/embiggen-disk/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_EMBIGGEN_DISK
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on !BR2_TOOLCHAIN_USES_UCLIBC # no fexecve
>  	depends on BR2_USE_MMU # util-linux
> +	select BR2_PACKAGE_HOST_GO
>  	select BR2_PACKAGE_UTIL_LINUX # sfdisk
>  	select BR2_PACKAGE_UTIL_LINUX_BINARIES # sfdisk
>  	help
> diff --git a/package/flannel/Config.in b/package/flannel/Config.in
> index eb8d798f48..f37cfaa9cc 100644
> --- a/package/flannel/Config.in
> +++ b/package/flannel/Config.in
> @@ -8,6 +8,7 @@ config BR2_PACKAGE_FLANNEL
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_CGO_LINKING_SUPPORTS
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	select BR2_PACKAGE_HOST_GO
>  	help
>  	  Flannel is a virtual network that gives a subnet to each
>  	  host for use with container runtimes.
> diff --git a/package/gitlab-runner/Config.in b/package/gitlab-runner/Config.in
> index 4289613ab9..cfe8c941bc 100644
> --- a/package/gitlab-runner/Config.in
> +++ b/package/gitlab-runner/Config.in
> @@ -9,6 +9,7 @@ config BR2_PACKAGE_GITLAB_RUNNER
>  	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # bash
>  	select BR2_PACKAGE_CA_CERTIFICATES # runtime
>  	select BR2_PACKAGE_GIT # runtime
> +	select BR2_PACKAGE_HOST_GO
>  	select BR2_PACKAGE_LIBCURL # runtime
>  	select BR2_PACKAGE_LIBCURL_CURL # runtime
>  	select BR2_PACKAGE_LIBCURL_FORCE_TLS # runtime
> diff --git a/package/go/Config.in.host b/package/go/Config.in.host
> index 7edf45850d..e1833d0905 100644
> --- a/package/go/Config.in.host
> +++ b/package/go/Config.in.host
> @@ -32,6 +32,11 @@ config BR2_PACKAGE_HOST_GO_HOST_ARCH_SUPPORTS
>  	default y
>  	depends on BR2_PACKAGE_HOST_GO_BOOTSTRAP_STAGE3_ARCH_SUPPORTS
> 
> +# Go packages should select BR2_PACKAGE_HOST_GO
> +config BR2_PACKAGE_HOST_GO
> +	bool
> +	depends on BR2_PACKAGE_HOST_GO_HOST_ARCH_SUPPORTS
> +
>  source "package/go/go-bootstrap-stage1/Config.in.host"
>  source "package/go/go-bootstrap-stage2/Config.in.host"
>  source "package/go/go-bootstrap-stage3/Config.in.host"
> diff --git a/package/gocryptfs/Config.in b/package/gocryptfs/Config.in
> index 2630cafdcf..2c70b9b21b 100644
> --- a/package/gocryptfs/Config.in
> +++ b/package/gocryptfs/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_GOCRYPTFS
>  	bool "gocryptfs"
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	select BR2_PACKAGE_HOST_GO
>  	help
>  	  gocryptfs is an encrypted FUSE overlay filesystem.
> 
> diff --git a/package/mender-artifact/Config.in.host b/package/mender-artifact/Config.in.host
> index c7be0ed261..39353b23e7 100644
> --- a/package/mender-artifact/Config.in.host
> +++ b/package/mender-artifact/Config.in.host
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_HOST_MENDER_ARTIFACT
>  	bool "host mender-artifact"
>  	depends on BR2_PACKAGE_HOST_GO_HOST_ARCH_SUPPORTS
> +	select BR2_PACKAGE_HOST_GO
>  	help
>  	  The mender-artifact tool is a CLI implementation of the
>  	  Mender artifacts library.
> diff --git a/package/mender-connect/Config.in b/package/mender-connect/Config.in
> index 0845910880..d478e468c2 100644
> --- a/package/mender-connect/Config.in
> +++ b/package/mender-connect/Config.in
> @@ -6,6 +6,7 @@ config BR2_PACKAGE_MENDER_CONNECT
>  	depends on BR2_USE_WCHAR # libglib2 -> gettext
>  	depends on BR2_USE_MMU # dbus -> fork()
>  	select BR2_PACKAGE_DBUS # runtime
> +	select BR2_PACKAGE_HOST_GO
>  	select BR2_PACKAGE_LIBGLIB2
>  	select BR2_PACKAGE_MENDER # runtime
>  	select BR2_PACKAGE_OPENSSL
> diff --git a/package/mender/Config.in b/package/mender/Config.in
> index 7d768cebec..4831548f76 100644
> --- a/package/mender/Config.in
> +++ b/package/mender/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_MENDER
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_CGO_LINKING_SUPPORTS
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	select BR2_PACKAGE_HOST_GO
>  	select BR2_PACKAGE_OPENSSL
>  	select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL
>  	select BR2_PACKAGE_LIBOPENSSL_ENABLE_MD4
> diff --git a/package/moby-buildkit/Config.in b/package/moby-buildkit/Config.in
> index 93c852bcdb..1a0b599097 100644
> --- a/package/moby-buildkit/Config.in
> +++ b/package/moby-buildkit/Config.in
> @@ -6,6 +6,7 @@ config BR2_PACKAGE_MOBY_BUILDKIT
>  	depends on !BR2_TOOLCHAIN_USES_UCLIBC
>  	depends on BR2_USE_MMU
>  	select BR2_PACKAGE_CGROUPFS_MOUNT if !BR2_PACKAGE_SYSTEMD # runtime dependency
> +	select BR2_PACKAGE_HOST_GO
>  	help
>  	  BuildKit is a toolkit for converting source code to build
>  	  artifacts in an efficient, expressive and repeatable manner.
> diff --git a/package/moby-buildkit/Config.in.host b/package/moby-buildkit/Config.in.host
> index a3b18548f8..d4eb0d74c3 100644
> --- a/package/moby-buildkit/Config.in.host
> +++ b/package/moby-buildkit/Config.in.host
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_HOST_MOBY_BUILDKIT
>  	bool "host moby-buildkit"
>  	depends on BR2_PACKAGE_HOST_GO_HOST_ARCH_SUPPORTS
> +	select BR2_PACKAGE_HOST_GO
>  	help
>  	  BuildKit is a toolkit for converting source code to build
>  	  artifacts in an efficient expressive and repeatable manner.
> diff --git a/package/nerdctl/Config.in b/package/nerdctl/Config.in
> index 969b9bb40e..062b36ab85 100644
> --- a/package/nerdctl/Config.in
> +++ b/package/nerdctl/Config.in
> @@ -6,6 +6,7 @@ config BR2_PACKAGE_NERDCTL
>  	depends on !BR2_TOOLCHAIN_USES_UCLIBC # containerd
>  	depends on BR2_USE_MMU # util-linux
>  	select BR2_PACKAGE_CONTAINERD # runtime
> +	select BR2_PACKAGE_HOST_GO
>  	help
>  	  Docker-compatible CLI for containerd, controlling runc.
> 
> diff --git a/package/runc/Config.in b/package/runc/Config.in
> index fe527b1954..73eac72527 100644
> --- a/package/runc/Config.in
> +++ b/package/runc/Config.in
> @@ -4,6 +4,7 @@ config BR2_PACKAGE_RUNC
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_CGO_LINKING_SUPPORTS
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on !BR2_TOOLCHAIN_USES_UCLIBC # no fexecve
> +	select BR2_PACKAGE_HOST_GO
>  	help
>  	  runC is a CLI tool for spawning and running containers
>  	  according to the OCI specification.
> diff --git a/package/runc/Config.in.host b/package/runc/Config.in.host
> index 4b2555e029..78193cb499 100644
> --- a/package/runc/Config.in.host
> +++ b/package/runc/Config.in.host
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_HOST_RUNC
>  	bool "host runc"
>  	depends on BR2_PACKAGE_HOST_GO_HOST_ARCH_SUPPORTS
> +	select BR2_PACKAGE_HOST_GO
>  	help
>  	  runC is a CLI tool for spawning and running containers
>  	  according to the OCI specification.
> diff --git a/package/tinifier/Config.in b/package/tinifier/Config.in
> index fbadfe6bd9..eae8b8f499 100644
> --- a/package/tinifier/Config.in
> +++ b/package/tinifier/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_TINIFIER
>  	bool "tinifier"
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS
> +	select BR2_PACKAGE_HOST_GO
>  	help
>  	  CLI tool for images compressing
> 
> diff --git a/package/wtfutil/Config.in b/package/wtfutil/Config.in
> index 8c3efcea5d..3fd8c41bab 100644
> --- a/package/wtfutil/Config.in
> +++ b/package/wtfutil/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_WTFUTIL
>  	bool "wtfutil"
>  	depends on BR2_USE_MMU  # fork()
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS
> +	select BR2_PACKAGE_HOST_GO
>  	help
>  	  WTF is the personal information dashboard for your terminal.
> 
> --
> 2.44.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-06-01 15:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 16:22 [Buildroot] [PATCH v2 0/6] support for a pre-built Go compiler Thomas Perale via buildroot
2024-04-15 16:22 ` [Buildroot] [PATCH v2 1/6] DEVELOPERS: add Thomas Perale for 'go' Thomas Perale via buildroot
2024-04-15 16:44   ` Yann E. MORIN
2024-04-15 17:38     ` Thomas Perale via buildroot
2024-04-15 20:20       ` Yann E. MORIN
2024-06-01 15:39   ` Yann E. MORIN
2024-04-15 16:22 ` [Buildroot] [PATCH v2 2/6] package/go: new subdirectory for go variants Thomas Perale via buildroot
2024-06-01 15:41   ` Yann E. MORIN
2024-04-15 16:22 ` [Buildroot] [PATCH v2 3/6] package/pkg-golang: select BR2_PACKAGE_HOST_GO Thomas Perale via buildroot
2024-06-01 15:41   ` Yann E. MORIN [this message]
2024-06-06 11:44   ` Yann E. MORIN
2024-04-15 16:22 ` [Buildroot] [PATCH v2 4/6] package/go: make host package a virtual package Thomas Perale via buildroot
2024-06-01 15:42   ` Yann E. MORIN
2024-04-15 16:22 ` [Buildroot] [PATCH v2 5/6] package/go/go-bin: new host-go provider Thomas Perale via buildroot
2024-06-01 15:51   ` Yann E. MORIN
2024-06-14  4:07     ` Christian Stewart via buildroot
2024-06-14  5:44       ` Yann E. MORIN
2024-06-15  7:20         ` Yann E. MORIN
2024-08-19 21:22       ` Yann E. MORIN
2024-04-15 16:22 ` [Buildroot] [PATCH v2 6/6] support/testing: add tests for Go providers Thomas Perale via buildroot
2024-06-01 15:51   ` Yann E. MORIN
2024-06-01 15:54 ` [Buildroot] [PATCH v2 0/6] support for a pre-built Go compiler Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZltBR4HNEeCcAjM-@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=christian@paral.in \
    --cc=thomas.perale@essensium.com \
    --cc=thomas.perale@mind.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox