Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Romain Naour <romain.naour@smile.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] configs/beagleboneai64_defconfig: new defconfig
Date: Sun, 5 May 2024 20:45:08 +0200	[thread overview]
Message-ID: <ZjfTtH0pArzsV4fN@landeda> (raw)
In-Reply-To: <20240502141809.2292787-1-romain.naour@smile.fr>

Romain, All,

On 2024-05-02 16:18 +0200, Romain Naour spake thusly:
> Adds support for BeagleBone AI-64 board by introducing the
> beagleboneai64_defconfig file and related support files.
[--SNIP--]
>  .../beagleboard/beagleboneai64/post-build.sh  | 15 ++++++

    $ ./utild/docker-run make check-package
    board/beagleboard/beagleboneai64/post-build.sh:0: run 'shellcheck' and fix the warnings

    $ ./utild/docker-run shellcheck board/beagleboard/beagleboneai64/post-build.sh
    In board/beagleboard/beagleboneai64/post-build.sh line 2:
    BOARD_DIR="$(dirname $0)"
                         ^-- SC2086: Double quote to prevent globbing and word splitting.

    Did you mean:
    BOARD_DIR="$(dirname "$0")"


    In board/beagleboard/beagleboneai64/post-build.sh line 4:
    cp $BOARD_DIR/uEnv.txt $BINARIES_DIR/uEnv.txt
       ^--------^ SC2086: Double quote to prevent globbing and word splitting.
                           ^-----------^ SC2086: Double quote to prevent globbing and word splitting.

    Did you mean:
    cp "$BOARD_DIR"/uEnv.txt "$BINARIES_DIR"/uEnv.txt


    In board/beagleboard/beagleboneai64/post-build.sh line 15:
    ln -sfn . ${TARGET_DIR}/boot/dtb
              ^-----------^ SC2086: Double quote to prevent globbing and word splitting.

    Did you mean:
    ln -sfn . "${TARGET_DIR}"/boot/dtb

Care to fix and respin, please?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-05-05 18:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-02 14:18 [Buildroot] [PATCH] configs/beagleboneai64_defconfig: new defconfig Romain Naour
2024-05-05 18:45 ` Yann E. MORIN [this message]
2024-05-06  8:42   ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjfTtH0pArzsV4fN@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=romain.naour@smile.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox