From: Romain Naour <romain.naour@smile.fr>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] configs/beagleboneai64_defconfig: new defconfig
Date: Mon, 6 May 2024 10:42:59 +0200 [thread overview]
Message-ID: <a41aae60-cded-427a-9bc9-10c330eaf37f@smile.fr> (raw)
In-Reply-To: <ZjfTtH0pArzsV4fN@landeda>
Hello Yann, All,
Le 05/05/2024 à 20:45, Yann E. MORIN a écrit :
> Romain, All,
>
> On 2024-05-02 16:18 +0200, Romain Naour spake thusly:
>> Adds support for BeagleBone AI-64 board by introducing the
>> beagleboneai64_defconfig file and related support files.
> [--SNIP--]
>> .../beagleboard/beagleboneai64/post-build.sh | 15 ++++++
>
> $ ./utild/docker-run make check-package
> board/beagleboard/beagleboneai64/post-build.sh:0: run 'shellcheck' and fix the warnings
>
> $ ./utild/docker-run shellcheck board/beagleboard/beagleboneai64/post-build.sh
> In board/beagleboard/beagleboneai64/post-build.sh line 2:
> BOARD_DIR="$(dirname $0)"
> ^-- SC2086: Double quote to prevent globbing and word splitting.
>
> Did you mean:
> BOARD_DIR="$(dirname "$0")"
>
>
> In board/beagleboard/beagleboneai64/post-build.sh line 4:
> cp $BOARD_DIR/uEnv.txt $BINARIES_DIR/uEnv.txt
> ^--------^ SC2086: Double quote to prevent globbing and word splitting.
> ^-----------^ SC2086: Double quote to prevent globbing and word splitting.
>
> Did you mean:
> cp "$BOARD_DIR"/uEnv.txt "$BINARIES_DIR"/uEnv.txt
>
>
> In board/beagleboard/beagleboneai64/post-build.sh line 15:
> ln -sfn . ${TARGET_DIR}/boot/dtb
> ^-----------^ SC2086: Double quote to prevent globbing and word splitting.
>
> Did you mean:
> ln -sfn . "${TARGET_DIR}"/boot/dtb
>
> Care to fix and respin, please?
Thanks!
While at it I updated the kernel to the latest 6.6.30 release and used
utils/add-custom-hashes script to regen all file hash.
Best regards,
Romain
>
> Regards,
> Yann E. MORIN.
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-05-06 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 14:18 [Buildroot] [PATCH] configs/beagleboneai64_defconfig: new defconfig Romain Naour
2024-05-05 18:45 ` Yann E. MORIN
2024-05-06 8:42 ` Romain Naour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a41aae60-cded-427a-9bc9-10c330eaf37f@smile.fr \
--to=romain.naour@smile.fr \
--cc=buildroot@buildroot.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox