Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/kodi: remove libatomic from linker flags
@ 2024-05-12 16:31 Bernd Kuhls
  2024-05-12 17:54 ` Yann E. MORIN
  2024-06-08 11:25 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2024-05-12 16:31 UTC (permalink / raw)
  To: buildroot

Kodi added detection for atomic/libatomic with commit
https://github.com/xbmc/xbmc/commit/1673f476b802da1da942cef256cae6272fdf9a4b
so we can remove our own code to handle the dependency.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/kodi/kodi.mk | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
index 62463b731e..94cab237dc 100644
--- a/package/kodi/kodi.mk
+++ b/package/kodi/kodi.mk
@@ -217,11 +217,6 @@ else
 KODI_CONF_OPTS += -D_AVX2_OK=OFF -D_AVX2_TRUE=OFF
 endif
 
-# mips: uses __atomic_load_8
-ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
-KODI_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic
-endif
-
 ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_5),)
 KODI_C_FLAGS += -std=gnu99
 endif
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/kodi: remove libatomic from linker flags
  2024-05-12 16:31 [Buildroot] [PATCH 1/1] package/kodi: remove libatomic from linker flags Bernd Kuhls
@ 2024-05-12 17:54 ` Yann E. MORIN
  2024-06-08 11:25 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2024-05-12 17:54 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot

Bernd, All,

On 2024-05-12 18:31 +0200, Bernd Kuhls spake thusly:
> Kodi added detection for atomic/libatomic with commit
> https://github.com/xbmc/xbmc/commit/1673f476b802da1da942cef256cae6272fdf9a4b
> so we can remove our own code to handle the dependency.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied to master, thanks for the quick fix!

Regards,
Yann E. MORIN.

> ---
>  package/kodi/kodi.mk | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
> index 62463b731e..94cab237dc 100644
> --- a/package/kodi/kodi.mk
> +++ b/package/kodi/kodi.mk
> @@ -217,11 +217,6 @@ else
>  KODI_CONF_OPTS += -D_AVX2_OK=OFF -D_AVX2_TRUE=OFF
>  endif
>  
> -# mips: uses __atomic_load_8
> -ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> -KODI_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic
> -endif
> -
>  ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_5),)
>  KODI_C_FLAGS += -std=gnu99
>  endif
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/kodi: remove libatomic from linker flags
  2024-05-12 16:31 [Buildroot] [PATCH 1/1] package/kodi: remove libatomic from linker flags Bernd Kuhls
  2024-05-12 17:54 ` Yann E. MORIN
@ 2024-06-08 11:25 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2024-06-08 11:25 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot

>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:

 > Kodi added detection for atomic/libatomic with commit
 > https://github.com/xbmc/xbmc/commit/1673f476b802da1da942cef256cae6272fdf9a4b
 > so we can remove our own code to handle the dependency.

 > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Committed to 2024.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-08 11:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-12 16:31 [Buildroot] [PATCH 1/1] package/kodi: remove libatomic from linker flags Bernd Kuhls
2024-05-12 17:54 ` Yann E. MORIN
2024-06-08 11:25 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox