Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/ivi-homescreen: needs gcc >= 8
@ 2024-05-19 10:54 Fabrice Fontaine
  2024-05-21  4:58 ` Yann E. MORIN
  2024-06-08 13:43 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2024-05-19 10:54 UTC (permalink / raw)
  To: buildroot; +Cc: Adam Duskett, Fabrice Fontaine

ivi-homescreen needs C++17 filesystem resulting in the following build
failure with gcc < 8 since its addition in commit
9d8497e79de3ced144877ba6ee38cc5b7181aaeb:

In file included from /home/buildroot/instance-0/output-1/build/ivi-homescreen-5ab78a19e95c88cc5d6b173ab1260a211e78cf0a/third_party/flutter/shell/platform/common/path_utils.cc:5:0:
/home/buildroot/instance-0/output-1/build/ivi-homescreen-5ab78a19e95c88cc5d6b173ab1260a211e78cf0a/third_party/./flutter/shell/platform/common/path_utils.h:8:10: fatal error: filesystem: No such file or directory
 #include <filesystem>
          ^~~~~~~~~~~~

Fixes: 9d8497e79de3ced144877ba6ee38cc5b7181aaeb
 - http://autobuild.buildroot.org/results/a5e88d5a4264a6165be31a99f1c123af53fa382e

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/ivi-homescreen/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/ivi-homescreen/Config.in b/package/ivi-homescreen/Config.in
index dc2ccb0c97..a4f5f6835f 100644
--- a/package/ivi-homescreen/Config.in
+++ b/package/ivi-homescreen/Config.in
@@ -3,7 +3,7 @@ menuconfig BR2_PACKAGE_IVI_HOMESCREEN
 	depends on BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_ARCH_SUPPORTS
 	depends on BR2_PACKAGE_FLUTTER_ENGINE_ARCH_SUPPORTS
 	depends on BR2_HOST_GCC_AT_LEAST_5 # flutter-engine
-	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # flutter-engine
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # C++17 filesystem
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # flutter-engine
 	depends on BR2_TOOLCHAIN_USES_GLIBC # flutter-engine
 	depends on BR2_INSTALL_LIBSTDCPP # flutter-engine
@@ -250,11 +250,11 @@ comment "OpenGL texture plugin needs an EGL backend"
 
 endif # BR2_PACKAGE_IVI_HOMESCREEN
 
-comment "ivi-homescreen needs a glibc toolchain w/ wchar, C++, gcc >= 5, dynamic library, host gcc >= 5"
+comment "ivi-homescreen needs a glibc toolchain w/ wchar, C++, gcc >= 8, dynamic library, host gcc >= 5"
 	depends on BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_ARCH_SUPPORTS
 	depends on BR2_PACKAGE_FLUTTER_ENGINE_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_USES_GLIBC \
-		|| !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_5 \
+		|| !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_8 \
 		|| BR2_STATIC_LIBS || !BR2_USE_WCHAR \
 		|| !BR2_HOST_GCC_AT_LEAST_5
 
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/ivi-homescreen: needs gcc >= 8
  2024-05-19 10:54 [Buildroot] [PATCH 1/1] package/ivi-homescreen: needs gcc >= 8 Fabrice Fontaine
@ 2024-05-21  4:58 ` Yann E. MORIN
  2024-06-08 13:43 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2024-05-21  4:58 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Adam Duskett, buildroot

Fabrice, All,

On 2024-05-19 12:54 +0200, Fabrice Fontaine spake thusly:
> ivi-homescreen needs C++17 filesystem resulting in the following build
> failure with gcc < 8 since its addition in commit
> 9d8497e79de3ced144877ba6ee38cc5b7181aaeb:
> 
> In file included from /home/buildroot/instance-0/output-1/build/ivi-homescreen-5ab78a19e95c88cc5d6b173ab1260a211e78cf0a/third_party/flutter/shell/platform/common/path_utils.cc:5:0:
> /home/buildroot/instance-0/output-1/build/ivi-homescreen-5ab78a19e95c88cc5d6b173ab1260a211e78cf0a/third_party/./flutter/shell/platform/common/path_utils.h:8:10: fatal error: filesystem: No such file or directory
>  #include <filesystem>
>           ^~~~~~~~~~~~
> 
> Fixes: 9d8497e79de3ced144877ba6ee38cc5b7181aaeb
>  - http://autobuild.buildroot.org/results/a5e88d5a4264a6165be31a99f1c123af53fa382e
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/ivi-homescreen/Config.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/ivi-homescreen/Config.in b/package/ivi-homescreen/Config.in
> index dc2ccb0c97..a4f5f6835f 100644
> --- a/package/ivi-homescreen/Config.in
> +++ b/package/ivi-homescreen/Config.in
> @@ -3,7 +3,7 @@ menuconfig BR2_PACKAGE_IVI_HOMESCREEN
>  	depends on BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_ARCH_SUPPORTS
>  	depends on BR2_PACKAGE_FLUTTER_ENGINE_ARCH_SUPPORTS
>  	depends on BR2_HOST_GCC_AT_LEAST_5 # flutter-engine
> -	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # flutter-engine
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # C++17 filesystem
>  	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # flutter-engine
>  	depends on BR2_TOOLCHAIN_USES_GLIBC # flutter-engine
>  	depends on BR2_INSTALL_LIBSTDCPP # flutter-engine
> @@ -250,11 +250,11 @@ comment "OpenGL texture plugin needs an EGL backend"
>  
>  endif # BR2_PACKAGE_IVI_HOMESCREEN
>  
> -comment "ivi-homescreen needs a glibc toolchain w/ wchar, C++, gcc >= 5, dynamic library, host gcc >= 5"
> +comment "ivi-homescreen needs a glibc toolchain w/ wchar, C++, gcc >= 8, dynamic library, host gcc >= 5"
>  	depends on BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_ARCH_SUPPORTS
>  	depends on BR2_PACKAGE_FLUTTER_ENGINE_ARCH_SUPPORTS
>  	depends on !BR2_TOOLCHAIN_USES_GLIBC \
> -		|| !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_5 \
> +		|| !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_8 \
>  		|| BR2_STATIC_LIBS || !BR2_USE_WCHAR \
>  		|| !BR2_HOST_GCC_AT_LEAST_5
>  
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/ivi-homescreen: needs gcc >= 8
  2024-05-19 10:54 [Buildroot] [PATCH 1/1] package/ivi-homescreen: needs gcc >= 8 Fabrice Fontaine
  2024-05-21  4:58 ` Yann E. MORIN
@ 2024-06-08 13:43 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2024-06-08 13:43 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Adam Duskett, buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > ivi-homescreen needs C++17 filesystem resulting in the following build
 > failure with gcc < 8 since its addition in commit
 > 9d8497e79de3ced144877ba6ee38cc5b7181aaeb:

 > In file included from /home/buildroot/instance-0/output-1/build/ivi-homescreen-5ab78a19e95c88cc5d6b173ab1260a211e78cf0a/third_party/flutter/shell/platform/common/path_utils.cc:5:0:
 > /home/buildroot/instance-0/output-1/build/ivi-homescreen-5ab78a19e95c88cc5d6b173ab1260a211e78cf0a/third_party/./flutter/shell/platform/common/path_utils.h:8:10: fatal error: filesystem: No such file or directory
 >  #include <filesystem>
 >           ^~~~~~~~~~~~

 > Fixes: 9d8497e79de3ced144877ba6ee38cc5b7181aaeb
 >  - http://autobuild.buildroot.org/results/a5e88d5a4264a6165be31a99f1c123af53fa382e

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2024.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-08 13:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-19 10:54 [Buildroot] [PATCH 1/1] package/ivi-homescreen: needs gcc >= 8 Fabrice Fontaine
2024-05-21  4:58 ` Yann E. MORIN
2024-06-08 13:43 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox