[Buildroot] [PATCH 1/1] utils/genrandconfig: drop glibc Linaro toolchain version check

[Buildroot] [PATCH 1/1] utils/genrandconfig: drop glibc Linaro toolchain version check

[James Hilliard]

It has been well over 10 years since glibc 2.14 was released, I don't
think we need this check anymore.

The distutils module is no longer bundled with python 3.12 so this
eliminates the need to install additional python modules under python
3.12.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 utils/genrandconfig | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/utils/genrandconfig b/utils/genrandconfig
index b838dda34d..0889be0d43 100755
--- a/utils/genrandconfig
+++ b/utils/genrandconfig
@@ -25,8 +25,6 @@ import os
 from random import randint
 import sys
 import traceback
-from distutils.version import StrictVersion
-import platform
 
 
 class SystemInfo:
@@ -166,23 +164,6 @@ async def is_toolchain_usable(configfile, config):
             print("      Missing: %s" % toolchainline.strip(), file=sys.stderr)
             return False
 
-    # The latest Linaro toolchains on x86-64 hosts requires glibc
-    # 2.14+ on the host.
-    if platform.machine() == 'x86_64':
-        if 'BR2_TOOLCHAIN_EXTERNAL_LINARO_ARM=y\n' in configlines or \
-           'BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64=y\n' in configlines or \
-           'BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64_BE=y\n' in configlines or \
-           'BR2_TOOLCHAIN_EXTERNAL_LINARO_ARMEB=y\n' in configlines:
-            proc = await asyncio.create_subprocess_exec(
-                'ldd', '--version', stdout=asyncio.subprocess.PIPE)
-            ldd_version_output, _ = await proc.communicate()
-            if proc.returncode:
-                return False
-            glibc_version = ldd_version_output.decode().splitlines()[0].split()[-1]
-            if StrictVersion('2.14') > StrictVersion(glibc_version):
-                print("WARN: ignoring the Linaro ARM toolchains because too old host glibc", file=sys.stderr)
-                return False
-
     return True
 
 
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] utils/genrandconfig: drop glibc Linaro toolchain version check

[Yann E. MORIN]

James, All,

On 2024-05-31 19:17 -0600, James Hilliard spake thusly:
> It has been well over 10 years since glibc 2.14 was released, I don't
> think we need this check anymore.

To support that claim, I've added references to Debian and Ubuntu, and
when they stopped using glibc versions older than 2.14.

> The distutils module is no longer bundled with python 3.12 so this
> eliminates the need to install additional python modules under python
> 3.12.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  utils/genrandconfig | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/utils/genrandconfig b/utils/genrandconfig
> index b838dda34d..0889be0d43 100755
> --- a/utils/genrandconfig
> +++ b/utils/genrandconfig
> @@ -25,8 +25,6 @@ import os
>  from random import randint
>  import sys
>  import traceback
> -from distutils.version import StrictVersion
> -import platform
>  
>  
>  class SystemInfo:
> @@ -166,23 +164,6 @@ async def is_toolchain_usable(configfile, config):
>              print("      Missing: %s" % toolchainline.strip(), file=sys.stderr)
>              return False
>  
> -    # The latest Linaro toolchains on x86-64 hosts requires glibc
> -    # 2.14+ on the host.
> -    if platform.machine() == 'x86_64':
> -        if 'BR2_TOOLCHAIN_EXTERNAL_LINARO_ARM=y\n' in configlines or \
> -           'BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64=y\n' in configlines or \
> -           'BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64_BE=y\n' in configlines or \
> -           'BR2_TOOLCHAIN_EXTERNAL_LINARO_ARMEB=y\n' in configlines:
> -            proc = await asyncio.create_subprocess_exec(
> -                'ldd', '--version', stdout=asyncio.subprocess.PIPE)
> -            ldd_version_output, _ = await proc.communicate()
> -            if proc.returncode:
> -                return False
> -            glibc_version = ldd_version_output.decode().splitlines()[0].split()[-1]
> -            if StrictVersion('2.14') > StrictVersion(glibc_version):
> -                print("WARN: ignoring the Linaro ARM toolchains because too old host glibc", file=sys.stderr)
> -                return False
> -
>      return True
>  
>  
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] utils/genrandconfig: drop glibc Linaro toolchain version check

[Peter Korsgaard]

>>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes:

 > It has been well over 10 years since glibc 2.14 was released, I don't
 > think we need this check anymore.

 > The distutils module is no longer bundled with python 3.12 so this
 > eliminates the need to install additional python modules under python
 > 3.12.

 > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Committed to 2024.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot