* [Buildroot] [PATCH 1/1] package/nut: needs threads
@ 2024-06-15 18:20 Fabrice Fontaine
2024-06-15 19:27 ` Yann E. MORIN
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2024-06-15 18:20 UTC (permalink / raw)
To: buildroot; +Cc: Bernd Kuhls, Yann E . MORIN, Asaf Kahlon, Fabrice Fontaine
threads are mandantory since bump to version 2.8.2 in commit
4edd837ac0193db83202030ee2997ac811e6bc45 and
https://github.com/networkupstools/nut/commit/ff401e538bcbead62a3532887135518ef9e779df:
In file included from nutipc.cpp:38:
../include/nutipc.hpp:455:3: error: 'pthread_t' does not name a type
455 | pthread_t m_impl;
| ^~~~~~~~~
Fixes: 4edd837ac0193db83202030ee2997ac811e6bc45
- http://autobuild.buildroot.org/results/d16a24d60b298d7616a516ec0c6c30696ed93a58
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/collectd/Config.in | 5 +++--
package/nut/Config.in | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/package/collectd/Config.in b/package/collectd/Config.in
index 80759e9566..35f544b626 100644
--- a/package/collectd/Config.in
+++ b/package/collectd/Config.in
@@ -430,13 +430,14 @@ config BR2_PACKAGE_COLLECTD_NTPD
config BR2_PACKAGE_COLLECTD_NUT
bool "nut"
depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_TOOLCHAIN_HAS_THREADS
select BR2_PACKAGE_NUT
help
The NUT plugin collects uninterruptible power supply (UPS)
statistics using the Network UPS Tools (NUT).
-comment "nut needs a toolchain w/ C++"
- depends on !BR2_INSTALL_LIBSTDCPP
+comment "nut needs a toolchain w/ C++, threads"
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
config BR2_PACKAGE_COLLECTD_OLSRD
bool "olsrd"
diff --git a/package/nut/Config.in b/package/nut/Config.in
index df647b9b48..0ecd33d583 100644
--- a/package/nut/Config.in
+++ b/package/nut/Config.in
@@ -1,11 +1,12 @@
-comment "nut needs a toolchain w/ C++"
+comment "nut needs a toolchain w/ C++, threads"
depends on BR2_USE_MMU
- depends on !BR2_INSTALL_LIBSTDCPP
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
config BR2_PACKAGE_NUT
bool "nut"
depends on BR2_USE_MMU # fork()
depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_TOOLCHAIN_HAS_THREADS
help
Network UPS tools
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/nut: needs threads
2024-06-15 18:20 [Buildroot] [PATCH 1/1] package/nut: needs threads Fabrice Fontaine
@ 2024-06-15 19:27 ` Yann E. MORIN
2024-06-16 8:59 ` Yann E. MORIN
2024-06-24 9:16 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2024-06-15 19:27 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Bernd Kuhls, Asaf Kahlon, buildroot
Fabrice, All,
On 2024-06-15 20:20 +0200, Fabrice Fontaine spake thusly:
> threads are mandantory since bump to version 2.8.2 in commit
> 4edd837ac0193db83202030ee2997ac811e6bc45 and
> https://github.com/networkupstools/nut/commit/ff401e538bcbead62a3532887135518ef9e779df:
>
> In file included from nutipc.cpp:38:
> ../include/nutipc.hpp:455:3: error: 'pthread_t' does not name a type
> 455 | pthread_t m_impl;
> | ^~~~~~~~~
>
> Fixes: 4edd837ac0193db83202030ee2997ac811e6bc45
> - http://autobuild.buildroot.org/results/d16a24d60b298d7616a516ec0c6c30696ed93a58
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/collectd/Config.in | 5 +++--
> package/nut/Config.in | 5 +++--
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/package/collectd/Config.in b/package/collectd/Config.in
> index 80759e9566..35f544b626 100644
> --- a/package/collectd/Config.in
> +++ b/package/collectd/Config.in
> @@ -430,13 +430,14 @@ config BR2_PACKAGE_COLLECTD_NTPD
> config BR2_PACKAGE_COLLECTD_NUT
> bool "nut"
> depends on BR2_INSTALL_LIBSTDCPP
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> select BR2_PACKAGE_NUT
> help
> The NUT plugin collects uninterruptible power supply (UPS)
> statistics using the Network UPS Tools (NUT).
>
> -comment "nut needs a toolchain w/ C++"
> - depends on !BR2_INSTALL_LIBSTDCPP
> +comment "nut needs a toolchain w/ C++, threads"
> + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
>
> config BR2_PACKAGE_COLLECTD_OLSRD
> bool "olsrd"
> diff --git a/package/nut/Config.in b/package/nut/Config.in
> index df647b9b48..0ecd33d583 100644
> --- a/package/nut/Config.in
> +++ b/package/nut/Config.in
> @@ -1,11 +1,12 @@
> -comment "nut needs a toolchain w/ C++"
> +comment "nut needs a toolchain w/ C++, threads"
> depends on BR2_USE_MMU
> - depends on !BR2_INSTALL_LIBSTDCPP
> + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
>
> config BR2_PACKAGE_NUT
> bool "nut"
> depends on BR2_USE_MMU # fork()
> depends on BR2_INSTALL_LIBSTDCPP
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> help
> Network UPS tools
>
> --
> 2.43.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/nut: needs threads
2024-06-15 18:20 [Buildroot] [PATCH 1/1] package/nut: needs threads Fabrice Fontaine
2024-06-15 19:27 ` Yann E. MORIN
@ 2024-06-16 8:59 ` Yann E. MORIN
2024-06-24 9:16 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2024-06-16 8:59 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Bernd Kuhls, Asaf Kahlon, buildroot
Fabrice, All,
On 2024-06-15 20:20 +0200, Fabrice Fontaine spake thusly:
> threads are mandantory since bump to version 2.8.2 in commit
> 4edd837ac0193db83202030ee2997ac811e6bc45 and
> https://github.com/networkupstools/nut/commit/ff401e538bcbead62a3532887135518ef9e779df:
>
> In file included from nutipc.cpp:38:
> ../include/nutipc.hpp:455:3: error: 'pthread_t' does not name a type
> 455 | pthread_t m_impl;
> | ^~~~~~~~~
>
> Fixes: 4edd837ac0193db83202030ee2997ac811e6bc45
> - http://autobuild.buildroot.org/results/d16a24d60b298d7616a516ec0c6c30696ed93a58
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/collectd/Config.in | 5 +++--
> package/nut/Config.in | 5 +++--
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/package/collectd/Config.in b/package/collectd/Config.in
> index 80759e9566..35f544b626 100644
> --- a/package/collectd/Config.in
> +++ b/package/collectd/Config.in
> @@ -430,13 +430,14 @@ config BR2_PACKAGE_COLLECTD_NTPD
> config BR2_PACKAGE_COLLECTD_NUT
> bool "nut"
> depends on BR2_INSTALL_LIBSTDCPP
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> select BR2_PACKAGE_NUT
> help
> The NUT plugin collects uninterruptible power supply (UPS)
> statistics using the Network UPS Tools (NUT).
>
> -comment "nut needs a toolchain w/ C++"
> - depends on !BR2_INSTALL_LIBSTDCPP
> +comment "nut needs a toolchain w/ C++, threads"
> + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
>
> config BR2_PACKAGE_COLLECTD_OLSRD
> bool "olsrd"
> diff --git a/package/nut/Config.in b/package/nut/Config.in
> index df647b9b48..0ecd33d583 100644
> --- a/package/nut/Config.in
> +++ b/package/nut/Config.in
> @@ -1,11 +1,12 @@
> -comment "nut needs a toolchain w/ C++"
> +comment "nut needs a toolchain w/ C++, threads"
> depends on BR2_USE_MMU
> - depends on !BR2_INSTALL_LIBSTDCPP
> + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
>
> config BR2_PACKAGE_NUT
> bool "nut"
> depends on BR2_USE_MMU # fork()
> depends on BR2_INSTALL_LIBSTDCPP
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> help
> Network UPS tools
>
> --
> 2.43.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/nut: needs threads
2024-06-15 18:20 [Buildroot] [PATCH 1/1] package/nut: needs threads Fabrice Fontaine
2024-06-15 19:27 ` Yann E. MORIN
2024-06-16 8:59 ` Yann E. MORIN
@ 2024-06-24 9:16 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2024-06-24 9:16 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Bernd Kuhls, Yann E . MORIN, Asaf Kahlon, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> threads are mandantory since bump to version 2.8.2 in commit
> 4edd837ac0193db83202030ee2997ac811e6bc45 and
> https://github.com/networkupstools/nut/commit/ff401e538bcbead62a3532887135518ef9e779df:
> In file included from nutipc.cpp:38:
> ../include/nutipc.hpp:455:3: error: 'pthread_t' does not name a type
> 455 | pthread_t m_impl;
> | ^~~~~~~~~
> Fixes: 4edd837ac0193db83202030ee2997ac811e6bc45
> - http://autobuild.buildroot.org/results/d16a24d60b298d7616a516ec0c6c30696ed93a58
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2024.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-24 9:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-15 18:20 [Buildroot] [PATCH 1/1] package/nut: needs threads Fabrice Fontaine
2024-06-15 19:27 ` Yann E. MORIN
2024-06-16 8:59 ` Yann E. MORIN
2024-06-24 9:16 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox