[Buildroot] [PATCH 1/1] configs/stm32f429_disco_xip: add hashes

[Buildroot] [PATCH 1/1] configs/stm32f429_disco_xip: add hashes

[Dario Binacchi]

The patch adds .hash files for Linux and Linux headers and then enables
BR2_DOWNLOAD_FORCE_CHECK_HASHES. With this, we can now drop the defconfig
from .checkpackageignore.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
 .checkpackageignore                                             | 1 -
 .../stm32f429-disco/patches/linux-headers/linux-headers.hash    | 1 +
 .../stmicroelectronics/stm32f429-disco/patches/linux/linux.hash | 2 ++
 configs/stm32f429_disco_xip_defconfig                           | 2 ++
 4 files changed, 5 insertions(+), 1 deletion(-)
 create mode 120000 board/stmicroelectronics/stm32f429-disco/patches/linux-headers/linux-headers.hash
 create mode 100644 board/stmicroelectronics/stm32f429-disco/patches/linux/linux.hash

diff --git a/.checkpackageignore b/.checkpackageignore
index d0bd179a5c02..437aafb41594 100644
--- a/.checkpackageignore
+++ b/.checkpackageignore
@@ -330,7 +330,6 @@ configs/solidrun_clearfog_defconfig lib_defconfig.ForceCheckHash
 configs/solidrun_clearfog_gt_8k_defconfig lib_defconfig.ForceCheckHash
 configs/solidrun_macchiatobin_defconfig lib_defconfig.ForceCheckHash
 configs/spike_riscv64_defconfig lib_defconfig.ForceCheckHash
-configs/stm32f429_disco_xip_defconfig lib_defconfig.ForceCheckHash
 configs/stm32f469_disco_sd_defconfig lib_defconfig.ForceCheckHash
 configs/stm32f469_disco_xip_defconfig lib_defconfig.ForceCheckHash
 configs/stm32f769_disco_sd_defconfig lib_defconfig.ForceCheckHash
diff --git a/board/stmicroelectronics/stm32f429-disco/patches/linux-headers/linux-headers.hash b/board/stmicroelectronics/stm32f429-disco/patches/linux-headers/linux-headers.hash
new file mode 120000
index 000000000000..5808d92afe89
--- /dev/null
+++ b/board/stmicroelectronics/stm32f429-disco/patches/linux-headers/linux-headers.hash
@@ -0,0 +1 @@
+../linux/linux.hash
\ No newline at end of file
diff --git a/board/stmicroelectronics/stm32f429-disco/patches/linux/linux.hash b/board/stmicroelectronics/stm32f429-disco/patches/linux/linux.hash
new file mode 100644
index 000000000000..c1bd9f9100d5
--- /dev/null
+++ b/board/stmicroelectronics/stm32f429-disco/patches/linux/linux.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256  c2b74b96dd3d0cc9f300914ef7c4eef76d5fac9de6047961f49e69447ce9f905  linux-6.1.27.tar.xz
diff --git a/configs/stm32f429_disco_xip_defconfig b/configs/stm32f429_disco_xip_defconfig
index 99ae8cc7533b..e3d3cc38ff8e 100644
--- a/configs/stm32f429_disco_xip_defconfig
+++ b/configs/stm32f429_disco_xip_defconfig
@@ -3,6 +3,8 @@ BR2_cortex_m4=y
 BR2_KERNEL_HEADERS_6_1=y
 # BR2_UCLIBC_INSTALL_UTILS is not set
 BR2_ENABLE_LTO=y
+BR2_GLOBAL_PATCH_DIR="board/stmicroelectronics/stm32f429-disco/patches"
+BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
 BR2_ROOTFS_POST_BUILD_SCRIPT="board/stmicroelectronics/common/stm32f4xx/stm32-post-build.sh"
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] configs/stm32f429_disco_xip: add hashes

[Yann E. MORIN]

Dario, All,

On 2024-06-06 12:22 +0200, Dario Binacchi spake thusly:
> The patch adds .hash files for Linux and Linux headers and then enables
> BR2_DOWNLOAD_FORCE_CHECK_HASHES. With this, we can now drop the defconfig
> from .checkpackageignore.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
[--SNIP--]
> diff --git a/board/stmicroelectronics/stm32f429-disco/patches/linux-headers/linux-headers.hash b/board/stmicroelectronics/stm32f429-disco/patches/linux-headers/linux-headers.hash
> new file mode 120000
> index 000000000000..5808d92afe89
> --- /dev/null
> +++ b/board/stmicroelectronics/stm32f429-disco/patches/linux-headers/linux-headers.hash
> @@ -0,0 +1 @@
> +../linux/linux.hash
> \ No newline at end of file

This symlink is not needed in that defconfig: it uses linux-headers that
are not the same as the kernel, and instead use the 6.1.x from the
linux-headers version choice.

SoI dropped the symlink, to avoid any confusion.

Applied to master, with the above fixed, thanks.

Regards,
Yann E. MORIN.

> diff --git a/board/stmicroelectronics/stm32f429-disco/patches/linux/linux.hash b/board/stmicroelectronics/stm32f429-disco/patches/linux/linux.hash
> new file mode 100644
> index 000000000000..c1bd9f9100d5
> --- /dev/null
> +++ b/board/stmicroelectronics/stm32f429-disco/patches/linux/linux.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256  c2b74b96dd3d0cc9f300914ef7c4eef76d5fac9de6047961f49e69447ce9f905  linux-6.1.27.tar.xz
> diff --git a/configs/stm32f429_disco_xip_defconfig b/configs/stm32f429_disco_xip_defconfig
> index 99ae8cc7533b..e3d3cc38ff8e 100644
> --- a/configs/stm32f429_disco_xip_defconfig
> +++ b/configs/stm32f429_disco_xip_defconfig
> @@ -3,6 +3,8 @@ BR2_cortex_m4=y
>  BR2_KERNEL_HEADERS_6_1=y
>  # BR2_UCLIBC_INSTALL_UTILS is not set
>  BR2_ENABLE_LTO=y
> +BR2_GLOBAL_PATCH_DIR="board/stmicroelectronics/stm32f429-disco/patches"
> +BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
>  BR2_ROOTFS_POST_BUILD_SCRIPT="board/stmicroelectronics/common/stm32f4xx/stm32-post-build.sh"
>  BR2_LINUX_KERNEL=y
>  BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] configs/stm32f429_disco_xip: add hashes

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

Hi,

 >> +++ b/board/stmicroelectronics/stm32f429-disco/patches/linux-headers/linux-headers.hash
 >> @@ -0,0 +1 @@
 >> +../linux/linux.hash
 >> \ No newline at end of file

 > This symlink is not needed in that defconfig: it uses linux-headers that
 > are not the same as the kernel, and instead use the 6.1.x from the
 > linux-headers version choice.

Is there any valid reason why it does so? If not, I would suggest to
change it to match the other defconfigs.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot