Re: [Buildroot] [PATCH 1/1] package/python-sqlalchemy: fix build issue with setuptools > 69.3

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Flávio, All,

On 2024-09-02 10:24 -0300, Flávio Tapajós spake thusly:
> Patching the version constraint is considered safe by https://github.com/sqlalchemy/sqlalchemy/discussions/11818
> 
> Fixes:
>   http://autobuild.buildroot.org/results/c531b6e63c5121138e8e8a1c5d1501d9d7e1391e/
> 
> Signed-off-by: Flávio Tapajós <flavio.tapajos@newtesc.com.br>
> ---
>  ...tools-below-69.3-and-prepare-for-bui.patch | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch
> 
> diff --git a/package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch b/package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch
> new file mode 100644
> index 0000000000..70533421c6
> --- /dev/null
> +++ b/package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch
> @@ -0,0 +1,35 @@
> +From 9f321c9e73f4c108baa1ef63528965079cab2f6d Mon Sep 17 00:00:00 2001
> +From: =?UTF-8?q?Fl=C3=A1vio=20Tapaj=C3=B3s?= <flavio.tapajos@newtesc.com.br>
> +Date: Mon, 2 Sep 2024 10:12:56 -0300
> +Subject: [PATCH 1/1] Revert "pin setuptools below 69.3 and prepare for "build"
> + for releases"
> +
> +This reverts commit 9553604fcc80fa175832433f4eff657ac95ae058.

    $ make check-package
    package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch:4: generate your patches with 'git format-patch -N'
    package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch:0: missing Signed-off-by in the header (https://nightly.buildroot.org/#_format_and_licensing_of_the_package_patches)
    package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch:0: missing Upstream in the header (https://nightly.buildroot.org/#_additional_patch_documentation)

However, ths patch has zero chance of getting upstream, so it means we'd
have to carry it foever and ever.

We've had a few packages already with the same issue, and we could just
cop out by adding --skip-dependency-check to _BUILD_OPTS, see for
example commit 4b4ec03998e (package/python-ml-dtypes: skip dependency
check).

What is the reason upstream has pinned to an older setuptools? Can we
just skip the dependency check insterad of reverting?

Regards,
Yann E. MORIN.

> +---
> + pyproject.toml | 12 +++++-------
> + 1 file changed, 5 insertions(+), 7 deletions(-)
> +
> +diff --git a/pyproject.toml b/pyproject.toml
> +index 0f53594df..780c9bf68 100644
> +--- a/pyproject.toml
> ++++ b/pyproject.toml
> +@@ -1,11 +1,9 @@
> + [build-system]
> +-build-backend = "setuptools.build_meta"
> +-requires = [
> +-    # avoid moving to https://github.com/pypa/setuptools/issues/3593
> +-    # until we're ready
> +-    "setuptools>=61.0,<69.3",
> +-    "cython>=0.29.24; platform_python_implementation == 'CPython'", # Skip cython when using pypy
> +-]
> ++    build-backend = "setuptools.build_meta"
> ++    requires = [
> ++        "setuptools>=47",
> ++        "cython>=0.29.24; platform_python_implementation == 'CPython'", # Skip cython when using pypy
> ++    ]
> + 
> + [tool.black]
> + line-length = 79
> +-- 
> +2.46.0
> +
> -- 
> 2.46.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot