Re: [Buildroot] [PATCH 1/1] package/python-sqlalchemy: fix build issue with setuptools > 69.3

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Flávio Tapajós" <flavio.tapajos@newtesc.com.br>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python-sqlalchemy: fix build issue with setuptools > 69.3
Date: Mon, 2 Sep 2024 18:05:29 +0200	[thread overview]
Message-ID: <ZtXiSdHDKwJIOl_g@landeda> (raw)
In-Reply-To: <84cd0ec9-1915-41c1-a4ab-031c4310112f@newtesc.com.br>

Flávio, All,

On 2024-09-02 12:58 -0300, Flávio Tapajós spake thusly:
> Morin,

Yann, please. ;-)

> Em 02/09/2024 12:24, Yann E. MORIN escreveu:
>     However, ths patch has zero chance of getting upstream, so it means we'd
>     have to carry it foever and ever.
> That is unlikely. After my question, maintainers opened the ticket [7]https://
> gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5478 with the description:
> 
> > The pin for ``setuptools<69.3`` in ``pyproject.toml`` has been removed.  This
> pin was to prevent a sudden change to :pep:`625` in setuptools from taking
> place which changes the file name of SQLAlchemy's source distribution on pypi
> to be an all lower case name, which is very likely to cause problems with
> various build environments that expected particular naming style.  However, the
> presence of this pin is now back environments that otherwise want to use a
> newer setuptools, so we' decided to move forward with this change, with the
> assumption that environments will have largely accommodated the setuptools
> change now.

Ah, if upstream has acknowledged the issue and will resolve it, then
indeed we can just revert in the meantime.

But then you should add that information to the commit log, and add an
Upstream-tag that mention it is not applicable when you respin,
something like:

    Upstream: N/A
    Upstream will fix this in an upcoming release:
        https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5478

Thank you for feedback!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot