* [Buildroot] [PATCH 1/1] package/python-sqlalchemy: fix build issue with setuptools > 69.3
@ 2024-09-02 13:24 Flávio Tapajós
2024-09-02 15:24 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Flávio Tapajós @ 2024-09-02 13:24 UTC (permalink / raw)
To: buildroot; +Cc: Flávio Tapajós, James Hilliard, Asaf Kahlon
Patching the version constraint is considered safe by https://github.com/sqlalchemy/sqlalchemy/discussions/11818
Fixes:
http://autobuild.buildroot.org/results/c531b6e63c5121138e8e8a1c5d1501d9d7e1391e/
Signed-off-by: Flávio Tapajós <flavio.tapajos@newtesc.com.br>
---
...tools-below-69.3-and-prepare-for-bui.patch | 35 +++++++++++++++++++
1 file changed, 35 insertions(+)
create mode 100644 package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch
diff --git a/package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch b/package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch
new file mode 100644
index 0000000000..70533421c6
--- /dev/null
+++ b/package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch
@@ -0,0 +1,35 @@
+From 9f321c9e73f4c108baa1ef63528965079cab2f6d Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Fl=C3=A1vio=20Tapaj=C3=B3s?= <flavio.tapajos@newtesc.com.br>
+Date: Mon, 2 Sep 2024 10:12:56 -0300
+Subject: [PATCH 1/1] Revert "pin setuptools below 69.3 and prepare for "build"
+ for releases"
+
+This reverts commit 9553604fcc80fa175832433f4eff657ac95ae058.
+---
+ pyproject.toml | 12 +++++-------
+ 1 file changed, 5 insertions(+), 7 deletions(-)
+
+diff --git a/pyproject.toml b/pyproject.toml
+index 0f53594df..780c9bf68 100644
+--- a/pyproject.toml
++++ b/pyproject.toml
+@@ -1,11 +1,9 @@
+ [build-system]
+-build-backend = "setuptools.build_meta"
+-requires = [
+- # avoid moving to https://github.com/pypa/setuptools/issues/3593
+- # until we're ready
+- "setuptools>=61.0,<69.3",
+- "cython>=0.29.24; platform_python_implementation == 'CPython'", # Skip cython when using pypy
+-]
++ build-backend = "setuptools.build_meta"
++ requires = [
++ "setuptools>=47",
++ "cython>=0.29.24; platform_python_implementation == 'CPython'", # Skip cython when using pypy
++ ]
+
+ [tool.black]
+ line-length = 79
+--
+2.46.0
+
--
2.46.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-sqlalchemy: fix build issue with setuptools > 69.3
2024-09-02 13:24 [Buildroot] [PATCH 1/1] package/python-sqlalchemy: fix build issue with setuptools > 69.3 Flávio Tapajós
@ 2024-09-02 15:24 ` Yann E. MORIN
2024-09-02 15:58 ` Flávio Tapajós
0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2024-09-02 15:24 UTC (permalink / raw)
To: Flávio Tapajós; +Cc: James Hilliard, Asaf Kahlon, buildroot
Flávio, All,
On 2024-09-02 10:24 -0300, Flávio Tapajós spake thusly:
> Patching the version constraint is considered safe by https://github.com/sqlalchemy/sqlalchemy/discussions/11818
>
> Fixes:
> http://autobuild.buildroot.org/results/c531b6e63c5121138e8e8a1c5d1501d9d7e1391e/
>
> Signed-off-by: Flávio Tapajós <flavio.tapajos@newtesc.com.br>
> ---
> ...tools-below-69.3-and-prepare-for-bui.patch | 35 +++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch
>
> diff --git a/package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch b/package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch
> new file mode 100644
> index 0000000000..70533421c6
> --- /dev/null
> +++ b/package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch
> @@ -0,0 +1,35 @@
> +From 9f321c9e73f4c108baa1ef63528965079cab2f6d Mon Sep 17 00:00:00 2001
> +From: =?UTF-8?q?Fl=C3=A1vio=20Tapaj=C3=B3s?= <flavio.tapajos@newtesc.com.br>
> +Date: Mon, 2 Sep 2024 10:12:56 -0300
> +Subject: [PATCH 1/1] Revert "pin setuptools below 69.3 and prepare for "build"
> + for releases"
> +
> +This reverts commit 9553604fcc80fa175832433f4eff657ac95ae058.
$ make check-package
package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch:4: generate your patches with 'git format-patch -N'
package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch:0: missing Signed-off-by in the header (https://nightly.buildroot.org/#_format_and_licensing_of_the_package_patches)
package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch:0: missing Upstream in the header (https://nightly.buildroot.org/#_additional_patch_documentation)
However, ths patch has zero chance of getting upstream, so it means we'd
have to carry it foever and ever.
We've had a few packages already with the same issue, and we could just
cop out by adding --skip-dependency-check to _BUILD_OPTS, see for
example commit 4b4ec03998e (package/python-ml-dtypes: skip dependency
check).
What is the reason upstream has pinned to an older setuptools? Can we
just skip the dependency check insterad of reverting?
Regards,
Yann E. MORIN.
> +---
> + pyproject.toml | 12 +++++-------
> + 1 file changed, 5 insertions(+), 7 deletions(-)
> +
> +diff --git a/pyproject.toml b/pyproject.toml
> +index 0f53594df..780c9bf68 100644
> +--- a/pyproject.toml
> ++++ b/pyproject.toml
> +@@ -1,11 +1,9 @@
> + [build-system]
> +-build-backend = "setuptools.build_meta"
> +-requires = [
> +- # avoid moving to https://github.com/pypa/setuptools/issues/3593
> +- # until we're ready
> +- "setuptools>=61.0,<69.3",
> +- "cython>=0.29.24; platform_python_implementation == 'CPython'", # Skip cython when using pypy
> +-]
> ++ build-backend = "setuptools.build_meta"
> ++ requires = [
> ++ "setuptools>=47",
> ++ "cython>=0.29.24; platform_python_implementation == 'CPython'", # Skip cython when using pypy
> ++ ]
> +
> + [tool.black]
> + line-length = 79
> +--
> +2.46.0
> +
> --
> 2.46.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/python-sqlalchemy: fix build issue with setuptools > 69.3
2024-09-02 15:24 ` Yann E. MORIN
@ 2024-09-02 15:58 ` Flávio Tapajós
2024-09-02 16:05 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Flávio Tapajós @ 2024-09-02 15:58 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: James Hilliard, Asaf Kahlon, buildroot
[-- Attachment #1.1: Type: text/plain, Size: 4568 bytes --]
Morin,
Em 02/09/2024 12:24, Yann E. MORIN escreveu:
> Flávio, All,
>
> On 2024-09-02 10:24 -0300, Flávio Tapajós spake thusly:
>> Patching the version constraint is considered safe byhttps://github.com/sqlalchemy/sqlalchemy/discussions/11818
>>
>> Fixes:
>> http://autobuild.buildroot.org/results/c531b6e63c5121138e8e8a1c5d1501d9d7e1391e/
>>
>> Signed-off-by: Flávio Tapajós<flavio.tapajos@newtesc.com.br>
>> ---
>> ...tools-below-69.3-and-prepare-for-bui.patch | 35 +++++++++++++++++++
>> 1 file changed, 35 insertions(+)
>> create mode 100644 package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch
>>
>> diff --git a/package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch b/package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch
>> new file mode 100644
>> index 0000000000..70533421c6
>> --- /dev/null
>> +++ b/package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch
>> @@ -0,0 +1,35 @@
>> +From 9f321c9e73f4c108baa1ef63528965079cab2f6d Mon Sep 17 00:00:00 2001
>> +From: =?UTF-8?q?Fl=C3=A1vio=20Tapaj=C3=B3s?=<flavio.tapajos@newtesc.com.br>
>> +Date: Mon, 2 Sep 2024 10:12:56 -0300
>> +Subject: [PATCH 1/1] Revert "pin setuptools below 69.3 and prepare for "build"
>> + for releases"
>> +
>> +This reverts commit 9553604fcc80fa175832433f4eff657ac95ae058.
> $ make check-package
> package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch:4: generate your patches with 'git format-patch -N'
> package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch:0: missing Signed-off-by in the header (https://nightly.buildroot.org/#_format_and_licensing_of_the_package_patches)
> package/python-sqlalchemy/2.0.32/0001-Revert-pin-setuptools-below-69.3-and-prepare-for-bui.patch:0: missing Upstream in the header (https://nightly.buildroot.org/#_additional_patch_documentation)
Sorry, I'll fix it
> However, ths patch has zero chance of getting upstream, so it means we'd
> have to carry it foever and ever.
That is unlikely. After my question, maintainers opened the ticket
https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5478 with the
description:
> The pin for ``setuptools<69.3`` in ``pyproject.toml`` has been
removed. This pin was to prevent a sudden change to :pep:`625` in
setuptools from taking place which changes the file name of SQLAlchemy's
source distribution on pypi to be an all lower case name, which is very
likely to cause problems with various build environments that expected
particular naming style. However, the presence of this pin is now back
environments that otherwise want to use a newer setuptools, so we'
decided to move forward with this change, with the assumption that
environments will have largely accommodated the setuptools change now.
> We've had a few packages already with the same issue, and we could just
> cop out by adding --skip-dependency-check to _BUILD_OPTS, see for
> example commit 4b4ec03998e (package/python-ml-dtypes: skip dependency
> check).
>
> What is the reason upstream has pinned to an older setuptools? Can we
> just skip the dependency check insterad of reverting?
I would find it better to revert, since the maintainers already
acknowledged that the pinning should be removed and dependency checks
are mostly useful
>
> Regards,
> Yann E. MORIN.
>
>> +---
>> + pyproject.toml | 12 +++++-------
>> + 1 file changed, 5 insertions(+), 7 deletions(-)
>> +
>> +diff --git a/pyproject.toml b/pyproject.toml
>> +index 0f53594df..780c9bf68 100644
>> +--- a/pyproject.toml
>> ++++ b/pyproject.toml
>> +@@ -1,11 +1,9 @@
>> + [build-system]
>> +-build-backend = "setuptools.build_meta"
>> +-requires = [
>> +- # avoid moving tohttps://github.com/pypa/setuptools/issues/3593
>> +- # until we're ready
>> +- "setuptools>=61.0,<69.3",
>> +- "cython>=0.29.24; platform_python_implementation == 'CPython'", # Skip cython when using pypy
>> +-]
>> ++ build-backend = "setuptools.build_meta"
>> ++ requires = [
>> ++ "setuptools>=47",
>> ++ "cython>=0.29.24; platform_python_implementation == 'CPython'", # Skip cython when using pypy
>> ++ ]
>> +
>> + [tool.black]
>> + line-length = 79
>> +--
>> +2.46.0
>> +
>> --
>> 2.46.0
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
[-- Attachment #1.2: Type: text/html, Size: 6688 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-sqlalchemy: fix build issue with setuptools > 69.3
2024-09-02 15:58 ` Flávio Tapajós
@ 2024-09-02 16:05 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2024-09-02 16:05 UTC (permalink / raw)
To: Flávio Tapajós; +Cc: James Hilliard, Asaf Kahlon, buildroot
Flávio, All,
On 2024-09-02 12:58 -0300, Flávio Tapajós spake thusly:
> Morin,
Yann, please. ;-)
> Em 02/09/2024 12:24, Yann E. MORIN escreveu:
> However, ths patch has zero chance of getting upstream, so it means we'd
> have to carry it foever and ever.
> That is unlikely. After my question, maintainers opened the ticket [7]https://
> gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5478 with the description:
>
> > The pin for ``setuptools<69.3`` in ``pyproject.toml`` has been removed. This
> pin was to prevent a sudden change to :pep:`625` in setuptools from taking
> place which changes the file name of SQLAlchemy's source distribution on pypi
> to be an all lower case name, which is very likely to cause problems with
> various build environments that expected particular naming style. However, the
> presence of this pin is now back environments that otherwise want to use a
> newer setuptools, so we' decided to move forward with this change, with the
> assumption that environments will have largely accommodated the setuptools
> change now.
Ah, if upstream has acknowledged the issue and will resolve it, then
indeed we can just revert in the meantime.
But then you should add that information to the commit log, and add an
Upstream-tag that mention it is not applicable when you respin,
something like:
Upstream: N/A
Upstream will fix this in an upcoming release:
https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5478
Thank you for feedback!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/python-sqlalchemy: fix build issue with setuptools > 69.3
@ 2024-09-02 19:21 Flávio Tapajós
2024-09-03 19:51 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Flávio Tapajós @ 2024-09-02 19:21 UTC (permalink / raw)
To: buildroot; +Cc: Flávio Tapajós, James Hilliard, Asaf Kahlon
This commit adds upstream patch that unpins setuptools:
https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5478
https://github.com/sqlalchemy/sqlalchemy/discussions/11818
Fixes:
http://autobuild.buildroot.org/results/c531b6e63c5121138e8e8a1c5d1501d9d7e1391e/
Signed-off-by: Flávio Tapajós <flavio.tapajos@newtesc.com.br>
---
.../2.0.32/0001-unpin-setuptools.patch | 72 +++++++++++++++++++
1 file changed, 72 insertions(+)
create mode 100644 package/python-sqlalchemy/2.0.32/0001-unpin-setuptools.patch
diff --git a/package/python-sqlalchemy/2.0.32/0001-unpin-setuptools.patch b/package/python-sqlalchemy/2.0.32/0001-unpin-setuptools.patch
new file mode 100644
index 0000000000..92dd1826a7
--- /dev/null
+++ b/package/python-sqlalchemy/2.0.32/0001-unpin-setuptools.patch
@@ -0,0 +1,72 @@
+From bf33cb4ffa5f058b4bb9e50efaa43038f37cc6e1 Mon Sep 17 00:00:00 2001
+From: Mike Bayer <mike_mp@zzzcomputing.com>
+Date: Mon, 2 Sep 2024 09:13:27 -0400
+Subject: [PATCH] unpin setuptools
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+This removes the pin that was placed in 2607262110bdc5c5dc96fc19ddca895a15a58e4e
+
+The pin for ``setuptools<69.3`` in ``pyproject.toml`` has been
+removed. This pin was to prevent a sudden change to :pep:`625` in
+setuptools from taking place which changes the file name of SQLAlchemy's
+source distribution on pypi to be an all lower case name, which is very
+likely to cause problems with various build environments that expected a
+particular naming style. However, the presence of this pin is now holding
+back environments that otherwise want to use a newer setuptools, so we've
+decided to move forward with this change, with the assumption that build
+environments will have largely accommodated the setuptools change by
+now.
+
+References: #11818
+Change-Id: I0cd9ab0512004669a8f0aa0cb7f560d89a2da2bd
+
+Upstream: https://gerrit.sqlalchemy.org/plugins/gitiles/sqlalchemy/sqlalchemy/+/cf82be60f811ed6bdc1a8c4221148d97dd6b704d
+Signed-off-by: Flávio Tapajós <flavio.tapajos@newtesc.com.br>
+---
+ doc/build/changelog/unreleased_20/11818.rst | 16 ++++++++++++++++
+ pyproject.toml | 4 +---
+ 2 files changed, 17 insertions(+), 3 deletions(-)
+ create mode 100644 doc/build/changelog/unreleased_20/11818.rst
+
+diff --git a/doc/build/changelog/unreleased_20/11818.rst b/doc/build/changelog/unreleased_20/11818.rst
+new file mode 100644
+index 000000000..c75a6c64b
+--- /dev/null
++++ b/doc/build/changelog/unreleased_20/11818.rst
+@@ -0,0 +1,16 @@
++.. change::
++ :tags: change, general
++ :tickets: 11818
++
++ The pin for ``setuptools<69.3`` in ``pyproject.toml`` has been
++ removed. This pin was to prevent a sudden change to :pep:`625` in
++ setuptools from taking place which changes the file name of SQLAlchemy's
++ source distribution on pypi to be an all lower case name, which is very
++ likely to cause problems with various build environments that expected a
++ particular naming style. However, the presence of this pin is now holding
++ back environments that otherwise want to use a newer setuptools, so we've
++ decided to move forward with this change, with the assumption that build
++ environments will have largely accommodated the setuptools change by
++ now.
++
++
+diff --git a/pyproject.toml b/pyproject.toml
+index 0f53594df..f75bf3192 100644
+--- a/pyproject.toml
++++ b/pyproject.toml
+@@ -1,9 +1,7 @@
+ [build-system]
+ build-backend = "setuptools.build_meta"
+ requires = [
+- # avoid moving to https://github.com/pypa/setuptools/issues/3593
+- # until we're ready
+- "setuptools>=61.0,<69.3",
++ "setuptools>=61.0",
+ "cython>=0.29.24; platform_python_implementation == 'CPython'", # Skip cython when using pypy
+ ]
+
+--
+2.46.0
+
--
2.46.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-sqlalchemy: fix build issue with setuptools > 69.3
2024-09-02 19:21 Flávio Tapajós
@ 2024-09-03 19:51 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2024-09-03 19:51 UTC (permalink / raw)
To: Flávio Tapajós; +Cc: James Hilliard, Asaf Kahlon, buildroot
Flavio, All,
On 2024-09-02 16:21 -0300, Flávio Tapajós spake thusly:
> This commit adds upstream patch that unpins setuptools:
> https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5478
> https://github.com/sqlalchemy/sqlalchemy/discussions/11818
>
> Fixes:
> http://autobuild.buildroot.org/results/c531b6e63c5121138e8e8a1c5d1501d9d7e1391e/
>
> Signed-off-by: Flávio Tapajós <flavio.tapajos@newtesc.com.br>
Thanks for the respin. However, upstream has released 2.0.33 with this
fix included. Since the fix applies to 20.0.32 that is only in the next
branch, we could probably bump now, no?
> diff --git a/package/python-sqlalchemy/2.0.32/0001-unpin-setuptools.patch b/package/python-sqlalchemy/2.0.32/0001-unpin-setuptools.patch
> new file mode 100644
> index 0000000000..92dd1826a7
> --- /dev/null
> +++ b/package/python-sqlalchemy/2.0.32/0001-unpin-setuptools.patch
Don't create the patches in a versioned sub-directory, as the package
does not have a version choice.
Keeping the patch at the root of the package dir will allow to notice
when we bump and the patch no longer applies (cleanly). Otherwise, we
can easily miss the patch and it would longer unused.
Regards,
Yann E. MORIN.
> @@ -0,0 +1,72 @@
> +From bf33cb4ffa5f058b4bb9e50efaa43038f37cc6e1 Mon Sep 17 00:00:00 2001
> +From: Mike Bayer <mike_mp@zzzcomputing.com>
> +Date: Mon, 2 Sep 2024 09:13:27 -0400
> +Subject: [PATCH] unpin setuptools
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +This removes the pin that was placed in 2607262110bdc5c5dc96fc19ddca895a15a58e4e
> +
> +The pin for ``setuptools<69.3`` in ``pyproject.toml`` has been
> +removed. This pin was to prevent a sudden change to :pep:`625` in
> +setuptools from taking place which changes the file name of SQLAlchemy's
> +source distribution on pypi to be an all lower case name, which is very
> +likely to cause problems with various build environments that expected a
> +particular naming style. However, the presence of this pin is now holding
> +back environments that otherwise want to use a newer setuptools, so we've
> +decided to move forward with this change, with the assumption that build
> +environments will have largely accommodated the setuptools change by
> +now.
> +
> +References: #11818
> +Change-Id: I0cd9ab0512004669a8f0aa0cb7f560d89a2da2bd
> +
> +Upstream: https://gerrit.sqlalchemy.org/plugins/gitiles/sqlalchemy/sqlalchemy/+/cf82be60f811ed6bdc1a8c4221148d97dd6b704d
> +Signed-off-by: Flávio Tapajós <flavio.tapajos@newtesc.com.br>
> +---
> + doc/build/changelog/unreleased_20/11818.rst | 16 ++++++++++++++++
> + pyproject.toml | 4 +---
> + 2 files changed, 17 insertions(+), 3 deletions(-)
> + create mode 100644 doc/build/changelog/unreleased_20/11818.rst
> +
> +diff --git a/doc/build/changelog/unreleased_20/11818.rst b/doc/build/changelog/unreleased_20/11818.rst
> +new file mode 100644
> +index 000000000..c75a6c64b
> +--- /dev/null
> ++++ b/doc/build/changelog/unreleased_20/11818.rst
> +@@ -0,0 +1,16 @@
> ++.. change::
> ++ :tags: change, general
> ++ :tickets: 11818
> ++
> ++ The pin for ``setuptools<69.3`` in ``pyproject.toml`` has been
> ++ removed. This pin was to prevent a sudden change to :pep:`625` in
> ++ setuptools from taking place which changes the file name of SQLAlchemy's
> ++ source distribution on pypi to be an all lower case name, which is very
> ++ likely to cause problems with various build environments that expected a
> ++ particular naming style. However, the presence of this pin is now holding
> ++ back environments that otherwise want to use a newer setuptools, so we've
> ++ decided to move forward with this change, with the assumption that build
> ++ environments will have largely accommodated the setuptools change by
> ++ now.
> ++
> ++
> +diff --git a/pyproject.toml b/pyproject.toml
> +index 0f53594df..f75bf3192 100644
> +--- a/pyproject.toml
> ++++ b/pyproject.toml
> +@@ -1,9 +1,7 @@
> + [build-system]
> + build-backend = "setuptools.build_meta"
> + requires = [
> +- # avoid moving to https://github.com/pypa/setuptools/issues/3593
> +- # until we're ready
> +- "setuptools>=61.0,<69.3",
> ++ "setuptools>=61.0",
> + "cython>=0.29.24; platform_python_implementation == 'CPython'", # Skip cython when using pypy
> + ]
> +
> +--
> +2.46.0
> +
> --
> 2.46.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-09-03 19:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-02 13:24 [Buildroot] [PATCH 1/1] package/python-sqlalchemy: fix build issue with setuptools > 69.3 Flávio Tapajós
2024-09-02 15:24 ` Yann E. MORIN
2024-09-02 15:58 ` Flávio Tapajós
2024-09-02 16:05 ` Yann E. MORIN
-- strict thread matches above, loose matches on Subject: below --
2024-09-02 19:21 Flávio Tapajós
2024-09-03 19:51 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox