Re: [Buildroot] [PATCH 1/1] package/python-cryptography: bump to version 43.0.1

["Yann E. MORIN" <yann.morin.1998@free.fr>]

James, All,

On 2024-09-07 21:57 +0200, Yann E. MORIN spake thusly:
> On 2024-09-06 11:11 -0600, James Hilliard spake thusly:
> > Migrate from setuptools-rust to maturin pep517 backend.
> > 
> > License hash changed due to dropping PSF license:
> > https://github.com/pyca/cryptography/commit/5e6476a4c6e094926a983dcf5cbe9488c30aeb53
> > 
> > We now need to enable chacha support when building with libopenssl.
> > 
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> 
> It would have been nice to add a little blurb to explain that we no
> longe rneed the hack introduced in commit c617ebbc977d.
> 
> I've added that when applying.
> 
> Applied to master, thanks.

No, I have not applied it, because it is incorrect: we *must* have a
mangled source filename, as explained in c617ebbc977d: we want the local
archive to have our -cargo2 post-version suffix, so that we are free to
update our vendoring code (and update the post-version suffix) without
causing conflicts in the future.

The weird diff about the _SOURCE_PYPI version should have trigerred a
red light when bumping the version: indeed, it is not a standard
variable set by scan-pypi, so defintiely something was going on...

Unfortunately, there is not much to do in the short term, except
manually updat ethe package (or manually tweak it after scan-pypi).

In the (very far) future, we are thinking about decorelating the lcoal
filename from the remote one, but this is going to take a lot of time,
so maybe a shorter solution would be for scan-pypi to handle the case
for packages that need cargo vendoring (basically, the maturin or
setuptools-rust packages).

Could you have a look at that too, please?

In the meantime, I've marked this patch as "Changes requested" in
Patchwork.

Regards,
Yann E. MORIN.

> Regards,
> Yann E. MORIN.
> 
> > ---
> >  package/python-cryptography/Config.in                | 1 +
> >  package/python-cryptography/python-cryptography.hash | 4 ++--
> >  package/python-cryptography/python-cryptography.mk   | 9 ++++-----
> >  3 files changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/package/python-cryptography/Config.in b/package/python-cryptography/Config.in
> > index 213aa24fa8..d12f040656 100644
> > --- a/package/python-cryptography/Config.in
> > +++ b/package/python-cryptography/Config.in
> > @@ -2,6 +2,7 @@ config BR2_PACKAGE_PYTHON_CRYPTOGRAPHY
> >  	bool "python-cryptography"
> >  	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
> >  	select BR2_PACKAGE_OPENSSL
> > +	select BR2_PACKAGE_LIBOPENSSL_ENABLE_CHACHA if BR2_PACKAGE_LIBOPENSSL
> >  	select BR2_PACKAGE_PYTHON_CFFI # runtime
> >  	help
> >  	  cryptography is a package designed to expose cryptographic
> > diff --git a/package/python-cryptography/python-cryptography.hash b/package/python-cryptography/python-cryptography.hash
> > index 5fbf69a208..5336f23257 100644
> > --- a/package/python-cryptography/python-cryptography.hash
> > +++ b/package/python-cryptography/python-cryptography.hash
> > @@ -1,6 +1,6 @@
> >  # Locally calculated after vendoring
> > -sha256  b55c6c011ba4bb803de0b557f40f1765bab9f63240e93516daaf75c3c68e6618  python-cryptography-39.0.2-cargo2.tar.gz
> > +sha256  c57ae743b2adfb29a3fc005b6f39bf1378e20d10529a859b6e2e425845bff8f3  cryptography-43.0.1.tar.gz
> >  # Locally computed sha256 checksums
> > -sha256  43dad2cc752ab721cd9a9f36ece70fb53ab7713551f2d3d8694d8e8c5a06d6e2  LICENSE
> > +sha256  3e0c7c091a948b82533ba98fd7cbb40432d6f1a9acbf85f5922d2f99a93ae6bb  LICENSE
> >  sha256  aac73b3148f6d1d7111dbca32099f68d26c644c6813ae1e4f05f6579aa2663fe  LICENSE.APACHE
> >  sha256  602c4c7482de6479dd2e9793cda275e5e63d773dacd1eca689232ab7008fb4fb  LICENSE.BSD
> > diff --git a/package/python-cryptography/python-cryptography.mk b/package/python-cryptography/python-cryptography.mk
> > index 1cbccd0d5c..2602289149 100644
> > --- a/package/python-cryptography/python-cryptography.mk
> > +++ b/package/python-cryptography/python-cryptography.mk
> > @@ -4,11 +4,10 @@
> >  #
> >  ################################################################################
> >  
> > -PYTHON_CRYPTOGRAPHY_VERSION = 39.0.2
> > -PYTHON_CRYPTOGRAPHY_SOURCE_PYPI = cryptography-$(PYTHON_CRYPTOGRAPHY_VERSION).tar.gz
> > -PYTHON_CRYPTOGRAPHY_SITE_PYPI = https://files.pythonhosted.org/packages/fa/f3/f4b8c175ea9a1de650b0085858059050b7953a93d66c97ed89b93b232996
> > -PYTHON_CRYPTOGRAPHY_SITE = $(PYTHON_CRYPTOGRAPHY_SITE_PYPI)/$(PYTHON_CRYPTOGRAPHY_SOURCE_PYPI)?buildroot-path=filename
> > -PYTHON_CRYPTOGRAPHY_SETUP_TYPE = setuptools-rust
> > +PYTHON_CRYPTOGRAPHY_VERSION = 43.0.1
> > +PYTHON_CRYPTOGRAPHY_SOURCE = cryptography-$(PYTHON_CRYPTOGRAPHY_VERSION).tar.gz
> > +PYTHON_CRYPTOGRAPHY_SITE = https://files.pythonhosted.org/packages/de/ba/0664727028b37e249e73879348cc46d45c5c1a2a2e81e8166462953c5755
> > +PYTHON_CRYPTOGRAPHY_SETUP_TYPE = maturin
> >  PYTHON_CRYPTOGRAPHY_LICENSE = Apache-2.0 or BSD-3-Clause
> >  PYTHON_CRYPTOGRAPHY_LICENSE_FILES = LICENSE LICENSE.APACHE LICENSE.BSD
> >  PYTHON_CRYPTOGRAPHY_CPE_ID_VENDOR = cryptography_project
> > -- 
> > 2.34.1
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot