From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Asaf Kahlon <asafka7@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python-cryptography: bump to version 43.0.1
Date: Sat, 7 Sep 2024 23:06:00 +0200 [thread overview]
Message-ID: <ZtzAOKw5leT7Za7s@landeda> (raw)
In-Reply-To: <CADvTj4rPAr0-TyeGsN50XGEhpSyeO95G6VXXCzJLHeH4qmrdPQ@mail.gmail.com>
James, All,
On 2024-09-07 14:49 -0600, James Hilliard spake thusly:
> On Sat, Sep 7, 2024 at 2:22 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
[--SNIP--]
> > No, I have not applied it, because it is incorrect: we *must* have a
> > mangled source filename, as explained in c617ebbc977d: we want the local
> > archive to have our -cargo2 post-version suffix, so that we are free to
> > update our vendoring code (and update the post-version suffix) without
> > causing conflicts in the future.
>
> Oh, I had taken the "this is a stop-gap measure" part as an indication
> that this was only being done in cases where it was needed to prevent
> hash conflicts(i.e. in cases where there would actually be a version
> conflict due to the filename not changing when the hash changes).
Exactly. Now, consider the situation if I apply this patch today, and
tomorrow we change the vendroing code in download/cargo-post-process:
there will be a hash mismatch again.
SO we want to avoid that, and so archives that are cargo-vendored must
have our post-version sussifx.
Yes, that is a stop-gap measure "while waiting for a generic solution
that works in all cases, not just with PyPI", and we do not yet have a
generic solution... :-/
> Since the version update would result in the package no longer
> conflicting I had removed the hack.
Right, it does not conflict today. But will conflict tomorrow. ;-)
[--SNIP--]
> > In the (very far) future, we are thinking about decorelating the lcoal
> > filename from the remote one, but this is going to take a lot of time,
> > so maybe a shorter solution would be for scan-pypi to handle the case
> > for packages that need cargo vendoring (basically, the maturin or
> > setuptools-rust packages).
> >
> > Could you have a look at that too, please?
>
> Ok, I'll change these to keep the cargo2 vendor version.
Thank you! 👍
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-09-07 21:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 17:11 [Buildroot] [PATCH 1/1] package/python-cryptography: bump to version 43.0.1 James Hilliard
2024-09-07 19:57 ` Yann E. MORIN
2024-09-07 20:22 ` Yann E. MORIN
2024-09-07 20:49 ` James Hilliard
2024-09-07 21:06 ` Yann E. MORIN [this message]
2024-09-07 21:24 ` James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtzAOKw5leT7Za7s@landeda \
--to=yann.morin.1998@free.fr \
--cc=asafka7@gmail.com \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox