* [Buildroot] [PATCH] package/piglit: bump to a70c33045c59310f972dbbdb33f322eb209971bc
@ 2025-10-22 9:38 Raphael Gallais-Pou
2025-11-02 14:23 ` Raphaël Gallais-Pou
2025-11-30 17:40 ` Julien Olivain via buildroot
0 siblings, 2 replies; 3+ messages in thread
From: Raphael Gallais-Pou @ 2025-10-22 9:38 UTC (permalink / raw)
To: buildroot; +Cc: Romain Naour, Julien Olivain
New dependency since commit 2519c330fba5 ("make: introduce option for
building vulkan tests") [1].
Add vulkan-loader new dependency and bump version to commit
a70c33045c59310f972dbbdb33f322eb209971bc.
[1] https://gitlab.freedesktop.org/mesa/piglit/-/commit/eec9ea557fe813b963e8aa77a95c4d2e6e432033
Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
---
package/piglit/Config.in | 1 +
package/piglit/piglit.hash | 2 +-
package/piglit/piglit.mk | 3 ++-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/piglit/Config.in b/package/piglit/Config.in
index 48b7641909b5..3b92443fc56f 100644
--- a/package/piglit/Config.in
+++ b/package/piglit/Config.in
@@ -6,6 +6,7 @@ config BR2_PACKAGE_PIGLIT
BR2_PACKAGE_WAFFLE_SUPPORTS_WAYLAND || \
BR2_PACKAGE_WAFFLE_SUPPORTS_X11_EGL || \
BR2_PACKAGE_WAFFLE_SUPPORTS_GBM
+ depends on BR2_PACKAGE_VULKAN_LOADER
depends on BR2_INSTALL_LIBSTDCPP # mesa3d-demos, python-numpy
depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL # python-numpy
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_9 # python-numpy
diff --git a/package/piglit/piglit.hash b/package/piglit/piglit.hash
index 2c0b6aa52a46..20c79a4546af 100644
--- a/package/piglit/piglit.hash
+++ b/package/piglit/piglit.hash
@@ -1,5 +1,5 @@
# Locally calculated
-sha256 ba4d1839038905f3833e9ab23b385913e08d552533dd222cc203c79c10e09918 piglit-2affee53f3ad7a96f5b397a2b6d6408af8a374b0-git4.tar.gz
+sha256 e968966faee7d97305c0a526d339102ddfc8435a2c9007c90444cb3303629f6a piglit-a70c33045c59310f972dbbdb33f322eb209971bc-git4.tar.gz
sha256 dcc398730859aee7cc1d6aa57f526f8d181b47bb3a49830e85b5723d5bc2c3bc COPYING
sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 licences/GPL-2
sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 licences/GPL-3
diff --git a/package/piglit/piglit.mk b/package/piglit/piglit.mk
index 4d17405d10ea..76a759cfca40 100644
--- a/package/piglit/piglit.mk
+++ b/package/piglit/piglit.mk
@@ -4,7 +4,7 @@
#
################################################################################
-PIGLIT_VERSION = 2affee53f3ad7a96f5b397a2b6d6408af8a374b0
+PIGLIT_VERSION = a70c33045c59310f972dbbdb33f322eb209971bc
PIGLIT_SITE = https://gitlab.freedesktop.org/mesa/piglit.git
PIGLIT_SITE_METHOD = git
PIGLIT_LICENSE = MIT (code), \
@@ -23,6 +23,7 @@ PIGLIT_DEPENDENCIES = host-pkgconf \
python-mako \
python-numpy \
python-six \
+ vulkan-loader \
waffle \
zlib
---
base-commit: c55714aeb9e9bb32b0674b93c4a4cd4b6fa4eb52
change-id: 20251021-piglit-ebd7afed9982
Best regards,
--
Raphael Gallais-Pou <rgallaispou@gmail.com>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Buildroot] [PATCH] package/piglit: bump to a70c33045c59310f972dbbdb33f322eb209971bc
2025-10-22 9:38 [Buildroot] [PATCH] package/piglit: bump to a70c33045c59310f972dbbdb33f322eb209971bc Raphael Gallais-Pou
@ 2025-11-02 14:23 ` Raphaël Gallais-Pou
2025-11-30 17:40 ` Julien Olivain via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Raphaël Gallais-Pou @ 2025-11-02 14:23 UTC (permalink / raw)
To: buildroot; +Cc: Romain Naour, Julien Olivain
Le Wed, Oct 22, 2025 at 11:38:40AM +0200, Raphael Gallais-Pou a écrit :
> New dependency since commit 2519c330fba5 ("make: introduce option for
> building vulkan tests") [1].
>
> Add vulkan-loader new dependency and bump version to commit
> a70c33045c59310f972dbbdb33f322eb209971bc.
>
> [1] https://gitlab.freedesktop.org/mesa/piglit/-/commit/eec9ea557fe813b963e8aa77a95c4d2e6e432033
>
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
> ---
Hi,
Gentle ping on this one.
Thanks for your time,
Best regards,
Raphaël
> package/piglit/Config.in | 1 +
> package/piglit/piglit.hash | 2 +-
> package/piglit/piglit.mk | 3 ++-
> 3 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/piglit/Config.in b/package/piglit/Config.in
> index 48b7641909b5..3b92443fc56f 100644
> --- a/package/piglit/Config.in
> +++ b/package/piglit/Config.in
> @@ -6,6 +6,7 @@ config BR2_PACKAGE_PIGLIT
> BR2_PACKAGE_WAFFLE_SUPPORTS_WAYLAND || \
> BR2_PACKAGE_WAFFLE_SUPPORTS_X11_EGL || \
> BR2_PACKAGE_WAFFLE_SUPPORTS_GBM
> + depends on BR2_PACKAGE_VULKAN_LOADER
> depends on BR2_INSTALL_LIBSTDCPP # mesa3d-demos, python-numpy
> depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL # python-numpy
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_9 # python-numpy
> diff --git a/package/piglit/piglit.hash b/package/piglit/piglit.hash
> index 2c0b6aa52a46..20c79a4546af 100644
> --- a/package/piglit/piglit.hash
> +++ b/package/piglit/piglit.hash
> @@ -1,5 +1,5 @@
> # Locally calculated
> -sha256 ba4d1839038905f3833e9ab23b385913e08d552533dd222cc203c79c10e09918 piglit-2affee53f3ad7a96f5b397a2b6d6408af8a374b0-git4.tar.gz
> +sha256 e968966faee7d97305c0a526d339102ddfc8435a2c9007c90444cb3303629f6a piglit-a70c33045c59310f972dbbdb33f322eb209971bc-git4.tar.gz
> sha256 dcc398730859aee7cc1d6aa57f526f8d181b47bb3a49830e85b5723d5bc2c3bc COPYING
> sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 licences/GPL-2
> sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 licences/GPL-3
> diff --git a/package/piglit/piglit.mk b/package/piglit/piglit.mk
> index 4d17405d10ea..76a759cfca40 100644
> --- a/package/piglit/piglit.mk
> +++ b/package/piglit/piglit.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -PIGLIT_VERSION = 2affee53f3ad7a96f5b397a2b6d6408af8a374b0
> +PIGLIT_VERSION = a70c33045c59310f972dbbdb33f322eb209971bc
> PIGLIT_SITE = https://gitlab.freedesktop.org/mesa/piglit.git
> PIGLIT_SITE_METHOD = git
> PIGLIT_LICENSE = MIT (code), \
> @@ -23,6 +23,7 @@ PIGLIT_DEPENDENCIES = host-pkgconf \
> python-mako \
> python-numpy \
> python-six \
> + vulkan-loader \
> waffle \
> zlib
>
>
> ---
> base-commit: c55714aeb9e9bb32b0674b93c4a4cd4b6fa4eb52
> change-id: 20251021-piglit-ebd7afed9982
>
> Best regards,
> --
> Raphael Gallais-Pou <rgallaispou@gmail.com>
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Buildroot] [PATCH] package/piglit: bump to a70c33045c59310f972dbbdb33f322eb209971bc
2025-10-22 9:38 [Buildroot] [PATCH] package/piglit: bump to a70c33045c59310f972dbbdb33f322eb209971bc Raphael Gallais-Pou
2025-11-02 14:23 ` Raphaël Gallais-Pou
@ 2025-11-30 17:40 ` Julien Olivain via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Julien Olivain via buildroot @ 2025-11-30 17:40 UTC (permalink / raw)
To: Raphael Gallais-Pou; +Cc: buildroot, Romain Naour
Hi Raphael,
Thanks for the patch.
On 22/10/2025 11:38, Raphael Gallais-Pou wrote:
> New dependency since commit 2519c330fba5 ("make: introduce option for
> building vulkan tests") [1].
>
> Add vulkan-loader new dependency and bump version to commit
> a70c33045c59310f972dbbdb33f322eb209971bc.
According to:
https://gitlab.freedesktop.org/mesa/piglit/-/commit/2519c330fba55ce6efd0dbee07aa67c703124d4f
The vulkan tests are enabled by default on Linux, but could
be disabled. It would be preferable to keep this vulkan
dependency optional.
Also, piglit Vulkan tests seems to also need glslangValidator.
So we could probably keep the vulkan-loader dependency optional,
with something like:
ifeq ($(BR2_PACKAGE_VULKAN_LOADER),y)
PIGLIT_DEPENDENCIES += host-python-glslang vulkan-loader
PIGLIT_CONF_OPTS += -DPIGLIT_BUILD_VK_TESTS=ON
else
PIGLIT_CONF_OPTS += -DPIGLIT_BUILD_VK_TESTS=OFF
endif
I'm not sure if piglit needs python-glslang on target.
It is not in Buildroot as a target package, at the moment.
Another option could be to always disable vulkan tests with:
-DPIGLIT_BUILD_VK_TESTS=OFF
>
> [1]
> https://gitlab.freedesktop.org/mesa/piglit/-/commit/eec9ea557fe813b963e8aa77a95c4d2e6e432033
>
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
> ---
> package/piglit/Config.in | 1 +
> package/piglit/piglit.hash | 2 +-
> package/piglit/piglit.mk | 3 ++-
> 3 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/piglit/Config.in b/package/piglit/Config.in
> index 48b7641909b5..3b92443fc56f 100644
> --- a/package/piglit/Config.in
> +++ b/package/piglit/Config.in
> @@ -6,6 +6,7 @@ config BR2_PACKAGE_PIGLIT
> BR2_PACKAGE_WAFFLE_SUPPORTS_WAYLAND || \
> BR2_PACKAGE_WAFFLE_SUPPORTS_X11_EGL || \
> BR2_PACKAGE_WAFFLE_SUPPORTS_GBM
> + depends on BR2_PACKAGE_VULKAN_LOADER
This dependency could be removed.
> depends on BR2_INSTALL_LIBSTDCPP # mesa3d-demos, python-numpy
> depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL #
> python-numpy
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_9 # python-numpy
> diff --git a/package/piglit/piglit.hash b/package/piglit/piglit.hash
> index 2c0b6aa52a46..20c79a4546af 100644
> --- a/package/piglit/piglit.hash
> +++ b/package/piglit/piglit.hash
> @@ -1,5 +1,5 @@
> # Locally calculated
> -sha256
> ba4d1839038905f3833e9ab23b385913e08d552533dd222cc203c79c10e09918
> piglit-2affee53f3ad7a96f5b397a2b6d6408af8a374b0-git4.tar.gz
> +sha256
> e968966faee7d97305c0a526d339102ddfc8435a2c9007c90444cb3303629f6a
> piglit-a70c33045c59310f972dbbdb33f322eb209971bc-git4.tar.gz
> sha256
> dcc398730859aee7cc1d6aa57f526f8d181b47bb3a49830e85b5723d5bc2c3bc
> COPYING
> sha256
> 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643
> licences/GPL-2
> sha256
> 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903
> licences/GPL-3
> diff --git a/package/piglit/piglit.mk b/package/piglit/piglit.mk
> index 4d17405d10ea..76a759cfca40 100644
> --- a/package/piglit/piglit.mk
> +++ b/package/piglit/piglit.mk
> @@ -4,7 +4,7 @@
> #
>
> ################################################################################
>
> -PIGLIT_VERSION = 2affee53f3ad7a96f5b397a2b6d6408af8a374b0
> +PIGLIT_VERSION = a70c33045c59310f972dbbdb33f322eb209971bc
> PIGLIT_SITE = https://gitlab.freedesktop.org/mesa/piglit.git
> PIGLIT_SITE_METHOD = git
> PIGLIT_LICENSE = MIT (code), \
> @@ -23,6 +23,7 @@ PIGLIT_DEPENDENCIES = host-pkgconf \
> python-mako \
> python-numpy \
> python-six \
> + vulkan-loader \
This hard dependency could be removed.
> waffle \
> zlib
>
>
> ---
> base-commit: c55714aeb9e9bb32b0674b93c4a4cd4b6fa4eb52
> change-id: 20251021-piglit-ebd7afed9982
>
> Best regards,
> --
> Raphael Gallais-Pou <rgallaispou@gmail.com>
While testing, I also seen that piglit enable X11 by default
on Linux. Piglit introduced PIGLIT_USE_X11 in:
https://gitlab.freedesktop.org/mesa/piglit/-/commit/d958b70d1fc5c2ee039363d862b14ca498a50e82
So it might be needed to add -DPIGLIT_USE_X11=ON/OFF in
the "ifeq ($(BR2_PACKAGE_XORG7),y)" block.
Could you have a look to make the vulkan-loader dependency optional,
please?
Best regards,
Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-30 17:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-22 9:38 [Buildroot] [PATCH] package/piglit: bump to a70c33045c59310f972dbbdb33f322eb209971bc Raphael Gallais-Pou
2025-11-02 14:23 ` Raphaël Gallais-Pou
2025-11-30 17:40 ` Julien Olivain via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox