[Buildroot] [PATCH 0/4] Make andes_ae350_45_defconfig more properly maintained

[Buildroot] [PATCH 0/4] Make andes_ae350_45_defconfig more properly maintained

[Leo Yu-Chi Liang via buildroot]

There are some warning when building with andes_ae350_45_defconfig.
1. Tarball source should be a tag instead of branch
2. Lack of "Upstream" tag in the patch files
3. Post-build script does not pass Shellcheck
4. Missing hash files for some packages

Fix them by

1. Modify the source to a tag
2. Update u-boot and opensbi version to remove the patch files
3. Fix the post-build script
4. Add hash files for u-boot, opensbi, and kernel

Leo Yu-Chi Liang (4):
  configs/andes_ae350_45_defconfig: Fix post-build.sh Shellcheck error
  configs/andes_ae350_45_defconfig: Fix linux tarball source
  configs/andes_ae350_45_defconfig: bump to opensbi v1.5
  configs/andes_ae350_45_defconfig: bump to uboot v2024.10

 .../patches/linux-headers/linux-headers.hash  |  2 +
 board/andes/ae350/patches/linux/linux.hash    |  2 +
 .../andes/ae350/patches/opensbi/opensbi.hash  |  2 +
 ...-Support-DTS-of-ftsdc010-driver-for-.patch | 38 -----------------
 ...-tree-blob-address-at-8-byte-boundar.patch | 42 -------------------
 board/andes/ae350/patches/uboot/uboot.hash    |  2 +
 board/andes/ae350/post-build.sh               |  4 +-
 configs/andes_ae350_45_defconfig              | 12 +++---
 8 files changed, 16 insertions(+), 88 deletions(-)
 create mode 100644 board/andes/ae350/patches/linux-headers/linux-headers.hash
 create mode 100644 board/andes/ae350/patches/linux/linux.hash
 create mode 100644 board/andes/ae350/patches/opensbi/opensbi.hash
 delete mode 100644 board/andes/ae350/patches/uboot/0001-mmc-ftsdc010_mci-Support-DTS-of-ftsdc010-driver-for-.patch
 delete mode 100644 board/andes/ae350/patches/uboot/0002-spl-Align-device-tree-blob-address-at-8-byte-boundar.patch
 create mode 100644 board/andes/ae350/patches/uboot/uboot.hash

-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 1/4] configs/andes_ae350_45_defconfig: Fix post-build.sh Shellcheck error

[Leo Yu-Chi Liang via buildroot]

Add quotation mark to fix Shellcheck error.

Signed-off-by: Leo Yu-Chi Liang <ycliang@andestech.com>
---
 board/andes/ae350/post-build.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/andes/ae350/post-build.sh b/board/andes/ae350/post-build.sh
index 84187a064b..e1669c2bcd 100755
--- a/board/andes/ae350/post-build.sh
+++ b/board/andes/ae350/post-build.sh
@@ -1,3 +1,3 @@
 #!/bin/sh
-cp $BINARIES_DIR/Image $TARGET_DIR/boot
-cp $BINARIES_DIR/ae350_ax45mp.dtb $TARGET_DIR/boot
+cp "$BINARIES_DIR"/Image "$TARGET_DIR"/boot
+cp "$BINARIES_DIR"/ae350_ax45mp.dtb "$TARGET_DIR"/boot
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/4] configs/andes_ae350_45_defconfig: Fix linux tarball source

[Leo Yu-Chi Liang via buildroot]

Use tag instead of branch to download the linux source,
and add proper hash files.

Signed-off-by: Leo Yu-Chi Liang <ycliang@andestech.com>
---
 board/andes/ae350/patches/linux-headers/linux-headers.hash | 2 ++
 board/andes/ae350/patches/linux/linux.hash                 | 2 ++
 configs/andes_ae350_45_defconfig                           | 2 +-
 3 files changed, 5 insertions(+), 1 deletion(-)
 create mode 100644 board/andes/ae350/patches/linux-headers/linux-headers.hash
 create mode 100644 board/andes/ae350/patches/linux/linux.hash

diff --git a/board/andes/ae350/patches/linux-headers/linux-headers.hash b/board/andes/ae350/patches/linux-headers/linux-headers.hash
new file mode 100644
index 0000000000..1a6a136b71
--- /dev/null
+++ b/board/andes/ae350/patches/linux-headers/linux-headers.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256  c71af3d2c86c0a0deca4f54b51d1c35217082b030052cc3513dc42e852652733  linux-v6.0.y-andes.tar.gz
diff --git a/board/andes/ae350/patches/linux/linux.hash b/board/andes/ae350/patches/linux/linux.hash
new file mode 100644
index 0000000000..1a6a136b71
--- /dev/null
+++ b/board/andes/ae350/patches/linux/linux.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256  c71af3d2c86c0a0deca4f54b51d1c35217082b030052cc3513dc42e852652733  linux-v6.0.y-andes.tar.gz
diff --git a/configs/andes_ae350_45_defconfig b/configs/andes_ae350_45_defconfig
index 7b5a6f73c6..c02c4d7c61 100644
--- a/configs/andes_ae350_45_defconfig
+++ b/configs/andes_ae350_45_defconfig
@@ -9,7 +9,7 @@ BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
 BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/andes/ae350/genimage_sdcard.cfg"
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
-BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,andestech,linux,v6.0.y_ae350-ax45mp)/linux-v6.0.y_ae350-ax45mp.tar.gz"
+BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,andestech,linux,v6.0.y-andes)/linux-v6.0.y-andes.tar.gz"
 BR2_LINUX_KERNEL_DEFCONFIG="ae350_ax45mp"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
 BR2_LINUX_KERNEL_INTREE_DTS_NAME="andes/ae350_ax45mp"
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 3/4] configs/andes_ae350_45_defconfig: bump to opensbi v1.5

[Leo Yu-Chi Liang via buildroot]

This bumps opensbi to v1.5 and add proper hash file.

Signed-off-by: Leo Yu-Chi Liang <ycliang@andestech.com>
---
 board/andes/ae350/patches/opensbi/opensbi.hash | 2 ++
 configs/andes_ae350_45_defconfig               | 6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)
 create mode 100644 board/andes/ae350/patches/opensbi/opensbi.hash

diff --git a/board/andes/ae350/patches/opensbi/opensbi.hash b/board/andes/ae350/patches/opensbi/opensbi.hash
new file mode 100644
index 0000000000..05c150a514
--- /dev/null
+++ b/board/andes/ae350/patches/opensbi/opensbi.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256  9880485672a3a2c48a81d373df6707517b568402f2d3f9eecbfa9d83f8e6f22f  opensbi-1.5.tar.gz
diff --git a/configs/andes_ae350_45_defconfig b/configs/andes_ae350_45_defconfig
index c02c4d7c61..6e0559659b 100644
--- a/configs/andes_ae350_45_defconfig
+++ b/configs/andes_ae350_45_defconfig
@@ -17,9 +17,9 @@ BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
 # BR2_TARGET_ROOTFS_TAR is not set
 BR2_TARGET_OPENSBI=y
-BR2_TARGET_OPENSBI_CUSTOM_TARBALL=y
-BR2_TARGET_OPENSBI_CUSTOM_TARBALL_LOCATION="$(call github,riscv,opensbi,22f38ee6c658a660083aa45c4ec6c72f66a17260)/opensbi-22f38ee6c658a660083aa45c4ec6c72f66a17260.tar.gz"
-BR2_TARGET_OPENSBI_PLAT="andes/ae350"
+BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
+BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.5"
+BR2_TARGET_OPENSBI_PLAT="generic"
 # BR2_TARGET_OPENSBI_INSTALL_JUMP_IMG is not set
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 4/4] configs/andes_ae350_45_defconfig: bump to uboot v2024.10

[Leo Yu-Chi Liang via buildroot]

This bumps uboot to v2024.10, removes unnecessary patches,
and add proper hash file.

Signed-off-by: Leo Yu-Chi Liang <ycliang@andestech.com>
---
 ...-Support-DTS-of-ftsdc010-driver-for-.patch | 38 -----------------
 ...-tree-blob-address-at-8-byte-boundar.patch | 42 -------------------
 board/andes/ae350/patches/uboot/uboot.hash    |  2 +
 configs/andes_ae350_45_defconfig              |  4 +-
 4 files changed, 4 insertions(+), 82 deletions(-)
 delete mode 100644 board/andes/ae350/patches/uboot/0001-mmc-ftsdc010_mci-Support-DTS-of-ftsdc010-driver-for-.patch
 delete mode 100644 board/andes/ae350/patches/uboot/0002-spl-Align-device-tree-blob-address-at-8-byte-boundar.patch
 create mode 100644 board/andes/ae350/patches/uboot/uboot.hash

diff --git a/board/andes/ae350/patches/uboot/0001-mmc-ftsdc010_mci-Support-DTS-of-ftsdc010-driver-for-.patch b/board/andes/ae350/patches/uboot/0001-mmc-ftsdc010_mci-Support-DTS-of-ftsdc010-driver-for-.patch
deleted file mode 100644
index be89a1563f..0000000000
--- a/board/andes/ae350/patches/uboot/0001-mmc-ftsdc010_mci-Support-DTS-of-ftsdc010-driver-for-.patch
+++ /dev/null
@@ -1,38 +0,0 @@
-From 16aad5594e08550295ea3c12c1c9ed6f64774748 Mon Sep 17 00:00:00 2001
-From: Rick Chen <rick@andestech.com>
-Date: Tue, 29 Mar 2022 13:41:10 +0800
-Subject: [PATCH] mmc: ftsdc010_mci: Support DTS of ftsdc010 driver for
- generic dma
-
-The ftsdc010 driver has been implemented for generic dma in Linux
-kernel. And its compatible is andestech,atfsdc010g to distinguish
-the legacy andestech,atfsdc010 which is not for generic dma.
-
-Althought the ftsdc010_mci driver in U-Boot does not use dma, but
-it still can work well with the mmc node for generic dma. So add
-the compatible string to support it.
-
-Signed-off-by: Rick Chen <rick@andestech.com>
-
-Upstream-Status: Pending
-
-Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
----
- drivers/mmc/ftsdc010_mci.c | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/drivers/mmc/ftsdc010_mci.c b/drivers/mmc/ftsdc010_mci.c
-index 570d54cf9d..65b1d447a8 100644
---- a/drivers/mmc/ftsdc010_mci.c
-+++ b/drivers/mmc/ftsdc010_mci.c
-@@ -460,6 +460,7 @@ int ftsdc010_mmc_bind(struct udevice *dev)
- 
- static const struct udevice_id ftsdc010_mmc_ids[] = {
- 	{ .compatible = "andestech,atfsdc010" },
-+	{ .compatible = "andestech,atfsdc010g" },
- 	{ }
- };
- 
--- 
-2.34.1
-
diff --git a/board/andes/ae350/patches/uboot/0002-spl-Align-device-tree-blob-address-at-8-byte-boundar.patch b/board/andes/ae350/patches/uboot/0002-spl-Align-device-tree-blob-address-at-8-byte-boundar.patch
deleted file mode 100644
index 5080554ca1..0000000000
--- a/board/andes/ae350/patches/uboot/0002-spl-Align-device-tree-blob-address-at-8-byte-boundar.patch
+++ /dev/null
@@ -1,42 +0,0 @@
-From 933ad8a59f7fd9b2088badc3e97167d750a40b5a Mon Sep 17 00:00:00 2001
-From: Bin Meng <bmeng.cn@gmail.com>
-Date: Mon, 12 Jul 2021 11:52:31 +0800
-Subject: [PATCH] spl: Align device tree blob address at 8-byte boundary
-
-Since libfdt v1.6.1, a new requirement on the device tree address via:
-
-  commit 5e735860c478 ("libfdt: Check for 8-byte address alignment in fdt_ro_probe_()")
-
-must be met that the device tree must be loaded in to memory at an
-8-byte aligned address.
-
-Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
-
-This patch was imported from U-boot patchwork:
-https://patchwork.ozlabs.org/project/uboot/patch/20210712035231.26475-1-bmeng.cn@gmail.com/
-
-Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
----
- common/spl/spl_fit.c | 6 ++++++
- 1 file changed, 6 insertions(+)
-
-diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c
-index a35be529..a76ad14a 100644
---- a/common/spl/spl_fit.c
-+++ b/common/spl/spl_fit.c
-@@ -382,6 +382,12 @@ static int spl_fit_append_fdt(struct spl_image_info *spl_image,
- 	 */
- 	image_info.load_addr = spl_image->load_addr + spl_image->size;
- 
-+	/*
-+	 * Since libfdt v1.6.1, the device tree must be loaded in to memory
-+	 * at an 8-byte aligned address.
-+	 */
-+	image_info.load_addr = roundup(image_info.load_addr, 8);
-+
- 	/* Figure out which device tree the board wants to use */
- 	node = spl_fit_get_image_node(ctx, FIT_FDT_PROP, index++);
- 	if (node < 0) {
--- 
-2.34.1
-
diff --git a/board/andes/ae350/patches/uboot/uboot.hash b/board/andes/ae350/patches/uboot/uboot.hash
new file mode 100644
index 0000000000..904fa56c02
--- /dev/null
+++ b/board/andes/ae350/patches/uboot/uboot.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256  b28daf4ac17e43156363078bf510297584137f6df50fced9b12df34f61a92fb0  u-boot-2024.10.tar.bz2
diff --git a/configs/andes_ae350_45_defconfig b/configs/andes_ae350_45_defconfig
index 6e0559659b..dfe2f2646c 100644
--- a/configs/andes_ae350_45_defconfig
+++ b/configs/andes_ae350_45_defconfig
@@ -23,8 +23,8 @@ BR2_TARGET_OPENSBI_PLAT="generic"
 # BR2_TARGET_OPENSBI_INSTALL_JUMP_IMG is not set
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
-BR2_TARGET_UBOOT_CUSTOM_TARBALL=y
-BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="$(call github,u-boot,u-boot,a5dfa3b8a0f7ad555495bad1386613d2de4ba619)/u-boot-a5dfa3b8a0f7ad555495bad1386613d2de4ba619.tar.gz"
+BR2_TARGET_UBOOT_CUSTOM_VERSION=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2024.10"
 BR2_TARGET_UBOOT_BOARD_DEFCONFIG="ae350_rv64_spl_xip"
 BR2_TARGET_UBOOT_CONFIG_FRAGMENT_FILES="board/andes/ae350/uboot.config.fragment"
 BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 3/4] configs/andes_ae350_45_defconfig: bump to opensbi v1.5

[Vincent Jardin via buildroot]

Hi Leo,

On Mon, Oct 27, 2025 at 11:32:41AM +0100, Leo Yu-Chi Liang wrote:
> This bumps opensbi to v1.5 and add proper hash file.
> 
> -BR2_TARGET_OPENSBI_CUSTOM_TARBALL_LOCATION="$(call github,riscv,opensbi,22f38ee6c658a660083aa45c4ec6c72f66a17260)/opensbi-22f38ee6c658a660083aa45c4ec6c72f66a17260.tar.gz"
> -BR2_TARGET_OPENSBI_PLAT="andes/ae350"
> +BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
> +BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.5"

Why using opensbi 1.5 knowing that the latest tag is 1.7 ?
  https://github.com/riscv-software-src/opensbi/tags
that was released last June.

> +BR2_TARGET_OPENSBI_PLAT="generic"

Nice that generic can be used.

Best regards,
  Vincent
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/4] configs/andes_ae350_45_defconfig: Fix post-build.sh Shellcheck error

[Vincent Jardin via buildroot]

Hi Leo,

On Mon, Oct 27, 2025 at 11:32:39AM +0100, Leo Yu-Chi Liang wrote:
> Add quotation mark to fix Shellcheck error.
> 
> Signed-off-by: Leo Yu-Chi Liang <ycliang@andestech.com>

Thanks for this cosmetic fix.

Reviewed-by: Vincent Jardin <vjardin@free.fr>

Best regards,
  Vincent
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 4/4] configs/andes_ae350_45_defconfig: bump to uboot v2024.10

[Vincent Jardin via buildroot]

Hi Leo,

On Mon, Oct 27, 2025 at 11:32:42AM +0100, Leo Yu-Chi Liang wrote:
> This bumps uboot to v2024.10, removes unnecessary patches,
> and add proper hash file.

Why 2024.10 but not:
  config BR2_TARGET_UBOOT_LATEST_VERSION
      bool "2025.01"
?

It is nice that patches can be removed ;)

Best regards,
  Vincent
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/4] configs/andes_ae350_45_defconfig: Fix linux tarball source

[Julien Olivain via buildroot]

Hi Leo,

Thanks for the patch.

On 27/10/2025 04:32, Leo Yu-Chi Liang via buildroot wrote:
> Use tag instead of branch to download the linux source,
> and add proper hash files.
> 
> Signed-off-by: Leo Yu-Chi Liang <ycliang@andestech.com>
> ---
>  board/andes/ae350/patches/linux-headers/linux-headers.hash | 2 ++
>  board/andes/ae350/patches/linux/linux.hash                 | 2 ++
>  configs/andes_ae350_45_defconfig                           | 2 +-
>  3 files changed, 5 insertions(+), 1 deletion(-)
>  create mode 100644 
> board/andes/ae350/patches/linux-headers/linux-headers.hash
>  create mode 100644 board/andes/ae350/patches/linux/linux.hash
> 
> diff --git a/board/andes/ae350/patches/linux-headers/linux-headers.hash 
> b/board/andes/ae350/patches/linux-headers/linux-headers.hash
> new file mode 100644
> index 0000000000..1a6a136b71
> --- /dev/null
> +++ b/board/andes/ae350/patches/linux-headers/linux-headers.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256  
> c71af3d2c86c0a0deca4f54b51d1c35217082b030052cc3513dc42e852652733  
> linux-v6.0.y-andes.tar.gz
> diff --git a/board/andes/ae350/patches/linux/linux.hash 
> b/board/andes/ae350/patches/linux/linux.hash
> new file mode 100644
> index 0000000000..1a6a136b71
> --- /dev/null
> +++ b/board/andes/ae350/patches/linux/linux.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256  
> c71af3d2c86c0a0deca4f54b51d1c35217082b030052cc3513dc42e852652733  
> linux-v6.0.y-andes.tar.gz

If you add the hash files here, the defconfig should also select:
BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
Without it, the hash files will be ignored.

Could you send an updated version adding it?

Also, could you consider, in a separate patch, updating this defconfig
to switch to external Bootlin stable toolchain, please?

See for example:
https://gitlab.com/buildroot.org/buildroot/-/commit/dd3ef914867dca5e429bb25ee14445fb0c87baa5

> diff --git a/configs/andes_ae350_45_defconfig 
> b/configs/andes_ae350_45_defconfig
> index 7b5a6f73c6..c02c4d7c61 100644
> --- a/configs/andes_ae350_45_defconfig
> +++ b/configs/andes_ae350_45_defconfig
> @@ -9,7 +9,7 @@ 
> BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
>  BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/andes/ae350/genimage_sdcard.cfg"
>  BR2_LINUX_KERNEL=y
>  BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> -BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call 
> github,andestech,linux,v6.0.y_ae350-ax45mp)/linux-v6.0.y_ae350-ax45mp.tar.gz"
> +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call 
> github,andestech,linux,v6.0.y-andes)/linux-v6.0.y-andes.tar.gz"
>  BR2_LINUX_KERNEL_DEFCONFIG="ae350_ax45mp"
>  BR2_LINUX_KERNEL_DTS_SUPPORT=y
>  BR2_LINUX_KERNEL_INTREE_DTS_NAME="andes/ae350_ax45mp"
> --
> 2.34.1

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/4] configs/andes_ae350_45_defconfig: Fix post-build.sh Shellcheck error

[Julien Olivain via buildroot]

On 27/10/2025 04:32, Leo Yu-Chi Liang via buildroot wrote:
> Add quotation mark to fix Shellcheck error.
> 
> Signed-off-by: Leo Yu-Chi Liang <ycliang@andestech.com>

I applied this patch only, with a small fixup. See:
https://gitlab.com/buildroot.org/buildroot/-/commit/7504f85c8432e155233b3000cd1bb78a8704ada1

I skipped other patches of the series since there is comments.

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/4] configs/andes_ae350_45_defconfig: Fix post-build.sh Shellcheck error

[Leo Liang via buildroot]

Hi Julien,

On Sat, Nov 01, 2025 at 06:27:56PM +0100, Julien Olivain wrote:
> [EXTERNAL MAIL]
> 
> On 27/10/2025 04:32, Leo Yu-Chi Liang via buildroot wrote:
> > Add quotation mark to fix Shellcheck error.
> > 
> > Signed-off-by: Leo Yu-Chi Liang <ycliang@andestech.com>
> 
> I applied this patch only, with a small fixup. See:
> https://gitlab.com/buildroot.org/buildroot/-/commit/7504f85c8432e155233b3000cd1bb78a8704ada1
> 
> I skipped other patches of the series since there is comments.
> 
> Best regards,
> 
> Julien.

Got it!

I will reply to other comments and respin a v2 patch set.

Thank you so much.

Best regards,
Leo
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/4] configs/andes_ae350_45_defconfig: Fix linux tarball source

[Leo Liang via buildroot]

Hi Julien,

On Wed, Oct 29, 2025 at 09:41:24PM +0100, Julien Olivain wrote:
> [EXTERNAL MAIL]
> 
> Hi Leo,
> 
> Thanks for the patch.
> 
> If you add the hash files here, the defconfig should also select:
> BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
> Without it, the hash files will be ignored.
> 
> Could you send an updated version adding it?
> 
> Also, could you consider, in a separate patch, updating this defconfig
> to switch to external Bootlin stable toolchain, please?
> 
> See for example:
> https://gitlab.com/buildroot.org/buildroot/-/commit/dd3ef914867dca5e429bb25ee14445fb0c87baa5
> 

Thanks for the review!

I will send an updated patch adding "BR2_DOWNLOAD_FORCE_CHECK_HASHES=y"
and another patch to switch to external Bootlin stable toolchain.

Best regards,
Leo

> Best regards,
> 
> Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 3/4] configs/andes_ae350_45_defconfig: bump to opensbi v1.5

[Leo Liang via buildroot]

Hi Vincent,

On Wed, Oct 29, 2025 at 02:54:57PM +0100, Vincent Jardin wrote:
> [EXTERNAL MAIL]
> 
> Hi Leo,
> 
> On Mon, Oct 27, 2025 at 11:32:41AM +0100, Leo Yu-Chi Liang wrote:
> > This bumps opensbi to v1.5 and add proper hash file.
> >
> > -BR2_TARGET_OPENSBI_CUSTOM_TARBALL_LOCATION="$(call github,riscv,opensbi,22f38ee6c658a660083aa45c4ec6c72f66a17260)/opensbi-22f38ee6c658a660083aa45c4ec6c72f66a17260.tar.gz"
> > -BR2_TARGET_OPENSBI_PLAT="andes/ae350"
> > +BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
> > +BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.5"
> 
> Why using opensbi 1.5 knowing that the latest tag is 1.7 ?
>   https://github.com/riscv-software-src/opensbi/tags
> that was released last June.
> 

Thanks for the review.

We are working on a patch to fix current v1.7 OpenSBI for our FPGA board.

For simplicity, we would like to use an older version OpenSBI and update 
the OpenSBI once the patch is merged.
That way we do not need an extra patch/ directory for our OpenSBI.

However, I've just found that v1.6 works.

Do you mind if we bump to v1.6 for this patchset?

Best regards,
Leo

> > +BR2_TARGET_OPENSBI_PLAT="generic"
> 
> Nice that generic can be used.
> 
> Best regards,
>   Vincent
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 4/4] configs/andes_ae350_45_defconfig: bump to uboot v2024.10

[Leo Liang via buildroot]

Hi Vincent,

On Wed, Oct 29, 2025 at 03:00:53PM +0100, Vincent Jardin wrote:
> [EXTERNAL MAIL]
> 
> Hi Leo,
> 
> On Mon, Oct 27, 2025 at 11:32:42AM +0100, Leo Yu-Chi Liang wrote:
> > This bumps uboot to v2024.10, removes unnecessary patches,
> > and add proper hash file.
> 
> Why 2024.10 but not:
>   config BR2_TARGET_UBOOT_LATEST_VERSION
>       bool "2025.01"
> ?
> 
> It is nice that patches can be removed ;)

Thanks for the review!

We have sent a patch to fix current v2025.10 u-boot as well.
(https://lists.denx.de/pipermail/u-boot/2025-October/601790.html)
We would like to update to current master after this patch is merged.

For now, we will respin a patch to bump u-boot version to v2025.07.

Best regards,
Leo

> 
> Best regards,
>   Vincent
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/4] configs/andes_ae350_45_defconfig: Fix post-build.sh Shellcheck error

[Arnout Vandecappelle via buildroot]

On 27/10/2025 04:32, Leo Yu-Chi Liang via buildroot wrote:
> Add quotation mark to fix Shellcheck error.
> 
> Signed-off-by: Leo Yu-Chi Liang <ycliang@andestech.com>

  Applied to 2025.02.x and 2025.08.x, thanks.

  Regards,
  Arnout

> ---
>   board/andes/ae350/post-build.sh | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/board/andes/ae350/post-build.sh b/board/andes/ae350/post-build.sh
> index 84187a064b..e1669c2bcd 100755
> --- a/board/andes/ae350/post-build.sh
> +++ b/board/andes/ae350/post-build.sh
> @@ -1,3 +1,3 @@
>   #!/bin/sh
> -cp $BINARIES_DIR/Image $TARGET_DIR/boot
> -cp $BINARIES_DIR/ae350_ax45mp.dtb $TARGET_DIR/boot
> +cp "$BINARIES_DIR"/Image "$TARGET_DIR"/boot
> +cp "$BINARIES_DIR"/ae350_ax45mp.dtb "$TARGET_DIR"/boot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot