Re: [Buildroot] Compilation Issue with Commit 793ebd5d28095c8df45a0d183d273d8a84b3f0a4

["Yann E. MORIN via buildroot" <buildroot@buildroot.org>]

José, All,

On 2025-11-29 18:14 +0100, José Luis Salvador Rufo spake thusly:
> The commit 793ebd5d28095c8df45a0d183d273d8a84b3f0a4 broke my compilation.

Please explain what the problem is.

> An AI suggested that the problem is because the script
> `support/scripts/check-merged` requires the following change:

Did you understand why the suggested change is correct?

In the end, I don't think we specifically care how you came up with the
proposed change, but we need to know why this is correct. We don't need
some hand-waving "I don't understand why but it works, magic!", but
rather an explanation for why this is needed. This is needed for the
future, when we eventually need to revisit that commit later on, to
understand why we thought the fix was correct back then, and see if some
assumptions valid right now would still be then.

However, thanks for disclosing the use of an AI agent; note that my
reply would have been the same even if you had not.

Would you care to resubmit this patch with a proper commit log (look at
the history to get some ideas); you can also look at some directions in
the manual (it is a bit verbose, but contains a lot of important
information):

    https://buildroot.org/downloads/manual/manual.html#submitting-patches

Also, please add in the commit log that this fixes a [previous commit,
e.g. with a line readoing;

    Fixes: 793ebd5d28095c8df45a0d183d273d8a84b3f0a4

When you do that, you can add my:

    Reviewed-by: Yann E. MORIN <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> diff --git a/support/scripts/check-merged b/support/scripts/check-merged
> index 447abfd815..23fdaac2c8 100755
> --- a/support/scripts/check-merged
> +++ b/support/scripts/check-merged
> @@ -47,6 +47,8 @@ while getopts "t:ub" OPT; do
>         esac
>  done
> 
> +shift $((OPTIND-1))
> +
>  if [ "${type}" = "skeleton" ]; then
>         strict=true
>  else
> 
> After applying this change, my compilation works again, in the same
> way as reverting commit 793ebd5d28095c8df45a0d183d273d8a84b3f0a4.
> I haven’t checked the reason for this `shift` myself.
> 
> Greetings.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot