Re: [Buildroot] Compilation Issue with Commit 793ebd5d28095c8df45a0d183d273d8a84b3f0a4

["Yann E. MORIN via buildroot" <buildroot@buildroot.org>]

Edgar, All,

On 2025-11-29 20:35 +0100, Edgar Bonet spake thusly:
> On 2025-11-29, José Luis Salvador Rufo wrote:
> > The commit 793ebd5d28095c8df45a0d183d273d8a84b3f0a4 broke my compilation.
> > An AI suggested that the problem is because the script
> > `support/scripts/check-merged` requires the following change:
[--SNIP--]
> Yann E. Morin replied:
> > Did you understand why the suggested change is correct?
> 
> I took a quick look at the commit in question (793ebd5d2809
> "support/scripts/check-merged: use getopts instead of getopt"). My
> understanding is that:

Thanks for the helping hand! :-)

>   • Before that commit, the options-parsing loop (`while :; do`, lines
>     44 through 63) consumed (with `shift`) the options and left the
>     other arguments in $@. Those extra arguments (the root directories
>     to check) where then consumed by the `for root; do` loop lines 125
>     through 144.
> 
>   • Since that commit, the options-parsing loop does not consume the
>     options it finds. The `for root; do` loop over the root directories,
>     however, has not been changed. This loop will then interpret the
>     options as extra root directories to check.

That's a perfectly correct analysis of the issue. 👍

However, that does not explain why it causes José's build to fail. Here,
it does not fail. Of course, the script is broken, and instrumenting it
shows that it indeed tries to handle the options as if they were
directories to validate.

However, when I run a build here with a few different overlays (properly
merged usr or bin, or not at all), and enabling or disabling the
corresponding MERGED_{USR,BIN} options, do not fail for me. Thsat's the
reason I did not catch the issue when I submitted my patch.

Hence we don't yet have a complete explanations as to what is different
in José's case, that causes the build to fail for them. That is what is
intersting: why does it fail?

And yes, the change *is* correct, and yes, the script *is* currently
borked. Still, there's this behaviour that I can't reproduce, that is
important to understand.

> @José Luis Salvador Rufo: I hope this can help you write a more
> appropriate commit message.

Yes, Your explanations, Edgar, do have their place in th commit log, as
the reason to explain the build failure, that should be described first.

Maybe describe your setup: how many overlays you are using, if they are
merged-usr, merged-bin, or not, and so on...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot