[Buildroot] [PATCH 1/1] package/vsftpd: fix build with newer gcc

[Buildroot] [PATCH 1/1] package/vsftpd: fix build with newer gcc

[Bernd Kuhls]

Fixes:
https://autobuild.buildroot.net/results/661/661edeafc949390df397fd40a8035330238cbe8a/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 ...ted-non-prototype-warning-with-clang.patch | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 package/vsftpd/0004-Fix-Wdeprecated-non-prototype-warning-with-clang.patch

diff --git a/package/vsftpd/0004-Fix-Wdeprecated-non-prototype-warning-with-clang.patch b/package/vsftpd/0004-Fix-Wdeprecated-non-prototype-warning-with-clang.patch
new file mode 100644
index 0000000000..ec305bf6bc
--- /dev/null
+++ b/package/vsftpd/0004-Fix-Wdeprecated-non-prototype-warning-with-clang.patch
@@ -0,0 +1,25 @@
+From 2bdb7ddbfcf6481ed7662d3d4eb5a3dc83d50224 Mon Sep 17 00:00:00 2001
+From: Tom Stellard <tstellar@redhat.com>
+Date: Fri, 28 Oct 2022 05:35:11 +0000
+Subject: [PATCH] Fix -Wdeprecated-non-prototype warning with clang
+
+Upstream: https://github.com/InfrastructureServices/vsftpd/pull/6
+
+Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
+---
+ ssl.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/ssl.c b/ssl.c
+index d401203..8826b05 100644
+--- a/ssl.c
++++ b/ssl.c
+@@ -36,7 +36,7 @@
+ static char* get_ssl_error();
+ static SSL* get_ssl(struct vsf_session* p_sess, int fd);
+ static int ssl_session_init(struct vsf_session* p_sess);
+-static void setup_bio_callbacks();
++static void setup_bio_callbacks(SSL *p_ssl);
+ static long bio_callback(
+   BIO* p_bio, int oper, const char* p_arg, int argi, long argl, long retval);
+ static int ssl_verify_callback(int verify_ok, X509_STORE_CTX* p_ctx);
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/vsftpd: fix build with newer gcc

[Thomas Petazzoni via buildroot]

Hello,

On Thu, Dec 04, 2025 at 11:38:55PM +0100, Bernd Kuhls wrote:
> Fixes:
> https://autobuild.buildroot.net/results/661/661edeafc949390df397fd40a8035330238cbe8a/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

The details in this commit message were a bit scarce. What is "newer
gcc"? Also when I tried building vsftpd with gcc 15.x, it just worked,
until I realized that it would only fail to build when OpenSSL was
enabled. It would have been nice to have both bits of information
mentioned in the commit message. So I improved a bit the commit
message when applying.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/vsftpd: fix build with newer gcc

[Thomas Perale via buildroot]

In reply of:
> Fixes:
> https://autobuild.buildroot.net/results/661/661edeafc949390df397fd40a8035330238cbe8a/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied to 2025.11.x. Thanks

> ---
>  ...ted-non-prototype-warning-with-clang.patch | 25 +++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 package/vsftpd/0004-Fix-Wdeprecated-non-prototype-warning-with-clang.patch
> 
> diff --git a/package/vsftpd/0004-Fix-Wdeprecated-non-prototype-warning-with-clang.patch b/package/vsftpd/0004-Fix-Wdeprecated-non-prototype-warning-with-clang.patch
> new file mode 100644
> index 0000000000..ec305bf6bc
> --- /dev/null
> +++ b/package/vsftpd/0004-Fix-Wdeprecated-non-prototype-warning-with-clang.patch
> @@ -0,0 +1,25 @@
> +From 2bdb7ddbfcf6481ed7662d3d4eb5a3dc83d50224 Mon Sep 17 00:00:00 2001
> +From: Tom Stellard <tstellar@redhat.com>
> +Date: Fri, 28 Oct 2022 05:35:11 +0000
> +Subject: [PATCH] Fix -Wdeprecated-non-prototype warning with clang
> +
> +Upstream: https://github.com/InfrastructureServices/vsftpd/pull/6
> +
> +Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> +---
> + ssl.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/ssl.c b/ssl.c
> +index d401203..8826b05 100644
> +--- a/ssl.c
> ++++ b/ssl.c
> +@@ -36,7 +36,7 @@
> + static char* get_ssl_error();
> + static SSL* get_ssl(struct vsf_session* p_sess, int fd);
> + static int ssl_session_init(struct vsf_session* p_sess);
> +-static void setup_bio_callbacks();
> ++static void setup_bio_callbacks(SSL *p_ssl);
> + static long bio_callback(
> +   BIO* p_bio, int oper, const char* p_arg, int argi, long argl, long retval);
> + static int ssl_verify_callback(int verify_ok, X509_STORE_CTX* p_ctx);
> -- 
> 2.47.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot