Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/mpg123: add sdl2 support
@ 2026-02-03  7:58 Peter Korsgaard
  2026-02-03 10:38 ` Thomas Petazzoni via buildroot
  2026-02-13 19:38 ` Thomas Perale via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Peter Korsgaard @ 2026-02-03  7:58 UTC (permalink / raw)
  To: buildroot; +Cc: Bernd Kuhls

mpg123 supports (and prefers) SDL2 as well for the sdl backends since 1.26.9
with:

https://github.com/madebr/mpg123/commit/792615f6512a0908081b5a2e98ca61f8677ed452

So support that here as well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/mpg123/mpg123.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/mpg123/mpg123.mk b/package/mpg123/mpg123.mk
index 2f04e0f979..23e061614d 100644
--- a/package/mpg123/mpg123.mk
+++ b/package/mpg123/mpg123.mk
@@ -64,10 +64,10 @@ MPG123_DEPENDENCIES += portaudio
 MPG123_CONF_ENV += LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs portaudio-2.0`"
 endif
 
-ifeq ($(BR2_PACKAGE_SDL),y)
+ifneq ($(BR2_PACKAGE_SDL)$(BR2_PACKAGE_SDL2),)
 MPG123_AUDIO += sdl
 MPG123_CONF_OPTS += --with-default-audio=sdl
-MPG123_DEPENDENCIES += sdl
+MPG123_DEPENDENCIES += $(if $(BR2_PACKAGE_SDL2),sdl2,sdl)
 endif
 
 ifeq ($(BR2_PACKAGE_ALSA_LIB),y)
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/mpg123: add sdl2 support
  2026-02-03  7:58 [Buildroot] [PATCH] package/mpg123: add sdl2 support Peter Korsgaard
@ 2026-02-03 10:38 ` Thomas Petazzoni via buildroot
  2026-02-13 19:38 ` Thomas Perale via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-02-03 10:38 UTC (permalink / raw)
  To: Peter Korsgaard; +Cc: buildroot, Bernd Kuhls

On Tue, Feb 03, 2026 at 08:58:18AM +0100, Peter Korsgaard wrote:
> mpg123 supports (and prefers) SDL2 as well for the sdl backends since 1.26.9
> with:
> 
> https://github.com/madebr/mpg123/commit/792615f6512a0908081b5a2e98ca61f8677ed452
> 
> So support that here as well.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Applied, thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/mpg123: add sdl2 support
  2026-02-03  7:58 [Buildroot] [PATCH] package/mpg123: add sdl2 support Peter Korsgaard
  2026-02-03 10:38 ` Thomas Petazzoni via buildroot
@ 2026-02-13 19:38 ` Thomas Perale via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Perale via buildroot @ 2026-02-13 19:38 UTC (permalink / raw)
  To: Peter Korsgaard; +Cc: Thomas Perale, buildroot

In reply of:
> mpg123 supports (and prefers) SDL2 as well for the sdl backends since 1.26.9
> with:
> 
> https://github.com/madebr/mpg123/commit/792615f6512a0908081b5a2e98ca61f8677ed452
> 
> So support that here as well.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Applied to 2025.02.x & 2025.11.x. Thanks

> ---
>  package/mpg123/mpg123.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/mpg123/mpg123.mk b/package/mpg123/mpg123.mk
> index 2f04e0f979..23e061614d 100644
> --- a/package/mpg123/mpg123.mk
> +++ b/package/mpg123/mpg123.mk
> @@ -64,10 +64,10 @@ MPG123_DEPENDENCIES += portaudio
>  MPG123_CONF_ENV += LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs portaudio-2.0`"
>  endif
>  
> -ifeq ($(BR2_PACKAGE_SDL),y)
> +ifneq ($(BR2_PACKAGE_SDL)$(BR2_PACKAGE_SDL2),)
>  MPG123_AUDIO += sdl
>  MPG123_CONF_OPTS += --with-default-audio=sdl
> -MPG123_DEPENDENCIES += sdl
> +MPG123_DEPENDENCIES += $(if $(BR2_PACKAGE_SDL2),sdl2,sdl)
>  endif
>  
>  ifeq ($(BR2_PACKAGE_ALSA_LIB),y)
> -- 
> 2.47.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-13 19:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-03  7:58 [Buildroot] [PATCH] package/mpg123: add sdl2 support Peter Korsgaard
2026-02-03 10:38 ` Thomas Petazzoni via buildroot
2026-02-13 19:38 ` Thomas Perale via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox