[Buildroot] [PATCH 1/1] package/screen: set socket-dir to /run

[Buildroot] [PATCH 1/1] package/screen: set socket-dir to /run

[Bernd Kuhls]

Buildroot commit 4769724ee2bebd671f6a9372fb8922a8c22c5079 bumped the
package from 4.9.1 to 5.0.0 which includes a major rewrite of the
configure script
https://cgit.git.savannah.gnu.org/cgit/screen.git/log/src/configure.ac?h=v.4.9.1
https://cgit.git.savannah.gnu.org/cgit/screen.git/log/src/configure.ac?h=v.5.0.0

Upstream commit
https://cgit.git.savannah.gnu.org/cgit/screen.git/commit/?id=78a961188f7da528c7cefcc63e07f35f04e69a93
added an option to configure the socket directory which defaults to
$HOME/.screen causing problems with read-only rootfs:

 # screen
 Cannot access /root/.screen: No such file or directory

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/issues/123

Updated project URL to https.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/screen/Config.in | 2 +-
 package/screen/screen.mk | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/screen/Config.in b/package/screen/Config.in
index 81a9bbe4c3..453950bff2 100644
--- a/package/screen/Config.in
+++ b/package/screen/Config.in
@@ -14,7 +14,7 @@ config BR2_PACKAGE_SCREEN
 	  ISO 2022 standards (e.g., insert/delete line and support for
 	  multiple character sets).
 
-	  http://www.gnu.org/software/screen/
+	  https://www.gnu.org/software/screen/
 
 comment "screen needs a toolchain w/ wchar, gcc >= 8"
 	depends on BR2_USE_MMU
diff --git a/package/screen/screen.mk b/package/screen/screen.mk
index 74453faff8..c7411ab6ca 100644
--- a/package/screen/screen.mk
+++ b/package/screen/screen.mk
@@ -13,7 +13,7 @@ SCREEN_SELINUX_MODULES = screen
 SCREEN_DEPENDENCIES = ncurses
 SCREEN_AUTORECONF = YES
 SCREEN_CONF_ENV = CFLAGS="$(TARGET_CFLAGS)"
-SCREEN_CONF_OPTS = --enable-colors256
+SCREEN_CONF_OPTS = --enable-colors256 --enable-socket-dir=/run
 SCREEN_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) SCREEN=screen install_bin
 
 ifeq ($(BR2_PACKAGE_LIBXCRYPT),y)
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/screen: set socket-dir to /run

[Fiona Klute via buildroot]

Am 18.01.26 um 12:47 schrieb Bernd Kuhls:
> Buildroot commit 4769724ee2bebd671f6a9372fb8922a8c22c5079 bumped the
> package from 4.9.1 to 5.0.0 which includes a major rewrite of the
> configure script
> https://cgit.git.savannah.gnu.org/cgit/screen.git/log/src/configure.ac?h=v.4.9.1
> https://cgit.git.savannah.gnu.org/cgit/screen.git/log/src/configure.ac?h=v.5.0.0
> 
> Upstream commit
> https://cgit.git.savannah.gnu.org/cgit/screen.git/commit/?id=78a961188f7da528c7cefcc63e07f35f04e69a93
> added an option to configure the socket directory which defaults to
> $HOME/.screen causing problems with read-only rootfs:
> 
>   # screen
>   Cannot access /root/.screen: No such file or directory
> 
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/issues/123
> 
> Updated project URL to https.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>   package/screen/Config.in | 2 +-
>   package/screen/screen.mk | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/screen/Config.in b/package/screen/Config.in
> index 81a9bbe4c3..453950bff2 100644
> --- a/package/screen/Config.in
> +++ b/package/screen/Config.in
> @@ -14,7 +14,7 @@ config BR2_PACKAGE_SCREEN
>   	  ISO 2022 standards (e.g., insert/delete line and support for
>   	  multiple character sets).
>   
> -	  http://www.gnu.org/software/screen/
> +	  https://www.gnu.org/software/screen/
>   
>   comment "screen needs a toolchain w/ wchar, gcc >= 8"
>   	depends on BR2_USE_MMU
> diff --git a/package/screen/screen.mk b/package/screen/screen.mk
> index 74453faff8..c7411ab6ca 100644
> --- a/package/screen/screen.mk
> +++ b/package/screen/screen.mk
> @@ -13,7 +13,7 @@ SCREEN_SELINUX_MODULES = screen
>   SCREEN_DEPENDENCIES = ncurses
>   SCREEN_AUTORECONF = YES
>   SCREEN_CONF_ENV = CFLAGS="$(TARGET_CFLAGS)"
> -SCREEN_CONF_OPTS = --enable-colors256
> +SCREEN_CONF_OPTS = --enable-colors256 --enable-socket-dir=/run

Won't that break screen for non-root users? /run is usually mounted with 
mode=0755, and changing that would likely create security problems.

I haven't checked how far you can use environment variables in the value 
yet, but in principle I think something like /tmp/screen-$USER would 
make sense (with the same permissions as the default).

Best regards,
Fiona

>   SCREEN_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) SCREEN=screen install_bin
>   
>   ifeq ($(BR2_PACKAGE_LIBXCRYPT),y)

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/screen: set socket-dir to /run

[Fiona Klute via buildroot]

Am 18.01.26 um 14:39 schrieb Fiona Klute via buildroot:
> Am 18.01.26 um 12:47 schrieb Bernd Kuhls:
>> Buildroot commit 4769724ee2bebd671f6a9372fb8922a8c22c5079 bumped the
>> package from 4.9.1 to 5.0.0 which includes a major rewrite of the
>> configure script
>> https://cgit.git.savannah.gnu.org/cgit/screen.git/log/src/ 
>> configure.ac?h=v.4.9.1
>> https://cgit.git.savannah.gnu.org/cgit/screen.git/log/src/ 
>> configure.ac?h=v.5.0.0
>>
>> Upstream commit
>> https://cgit.git.savannah.gnu.org/cgit/screen.git/commit/? 
>> id=78a961188f7da528c7cefcc63e07f35f04e69a93
>> added an option to configure the socket directory which defaults to
>> $HOME/.screen causing problems with read-only rootfs:
>>
>>   # screen
>>   Cannot access /root/.screen: No such file or directory
>>
>> Fixes:
>> https://gitlab.com/buildroot.org/buildroot/-/issues/123
>>
>> Updated project URL to https.
>>
>> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
>> ---
>>   package/screen/Config.in | 2 +-
>>   package/screen/screen.mk | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/screen/Config.in b/package/screen/Config.in
>> index 81a9bbe4c3..453950bff2 100644
>> --- a/package/screen/Config.in
>> +++ b/package/screen/Config.in
>> @@ -14,7 +14,7 @@ config BR2_PACKAGE_SCREEN
>>         ISO 2022 standards (e.g., insert/delete line and support for
>>         multiple character sets).
>> -      http://www.gnu.org/software/screen/
>> +      https://www.gnu.org/software/screen/
>>   comment "screen needs a toolchain w/ wchar, gcc >= 8"
>>       depends on BR2_USE_MMU
>> diff --git a/package/screen/screen.mk b/package/screen/screen.mk
>> index 74453faff8..c7411ab6ca 100644
>> --- a/package/screen/screen.mk
>> +++ b/package/screen/screen.mk
>> @@ -13,7 +13,7 @@ SCREEN_SELINUX_MODULES = screen
>>   SCREEN_DEPENDENCIES = ncurses
>>   SCREEN_AUTORECONF = YES
>>   SCREEN_CONF_ENV = CFLAGS="$(TARGET_CFLAGS)"
>> -SCREEN_CONF_OPTS = --enable-colors256
>> +SCREEN_CONF_OPTS = --enable-colors256 --enable-socket-dir=/run
> 
> Won't that break screen for non-root users? /run is usually mounted with 
> mode=0755, and changing that would likely create security problems.
> 
> I haven't checked how far you can use environment variables in the value 
> yet, but in principle I think something like /tmp/screen-$USER would 
> make sense (with the same permissions as the default).
Sorry, I hadn't realized screen is installed with setuid. I don't like 
setuid, but it means this change won't cause permission issues. :-)

Though maybe /run/screen or similar would be better, so we don't end up 
with "S-$USER" dirs directly in /run? At least that's what screen does 
if you enable socket-dir without setting a path.

Best regards,
Fiona

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/screen: set socket-dir to /run

[Thomas Petazzoni via buildroot]

Hello Bernd,

+Fiona in Cc, since she gave feedback.

On Sun, Jan 18, 2026 at 12:47:34PM +0100, Bernd Kuhls wrote:
> Buildroot commit 4769724ee2bebd671f6a9372fb8922a8c22c5079 bumped the
> package from 4.9.1 to 5.0.0 which includes a major rewrite of the
> configure script
> https://cgit.git.savannah.gnu.org/cgit/screen.git/log/src/configure.ac?h=v.4.9.1
> https://cgit.git.savannah.gnu.org/cgit/screen.git/log/src/configure.ac?h=v.5.0.0
> 
> Upstream commit
> https://cgit.git.savannah.gnu.org/cgit/screen.git/commit/?id=78a961188f7da528c7cefcc63e07f35f04e69a93
> added an option to configure the socket directory which defaults to
> $HOME/.screen causing problems with read-only rootfs:

This is not correct: the option defaults to /run/screen. It's when the
option is not passed at all that it defaults to $HOME/.screen.

As suggested by Fiona, I've changed to just --enable-socket-dir, which
sets the path to /run/screen/ which is better than /run.

I've adjusted the commit message.

> Updated project URL to https.

I've also dropped this change which is unrelated.

Thanks, applied with those changes!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/screen: set socket-dir to /run

[Thomas Perale via buildroot]

In reply of:
> Buildroot commit 4769724ee2bebd671f6a9372fb8922a8c22c5079 bumped the
> package from 4.9.1 to 5.0.0 which includes a major rewrite of the
> configure script
> https://cgit.git.savannah.gnu.org/cgit/screen.git/log/src/configure.ac?h=v.4.9.1
> https://cgit.git.savannah.gnu.org/cgit/screen.git/log/src/configure.ac?h=v.5.0.0
> 
> Upstream commit
> https://cgit.git.savannah.gnu.org/cgit/screen.git/commit/?id=78a961188f7da528c7cefcc63e07f35f04e69a93
> added an option to configure the socket directory which defaults to
> $HOME/.screen causing problems with read-only rootfs:
> 
>  # screen
>  Cannot access /root/.screen: No such file or directory
> 
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/issues/123
> 
> Updated project URL to https.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied to 2025.02.x & 2025.11.x. Thanks

> ---
>  package/screen/Config.in | 2 +-
>  package/screen/screen.mk | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/screen/Config.in b/package/screen/Config.in
> index 81a9bbe4c3..453950bff2 100644
> --- a/package/screen/Config.in
> +++ b/package/screen/Config.in
> @@ -14,7 +14,7 @@ config BR2_PACKAGE_SCREEN
>  	  ISO 2022 standards (e.g., insert/delete line and support for
>  	  multiple character sets).
>  
> -	  http://www.gnu.org/software/screen/
> +	  https://www.gnu.org/software/screen/
>  
>  comment "screen needs a toolchain w/ wchar, gcc >= 8"
>  	depends on BR2_USE_MMU
> diff --git a/package/screen/screen.mk b/package/screen/screen.mk
> index 74453faff8..c7411ab6ca 100644
> --- a/package/screen/screen.mk
> +++ b/package/screen/screen.mk
> @@ -13,7 +13,7 @@ SCREEN_SELINUX_MODULES = screen
>  SCREEN_DEPENDENCIES = ncurses
>  SCREEN_AUTORECONF = YES
>  SCREEN_CONF_ENV = CFLAGS="$(TARGET_CFLAGS)"
> -SCREEN_CONF_OPTS = --enable-colors256
> +SCREEN_CONF_OPTS = --enable-colors256 --enable-socket-dir=/run
>  SCREEN_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) SCREEN=screen install_bin
>  
>  ifeq ($(BR2_PACKAGE_LIBXCRYPT),y)
> -- 
> 2.47.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot