Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/openscap: set dependency on C++ support
@ 2026-02-16  9:40 Alexis Lothoré via buildroot
  2026-02-16  9:56 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 4+ messages in thread
From: Alexis Lothoré via buildroot @ 2026-02-16  9:40 UTC (permalink / raw)
  To: buildroot; +Cc: Thomas Petazzoni, Alexis Lothoré

When the toolchain involved in openscap build does not support C++, the
configure step fails with the following error:

  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - failed
  -- Check for working CXX compiler: /bin/false
  -- Check for working CXX compiler: /bin/false - broken
  CMake Error at /usr/share/cmake/Modules/CMakeTestCXXCompiler.cmake:73 (message):
    The C++ compiler

      "/bin/false"

    is not able to compile a simple test program.

    It fails with the following output:

      Change Dir: '/home/autobuild/autobuild/instance-6/output-1/build/openscap-1.3.12/buildroot-build/CMakeFiles/CMakeScratch/TryCompile-tUydqI'

      Run Build Command(s): /usr/bin/cmake -E env VERBOSE=1 /usr/bin/make -f Makefile cmTC_1834b/fast
      make[1]: Entering directory '/home/autobuild/autobuild/instance-6/output-1/build/openscap-1.3.12/buildroot-build/CMakeFiles/CMakeScratch/TryCompile-tUydqI'
      /usr/bin/make  -f CMakeFiles/cmTC_1834b.dir/build.make CMakeFiles/cmTC_1834b.dir/build
      make[2]: Entering directory '/home/autobuild/autobuild/instance-6/output-1/build/openscap-1.3.12/buildroot-build/CMakeFiles/CMakeScratch/TryCompile-tUydqI'
      Building CXX object CMakeFiles/cmTC_1834b.dir/testCXXCompiler.cxx.o
      /bin/false    -o CMakeFiles/cmTC_1834b.dir/testCXXCompiler.cxx.o -c /home/autobuild/autobuild/instance-6/output-1/build/openscap-1.3.12/buildroot-build/CMakeFiles/CMakeScratch/TryCompile-tUydqI/testCXXCompiler.cxx
      make[2]: *** [CMakeFiles/cmTC_1834b.dir/build.make:81: CMakeFiles/cmTC_1834b.dir/testCXXCompiler.cxx.o] Error 1
      make[2]: Leaving directory '/home/autobuild/autobuild/instance-6/output-1/build/openscap-1.3.12/buildroot-build/CMakeFiles/CMakeScratch/TryCompile-tUydqI'
      make[1]: *** [Makefile:134: cmTC_1834b/fast] Error 2
      make[1]: Leaving directory '/home/autobuild/autobuild/instance-6/output-1/build/openscap-1.3.12/buildroot-build/CMakeFiles/CMakeScratch/TryCompile-tUydqI'

    CMake will not be able to correctly generate this project.
  Call Stack (most recent call first):
    CMakeLists.txt:11 (project)

  -- Configuring incomplete, errors occurred!
  make: *** [package/pkg-generic.mk:263: /home/autobuild/autobuild/instance-6/output-1/build/openscap-1.3.12/.stamp_configured] Error 1
  make: Leaving directory '/home/autobuild/autobuild/instance-6/buildroot'

Make openscap depend on proper C++ support.

Fixes: https://autobuild.buildroot.org/results/1fe550ffa79f0a083a450ae03fe067a8ab7336be
Fixes: https://autobuild.buildroot.org/results/e9d52b52658544916022050c78dcb137ca6c97e0
Fixes: https://autobuild.buildroot.org/results/4a9c21763aaddb217ee5f8bb8947faad9767baa3
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
---
 package/openscap/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/openscap/Config.in b/package/openscap/Config.in
index 317055c75327..375fcacc2d05 100644
--- a/package/openscap/Config.in
+++ b/package/openscap/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_OPENSCAP
 	bool "openscap"
 	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS  # libgcrypt
 	depends on !BR2_STATIC_LIBS # dlfcn.h
+	depends on BR2_INSTALL_LIBSTDCPP
 	select BR2_PACKAGE_LIBCURL
 	# In theory should build without crypto, but in practice it
 	# doesn't: https://github.com/OpenSCAP/openscap/issues/2310
@@ -19,6 +20,6 @@ config BR2_PACKAGE_OPENSCAP
 	  https://www.open-scap.org/
 	  https://github.com/OpenSCAP/openscap
 
-comment "openscap needs a toolchain w/ dynamic library"
+comment "openscap needs a toolchain w/ C++, dynamic library"
 	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
-	depends on BR2_STATIC_LIBS
+	depends on BR2_STATIC_LIBS || !BR2_INSTALL_LIBSTDCPP

---
base-commit: 78d38d9ddda81d7c6bff9b520656fe4f46f0f692
change-id: 20260216-openscap_cpp-5e4035d7dbf8

Best regards,
-- 
Alexis Lothoré <alexis.lothore@bootlin.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/openscap: set dependency on C++ support
  2026-02-16  9:40 [Buildroot] [PATCH] package/openscap: set dependency on C++ support Alexis Lothoré via buildroot
@ 2026-02-16  9:56 ` Thomas Petazzoni via buildroot
  2026-02-16 12:59   ` Alexis Lothoré via buildroot
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-02-16  9:56 UTC (permalink / raw)
  To: Alexis Lothoré; +Cc: buildroot

Hello Alexis,

Thanks for the fix!

On Mon, Feb 16, 2026 at 10:40:42AM +0100, Alexis Lothoré wrote:
> When the toolchain involved in openscap build does not support C++, the
> configure step fails with the following error:
> 
>   -- Detecting CXX compiler ABI info
>   -- Detecting CXX compiler ABI info - failed
>   -- Check for working CXX compiler: /bin/false
>   -- Check for working CXX compiler: /bin/false - broken
>   CMake Error at /usr/share/cmake/Modules/CMakeTestCXXCompiler.cmake:73 (message):
>     The C++ compiler

From a quick look, it doesn't seem like openscap contains C++ code. So
instead the right fix is most likely to change CMakeLists.txt to check
for the C compiler only.

To do that, in CMakeLists.txt, change:

project(blabla)

to

project(blabla C)

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/openscap: set dependency on C++ support
  2026-02-16  9:56 ` Thomas Petazzoni via buildroot
@ 2026-02-16 12:59   ` Alexis Lothoré via buildroot
  2026-02-16 14:23     ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 4+ messages in thread
From: Alexis Lothoré via buildroot @ 2026-02-16 12:59 UTC (permalink / raw)
  To: Thomas Petazzoni, Alexis Lothoré; +Cc: buildroot

On Mon Feb 16, 2026 at 10:56 AM CET, Thomas Petazzoni wrote:
> Hello Alexis,
>
> Thanks for the fix!
>
> On Mon, Feb 16, 2026 at 10:40:42AM +0100, Alexis Lothoré wrote:
>> When the toolchain involved in openscap build does not support C++, the
>> configure step fails with the following error:
>> 
>>   -- Detecting CXX compiler ABI info
>>   -- Detecting CXX compiler ABI info - failed
>>   -- Check for working CXX compiler: /bin/false
>>   -- Check for working CXX compiler: /bin/false - broken
>>   CMake Error at /usr/share/cmake/Modules/CMakeTestCXXCompiler.cmake:73 (message):
>>     The C++ compiler
>
> From a quick look, it doesn't seem like openscap contains C++ code. So
> instead the right fix is most likely to change CMakeLists.txt to check
> for the C compiler only.
>
> To do that, in CMakeLists.txt, change:
>
> project(blabla)
>
> to
>
> project(blabla C)

Good point, thanks. I'll send this fix to the upstream project. As
the package is now integrated in master (and so triggering failures
every day in the autobuilder), I guess it is ok to follow-up with a v2
bringing the corresponding patch submitted on the upstream project, even
if not merged yet ?

Alexis


-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/openscap: set dependency on C++ support
  2026-02-16 12:59   ` Alexis Lothoré via buildroot
@ 2026-02-16 14:23     ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-02-16 14:23 UTC (permalink / raw)
  To: Alexis Lothoré; +Cc: buildroot

On Mon, Feb 16, 2026 at 01:59:24PM +0100, Alexis Lothoré wrote:

> Good point, thanks. I'll send this fix to the upstream project. As
> the package is now integrated in master (and so triggering failures
> every day in the autobuilder), I guess it is ok to follow-up with a v2
> bringing the corresponding patch submitted on the upstream project, even
> if not merged yet ?

It is absolutely OK, and is exactly what we would expect :-)

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-02-16 14:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-16  9:40 [Buildroot] [PATCH] package/openscap: set dependency on C++ support Alexis Lothoré via buildroot
2026-02-16  9:56 ` Thomas Petazzoni via buildroot
2026-02-16 12:59   ` Alexis Lothoré via buildroot
2026-02-16 14:23     ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox