[Buildroot] [PATCH] package/opendoas: fix install mode

[Buildroot] [PATCH] package/opendoas: fix install mode

[Francois Perrad via buildroot]

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/opendoas/opendoas.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/opendoas/opendoas.mk b/package/opendoas/opendoas.mk
index 06626508f..f8421e8c7 100644
--- a/package/opendoas/opendoas.mk
+++ b/package/opendoas/opendoas.mk
@@ -50,7 +50,7 @@ define OPENDOAS_BUILD_CMDS
 endef
 
 define OPENDOAS_INSTALL_TARGET_CMDS
-	$(INSTALL) -D -m 0755 $(@D)/doas $(TARGET_DIR)/usr/bin/doas
+	$(INSTALL) -D -m 04755 $(@D)/doas $(TARGET_DIR)/usr/bin/doas
 	$(OPENDOAS_INSTALL_PAM_CONF)
 endef
 
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/opendoas: fix install mode

[yann.morin]

François, All,

On 2026-05-12 12:32 +0200, Francois Perrad via buildroot spake thusly:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  package/opendoas/opendoas.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/opendoas/opendoas.mk b/package/opendoas/opendoas.mk
> index 06626508f..f8421e8c7 100644
> --- a/package/opendoas/opendoas.mk
> +++ b/package/opendoas/opendoas.mk
> @@ -50,7 +50,7 @@ define OPENDOAS_BUILD_CMDS
>  endef
>  
>  define OPENDOAS_INSTALL_TARGET_CMDS
> -	$(INSTALL) -D -m 0755 $(@D)/doas $(TARGET_DIR)/usr/bin/doas

As I suggested earlier today [0]: do not create a set-uid file on disk;
instead use a_PERMISSION for that:

    define OPENDOAS_PERMISSIONS 
        /usr/bin/doas f 4755 0 0 - - - - -
    endef

[0] https://lore.kernel.org/buildroot/agLg8LER0UAV4uWC@yd-6wlzhs3/

Regards,
Yann E. MORIN.

> +	$(INSTALL) -D -m 04755 $(@D)/doas $(TARGET_DIR)/usr/bin/doas
>  	$(OPENDOAS_INSTALL_PAM_CONF)
>  endef
>  
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
                                        ____________
.-----------------.--------------------:       _    :------------------.
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
|                 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
| +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
| yann.morin (at) orange.com           |_="    ,--' | / \ HTML MAIL    |
'--------------------------------------:______/_____:------------------'

____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot