Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/3] package/vlc: replace wayland-scanner patch with upstream commit
@ 2026-02-24 18:20 Bernd Kuhls
  2026-02-24 18:20 ` [Buildroot] [PATCH 2/3] package/vlc: update freerdp2 patch Bernd Kuhls
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Bernd Kuhls @ 2026-02-24 18:20 UTC (permalink / raw)
  To: buildroot; +Cc: Simon Dawson

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 .checkpackageignore                           |  1 -
 ...t-possible-to-override-wayland-scann.patch | 39 +++++++++++++++
 ...o-use-AC_PATH_PROG-to-check-for-wayl.patch | 50 -------------------
 package/vlc/vlc.mk                            |  1 +
 4 files changed, 40 insertions(+), 51 deletions(-)
 create mode 100644 package/vlc/0008-configure-make-it-possible-to-override-wayland-scann.patch
 delete mode 100644 package/vlc/0008-configure.ac-also-use-AC_PATH_PROG-to-check-for-wayl.patch

diff --git a/.checkpackageignore b/.checkpackageignore
index 695e0d50c6..3ad99d0eb1 100644
--- a/.checkpackageignore
+++ b/.checkpackageignore
@@ -975,7 +975,6 @@ package/vlc/0004-Fix-build-error-using-uClibc-by-adding-sys-types.h.patch lib_pa
 package/vlc/0005-Don-t-assume-strerror_l-is-available.patch lib_patch.Upstream
 package/vlc/0006-posix-remove-ancient-run-time-fallback-to-real-time-.patch lib_patch.Upstream
 package/vlc/0007-Add-support-for-freerdp2.patch lib_patch.Upstream
-package/vlc/0008-configure.ac-also-use-AC_PATH_PROG-to-check-for-wayl.patch lib_patch.Upstream
 package/vlc/0009-modules-video_filter-opencv_example.cpp-fix-build-wi.patch lib_patch.Upstream
 package/vlc/0010-opengl-missing-library-check.patch lib_patch.Upstream
 package/vpnc/0001-Makefile-allow-to-override-the-PREFIX-variable.patch lib_patch.Upstream
diff --git a/package/vlc/0008-configure-make-it-possible-to-override-wayland-scann.patch b/package/vlc/0008-configure-make-it-possible-to-override-wayland-scann.patch
new file mode 100644
index 0000000000..b89687ec74
--- /dev/null
+++ b/package/vlc/0008-configure-make-it-possible-to-override-wayland-scann.patch
@@ -0,0 +1,39 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Yann Lochet <yann@l0chet.fr>
+Date: Fri, 25 Nov 2022 16:20:45 +0100
+Subject: [PATCH] configure: make it possible to override wayland-scanner
+
+When cross-compiling, PKG_CONFIG might pick up the wayland-scanner
+from the sysroot.
+
+Upstream: https://code.videolan.org/videolan/vlc/-/commit/75e52f617bf3273f4883b56c4175d68211e02d14
+
+[Bernd: rebased for 3.0.23]
+Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
+---
+ configure.ac | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/configure.ac b/configure.ac
+index a91fc73172..5e8821dea9 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -3277,6 +3277,7 @@ AS_IF([test "${enable_wayland}" = "yes"], [
+     ])
+ 
+     AC_MSG_CHECKING([for the Wayland scanner])
++    AS_VAR_SET_IF(WAYLAND_SCANNER, [],[
+     PKG_CHECK_EXISTS([wayland-scanner], [
+       WAYLAND_SCANNER="$(${PKG_CONFIG} wayland-scanner --variable wayland_scanner)"
+       AC_MSG_RESULT([${WAYLAND_SCANNER}])
+@@ -3284,6 +3285,7 @@ AS_IF([test "${enable_wayland}" = "yes"], [
+       AC_MSG_RESULT([not found])
+       AC_MSG_ERROR([$(${PKG_CONFIG} --print-errors wayland-scanner)])
+     ])
++    ])
+ 
+     have_wayland="yes"
+ 
+-- 
+2.47.3
+
diff --git a/package/vlc/0008-configure.ac-also-use-AC_PATH_PROG-to-check-for-wayl.patch b/package/vlc/0008-configure.ac-also-use-AC_PATH_PROG-to-check-for-wayl.patch
deleted file mode 100644
index 2b74fe0d39..0000000000
--- a/package/vlc/0008-configure.ac-also-use-AC_PATH_PROG-to-check-for-wayl.patch
+++ /dev/null
@@ -1,50 +0,0 @@
-From 27635f902831fac898586f1f3dc98369f12582c9 Mon Sep 17 00:00:00 2001
-From: Bernd Kuhls <bernd.kuhls@t-online.de>
-Date: Sun, 26 Aug 2018 12:51:04 +0200
-Subject: [PATCH] configure.ac: also use AC_PATH_PROG to check for
- wayland-scanner
-
-When cross-compiling the .pc file might point to the wrong
-wayland-scanner binary (target rather than host) resulting in a
-non-executable and wrong scanner.
-Try searching the PATH first, and if that fails fall back into
-pkg-config.
-
-Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
----
- configure.ac | 19 +++++++++++--------
- 1 file changed, 11 insertions(+), 8 deletions(-)
-
-diff --git a/configure.ac b/configure.ac
-index 4808b8becf..a18641ed23 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -3140,14 +3140,17 @@ AS_IF([test "${enable_wayland}" != "no"], [
-       AC_MSG_ERROR([$(${PKG_CONFIG} --print-errors 'wayland-protocols >= 1.4')])
-     ])
- 
--    AC_MSG_CHECKING([for the Wayland scanner])
--    PKG_CHECK_EXISTS([wayland-scanner], [
--      WAYLAND_SCANNER="$(${PKG_CONFIG} wayland-scanner --variable wayland_scanner)"
--      AC_MSG_RESULT([${WAYLAND_SCANNER}])
--    ], [
--      AC_MSG_RESULT([not found])
--      AC_MSG_ERROR([$(${PKG_CONFIG} --print-errors wayland-scanner)])
--    ])
-+    AC_PATH_PROG([WAYLAND_SCANNER], [wayland-scanner])
-+    if test "x$WAYLAND_SCANNER" = x; then
-+        AC_MSG_CHECKING([for the Wayland scanner])
-+        PKG_CHECK_EXISTS([wayland-scanner], [
-+          WAYLAND_SCANNER="$(${PKG_CONFIG} wayland-scanner --variable wayland_scanner)"
-+          AC_MSG_RESULT([${WAYLAND_SCANNER}])
-+        ], [
-+          AC_MSG_RESULT([not found])
-+          AC_MSG_ERROR([$(${PKG_CONFIG} --print-errors wayland-scanner)])
-+        ])
-+    fi
- 
-     have_wayland="yes"
- 
--- 
-2.18.0
-
diff --git a/package/vlc/vlc.mk b/package/vlc/vlc.mk
index 07aeefd193..0ce6662353 100644
--- a/package/vlc/vlc.mk
+++ b/package/vlc/vlc.mk
@@ -527,6 +527,7 @@ VLC_CONF_OPTS += --disable-udev
 endif
 
 ifeq ($(BR2_PACKAGE_WAYLAND)$(BR2_PACKAGE_WAYLAND_PROTOCOLS),yy)
+VLC_CONF_ENV += WAYLAND_SCANNER=$(HOST_DIR)/bin/wayland-scanner
 VLC_CONF_OPTS += --enable-wayland
 VLC_DEPENDENCIES += wayland wayland-protocols
 else
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 2/3] package/vlc: update freerdp2 patch
  2026-02-24 18:20 [Buildroot] [PATCH 1/3] package/vlc: replace wayland-scanner patch with upstream commit Bernd Kuhls
@ 2026-02-24 18:20 ` Bernd Kuhls
  2026-06-05 12:50   ` Thomas Perale via buildroot
  2026-02-24 18:20 ` [Buildroot] [PATCH 3/3] package/vlc: rebase patch set Bernd Kuhls
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 7+ messages in thread
From: Bernd Kuhls @ 2026-02-24 18:20 UTC (permalink / raw)
  To: buildroot; +Cc: Simon Dawson

Replace Gentoo patch from 2018 with rebased version of an upstream
commit from 2022 which also fixes build errors introduced by gcc 14.x:

access/rdp.c: In function 'postConnectHandler':
access/rdp.c:238:39: error: assignment to 'pDesktopResize' {aka 'int
 (*)(struct rdp_context *)'} from incompatible pointer type 'void
 (*)(rdpContext *)' {aka 'void (*)(struct rdp_context *)'}
 [-Wincompatible-pointer-types]
  238 |     p_instance->update->DesktopResize = desktopResizeHandler;
      |                                       ^

No autobuilder error was recorded, the build error can be reproduced
with this defconfig:

BR2_x86_64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_VLC=y
BR2_PACKAGE_FREERDP=y

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 .checkpackageignore                           |   1 -
 .../vlc/0007-Add-support-for-freerdp2.patch   | 173 ++++++++++++++----
 2 files changed, 133 insertions(+), 41 deletions(-)

diff --git a/.checkpackageignore b/.checkpackageignore
index 3ad99d0eb1..cf3702acf6 100644
--- a/.checkpackageignore
+++ b/.checkpackageignore
@@ -974,7 +974,6 @@ package/vlc/0003-build-use-pkg-config-to-get-tremor-libs.patch lib_patch.Upstrea
 package/vlc/0004-Fix-build-error-using-uClibc-by-adding-sys-types.h.patch lib_patch.Upstream
 package/vlc/0005-Don-t-assume-strerror_l-is-available.patch lib_patch.Upstream
 package/vlc/0006-posix-remove-ancient-run-time-fallback-to-real-time-.patch lib_patch.Upstream
-package/vlc/0007-Add-support-for-freerdp2.patch lib_patch.Upstream
 package/vlc/0009-modules-video_filter-opencv_example.cpp-fix-build-wi.patch lib_patch.Upstream
 package/vlc/0010-opengl-missing-library-check.patch lib_patch.Upstream
 package/vpnc/0001-Makefile-allow-to-override-the-PREFIX-variable.patch lib_patch.Upstream
diff --git a/package/vlc/0007-Add-support-for-freerdp2.patch b/package/vlc/0007-Add-support-for-freerdp2.patch
index 75f095545b..c3148600ca 100644
--- a/package/vlc/0007-Add-support-for-freerdp2.patch
+++ b/package/vlc/0007-Add-support-for-freerdp2.patch
@@ -1,32 +1,32 @@
-From 3780bbb20bf35aa8f21ac672da3f0c5f408468e9 Mon Sep 17 00:00:00 2001
-From: Bernd Kuhls <bernd.kuhls@t-online.de>
-Date: Thu, 16 Aug 2018 12:27:40 +0200
-Subject: [PATCH] Add support for freerdp2
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Juliane de Sartiges <jill@videolabs.io>
+Date: Wed, 27 Jul 2022 09:32:25 +0200
+Subject: [PATCH] freerdp: update to freerdp2 api
 
-Downloaded from
-https://gitweb.gentoo.org/repo/gentoo.git/tree/media-video/vlc/files/vlc-2.2.8-freerdp-2.patch
+Upstream: https://code.videolan.org/videolan/vlc/-/commit/95e7bba6105bd8c2b8ea9cabc02c8dfe7411cab2
 
-Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
+[Bernd: rebased for 3.0.23]
+Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
 ---
  configure.ac         |  2 +-
- modules/access/rdp.c | 51 ++++++++++++++-------------------------------------
- 2 files changed, 15 insertions(+), 38 deletions(-)
+ modules/access/rdp.c | 85 ++++++++++++++++++++------------------------
+ 2 files changed, 40 insertions(+), 47 deletions(-)
 
 diff --git a/configure.ac b/configure.ac
-index bfe43512a2..4808b8becf 100644
+index d96287d3e0..a91fc73172 100644
 --- a/configure.ac
 +++ b/configure.ac
-@@ -1992,7 +1992,7 @@ PKG_ENABLE_MODULES_VLC([VNC], [vnc], [libvncclient >= 0.9.9], (VNC/rfb client su
+@@ -2194,7 +2194,7 @@ PKG_ENABLE_MODULES_VLC([VNC], [vnc], [libvncclient >= 0.9.9], (VNC/rfb client su
  
  dnl  RDP/Remote Desktop access module
  dnl
 -PKG_ENABLE_MODULES_VLC([FREERDP], [rdp], [freerdp >= 1.0.1], (RDP/Remote Desktop client support) )
-+PKG_ENABLE_MODULES_VLC([FREERDP], [rdp], [freerdp2 >= 1.0.1], (RDP/Remote Desktop client support) )
++PKG_ENABLE_MODULES_VLC([FREERDP], [rdp], [freerdp2 >= 2.0.0], (RDP/Remote Desktop client support) )
  
  dnl
  dnl  Real RTSP plugin
 diff --git a/modules/access/rdp.c b/modules/access/rdp.c
-index 2992090219..49986f5da9 100644
+index 0c39663c64..04ae005938 100644
 --- a/modules/access/rdp.c
 +++ b/modules/access/rdp.c
 @@ -45,18 +45,6 @@
@@ -48,37 +48,51 @@ index 2992090219..49986f5da9 100644
  #include <errno.h>
  #ifdef HAVE_POLL
  # include <poll.h>
-@@ -144,6 +132,7 @@ static void desktopResizeHandler( rdpContext *p_context )
+@@ -75,6 +63,8 @@
+ 
+ #define CFG_PREFIX "rdp-"
+ 
++#define FREERDP_PIXEL_BPP(_format) (_format >> 24)
++
+ /*****************************************************************************
+  * Module descriptor
+  *****************************************************************************/
+@@ -139,11 +129,12 @@ typedef struct vlcrdp_context_t vlcrdp_context_t;
+ 
+ /* updates handlers */
+ 
+-static void desktopResizeHandler( rdpContext *p_context )
++static BOOL desktopResizeHandler( rdpContext *p_context )
+ {
      vlcrdp_context_t * p_vlccontext = (vlcrdp_context_t *) p_context;
      demux_sys_t *p_sys = p_vlccontext->p_demux->p_sys;
      rdpGdi *p_gdi = p_context->gdi;
-+    unsigned bytesPerPixel;
++    int i_colordepth = FREERDP_PIXEL_BPP( p_gdi->dstFormat );
  
      if ( p_sys->es )
      {
-@@ -153,17 +142,21 @@ static void desktopResizeHandler( rdpContext *p_context )
+@@ -151,11 +142,13 @@ static void desktopResizeHandler( rdpContext *p_context )
+         p_sys->es = NULL;
+     }
  
-     /* Now init and fill es format */
+-    /* Now init and fill es format */
      vlc_fourcc_t i_chroma;
 -    switch( p_gdi->bytesPerPixel )
-+    switch( p_gdi->dstFormat )
++    /* Now init and fill es format */
++    switch ( i_colordepth )
      {
          default:
--        case 16:
-+            msg_Dbg( p_vlccontext->p_demux, "unhandled dstFormat %x bpp", p_gdi->dstFormat);
-+        case PIXEL_FORMAT_BGR16:
++            msg_Dbg( p_vlccontext->p_demux, "invalid color depth %d", i_colordepth);
++            /* fallthrough */
+         case 16:
              i_chroma = VLC_CODEC_RGB16;
-+            bytesPerPixel = 16;
              break;
--        case 24:
-+        case PIXEL_FORMAT_BGR24:
+@@ -163,7 +156,7 @@ static void desktopResizeHandler( rdpContext *p_context )
              i_chroma = VLC_CODEC_RGB24;
-+            bytesPerPixel = 24;
              break;
--        case 32:
-+        case PIXEL_FORMAT_BGRA32:
-             i_chroma = VLC_CODEC_RGB32;
-+            bytesPerPixel = 32;
+         case 32:
+-            i_chroma = VLC_CODEC_RGB32;
++            i_chroma = VLC_CODEC_ARGB;
              break;
      }
      es_format_t fmt;
@@ -87,11 +101,61 @@ index 2992090219..49986f5da9 100644
      fmt.video.i_frame_rate_base = 1000;
      fmt.video.i_frame_rate = 1000 * p_sys->f_fps;
 -    p_sys->i_framebuffersize = p_gdi->width * p_gdi->height * p_gdi->bytesPerPixel;
-+    p_sys->i_framebuffersize = p_gdi->width * p_gdi->height * bytesPerPixel;
++    p_sys->i_framebuffersize = p_gdi->width * p_gdi->height * (i_colordepth >> 3);
  
      if ( p_sys->p_block )
          p_sys->p_block = block_Realloc( p_sys->p_block, 0, p_sys->i_framebuffersize );
-@@ -237,28 +230,19 @@ static bool postConnectHandler( freerdp *p_instance )
+@@ -184,20 +177,21 @@ static void desktopResizeHandler( rdpContext *p_context )
+         p_sys->p_block = block_Alloc( p_sys->i_framebuffersize );
+ 
+     p_sys->es = es_out_Add( p_vlccontext->p_demux->out, &fmt );
++    return TRUE;
+ }
+ 
+-static void beginPaintHandler( rdpContext *p_context )
++static BOOL beginPaintHandler( rdpContext *p_context )
+ {
+     vlcrdp_context_t * p_vlccontext = (vlcrdp_context_t *) p_context;
+     demux_sys_t *p_sys = p_vlccontext->p_demux->p_sys;
+     rdpGdi *p_gdi = p_context->gdi;
+-    p_gdi->primary->hdc->hwnd->invalid->null = 1;
+-    p_gdi->primary->hdc->hwnd->ninvalid = 0;
++    p_gdi->primary->hdc->hwnd->invalid->null = TRUE;
+     if ( ! p_sys->p_block && p_sys->i_framebuffersize )
+         p_sys->p_block = block_Alloc( p_sys->i_framebuffersize );
++    return TRUE;
+ }
+ 
+-static void endPaintHandler( rdpContext *p_context )
++static BOOL endPaintHandler( rdpContext *p_context )
+ {
+     vlcrdp_context_t * p_vlccontext = (vlcrdp_context_t *) p_context;
+     demux_sys_t *p_sys = p_vlccontext->p_demux->p_sys;
+@@ -208,11 +202,12 @@ static void endPaintHandler( rdpContext *p_context )
+         p_sys->p_block->i_buffer = p_sys->i_framebuffersize;
+         memcpy( p_sys->p_block->p_buffer, p_gdi->primary_buffer, p_sys->p_block->i_buffer );
+     }
++    return TRUE;
+ }
+ 
+ /* instance handlers */
+ 
+-static bool preConnectHandler( freerdp *p_instance )
++static BOOL preConnectHandler( freerdp *p_instance )
+ {
+     vlcrdp_context_t * p_vlccontext = (vlcrdp_context_t *) p_instance->context;
+     demux_sys_t *p_sys = p_vlccontext->p_demux->p_sys;
+@@ -229,49 +224,54 @@ static bool preConnectHandler( freerdp *p_instance )
+     p_instance->settings->EncryptionMethods =
+             var_InheritBool( p_vlccontext->p_demux, CFG_PREFIX "encrypt" );
+ 
+-    return true;
++    return TRUE;
+ }
+ 
+-static bool postConnectHandler( freerdp *p_instance )
++static BOOL postConnectHandler( freerdp *p_instance )
+ {
      vlcrdp_context_t * p_vlccontext = (vlcrdp_context_t *) p_instance->context;
  
      msg_Dbg( p_vlccontext->p_demux, "connected to desktop %dx%d (%d bpp)",
@@ -109,22 +173,51 @@ index 2992090219..49986f5da9 100644
      p_instance->update->DesktopResize = desktopResizeHandler;
      p_instance->update->BeginPaint = beginPaintHandler;
      p_instance->update->EndPaint = endPaintHandler;
++    UINT32 format;
++    switch ( p_instance->settings->ColorDepth )
++    {
++        default:
++            msg_Dbg( p_vlccontext->p_demux, "no valid pixel format found for color depth %d bpp", p_instance->settings->ColorDepth);
++            /* fallthrough */
++        case 16:
++            format = PIXEL_FORMAT_RGB16;
++            break;
++        case 24:
++            format = PIXEL_FORMAT_RGB24;
++            break;
++        case 32:
++            format = PIXEL_FORMAT_ARGB32;
++            break;
++    }
  
--    gdi_init( p_instance,
+     gdi_init( p_instance,
 -                CLRBUF_16BPP |
 -#if defined(FREERDP_VERSION_MAJOR) && defined(FREERDP_VERSION_MINOR) && \
 -    !(FREERDP_VERSION_MAJOR > 1 || (FREERDP_VERSION_MAJOR == 1 && FREERDP_VERSION_MINOR >= 2))
 -                CLRBUF_24BPP |
 -#endif
 -                CLRBUF_32BPP, NULL );
-+    if ( p_instance->settings->ColorDepth > 16 )
-+        gdi_init( p_instance, PIXEL_FORMAT_XRGB32);
-+    else
-+        gdi_init( p_instance, PIXEL_FORMAT_RGB16);
++                format );
  
      desktopResizeHandler( p_instance->context );
-     return true;
-@@ -432,10 +416,6 @@ static int Open( vlc_object_t *p_this )
+-    return true;
++    return TRUE;
+ }
+ 
+-static bool authenticateHandler( freerdp *p_instance, char** ppsz_username,
++static BOOL authenticateHandler( freerdp *p_instance, char** ppsz_username,
+                                  char** ppsz_password, char** ppsz_domain )
+ {
+     VLC_UNUSED(ppsz_domain);
+     vlcrdp_context_t * p_vlccontext = (vlcrdp_context_t *) p_instance->context;
+     *ppsz_username = var_InheritString( p_vlccontext->p_demux, CFG_PREFIX "user" );
+     *ppsz_password = var_InheritString( p_vlccontext->p_demux, CFG_PREFIX "password" );
+-    return true;
++    return TRUE;
+ }
+ 
+ /*****************************************************************************
+@@ -432,10 +432,6 @@ static int Open( vlc_object_t *p_this )
      if ( p_sys->f_fps <= 0 ) p_sys->f_fps = 1.0;
      p_sys->i_frame_interval = 1000000 / p_sys->f_fps;
  
@@ -135,7 +228,7 @@ index 2992090219..49986f5da9 100644
      p_sys->p_instance = freerdp_new();
      if ( !p_sys->p_instance )
      {
-@@ -508,9 +488,6 @@ static void Close( vlc_object_t *p_this )
+@@ -512,9 +508,6 @@ static void Close( vlc_object_t *p_this )
  
      freerdp_disconnect( p_sys->p_instance );
      freerdp_free( p_sys->p_instance );
@@ -146,5 +239,5 @@ index 2992090219..49986f5da9 100644
      if ( p_sys->p_block )
          block_Release( p_sys->p_block );
 -- 
-2.14.4
+2.47.3
 
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 3/3] package/vlc: rebase patch set
  2026-02-24 18:20 [Buildroot] [PATCH 1/3] package/vlc: replace wayland-scanner patch with upstream commit Bernd Kuhls
  2026-02-24 18:20 ` [Buildroot] [PATCH 2/3] package/vlc: update freerdp2 patch Bernd Kuhls
@ 2026-02-24 18:20 ` Bernd Kuhls
  2026-06-05 12:50   ` Thomas Perale via buildroot
  2026-05-29 15:16 ` [Buildroot] [PATCH 1/3] package/vlc: replace wayland-scanner patch with upstream commit Thomas Petazzoni via buildroot
  2026-06-05 12:50 ` Thomas Perale via buildroot
  3 siblings, 1 reply; 7+ messages in thread
From: Bernd Kuhls @ 2026-02-24 18:20 UTC (permalink / raw)
  To: buildroot; +Cc: Simon Dawson

Added Upstream: tags when possible.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 .checkpackageignore                              |  3 ---
 ...uilding-of-statically-linked-vlc-binary.patch | 13 +++++++------
 ...build-use-pkg-config-to-get-tremor-libs.patch | 14 ++++++++------
 ...rror-using-uClibc-by-adding-sys-types.h.patch | 12 ++++++------
 ..._filter-opencv_example.cpp-fix-build-wi.patch | 13 ++++++++-----
 .../vlc/0010-opengl-missing-library-check.patch  | 16 ++++++++--------
 6 files changed, 37 insertions(+), 34 deletions(-)

diff --git a/.checkpackageignore b/.checkpackageignore
index cf3702acf6..2444d40ac9 100644
--- a/.checkpackageignore
+++ b/.checkpackageignore
@@ -971,11 +971,8 @@ package/vdr/0001-getloadavg.patch lib_patch.Upstream
 package/vlc/0001-Disable-building-of-statically-linked-vlc-binary.patch lib_patch.Upstream
 package/vlc/0002-automake-add-subdir-objects-option.patch lib_patch.Upstream
 package/vlc/0003-build-use-pkg-config-to-get-tremor-libs.patch lib_patch.Upstream
-package/vlc/0004-Fix-build-error-using-uClibc-by-adding-sys-types.h.patch lib_patch.Upstream
 package/vlc/0005-Don-t-assume-strerror_l-is-available.patch lib_patch.Upstream
 package/vlc/0006-posix-remove-ancient-run-time-fallback-to-real-time-.patch lib_patch.Upstream
-package/vlc/0009-modules-video_filter-opencv_example.cpp-fix-build-wi.patch lib_patch.Upstream
-package/vlc/0010-opengl-missing-library-check.patch lib_patch.Upstream
 package/vpnc/0001-Makefile-allow-to-override-the-PREFIX-variable.patch lib_patch.Upstream
 package/vpnc/0002-Makefile-allow-to-override-the-version.patch lib_patch.Upstream
 package/vpnc/0003-Makefile-allow-passing-custom-CFLAGS-CPPFLAGS.patch lib_patch.Upstream
diff --git a/package/vlc/0001-Disable-building-of-statically-linked-vlc-binary.patch b/package/vlc/0001-Disable-building-of-statically-linked-vlc-binary.patch
index 784ffa35f6..e07c5c6097 100644
--- a/package/vlc/0001-Disable-building-of-statically-linked-vlc-binary.patch
+++ b/package/vlc/0001-Disable-building-of-statically-linked-vlc-binary.patch
@@ -1,19 +1,20 @@
-From 7c2b3343a30ee53a1cded2ca5e712d8cd7d50f5f Mon Sep 17 00:00:00 2001
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
 From: Bernd Kuhls <bernd.kuhls@t-online.de>
 Date: Tue, 1 May 2018 22:27:21 +0200
 Subject: [PATCH] Disable building of statically linked vlc binary
 
-Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
+[Bernd: rebased for 3.0.23]
+Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
 ---
  Makefile.am     | 2 +-
  bin/Makefile.am | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/Makefile.am b/Makefile.am
-index 3ac82623ad..637504a3f5 100644
+index 5846e6d701..c72ceddaf2 100644
 --- a/Makefile.am
 +++ b/Makefile.am
-@@ -108,7 +108,7 @@ libvlc: libvlccore
+@@ -106,7 +106,7 @@ libvlc: libvlccore
  	cd lib && $(MAKE) $(AM_MAKEFLAGS) libvlc.la
  
  core: libvlc vlc$(EXEEXT)
@@ -23,7 +24,7 @@ index 3ac82623ad..637504a3f5 100644
  doc:
  	cd doc && $(MAKE) $(AM_MAKEFLAGS) doc
 diff --git a/bin/Makefile.am b/bin/Makefile.am
-index 2877e8b0ea..bef4160e8b 100644
+index 4de299d394..2ba28ad806 100644
 --- a/bin/Makefile.am
 +++ b/bin/Makefile.am
 @@ -6,7 +6,7 @@ bin_PROGRAMS = vlc-osx
@@ -36,5 +37,5 @@ index 2877e8b0ea..bef4160e8b 100644
  endif
  EXTRA_DIST = vlc_win32_rc.rc.in
 -- 
-2.14.4
+2.47.3
 
diff --git a/package/vlc/0003-build-use-pkg-config-to-get-tremor-libs.patch b/package/vlc/0003-build-use-pkg-config-to-get-tremor-libs.patch
index 652718b013..2f9275713c 100644
--- a/package/vlc/0003-build-use-pkg-config-to-get-tremor-libs.patch
+++ b/package/vlc/0003-build-use-pkg-config-to-get-tremor-libs.patch
@@ -1,4 +1,4 @@
-From fb257e1e204c30436b3509ea3fa9f7c5fe131dc1 Mon Sep 17 00:00:00 2001
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
 From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 Date: Tue, 16 Oct 2018 14:25:20 +0200
 Subject: [PATCH] build: use pkg-config to get tremor libs
@@ -7,16 +7,18 @@ Use PKG_ENABLE_MODULES_VLC to enable tremor based on availability of
 ogg and vorbisidec
 
 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Bernd: rebased for 3.0.23]
+Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
 ---
  configure.ac              | 9 +--------
  modules/codec/Makefile.am | 2 +-
  2 files changed, 2 insertions(+), 9 deletions(-)
 
 diff --git a/configure.ac b/configure.ac
-index 0d3222e00f..b506d735f2 100644
+index 49fc9dbb27..9d5d532133 100644
 --- a/configure.ac
 +++ b/configure.ac
-@@ -2710,14 +2710,7 @@ PKG_ENABLE_MODULES_VLC([VORBIS], [], [ogg vorbis >= 1.1 vorbisenc >= 1.1], [Vorb
+@@ -2862,14 +2862,7 @@ PKG_ENABLE_MODULES_VLC([VORBIS], [], [ogg vorbis >= 1.1 vorbisenc >= 1.1], [Vorb
  dnl
  dnl  Tremor plugin
  dnl
@@ -33,10 +35,10 @@ index 0d3222e00f..b506d735f2 100644
  dnl
  dnl  Speex plugins
 diff --git a/modules/codec/Makefile.am b/modules/codec/Makefile.am
-index 075ee2a0e9..637b1d45a6 100644
+index dd04391c1b..bdbd94880e 100644
 --- a/modules/codec/Makefile.am
 +++ b/modules/codec/Makefile.am
-@@ -318,7 +318,7 @@ codec_LTLIBRARIES += $(LTLIBdaala)
+@@ -324,7 +324,7 @@ codec_LTLIBRARIES += $(LTLIBdaala)
  libtremor_plugin_la_SOURCES = codec/vorbis.c
  libtremor_plugin_la_CPPFLAGS = $(AM_CPPFLAGS) -DMODULE_NAME_IS_tremor
  libtremor_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(codecdir)'
@@ -46,5 +48,5 @@ index 075ee2a0e9..637b1d45a6 100644
  codec_LTLIBRARIES += $(LTLIBtremor)
  
 -- 
-2.17.1
+2.47.3
 
diff --git a/package/vlc/0004-Fix-build-error-using-uClibc-by-adding-sys-types.h.patch b/package/vlc/0004-Fix-build-error-using-uClibc-by-adding-sys-types.h.patch
index a1d7189689..5c384cb717 100644
--- a/package/vlc/0004-Fix-build-error-using-uClibc-by-adding-sys-types.h.patch
+++ b/package/vlc/0004-Fix-build-error-using-uClibc-by-adding-sys-types.h.patch
@@ -1,4 +1,4 @@
-From bbb15b9cbf9353423619f2c40abdf95d861e66ba Mon Sep 17 00:00:00 2001
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
 From: Bernd Kuhls <bernd.kuhls@t-online.de>
 Date: Sat, 2 Apr 2016 16:49:54 +0200
 Subject: [PATCH] Fix build error using uClibc by adding sys/types.h
@@ -19,15 +19,15 @@ https://trac.videolan.org/vlc/ticket/16768
 
 This patch was suggested by courmisch in the trac ticket.
 
-Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
-[Patch sent upstream:
- https://mailman.videolan.org/pipermail/vlc-devel/2016-April/106952.html]
+Upstream: https://mailman.videolan.org/pipermail/vlc-devel/2016-April/106952.html
+
+Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
 ---
  include/vlc/libvlc_media.h | 2 ++
  1 file changed, 2 insertions(+)
 
 diff --git a/include/vlc/libvlc_media.h b/include/vlc/libvlc_media.h
-index 383f366b69..1cbf00c3e3 100644
+index 01950493e9..9b84aa4835 100644
 --- a/include/vlc/libvlc_media.h
 +++ b/include/vlc/libvlc_media.h
 @@ -26,6 +26,8 @@
@@ -40,5 +40,5 @@ index 383f366b69..1cbf00c3e3 100644
  extern "C" {
  # endif
 -- 
-2.14.4
+2.47.3
 
diff --git a/package/vlc/0009-modules-video_filter-opencv_example.cpp-fix-build-wi.patch b/package/vlc/0009-modules-video_filter-opencv_example.cpp-fix-build-wi.patch
index 952f9fdf51..7cf65d66ee 100644
--- a/package/vlc/0009-modules-video_filter-opencv_example.cpp-fix-build-wi.patch
+++ b/package/vlc/0009-modules-video_filter-opencv_example.cpp-fix-build-wi.patch
@@ -1,4 +1,4 @@
-From 57b1e723b73da4c8d42c20d4e28040ec4c0edd85 Mon Sep 17 00:00:00 2001
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
 From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 Date: Fri, 28 Feb 2020 14:29:47 +0100
 Subject: [PATCH] modules/video_filter/opencv_example.cpp: fix build with
@@ -18,17 +18,20 @@ Indeed, CV_RGB is defined as cv::Scalar instead of cvScalar since
 version 3.4.2 and
 https://github.com/opencv/opencv/commit/7f9253ea0a9fe2635926379420002dbf0c3fce0f
 
+Upstream: https://patches.videolan.org/patch/26655
+
 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
-[Upstream status: https://patches.videolan.org/patch/26655]
+[Bernd: rebased for 3.0.23]
+Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
 ---
  modules/video_filter/opencv_example.cpp | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/modules/video_filter/opencv_example.cpp b/modules/video_filter/opencv_example.cpp
-index 1334cd4c36..1a8d574f7a 100644
+index a7a0bd7821..23483f0974 100644
 --- a/modules/video_filter/opencv_example.cpp
 +++ b/modules/video_filter/opencv_example.cpp
-@@ -202,7 +202,7 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
+@@ -197,7 +197,7 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
              pt2.x = (r->x+r->width)*scale;
              pt1.y = r->y*scale;
              pt2.y = (r->y+r->height)*scale;
@@ -38,5 +41,5 @@ index 1334cd4c36..1a8d574f7a 100644
              *(CvRect*)(&(p_sys->event_info.p_region[i])) = *r;
              p_sys->event_info.p_region[i].i_id = p_sys->i_id++;
 -- 
-2.25.0
+2.47.3
 
diff --git a/package/vlc/0010-opengl-missing-library-check.patch b/package/vlc/0010-opengl-missing-library-check.patch
index 3a28fe34e3..fc3a139842 100644
--- a/package/vlc/0010-opengl-missing-library-check.patch
+++ b/package/vlc/0010-opengl-missing-library-check.patch
@@ -1,4 +1,4 @@
-From 4ab41404cb85684125d73977cadebf83bbc246f5 Mon Sep 17 00:00:00 2001
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
 From: =?UTF-8?q?R=C3=A9mi=20Denis-Courmont?= <remi@remlab.net>
 Date: Sat, 22 Jan 2022 11:34:38 +0200
 Subject: [PATCH] opengl: missing library check
@@ -12,19 +12,19 @@ is platform-dependent. It is common for the header to be present while
 the library is absent with "multilib" installations (i.e. Linux
 installation with multiple architectures).
 
-Downloaded from upstream commit:
-https://code.videolan.org/videolan/vlc/-/commit/4ab41404cb85684125d73977cadebf83bbc246f5
+Upstream: https://code.videolan.org/videolan/vlc/-/commit/4ab41404cb85684125d73977cadebf83bbc246f5
 
-Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
+[Bernd: rebased for 3.0.23]
+Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
 ---
  configure.ac | 9 ++++++---
  1 file changed, 6 insertions(+), 3 deletions(-)
 
 diff --git a/configure.ac b/configure.ac
-index 2f50808d597..0d57fadbf8b 100644
+index 67316b589b..7196a69017 100644
 --- a/configure.ac
 +++ b/configure.ac
-@@ -3169,7 +3169,6 @@ have_gl="no"
+@@ -3138,7 +3138,6 @@ have_gl="no"
  PKG_CHECK_MODULES([GL], [gl], [
    have_gl="yes"
  ], [
@@ -32,7 +32,7 @@ index 2f50808d597..0d57fadbf8b 100644
    AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
  #ifdef _WIN32
  # include <GL/glew.h>
-@@ -3179,13 +3178,17 @@ PKG_CHECK_MODULES([GL], [gl], [
+@@ -3148,13 +3147,17 @@ PKG_CHECK_MODULES([GL], [gl], [
      [int t0 = GL_TEXTURE0;]])
    ], [
      GL_CFLAGS=""
@@ -53,5 +53,5 @@ index 2f50808d597..0d57fadbf8b 100644
  ])
  AM_CONDITIONAL([HAVE_GL], [test "${have_gl}" = "yes"])
 -- 
-GitLab
+2.47.3
 
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH 1/3] package/vlc: replace wayland-scanner patch with upstream commit
  2026-02-24 18:20 [Buildroot] [PATCH 1/3] package/vlc: replace wayland-scanner patch with upstream commit Bernd Kuhls
  2026-02-24 18:20 ` [Buildroot] [PATCH 2/3] package/vlc: update freerdp2 patch Bernd Kuhls
  2026-02-24 18:20 ` [Buildroot] [PATCH 3/3] package/vlc: rebase patch set Bernd Kuhls
@ 2026-05-29 15:16 ` Thomas Petazzoni via buildroot
  2026-06-05 12:50 ` Thomas Perale via buildroot
  3 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-05-29 15:16 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot, Simon Dawson

On Tue, Feb 24, 2026 at 07:20:14PM +0100, Bernd Kuhls wrote:
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Series applied to master, thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH 3/3] package/vlc: rebase patch set
  2026-02-24 18:20 ` [Buildroot] [PATCH 3/3] package/vlc: rebase patch set Bernd Kuhls
@ 2026-06-05 12:50   ` Thomas Perale via buildroot
  0 siblings, 0 replies; 7+ messages in thread
From: Thomas Perale via buildroot @ 2026-06-05 12:50 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: Thomas Perale, buildroot

In reply of:
> Added Upstream: tags when possible.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied to 2025.02.x & 2026.02.x. Thanks

> ---
>  .checkpackageignore                              |  3 ---
>  ...uilding-of-statically-linked-vlc-binary.patch | 13 +++++++------
>  ...build-use-pkg-config-to-get-tremor-libs.patch | 14 ++++++++------
>  ...rror-using-uClibc-by-adding-sys-types.h.patch | 12 ++++++------
>  ..._filter-opencv_example.cpp-fix-build-wi.patch | 13 ++++++++-----
>  .../vlc/0010-opengl-missing-library-check.patch  | 16 ++++++++--------
>  6 files changed, 37 insertions(+), 34 deletions(-)
> 
> diff --git a/.checkpackageignore b/.checkpackageignore
> index cf3702acf6..2444d40ac9 100644
> --- a/.checkpackageignore
> +++ b/.checkpackageignore
> @@ -971,11 +971,8 @@ package/vdr/0001-getloadavg.patch lib_patch.Upstream
>  package/vlc/0001-Disable-building-of-statically-linked-vlc-binary.patch lib_patch.Upstream
>  package/vlc/0002-automake-add-subdir-objects-option.patch lib_patch.Upstream
>  package/vlc/0003-build-use-pkg-config-to-get-tremor-libs.patch lib_patch.Upstream
> -package/vlc/0004-Fix-build-error-using-uClibc-by-adding-sys-types.h.patch lib_patch.Upstream
>  package/vlc/0005-Don-t-assume-strerror_l-is-available.patch lib_patch.Upstream
>  package/vlc/0006-posix-remove-ancient-run-time-fallback-to-real-time-.patch lib_patch.Upstream
> -package/vlc/0009-modules-video_filter-opencv_example.cpp-fix-build-wi.patch lib_patch.Upstream
> -package/vlc/0010-opengl-missing-library-check.patch lib_patch.Upstream
>  package/vpnc/0001-Makefile-allow-to-override-the-PREFIX-variable.patch lib_patch.Upstream
>  package/vpnc/0002-Makefile-allow-to-override-the-version.patch lib_patch.Upstream
>  package/vpnc/0003-Makefile-allow-passing-custom-CFLAGS-CPPFLAGS.patch lib_patch.Upstream
> diff --git a/package/vlc/0001-Disable-building-of-statically-linked-vlc-binary.patch b/package/vlc/0001-Disable-building-of-statically-linked-vlc-binary.patch
> index 784ffa35f6..e07c5c6097 100644
> --- a/package/vlc/0001-Disable-building-of-statically-linked-vlc-binary.patch
> +++ b/package/vlc/0001-Disable-building-of-statically-linked-vlc-binary.patch
> @@ -1,19 +1,20 @@
> -From 7c2b3343a30ee53a1cded2ca5e712d8cd7d50f5f Mon Sep 17 00:00:00 2001
> +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
>  From: Bernd Kuhls <bernd.kuhls@t-online.de>
>  Date: Tue, 1 May 2018 22:27:21 +0200
>  Subject: [PATCH] Disable building of statically linked vlc binary
>  
> -Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> +[Bernd: rebased for 3.0.23]
> +Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
>  ---
>   Makefile.am     | 2 +-
>   bin/Makefile.am | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>  
>  diff --git a/Makefile.am b/Makefile.am
> -index 3ac82623ad..637504a3f5 100644
> +index 5846e6d701..c72ceddaf2 100644
>  --- a/Makefile.am
>  +++ b/Makefile.am
> -@@ -108,7 +108,7 @@ libvlc: libvlccore
> +@@ -106,7 +106,7 @@ libvlc: libvlccore
>   	cd lib && $(MAKE) $(AM_MAKEFLAGS) libvlc.la
>   
>   core: libvlc vlc$(EXEEXT)
> @@ -23,7 +24,7 @@ index 3ac82623ad..637504a3f5 100644
>   doc:
>   	cd doc && $(MAKE) $(AM_MAKEFLAGS) doc
>  diff --git a/bin/Makefile.am b/bin/Makefile.am
> -index 2877e8b0ea..bef4160e8b 100644
> +index 4de299d394..2ba28ad806 100644
>  --- a/bin/Makefile.am
>  +++ b/bin/Makefile.am
>  @@ -6,7 +6,7 @@ bin_PROGRAMS = vlc-osx
> @@ -36,5 +37,5 @@ index 2877e8b0ea..bef4160e8b 100644
>   endif
>   EXTRA_DIST = vlc_win32_rc.rc.in
>  -- 
> -2.14.4
> +2.47.3
>  
> diff --git a/package/vlc/0003-build-use-pkg-config-to-get-tremor-libs.patch b/package/vlc/0003-build-use-pkg-config-to-get-tremor-libs.patch
> index 652718b013..2f9275713c 100644
> --- a/package/vlc/0003-build-use-pkg-config-to-get-tremor-libs.patch
> +++ b/package/vlc/0003-build-use-pkg-config-to-get-tremor-libs.patch
> @@ -1,4 +1,4 @@
> -From fb257e1e204c30436b3509ea3fa9f7c5fe131dc1 Mon Sep 17 00:00:00 2001
> +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
>  From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>  Date: Tue, 16 Oct 2018 14:25:20 +0200
>  Subject: [PATCH] build: use pkg-config to get tremor libs
> @@ -7,16 +7,18 @@ Use PKG_ENABLE_MODULES_VLC to enable tremor based on availability of
>  ogg and vorbisidec
>  
>  Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +[Bernd: rebased for 3.0.23]
> +Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
>  ---
>   configure.ac              | 9 +--------
>   modules/codec/Makefile.am | 2 +-
>   2 files changed, 2 insertions(+), 9 deletions(-)
>  
>  diff --git a/configure.ac b/configure.ac
> -index 0d3222e00f..b506d735f2 100644
> +index 49fc9dbb27..9d5d532133 100644
>  --- a/configure.ac
>  +++ b/configure.ac
> -@@ -2710,14 +2710,7 @@ PKG_ENABLE_MODULES_VLC([VORBIS], [], [ogg vorbis >= 1.1 vorbisenc >= 1.1], [Vorb
> +@@ -2862,14 +2862,7 @@ PKG_ENABLE_MODULES_VLC([VORBIS], [], [ogg vorbis >= 1.1 vorbisenc >= 1.1], [Vorb
>   dnl
>   dnl  Tremor plugin
>   dnl
> @@ -33,10 +35,10 @@ index 0d3222e00f..b506d735f2 100644
>   dnl
>   dnl  Speex plugins
>  diff --git a/modules/codec/Makefile.am b/modules/codec/Makefile.am
> -index 075ee2a0e9..637b1d45a6 100644
> +index dd04391c1b..bdbd94880e 100644
>  --- a/modules/codec/Makefile.am
>  +++ b/modules/codec/Makefile.am
> -@@ -318,7 +318,7 @@ codec_LTLIBRARIES += $(LTLIBdaala)
> +@@ -324,7 +324,7 @@ codec_LTLIBRARIES += $(LTLIBdaala)
>   libtremor_plugin_la_SOURCES = codec/vorbis.c
>   libtremor_plugin_la_CPPFLAGS = $(AM_CPPFLAGS) -DMODULE_NAME_IS_tremor
>   libtremor_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(codecdir)'
> @@ -46,5 +48,5 @@ index 075ee2a0e9..637b1d45a6 100644
>   codec_LTLIBRARIES += $(LTLIBtremor)
>   
>  -- 
> -2.17.1
> +2.47.3
>  
> diff --git a/package/vlc/0004-Fix-build-error-using-uClibc-by-adding-sys-types.h.patch b/package/vlc/0004-Fix-build-error-using-uClibc-by-adding-sys-types.h.patch
> index a1d7189689..5c384cb717 100644
> --- a/package/vlc/0004-Fix-build-error-using-uClibc-by-adding-sys-types.h.patch
> +++ b/package/vlc/0004-Fix-build-error-using-uClibc-by-adding-sys-types.h.patch
> @@ -1,4 +1,4 @@
> -From bbb15b9cbf9353423619f2c40abdf95d861e66ba Mon Sep 17 00:00:00 2001
> +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
>  From: Bernd Kuhls <bernd.kuhls@t-online.de>
>  Date: Sat, 2 Apr 2016 16:49:54 +0200
>  Subject: [PATCH] Fix build error using uClibc by adding sys/types.h
> @@ -19,15 +19,15 @@ https://trac.videolan.org/vlc/ticket/16768
>  
>  This patch was suggested by courmisch in the trac ticket.
>  
> -Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> -[Patch sent upstream:
> - https://mailman.videolan.org/pipermail/vlc-devel/2016-April/106952.html]
> +Upstream: https://mailman.videolan.org/pipermail/vlc-devel/2016-April/106952.html
> +
> +Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
>  ---
>   include/vlc/libvlc_media.h | 2 ++
>   1 file changed, 2 insertions(+)
>  
>  diff --git a/include/vlc/libvlc_media.h b/include/vlc/libvlc_media.h
> -index 383f366b69..1cbf00c3e3 100644
> +index 01950493e9..9b84aa4835 100644
>  --- a/include/vlc/libvlc_media.h
>  +++ b/include/vlc/libvlc_media.h
>  @@ -26,6 +26,8 @@
> @@ -40,5 +40,5 @@ index 383f366b69..1cbf00c3e3 100644
>   extern "C" {
>   # endif
>  -- 
> -2.14.4
> +2.47.3
>  
> diff --git a/package/vlc/0009-modules-video_filter-opencv_example.cpp-fix-build-wi.patch b/package/vlc/0009-modules-video_filter-opencv_example.cpp-fix-build-wi.patch
> index 952f9fdf51..7cf65d66ee 100644
> --- a/package/vlc/0009-modules-video_filter-opencv_example.cpp-fix-build-wi.patch
> +++ b/package/vlc/0009-modules-video_filter-opencv_example.cpp-fix-build-wi.patch
> @@ -1,4 +1,4 @@
> -From 57b1e723b73da4c8d42c20d4e28040ec4c0edd85 Mon Sep 17 00:00:00 2001
> +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
>  From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>  Date: Fri, 28 Feb 2020 14:29:47 +0100
>  Subject: [PATCH] modules/video_filter/opencv_example.cpp: fix build with
> @@ -18,17 +18,20 @@ Indeed, CV_RGB is defined as cv::Scalar instead of cvScalar since
>  version 3.4.2 and
>  https://github.com/opencv/opencv/commit/7f9253ea0a9fe2635926379420002dbf0c3fce0f
>  
> +Upstream: https://patches.videolan.org/patch/26655
> +
>  Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> -[Upstream status: https://patches.videolan.org/patch/26655]
> +[Bernd: rebased for 3.0.23]
> +Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
>  ---
>   modules/video_filter/opencv_example.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>  
>  diff --git a/modules/video_filter/opencv_example.cpp b/modules/video_filter/opencv_example.cpp
> -index 1334cd4c36..1a8d574f7a 100644
> +index a7a0bd7821..23483f0974 100644
>  --- a/modules/video_filter/opencv_example.cpp
>  +++ b/modules/video_filter/opencv_example.cpp
> -@@ -202,7 +202,7 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
> +@@ -197,7 +197,7 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
>               pt2.x = (r->x+r->width)*scale;
>               pt1.y = r->y*scale;
>               pt2.y = (r->y+r->height)*scale;
> @@ -38,5 +41,5 @@ index 1334cd4c36..1a8d574f7a 100644
>               *(CvRect*)(&(p_sys->event_info.p_region[i])) = *r;
>               p_sys->event_info.p_region[i].i_id = p_sys->i_id++;
>  -- 
> -2.25.0
> +2.47.3
>  
> diff --git a/package/vlc/0010-opengl-missing-library-check.patch b/package/vlc/0010-opengl-missing-library-check.patch
> index 3a28fe34e3..fc3a139842 100644
> --- a/package/vlc/0010-opengl-missing-library-check.patch
> +++ b/package/vlc/0010-opengl-missing-library-check.patch
> @@ -1,4 +1,4 @@
> -From 4ab41404cb85684125d73977cadebf83bbc246f5 Mon Sep 17 00:00:00 2001
> +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
>  From: =?UTF-8?q?R=C3=A9mi=20Denis-Courmont?= <remi@remlab.net>
>  Date: Sat, 22 Jan 2022 11:34:38 +0200
>  Subject: [PATCH] opengl: missing library check
> @@ -12,19 +12,19 @@ is platform-dependent. It is common for the header to be present while
>  the library is absent with "multilib" installations (i.e. Linux
>  installation with multiple architectures).
>  
> -Downloaded from upstream commit:
> -https://code.videolan.org/videolan/vlc/-/commit/4ab41404cb85684125d73977cadebf83bbc246f5
> +Upstream: https://code.videolan.org/videolan/vlc/-/commit/4ab41404cb85684125d73977cadebf83bbc246f5
>  
> -Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> +[Bernd: rebased for 3.0.23]
> +Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
>  ---
>   configure.ac | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
>  
>  diff --git a/configure.ac b/configure.ac
> -index 2f50808d597..0d57fadbf8b 100644
> +index 67316b589b..7196a69017 100644
>  --- a/configure.ac
>  +++ b/configure.ac
> -@@ -3169,7 +3169,6 @@ have_gl="no"
> +@@ -3138,7 +3138,6 @@ have_gl="no"
>   PKG_CHECK_MODULES([GL], [gl], [
>     have_gl="yes"
>   ], [
> @@ -32,7 +32,7 @@ index 2f50808d597..0d57fadbf8b 100644
>     AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
>   #ifdef _WIN32
>   # include <GL/glew.h>
> -@@ -3179,13 +3178,17 @@ PKG_CHECK_MODULES([GL], [gl], [
> +@@ -3148,13 +3147,17 @@ PKG_CHECK_MODULES([GL], [gl], [
>       [int t0 = GL_TEXTURE0;]])
>     ], [
>       GL_CFLAGS=""
> @@ -53,5 +53,5 @@ index 2f50808d597..0d57fadbf8b 100644
>   ])
>   AM_CONDITIONAL([HAVE_GL], [test "${have_gl}" = "yes"])
>  -- 
> -GitLab
> +2.47.3
>  
> -- 
> 2.47.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH 1/3] package/vlc: replace wayland-scanner patch with upstream commit
  2026-02-24 18:20 [Buildroot] [PATCH 1/3] package/vlc: replace wayland-scanner patch with upstream commit Bernd Kuhls
                   ` (2 preceding siblings ...)
  2026-05-29 15:16 ` [Buildroot] [PATCH 1/3] package/vlc: replace wayland-scanner patch with upstream commit Thomas Petazzoni via buildroot
@ 2026-06-05 12:50 ` Thomas Perale via buildroot
  3 siblings, 0 replies; 7+ messages in thread
From: Thomas Perale via buildroot @ 2026-06-05 12:50 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: Thomas Perale, buildroot

In reply of:
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied to 2025.02.x & 2026.02.x. Thanks

> ---
>  .checkpackageignore                           |  1 -
>  ...t-possible-to-override-wayland-scann.patch | 39 +++++++++++++++
>  ...o-use-AC_PATH_PROG-to-check-for-wayl.patch | 50 -------------------
>  package/vlc/vlc.mk                            |  1 +
>  4 files changed, 40 insertions(+), 51 deletions(-)
>  create mode 100644 package/vlc/0008-configure-make-it-possible-to-override-wayland-scann.patch
>  delete mode 100644 package/vlc/0008-configure.ac-also-use-AC_PATH_PROG-to-check-for-wayl.patch
> 
> diff --git a/.checkpackageignore b/.checkpackageignore
> index 695e0d50c6..3ad99d0eb1 100644
> --- a/.checkpackageignore
> +++ b/.checkpackageignore
> @@ -975,7 +975,6 @@ package/vlc/0004-Fix-build-error-using-uClibc-by-adding-sys-types.h.patch lib_pa
>  package/vlc/0005-Don-t-assume-strerror_l-is-available.patch lib_patch.Upstream
>  package/vlc/0006-posix-remove-ancient-run-time-fallback-to-real-time-.patch lib_patch.Upstream
>  package/vlc/0007-Add-support-for-freerdp2.patch lib_patch.Upstream
> -package/vlc/0008-configure.ac-also-use-AC_PATH_PROG-to-check-for-wayl.patch lib_patch.Upstream
>  package/vlc/0009-modules-video_filter-opencv_example.cpp-fix-build-wi.patch lib_patch.Upstream
>  package/vlc/0010-opengl-missing-library-check.patch lib_patch.Upstream
>  package/vpnc/0001-Makefile-allow-to-override-the-PREFIX-variable.patch lib_patch.Upstream
> diff --git a/package/vlc/0008-configure-make-it-possible-to-override-wayland-scann.patch b/package/vlc/0008-configure-make-it-possible-to-override-wayland-scann.patch
> new file mode 100644
> index 0000000000..b89687ec74
> --- /dev/null
> +++ b/package/vlc/0008-configure-make-it-possible-to-override-wayland-scann.patch
> @@ -0,0 +1,39 @@
> +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
> +From: Yann Lochet <yann@l0chet.fr>
> +Date: Fri, 25 Nov 2022 16:20:45 +0100
> +Subject: [PATCH] configure: make it possible to override wayland-scanner
> +
> +When cross-compiling, PKG_CONFIG might pick up the wayland-scanner
> +from the sysroot.
> +
> +Upstream: https://code.videolan.org/videolan/vlc/-/commit/75e52f617bf3273f4883b56c4175d68211e02d14
> +
> +[Bernd: rebased for 3.0.23]
> +Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> +---
> + configure.ac | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/configure.ac b/configure.ac
> +index a91fc73172..5e8821dea9 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -3277,6 +3277,7 @@ AS_IF([test "${enable_wayland}" = "yes"], [
> +     ])
> + 
> +     AC_MSG_CHECKING([for the Wayland scanner])
> ++    AS_VAR_SET_IF(WAYLAND_SCANNER, [],[
> +     PKG_CHECK_EXISTS([wayland-scanner], [
> +       WAYLAND_SCANNER="$(${PKG_CONFIG} wayland-scanner --variable wayland_scanner)"
> +       AC_MSG_RESULT([${WAYLAND_SCANNER}])
> +@@ -3284,6 +3285,7 @@ AS_IF([test "${enable_wayland}" = "yes"], [
> +       AC_MSG_RESULT([not found])
> +       AC_MSG_ERROR([$(${PKG_CONFIG} --print-errors wayland-scanner)])
> +     ])
> ++    ])
> + 
> +     have_wayland="yes"
> + 
> +-- 
> +2.47.3
> +
> diff --git a/package/vlc/0008-configure.ac-also-use-AC_PATH_PROG-to-check-for-wayl.patch b/package/vlc/0008-configure.ac-also-use-AC_PATH_PROG-to-check-for-wayl.patch
> deleted file mode 100644
> index 2b74fe0d39..0000000000
> --- a/package/vlc/0008-configure.ac-also-use-AC_PATH_PROG-to-check-for-wayl.patch
> +++ /dev/null
> @@ -1,50 +0,0 @@
> -From 27635f902831fac898586f1f3dc98369f12582c9 Mon Sep 17 00:00:00 2001
> -From: Bernd Kuhls <bernd.kuhls@t-online.de>
> -Date: Sun, 26 Aug 2018 12:51:04 +0200
> -Subject: [PATCH] configure.ac: also use AC_PATH_PROG to check for
> - wayland-scanner
> -
> -When cross-compiling the .pc file might point to the wrong
> -wayland-scanner binary (target rather than host) resulting in a
> -non-executable and wrong scanner.
> -Try searching the PATH first, and if that fails fall back into
> -pkg-config.
> -
> -Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ----
> - configure.ac | 19 +++++++++++--------
> - 1 file changed, 11 insertions(+), 8 deletions(-)
> -
> -diff --git a/configure.ac b/configure.ac
> -index 4808b8becf..a18641ed23 100644
> ---- a/configure.ac
> -+++ b/configure.ac
> -@@ -3140,14 +3140,17 @@ AS_IF([test "${enable_wayland}" != "no"], [
> -       AC_MSG_ERROR([$(${PKG_CONFIG} --print-errors 'wayland-protocols >= 1.4')])
> -     ])
> - 
> --    AC_MSG_CHECKING([for the Wayland scanner])
> --    PKG_CHECK_EXISTS([wayland-scanner], [
> --      WAYLAND_SCANNER="$(${PKG_CONFIG} wayland-scanner --variable wayland_scanner)"
> --      AC_MSG_RESULT([${WAYLAND_SCANNER}])
> --    ], [
> --      AC_MSG_RESULT([not found])
> --      AC_MSG_ERROR([$(${PKG_CONFIG} --print-errors wayland-scanner)])
> --    ])
> -+    AC_PATH_PROG([WAYLAND_SCANNER], [wayland-scanner])
> -+    if test "x$WAYLAND_SCANNER" = x; then
> -+        AC_MSG_CHECKING([for the Wayland scanner])
> -+        PKG_CHECK_EXISTS([wayland-scanner], [
> -+          WAYLAND_SCANNER="$(${PKG_CONFIG} wayland-scanner --variable wayland_scanner)"
> -+          AC_MSG_RESULT([${WAYLAND_SCANNER}])
> -+        ], [
> -+          AC_MSG_RESULT([not found])
> -+          AC_MSG_ERROR([$(${PKG_CONFIG} --print-errors wayland-scanner)])
> -+        ])
> -+    fi
> - 
> -     have_wayland="yes"
> - 
> --- 
> -2.18.0
> -
> diff --git a/package/vlc/vlc.mk b/package/vlc/vlc.mk
> index 07aeefd193..0ce6662353 100644
> --- a/package/vlc/vlc.mk
> +++ b/package/vlc/vlc.mk
> @@ -527,6 +527,7 @@ VLC_CONF_OPTS += --disable-udev
>  endif
>  
>  ifeq ($(BR2_PACKAGE_WAYLAND)$(BR2_PACKAGE_WAYLAND_PROTOCOLS),yy)
> +VLC_CONF_ENV += WAYLAND_SCANNER=$(HOST_DIR)/bin/wayland-scanner
>  VLC_CONF_OPTS += --enable-wayland
>  VLC_DEPENDENCIES += wayland wayland-protocols
>  else
> -- 
> 2.47.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH 2/3] package/vlc: update freerdp2 patch
  2026-02-24 18:20 ` [Buildroot] [PATCH 2/3] package/vlc: update freerdp2 patch Bernd Kuhls
@ 2026-06-05 12:50   ` Thomas Perale via buildroot
  0 siblings, 0 replies; 7+ messages in thread
From: Thomas Perale via buildroot @ 2026-06-05 12:50 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: Thomas Perale, buildroot

In reply of:
> Replace Gentoo patch from 2018 with rebased version of an upstream
> commit from 2022 which also fixes build errors introduced by gcc 14.x:
> 
> access/rdp.c: In function 'postConnectHandler':
> access/rdp.c:238:39: error: assignment to 'pDesktopResize' {aka 'int
>  (*)(struct rdp_context *)'} from incompatible pointer type 'void
>  (*)(rdpContext *)' {aka 'void (*)(struct rdp_context *)'}
>  [-Wincompatible-pointer-types]
>   238 |     p_instance->update->DesktopResize = desktopResizeHandler;
>       |                                       ^
> 
> No autobuilder error was recorded, the build error can be reproduced
> with this defconfig:
> 
> BR2_x86_64=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_PACKAGE_VLC=y
> BR2_PACKAGE_FREERDP=y
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied to 2025.02.x & 2026.02.x. Thanks

> ---
>  .checkpackageignore                           |   1 -
>  .../vlc/0007-Add-support-for-freerdp2.patch   | 173 ++++++++++++++----
>  2 files changed, 133 insertions(+), 41 deletions(-)
> 
> diff --git a/.checkpackageignore b/.checkpackageignore
> index 3ad99d0eb1..cf3702acf6 100644
> --- a/.checkpackageignore
> +++ b/.checkpackageignore
> @@ -974,7 +974,6 @@ package/vlc/0003-build-use-pkg-config-to-get-tremor-libs.patch lib_patch.Upstrea
>  package/vlc/0004-Fix-build-error-using-uClibc-by-adding-sys-types.h.patch lib_patch.Upstream
>  package/vlc/0005-Don-t-assume-strerror_l-is-available.patch lib_patch.Upstream
>  package/vlc/0006-posix-remove-ancient-run-time-fallback-to-real-time-.patch lib_patch.Upstream
> -package/vlc/0007-Add-support-for-freerdp2.patch lib_patch.Upstream
>  package/vlc/0009-modules-video_filter-opencv_example.cpp-fix-build-wi.patch lib_patch.Upstream
>  package/vlc/0010-opengl-missing-library-check.patch lib_patch.Upstream
>  package/vpnc/0001-Makefile-allow-to-override-the-PREFIX-variable.patch lib_patch.Upstream
> diff --git a/package/vlc/0007-Add-support-for-freerdp2.patch b/package/vlc/0007-Add-support-for-freerdp2.patch
> index 75f095545b..c3148600ca 100644
> --- a/package/vlc/0007-Add-support-for-freerdp2.patch
> +++ b/package/vlc/0007-Add-support-for-freerdp2.patch
> @@ -1,32 +1,32 @@
> -From 3780bbb20bf35aa8f21ac672da3f0c5f408468e9 Mon Sep 17 00:00:00 2001
> -From: Bernd Kuhls <bernd.kuhls@t-online.de>
> -Date: Thu, 16 Aug 2018 12:27:40 +0200
> -Subject: [PATCH] Add support for freerdp2
> +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
> +From: Juliane de Sartiges <jill@videolabs.io>
> +Date: Wed, 27 Jul 2022 09:32:25 +0200
> +Subject: [PATCH] freerdp: update to freerdp2 api
>  
> -Downloaded from
> -https://gitweb.gentoo.org/repo/gentoo.git/tree/media-video/vlc/files/vlc-2.2.8-freerdp-2.patch
> +Upstream: https://code.videolan.org/videolan/vlc/-/commit/95e7bba6105bd8c2b8ea9cabc02c8dfe7411cab2
>  
> -Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> +[Bernd: rebased for 3.0.23]
> +Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
>  ---
>   configure.ac         |  2 +-
> - modules/access/rdp.c | 51 ++++++++++++++-------------------------------------
> - 2 files changed, 15 insertions(+), 38 deletions(-)
> + modules/access/rdp.c | 85 ++++++++++++++++++++------------------------
> + 2 files changed, 40 insertions(+), 47 deletions(-)
>  
>  diff --git a/configure.ac b/configure.ac
> -index bfe43512a2..4808b8becf 100644
> +index d96287d3e0..a91fc73172 100644
>  --- a/configure.ac
>  +++ b/configure.ac
> -@@ -1992,7 +1992,7 @@ PKG_ENABLE_MODULES_VLC([VNC], [vnc], [libvncclient >= 0.9.9], (VNC/rfb client su
> +@@ -2194,7 +2194,7 @@ PKG_ENABLE_MODULES_VLC([VNC], [vnc], [libvncclient >= 0.9.9], (VNC/rfb client su
>   
>   dnl  RDP/Remote Desktop access module
>   dnl
>  -PKG_ENABLE_MODULES_VLC([FREERDP], [rdp], [freerdp >= 1.0.1], (RDP/Remote Desktop client support) )
> -+PKG_ENABLE_MODULES_VLC([FREERDP], [rdp], [freerdp2 >= 1.0.1], (RDP/Remote Desktop client support) )
> ++PKG_ENABLE_MODULES_VLC([FREERDP], [rdp], [freerdp2 >= 2.0.0], (RDP/Remote Desktop client support) )
>   
>   dnl
>   dnl  Real RTSP plugin
>  diff --git a/modules/access/rdp.c b/modules/access/rdp.c
> -index 2992090219..49986f5da9 100644
> +index 0c39663c64..04ae005938 100644
>  --- a/modules/access/rdp.c
>  +++ b/modules/access/rdp.c
>  @@ -45,18 +45,6 @@
> @@ -48,37 +48,51 @@ index 2992090219..49986f5da9 100644
>   #include <errno.h>
>   #ifdef HAVE_POLL
>   # include <poll.h>
> -@@ -144,6 +132,7 @@ static void desktopResizeHandler( rdpContext *p_context )
> +@@ -75,6 +63,8 @@
> + 
> + #define CFG_PREFIX "rdp-"
> + 
> ++#define FREERDP_PIXEL_BPP(_format) (_format >> 24)
> ++
> + /*****************************************************************************
> +  * Module descriptor
> +  *****************************************************************************/
> +@@ -139,11 +129,12 @@ typedef struct vlcrdp_context_t vlcrdp_context_t;
> + 
> + /* updates handlers */
> + 
> +-static void desktopResizeHandler( rdpContext *p_context )
> ++static BOOL desktopResizeHandler( rdpContext *p_context )
> + {
>       vlcrdp_context_t * p_vlccontext = (vlcrdp_context_t *) p_context;
>       demux_sys_t *p_sys = p_vlccontext->p_demux->p_sys;
>       rdpGdi *p_gdi = p_context->gdi;
> -+    unsigned bytesPerPixel;
> ++    int i_colordepth = FREERDP_PIXEL_BPP( p_gdi->dstFormat );
>   
>       if ( p_sys->es )
>       {
> -@@ -153,17 +142,21 @@ static void desktopResizeHandler( rdpContext *p_context )
> +@@ -151,11 +142,13 @@ static void desktopResizeHandler( rdpContext *p_context )
> +         p_sys->es = NULL;
> +     }
>   
> -     /* Now init and fill es format */
> +-    /* Now init and fill es format */
>       vlc_fourcc_t i_chroma;
>  -    switch( p_gdi->bytesPerPixel )
> -+    switch( p_gdi->dstFormat )
> ++    /* Now init and fill es format */
> ++    switch ( i_colordepth )
>       {
>           default:
> --        case 16:
> -+            msg_Dbg( p_vlccontext->p_demux, "unhandled dstFormat %x bpp", p_gdi->dstFormat);
> -+        case PIXEL_FORMAT_BGR16:
> ++            msg_Dbg( p_vlccontext->p_demux, "invalid color depth %d", i_colordepth);
> ++            /* fallthrough */
> +         case 16:
>               i_chroma = VLC_CODEC_RGB16;
> -+            bytesPerPixel = 16;
>               break;
> --        case 24:
> -+        case PIXEL_FORMAT_BGR24:
> +@@ -163,7 +156,7 @@ static void desktopResizeHandler( rdpContext *p_context )
>               i_chroma = VLC_CODEC_RGB24;
> -+            bytesPerPixel = 24;
>               break;
> --        case 32:
> -+        case PIXEL_FORMAT_BGRA32:
> -             i_chroma = VLC_CODEC_RGB32;
> -+            bytesPerPixel = 32;
> +         case 32:
> +-            i_chroma = VLC_CODEC_RGB32;
> ++            i_chroma = VLC_CODEC_ARGB;
>               break;
>       }
>       es_format_t fmt;
> @@ -87,11 +101,61 @@ index 2992090219..49986f5da9 100644
>       fmt.video.i_frame_rate_base = 1000;
>       fmt.video.i_frame_rate = 1000 * p_sys->f_fps;
>  -    p_sys->i_framebuffersize = p_gdi->width * p_gdi->height * p_gdi->bytesPerPixel;
> -+    p_sys->i_framebuffersize = p_gdi->width * p_gdi->height * bytesPerPixel;
> ++    p_sys->i_framebuffersize = p_gdi->width * p_gdi->height * (i_colordepth >> 3);
>   
>       if ( p_sys->p_block )
>           p_sys->p_block = block_Realloc( p_sys->p_block, 0, p_sys->i_framebuffersize );
> -@@ -237,28 +230,19 @@ static bool postConnectHandler( freerdp *p_instance )
> +@@ -184,20 +177,21 @@ static void desktopResizeHandler( rdpContext *p_context )
> +         p_sys->p_block = block_Alloc( p_sys->i_framebuffersize );
> + 
> +     p_sys->es = es_out_Add( p_vlccontext->p_demux->out, &fmt );
> ++    return TRUE;
> + }
> + 
> +-static void beginPaintHandler( rdpContext *p_context )
> ++static BOOL beginPaintHandler( rdpContext *p_context )
> + {
> +     vlcrdp_context_t * p_vlccontext = (vlcrdp_context_t *) p_context;
> +     demux_sys_t *p_sys = p_vlccontext->p_demux->p_sys;
> +     rdpGdi *p_gdi = p_context->gdi;
> +-    p_gdi->primary->hdc->hwnd->invalid->null = 1;
> +-    p_gdi->primary->hdc->hwnd->ninvalid = 0;
> ++    p_gdi->primary->hdc->hwnd->invalid->null = TRUE;
> +     if ( ! p_sys->p_block && p_sys->i_framebuffersize )
> +         p_sys->p_block = block_Alloc( p_sys->i_framebuffersize );
> ++    return TRUE;
> + }
> + 
> +-static void endPaintHandler( rdpContext *p_context )
> ++static BOOL endPaintHandler( rdpContext *p_context )
> + {
> +     vlcrdp_context_t * p_vlccontext = (vlcrdp_context_t *) p_context;
> +     demux_sys_t *p_sys = p_vlccontext->p_demux->p_sys;
> +@@ -208,11 +202,12 @@ static void endPaintHandler( rdpContext *p_context )
> +         p_sys->p_block->i_buffer = p_sys->i_framebuffersize;
> +         memcpy( p_sys->p_block->p_buffer, p_gdi->primary_buffer, p_sys->p_block->i_buffer );
> +     }
> ++    return TRUE;
> + }
> + 
> + /* instance handlers */
> + 
> +-static bool preConnectHandler( freerdp *p_instance )
> ++static BOOL preConnectHandler( freerdp *p_instance )
> + {
> +     vlcrdp_context_t * p_vlccontext = (vlcrdp_context_t *) p_instance->context;
> +     demux_sys_t *p_sys = p_vlccontext->p_demux->p_sys;
> +@@ -229,49 +224,54 @@ static bool preConnectHandler( freerdp *p_instance )
> +     p_instance->settings->EncryptionMethods =
> +             var_InheritBool( p_vlccontext->p_demux, CFG_PREFIX "encrypt" );
> + 
> +-    return true;
> ++    return TRUE;
> + }
> + 
> +-static bool postConnectHandler( freerdp *p_instance )
> ++static BOOL postConnectHandler( freerdp *p_instance )
> + {
>       vlcrdp_context_t * p_vlccontext = (vlcrdp_context_t *) p_instance->context;
>   
>       msg_Dbg( p_vlccontext->p_demux, "connected to desktop %dx%d (%d bpp)",
> @@ -109,22 +173,51 @@ index 2992090219..49986f5da9 100644
>       p_instance->update->DesktopResize = desktopResizeHandler;
>       p_instance->update->BeginPaint = beginPaintHandler;
>       p_instance->update->EndPaint = endPaintHandler;
> ++    UINT32 format;
> ++    switch ( p_instance->settings->ColorDepth )
> ++    {
> ++        default:
> ++            msg_Dbg( p_vlccontext->p_demux, "no valid pixel format found for color depth %d bpp", p_instance->settings->ColorDepth);
> ++            /* fallthrough */
> ++        case 16:
> ++            format = PIXEL_FORMAT_RGB16;
> ++            break;
> ++        case 24:
> ++            format = PIXEL_FORMAT_RGB24;
> ++            break;
> ++        case 32:
> ++            format = PIXEL_FORMAT_ARGB32;
> ++            break;
> ++    }
>   
> --    gdi_init( p_instance,
> +     gdi_init( p_instance,
>  -                CLRBUF_16BPP |
>  -#if defined(FREERDP_VERSION_MAJOR) && defined(FREERDP_VERSION_MINOR) && \
>  -    !(FREERDP_VERSION_MAJOR > 1 || (FREERDP_VERSION_MAJOR == 1 && FREERDP_VERSION_MINOR >= 2))
>  -                CLRBUF_24BPP |
>  -#endif
>  -                CLRBUF_32BPP, NULL );
> -+    if ( p_instance->settings->ColorDepth > 16 )
> -+        gdi_init( p_instance, PIXEL_FORMAT_XRGB32);
> -+    else
> -+        gdi_init( p_instance, PIXEL_FORMAT_RGB16);
> ++                format );
>   
>       desktopResizeHandler( p_instance->context );
> -     return true;
> -@@ -432,10 +416,6 @@ static int Open( vlc_object_t *p_this )
> +-    return true;
> ++    return TRUE;
> + }
> + 
> +-static bool authenticateHandler( freerdp *p_instance, char** ppsz_username,
> ++static BOOL authenticateHandler( freerdp *p_instance, char** ppsz_username,
> +                                  char** ppsz_password, char** ppsz_domain )
> + {
> +     VLC_UNUSED(ppsz_domain);
> +     vlcrdp_context_t * p_vlccontext = (vlcrdp_context_t *) p_instance->context;
> +     *ppsz_username = var_InheritString( p_vlccontext->p_demux, CFG_PREFIX "user" );
> +     *ppsz_password = var_InheritString( p_vlccontext->p_demux, CFG_PREFIX "password" );
> +-    return true;
> ++    return TRUE;
> + }
> + 
> + /*****************************************************************************
> +@@ -432,10 +432,6 @@ static int Open( vlc_object_t *p_this )
>       if ( p_sys->f_fps <= 0 ) p_sys->f_fps = 1.0;
>       p_sys->i_frame_interval = 1000000 / p_sys->f_fps;
>   
> @@ -135,7 +228,7 @@ index 2992090219..49986f5da9 100644
>       p_sys->p_instance = freerdp_new();
>       if ( !p_sys->p_instance )
>       {
> -@@ -508,9 +488,6 @@ static void Close( vlc_object_t *p_this )
> +@@ -512,9 +508,6 @@ static void Close( vlc_object_t *p_this )
>   
>       freerdp_disconnect( p_sys->p_instance );
>       freerdp_free( p_sys->p_instance );
> @@ -146,5 +239,5 @@ index 2992090219..49986f5da9 100644
>       if ( p_sys->p_block )
>           block_Release( p_sys->p_block );
>  -- 
> -2.14.4
> +2.47.3
>  
> -- 
> 2.47.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-06-05 12:50 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-24 18:20 [Buildroot] [PATCH 1/3] package/vlc: replace wayland-scanner patch with upstream commit Bernd Kuhls
2026-02-24 18:20 ` [Buildroot] [PATCH 2/3] package/vlc: update freerdp2 patch Bernd Kuhls
2026-06-05 12:50   ` Thomas Perale via buildroot
2026-02-24 18:20 ` [Buildroot] [PATCH 3/3] package/vlc: rebase patch set Bernd Kuhls
2026-06-05 12:50   ` Thomas Perale via buildroot
2026-05-29 15:16 ` [Buildroot] [PATCH 1/3] package/vlc: replace wayland-scanner patch with upstream commit Thomas Petazzoni via buildroot
2026-06-05 12:50 ` Thomas Perale via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox