Re: [Buildroot] [PATCH] package/nginx: fix sparc compile

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Waldemar,

Do you have any updates on the feedback below?

Thanks!

Thomas

On Mon, Aug 05, 2024 at 09:31:06AM +0200, Thomas Petazzoni via buildroot wrote:
> On Mon, 5 Aug 2024 09:24:49 +0200
> Waldemar Brodkorb <wbx@openadk.org> wrote:
> 
> > The minimal reproducer is:
> > BR2_sparc=y
> > BR2_PACKAGE_NGINX=y
> 
> Weird, I didn't reproduce it with the Bootlin SPARC toolchain.
> 
> > For sparc only libatomic_ops is selected via
> > package/nginx/Config.in. So I think the build issue is unique to
> > sparcv8/leon.
> 
> Correct, but in the .mk file we have:
> 
> ifeq ($(BR2_PACKAGE_LIBATOMIC_OPS),y)
> NGINX_DEPENDENCIES += libatomic_ops
> NGINX_CONF_OPTS += --with-libatomic
> NGINX_CONF_ENV += ngx_force_have_libatomic=yes
> ifeq ($(BR2_sparc_v8)$(BR2_sparc_leon3),y)
> NGINX_CFLAGS += "-DAO_NO_SPARC_V9"
> endif
> else
> NGINX_CONF_ENV += ngx_force_have_libatomic=no
> endif
> 
> and BR2_PACKAGE_LIBATOMIC_OPS can very well be enabled on non-SPARC
> architectures. Yes nginx only forces BR2_PACKAGE_LIBATOMIC_OPS on
> Sparc, but nothing prevents another package (or even the user) to
> enable BR2_PACKAGE_LIBATOMIC_OPS on non-Sparc architectures.
> 
> Thomas
> -- 
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot